@webex/internal-plugin-metrics 3.12.0-next.9 → 3.12.0-webex-services-ready.1

package/test/unit/spec/call-diagnostic/call-diagnostic-metrics-latencies.ts

@@ -412,8 +412,10 @@ describe('internal-plugin-metrics', () => {
     });
 
     it('calculates getCallInitJoinReq correctly', () => {
+      cdl.saveTimestamp({key: 'internal.client.meeting.interstitial-window.showed', value: 5});
       cdl.saveTimestamp({key: 'internal.client.interstitial-window.click.joinbutton', value: 10});
       cdl.saveTimestamp({key: 'client.locus.join.request', value: 20});
+      // showedToJoinReq = 20-5 = 15, showInterstitialTime = 10-5 = 5, result = 15-5 = 10
       assert.deepEqual(cdl.getCallInitJoinReq(), 10);
     });
 
@@ -574,76 +576,40 @@ describe('internal-plugin-metrics', () => {
     });
 
     it('calculates getClickToInterstitial correctly', () => {
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.click.joinbutton',
-        value: 10,
-      });
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.interstitial-window.showed',
-        value: 20,
-      });
-      assert.deepEqual(cdl.getClickToInterstitial(), 10);
-    });
-
-    it('calculates getClickToInterstitial without join button timestamp', () => {
       cdl.saveLatency('internal.click.to.interstitial', 5);
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.interstitial-window.showed',
-        value: 20,
-      });
       assert.deepEqual(cdl.getClickToInterstitial(), 5);
     });
 
-    it('calculates getClickToInterstitial without join button timestamp when it is 0', () => {
+    it('calculates getClickToInterstitial correctly when it is 0', () => {
       cdl.saveLatency('internal.click.to.interstitial', 0);
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.interstitial-window.showed',
-        value: 20,
-      });
       assert.deepEqual(cdl.getClickToInterstitial(), 0);
     });
 
-    it('calculates getClickToInterstitial without join button timestamp when it is greater than MAX_INTEGER', () => {
+    it('calculates getClickToInterstitial correctly when it is greater than MAX_INTEGER', () => {
       cdl.saveLatency('internal.click.to.interstitial', 2147483648);
       assert.deepEqual(cdl.getClickToInterstitial(), 2147483647);
     });
 
     it('calculates getClickToInterstitialWithUserDelay correctly', () => {
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.click.joinbutton',
-        value: 10,
-      });
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.interstitial-window.showed',
-        value: 20,
-      });
-      assert.deepEqual(cdl.getClickToInterstitialWithUserDelay(), 10);
-    });
-
-    it('calculates getClickToInterstitialWithUserDelay without join button timestamp', () => {
       cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 5);
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.interstitial-window.showed',
-        value: 20,
-      });
       assert.deepEqual(cdl.getClickToInterstitialWithUserDelay(), 5);
     });
 
-    it('calculates getClickToInterstitialWithUserDelay without join button timestamp when it is 0', () => {
+    it('calculates getClickToInterstitialWithUserDelay correctly when it is 0', () => {
       cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 0);
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.interstitial-window.showed',
-        value: 20,
-      });
       assert.deepEqual(cdl.getClickToInterstitialWithUserDelay(), 0);
     });
 
-    it('calculates getClickToInterstitialWithUserDelay without join button timestamp when it is greater than MAX_INTEGER', () => {
+    it('calculates getClickToInterstitialWithUserDelay correctly when it is greater than MAX_INTEGER', () => {
       cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 2147483648);
       assert.deepEqual(cdl.getClickToInterstitialWithUserDelay(), 2147483647);
     });
 
     it('calculates getInterstitialToJoinOK correctly', () => {
+      cdl.saveTimestamp({
+        key: 'internal.client.meeting.interstitial-window.showed',
+        value: 5,
+      });
       cdl.saveTimestamp({
         key: 'internal.client.interstitial-window.click.joinbutton',
         value: 10,
@@ -652,12 +618,13 @@ describe('internal-plugin-metrics', () => {
         key: 'client.locus.join.response',
         value: 20,
       });
+      // showedToJoinResp = 20-5 = 15, showInterstitialTime = 10-5 = 5, result = 15-5 = 10
       assert.deepEqual(cdl.getInterstitialToJoinOK(), 10);
     });
 
     it('calculates getInterstitialToJoinOK correctly when one value is not a number', () => {
       cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
+        key: 'internal.client.meeting.interstitial-window.showed',
         value: 'ten' as unknown as number,
       });
       cdl.saveTimestamp({
@@ -673,10 +640,7 @@ describe('internal-plugin-metrics', () => {
     });
 
     it('calculates getTotalJMT correctly', () => {
-      cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
-        value: 5,
-      });
+      cdl.saveLatency('internal.click.to.interstitial', 10);
       cdl.saveTimestamp({
         key: 'internal.client.meeting.click.joinbutton',
         value: 10,
@@ -685,29 +649,39 @@ describe('internal-plugin-metrics', () => {
         key: 'internal.client.meeting.interstitial-window.showed',
         value: 20,
       });
+      cdl.saveTimestamp({
+        key: 'internal.client.interstitial-window.click.joinbutton',
+        value: 25,
+      });
       cdl.saveTimestamp({
         key: 'client.locus.join.response',
         value: 40,
       });
-      assert.deepEqual(cdl.getTotalJMT(), 45);
+      // clickToInterstitial = 20-10 = 10
+      // showedToJoinLocusResponse = 40-20 = 20
+      // showInterstitialTime = 25-20 = 5
+      // total = 10 + 20 - 5 = 25
+      assert.deepEqual(cdl.getTotalJMT(), 25);
     });
 
     it('calculates getTotalJMT correctly when clickToInterstitial is 0', () => {
       cdl.saveLatency('internal.click.to.interstitial', 0);
       cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
+        key: 'internal.client.meeting.interstitial-window.showed',
         value: 20,
       });
       cdl.saveTimestamp({
         key: 'client.locus.join.response',
         value: 40,
       });
+      // showedToJoinLocusResponse = 40-20 = 20, showInterstitialTime = 0
+      // total = 0 + 20 - 0 = 20
       assert.deepEqual(cdl.getTotalJMT(), 20);
     });
 
     it('calculates getTotalJMT correctly when interstitialClickJoinToJoinLocusResponse is 0', () => {
       cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
+        key: 'internal.client.meeting.interstitial-window.showed',
         value: 40,
       });
       cdl.saveLatency('internal.click.to.interstitial', 12);
@@ -715,12 +689,14 @@ describe('internal-plugin-metrics', () => {
         key: 'client.locus.join.response',
         value: 40,
       });
+      // showedToJoinLocusResponse = 0, showInterstitialTime = 0
+      // total = 12 + 0 - 0 = 12
       assert.deepEqual(cdl.getTotalJMT(), 12);
     });
 
     it('calculates getTotalJMT correctly when both clickToInterstitial and interstitialClickJoinToJoinLocusResponse are 0', () => {
       cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
+        key: 'internal.client.meeting.interstitial-window.showed',
         value: 40,
       });
       cdl.saveLatency('internal.click.to.interstitial', 0);
@@ -733,7 +709,7 @@ describe('internal-plugin-metrics', () => {
 
     it('calculates getTotalJMT correctly when both clickToInterstitial is not a number', () => {
       cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
+        key: 'internal.client.meeting.interstitial-window.showed',
         value: 40,
       });
       cdl.saveLatency('internal.click.to.interstitial', 'eleven' as unknown as number);
@@ -746,7 +722,7 @@ describe('internal-plugin-metrics', () => {
 
     it('calculates getTotalJMT correctly when it is greater than MAX_INTEGER', () => {
       cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
+        key: 'internal.client.meeting.interstitial-window.showed',
         value: 5,
       });
       cdl.saveTimestamp({
@@ -758,14 +734,7 @@ describe('internal-plugin-metrics', () => {
     });
 
     it('calculates getTotalJMTWithUserDelay correctly', () => {
-      cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
-        value: 5,
-      });
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.click.joinbutton',
-        value: 10,
-      });
+      cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 10);
       cdl.saveTimestamp({
         key: 'internal.client.meeting.interstitial-window.showed',
         value: 20,
@@ -846,48 +815,51 @@ describe('internal-plugin-metrics', () => {
     });
 
     it('calculates getTotalMediaJMT correctly with lobby exiting before media-engine.ready', () => {
-      cdl.saveTimestamp({key: 'internal.client.meeting.click.joinbutton', value: 5});
+      cdl.saveLatency('internal.click.to.interstitial', 3);
+      // clickToInterstitial = 3
       cdl.saveTimestamp({key: 'internal.client.meeting.interstitial-window.showed', value: 8});
-      // clickToInterstitial = 8 - 5 = 3
       cdl.saveTimestamp({key: 'internal.client.interstitial-window.click.joinbutton', value: 10});
       cdl.saveTimestamp({key: 'client.media-engine.ready', value: 50});
-      // interstitialClickJoinToMediaEngineReady = 50 - 10 = 40
+      // interstitialShowedToMediaEngineReady = 50 - 8 = 42
+      // showInterstitialTime = 10 - 8 = 2
       cdl.saveTimestamp({key: 'client.lobby.entered', value: 20});
       cdl.saveTimestamp({key: 'client.lobby.exited', value: 30});
       // stayLobbyTimeCappedByMediaEngineReady = min(30, 50) - 20 = 10
-      // total = 3 + 40 - 10 = 33
+      // total = 3 + 42 - 2 - 10 = 33
       assert.deepEqual(cdl.getTotalMediaJMT(), 33);
     });
 
     it('calculates getTotalMediaJMT correctly without lobby', () => {
-      cdl.saveTimestamp({key: 'internal.client.meeting.click.joinbutton', value: 5});
-      cdl.saveTimestamp({key: 'internal.client.meeting.interstitial-window.showed', value: 8});
+      cdl.saveLatency('internal.click.to.interstitial', 3);
       // clickToInterstitial = 3
+      cdl.saveTimestamp({key: 'internal.client.meeting.interstitial-window.showed', value: 8});
       cdl.saveTimestamp({key: 'internal.client.interstitial-window.click.joinbutton', value: 10});
       cdl.saveTimestamp({key: 'client.media-engine.ready', value: 50});
-      // interstitialClickJoinToMediaEngineReady = 40
+      // interstitialShowedToMediaEngineReady = 50 - 8 = 42
+      // showInterstitialTime = 10 - 8 = 2
       // no client.lobby.entered → stayLobbyTimeCappedByMediaEngineReady = 0
-      // total = 3 + 40 - 0 = 43
+      // total = 3 + 42 - 2 - 0 = 43
       assert.deepEqual(cdl.getTotalMediaJMT(), 43);
     });
 
     it('calculates getTotalMediaJMT correctly with lobby exiting after media-engine.ready', () => {
-      cdl.saveTimestamp({key: 'internal.client.meeting.click.joinbutton', value: 5});
-      cdl.saveTimestamp({key: 'internal.client.meeting.interstitial-window.showed', value: 8});
+      cdl.saveLatency('internal.click.to.interstitial', 3);
       // clickToInterstitial = 3
+      cdl.saveTimestamp({key: 'internal.client.meeting.interstitial-window.showed', value: 8});
       cdl.saveTimestamp({key: 'internal.client.interstitial-window.click.joinbutton', value: 10});
       cdl.saveTimestamp({key: 'client.media-engine.ready', value: 50});
-      // interstitialClickJoinToMediaEngineReady = 40
+      // interstitialShowedToMediaEngineReady = 50 - 8 = 42
+      // showInterstitialTime = 10 - 8 = 2
       cdl.saveTimestamp({key: 'client.lobby.entered', value: 20});
       cdl.saveTimestamp({key: 'client.lobby.exited', value: 60});
       // stayLobbyTimeCappedByMediaEngineReady = min(60, 50) - 20 = 30
-      // total = 3 + 40 - 30 = 13
+      // total = 3 + 42 - 2 - 30 = 13
       assert.deepEqual(cdl.getTotalMediaJMT(), 13);
     });
 
     it('calculates getTotalMediaJMT correctly when it is greater than MAX_INTEGER', () => {
-      cdl.saveTimestamp({key: 'internal.client.meeting.click.joinbutton', value: 5});
-      cdl.saveTimestamp({key: 'internal.client.meeting.interstitial-window.showed', value: 8});
+      cdl.saveLatency('internal.click.to.interstitial', 5);
+      cdl.saveTimestamp({key: 'internal.client.meeting.interstitial-window.showed', value: 10});
       cdl.saveTimestamp({key: 'internal.client.interstitial-window.click.joinbutton', value: 10});
       cdl.saveTimestamp({key: 'client.media-engine.ready', value: 4294967400});
       cdl.saveTimestamp({key: 'client.lobby.entered', value: 28});
@@ -896,7 +868,7 @@ describe('internal-plugin-metrics', () => {
     });
 
     it('returns undefined for getTotalMediaJMT when media-engine.ready is missing', () => {
-      cdl.saveTimestamp({key: 'internal.client.meeting.click.joinbutton', value: 5});
+      cdl.saveLatency('internal.click.to.interstitial', 3);
       cdl.saveTimestamp({key: 'internal.client.meeting.interstitial-window.showed', value: 8});
       cdl.saveTimestamp({key: 'internal.client.interstitial-window.click.joinbutton', value: 10});
       cdl.saveTimestamp({key: 'client.locus.join.response', value: 20});
@@ -904,14 +876,15 @@ describe('internal-plugin-metrics', () => {
     });
 
     it('calculates getTotalMediaJMT correctly when there is no lobby and stayLobbyTime defaults to 0', () => {
-      cdl.saveTimestamp({key: 'internal.client.meeting.click.joinbutton', value: 5});
+      cdl.saveLatency('internal.click.to.interstitial', 3);
+      // clickToInterstitial = 3
       cdl.saveTimestamp({key: 'internal.client.meeting.interstitial-window.showed', value: 8});
-      // clickToInterstitial = 8 - 5 = 3
       cdl.saveTimestamp({key: 'internal.client.interstitial-window.click.joinbutton', value: 10});
       cdl.saveTimestamp({key: 'client.media-engine.ready', value: 50});
-      // interstitialClickJoinToMediaEngineReady = 50 - 10 = 40
+      // interstitialShowedToMediaEngineReady = 50 - 8 = 42
+      // showInterstitialTime = 10 - 8 = 2
       // no client.lobby.entered → stayLobbyTimeCappedByMediaEngineReady = 0
-      // total = 3 + 40 - 0 = 43
+      // total = 3 + 42 - 2 - 0 = 43
       assert.deepEqual(cdl.getTotalMediaJMT(), 43);
     });
 
@@ -926,9 +899,9 @@ describe('internal-plugin-metrics', () => {
     });
 
     it('calculates getTotalMediaJMTWithUserDelay correctly for guest join', () => {
-      cdl.saveTimestamp({key: 'internal.client.meeting.click.joinbutton', value: 5});
+      cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 3);
+      // clickToInterstitialWithUserDelay = 3
       cdl.saveTimestamp({key: 'internal.client.meeting.interstitial-window.showed', value: 8});
-      // clickToInterstitialWithUserDelay = 8 - 5 = 3
       cdl.saveTimestamp({key: 'client.media-engine.ready', value: 50});
       // interstitialShowedToMediaEngineReady = 50 - 8 = 42
       // total = 3 + 42 = 45
@@ -991,6 +964,11 @@ describe('internal-plugin-metrics', () => {
     });
 
     it('calculates getClientJMT correctly', () => {
+      cdl.saveLatency('internal.click.to.interstitial.for.client.jmt', 5);
+      cdl.saveTimestamp({
+        key: 'internal.client.meeting.interstitial-window.showed',
+        value: 1,
+      });
       cdl.saveTimestamp({
         key: 'internal.client.interstitial-window.click.joinbutton',
         value: 2,
@@ -999,19 +977,30 @@ describe('internal-plugin-metrics', () => {
         key: 'client.locus.join.request',
         value: 6,
       });
+      // showedToLocusJoinRequest = 6-1 = 5, showInterstitialTime = 2-1 = 1
+      // clickToInterstitialForClientJmt (5) + 5 - 1 = 9
+      assert.deepEqual(cdl.getClientJMT(), 9);
+    });
+
+    it('returns undefined for getClientJMT when clickToInterstitialForClientJmt is missing', () => {
       cdl.saveTimestamp({
-        key: 'client.locus.join.response',
-        value: 8,
+        key: 'internal.client.meeting.interstitial-window.showed',
+        value: 1,
       });
       cdl.saveTimestamp({
-        key: 'client.ice.start',
-        value: 10,
+        key: 'internal.client.interstitial-window.click.joinbutton',
+        value: 2,
       });
       cdl.saveTimestamp({
-        key: 'client.ice.end',
-        value: 11,
+        key: 'client.locus.join.request',
+        value: 6,
       });
-      assert.deepEqual(cdl.getClientJMT(), 3);
+      assert.deepEqual(cdl.getClientJMT(), undefined);
+    });
+
+    it('returns undefined for getClientJMT when interstitialJoinToLocusJoinRequest is missing', () => {
+      cdl.saveLatency('internal.click.to.interstitial.for.client.jmt', 5);
+      assert.deepEqual(cdl.getClientJMT(), undefined);
     });
 
     it('calculates getAudioJoinRespRxStart correctly', () => {
@@ -1063,6 +1052,10 @@ describe('internal-plugin-metrics', () => {
     });
 
     it('calculates getInterstitialToMediaOKJMT correctly', () => {
+      cdl.saveTimestamp({
+        key: 'internal.client.meeting.interstitial-window.showed',
+        value: 2,
+      });
       cdl.saveTimestamp({
         key: 'internal.client.interstitial-window.click.joinbutton',
         value: 4,
@@ -1079,10 +1072,17 @@ describe('internal-plugin-metrics', () => {
         key: 'client.ice.end',
         value: 14,
       });
+      // showedToIceEnd = 14-2 = 12, showInterstitialTime = 4-2 = 2
+      // stayLobbyTimeCappedByIceEnd = min(12,14)-10 = 2
+      // result = 12 - 2 - 2 = 8
       assert.deepEqual(cdl.getInterstitialToMediaOKJMT(), 8);
     });
 
     it('calculates getInterstitialToMediaOKJMT correctly when it is greater than MAX_INTEGER', () => {
+      cdl.saveTimestamp({
+        key: 'internal.client.meeting.interstitial-window.showed',
+        value: 4,
+      });
       cdl.saveTimestamp({
         key: 'internal.client.interstitial-window.click.joinbutton',
         value: 4,
@@ -1103,6 +1103,10 @@ describe('internal-plugin-metrics', () => {
     });
 
     it('calculates getInterstitialToMediaOKJMT correctly without lobby', () => {
+      cdl.saveTimestamp({
+        key: 'internal.client.meeting.interstitial-window.showed',
+        value: 2,
+      });
       cdl.saveTimestamp({
         key: 'internal.client.interstitial-window.click.joinbutton',
         value: 4,
@@ -1111,12 +1115,17 @@ describe('internal-plugin-metrics', () => {
         key: 'client.ice.end',
         value: 14,
       });
-      // no client.lobby.entered → stayLobbyTimeCappedByIceEnd = 0
-      // result = (14 - 4) - 0 = 10
+      // showedToIceEnd = 14-2 = 12, showInterstitialTime = 4-2 = 2
+      // stayLobbyTimeCappedByIceEnd = 0 (no lobby)
+      // result = 12 - 2 - 0 = 10
       assert.deepEqual(cdl.getInterstitialToMediaOKJMT(), 10);
     });
 
     it('calculates getInterstitialToMediaOKJMT correctly when there is no lobby and stayLobbyTime defaults to 0', () => {
+      cdl.saveTimestamp({
+        key: 'internal.client.meeting.interstitial-window.showed',
+        value: 2,
+      });
       cdl.saveTimestamp({
         key: 'internal.client.interstitial-window.click.joinbutton',
         value: 4,
@@ -1125,8 +1134,9 @@ describe('internal-plugin-metrics', () => {
         key: 'client.ice.end',
         value: 14,
       });
-      // no client.lobby.entered → stayLobbyTimeCappedByIceEnd = 0
-      // result = (14 - 4) - 0 = 10
+      // showedToIceEnd = 14-2 = 12, showInterstitialTime = 4-2 = 2
+      // stayLobbyTimeCappedByIceEnd = 0 (no lobby)
+      // result = 12 - 2 - 0 = 10
       assert.deepEqual(cdl.getInterstitialToMediaOKJMT(), 10);
     });