@webex/internal-plugin-metrics 3.12.0-next.9 → 3.12.0-task-refactor.1

package/dist/types/call-diagnostic/call-diagnostic-metrics.util.d.ts

@@ -59,27 +59,6 @@ export declare const isUnauthorizedError: (rawError: any) => boolean;
  * @returns {boolean}
  */
 export declare const isSdpOfferCreationError: (rawError: any) => boolean;
-export declare const isWebrtcApiNotAvailableError: (rawError: {
-    code: number;
-    message: string;
-    name: string;
-} | unknown) => boolean;
-/**
- * Checks if the given error is a browser media error by its name.
- * Returns true if the error name matches any known browser media error name in the mapping.
- *
- * @param {Object} rawError - The error object to check.
- * @returns {boolean} True if the error is a browser media error, false otherwise.
- */
-export declare const isBrowserMediaError: (rawError: any) => boolean;
-/**
- * Returns the client error code mapped to the given browser media error name.
- * If the error name is not found in the mapping, returns undefined.
- *
- * @param {Object} rawError - The error object containing the error name.
- * @returns {string|undefined} The mapped client error code, or undefined if not found.
- */
-export declare const getBrowserMediaErrorCode: (rawError: any) => number;
 /**
  * MDN Media Devices getUserMedia() method returns a name if it errs
  * Documentation can be found here: https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia
@@ -93,7 +72,7 @@ export declare const isBrowserMediaErrorName: (errorName: any) => boolean;
  * @param webClientDomain
  * @returns
  */
-export declare const getBuildType: (webex: any, webClientDomain: any, markAsTestEvent?: boolean) => Event['origin']['buildType'];
+export declare const getBuildType: (webex: any, webClientDomain: any, markAsTestEvent?: boolean) => Event["origin"]["buildType"];
 /**
  * Prepare metric item for submission.
  * @param {Object} webex sdk instance
@@ -119,7 +98,7 @@ export declare const extractVersionMetadata: (version: string) => {
  * that happen when trying to add media in a meeting.
  */
 export declare const generateClientErrorCodeForIceFailure: ({ signalingState, iceConnected, turnServerUsed, unreachable, }: {
-    signalingState: RTCPeerConnection['signalingState'];
+    signalingState: RTCPeerConnection["signalingState"];
     iceConnected: boolean;
     turnServerUsed: boolean;
     unreachable: boolean;

package/dist/types/call-diagnostic/config.d.ts

@@ -15,8 +15,25 @@ export declare const ICE_AND_REACHABILITY_FAILED_CLIENT_CODE = 2011;
 export declare const MULTISTREAM_NOT_AVAILABLE_CLIENT_CODE = 2012;
 export declare const WBX_APP_API_URL = "wbxappapi";
 export declare const WEBEX_SUB_SERVICE_TYPES: Record<string, ClientSubServiceType>;
+declare const BROWSER_MEDIA_ERROR_NAMES: {
+    PERMISSION_DENIED_ERROR: string;
+    NOT_ALLOWED_ERROR: string;
+    NOT_READABLE_ERROR: string;
+    ABORT_ERROR: string;
+    NOT_FOUND_ERROR: string;
+    OVERCONSTRAINED_ERROR: string;
+    SECURITY_ERROR: string;
+    TYPE_ERROR: string;
+};
 export declare const BROWSER_MEDIA_ERROR_NAME_TO_CLIENT_ERROR_CODES_MAP: {
-    [x: string]: number;
+    [BROWSER_MEDIA_ERROR_NAMES.PERMISSION_DENIED_ERROR]: number;
+    [BROWSER_MEDIA_ERROR_NAMES.NOT_ALLOWED_ERROR]: number;
+    [BROWSER_MEDIA_ERROR_NAMES.NOT_READABLE_ERROR]: number;
+    [BROWSER_MEDIA_ERROR_NAMES.ABORT_ERROR]: number;
+    [BROWSER_MEDIA_ERROR_NAMES.NOT_FOUND_ERROR]: number;
+    [BROWSER_MEDIA_ERROR_NAMES.OVERCONSTRAINED_ERROR]: number;
+    [BROWSER_MEDIA_ERROR_NAMES.SECURITY_ERROR]: number;
+    [BROWSER_MEDIA_ERROR_NAMES.TYPE_ERROR]: number;
 };
 export declare const SDP_OFFER_CREATION_ERROR_MAP: {
     GENERAL: number;
@@ -99,7 +116,6 @@ export declare const ERROR_DESCRIPTIONS: {
     MULTISTREAM_NOT_AVAILABLE: string;
     SDP_OFFER_CREATION_ERROR: string;
     SDP_OFFER_CREATION_ERROR_MISSING_CODEC: string;
-    WEBRTC_API_NOT_AVAILABLE: string;
     WDM_RESTRICTED_REGION: string;
     USER_NOT_ALLOWED_JOIN_WEBINAR: string;
 };
@@ -198,3 +214,4 @@ export declare const SERVICE_ERROR_CODES_TO_CLIENT_ERROR_CODES_MAP: {
 export declare const CLIENT_ERROR_CODE_TO_ERROR_PAYLOAD: Record<number, Partial<ClientEventError>>;
 export declare const CALL_DIAGNOSTIC_EVENT_FAILED_TO_SEND = "js_sdk_call_diagnostic_event_failed_to_send";
 export declare const CALL_FEATURE_EVENT_FAILED_TO_SEND = "js_sdk_call_feature_event_failed_to_send";
+export {};

package/dist/types/config.d.ts

@@ -2,29 +2,29 @@ export const CLIENT_NAME: "webex-js-sdk";
 declare namespace _default {
     export namespace device {
         namespace preDiscoveryServices {
-            const metricsServiceUrl: string;
-            const metrics: string;
+            let metricsServiceUrl: string;
+            let metrics: string;
         }
     }
     export namespace metrics_1 {
-        const appType: string;
-        const batcherWait: number;
-        const batcherMaxCalls: number;
-        const batcherMaxWait: number;
-        const batcherRetryPlateau: number;
-        const waitForServiceTimeout: number;
+        let appType: string;
+        let batcherWait: number;
+        let batcherMaxCalls: number;
+        let batcherMaxWait: number;
+        let batcherRetryPlateau: number;
+        let waitForServiceTimeout: number;
     }
     export { metrics_1 as metrics };
 }
 export default _default;
 export namespace OS_NAME {
-    const WINDOWS: string;
-    const MAC: string;
-    const IOS: string;
-    const ANDROID: string;
-    const CHROME: string;
-    const LINUX: string;
-    const OTHERS: string;
+    let WINDOWS: string;
+    let MAC: string;
+    let IOS: string;
+    let ANDROID: string;
+    let CHROME: string;
+    let LINUX: string;
+    let OTHERS: string;
 }
 export const OSMap: {
     'Chrome OS': string;

package/dist/types/index.d.ts

@@ -13,7 +13,6 @@ import BehavioralMetrics from './behavioral-metrics';
 import OperationalMetrics from './operational-metrics';
 import BusinessMetrics from './business-metrics';
 import RtcMetrics from './rtcMetrics';
-import PreLoginMetrics from './prelogin-metrics';
 export { default, getOSNameInternal } from './metrics';
-export { config, CALL_DIAGNOSTIC_CONFIG, NewMetrics, Utils, CallDiagnosticUtils, CallDiagnosticLatencies, CallDiagnosticMetrics, BehavioralMetrics, OperationalMetrics, BusinessMetrics, RtcMetrics, PreLoginMetrics, };
+export { config, CALL_DIAGNOSTIC_CONFIG, NewMetrics, Utils, CallDiagnosticUtils, CallDiagnosticLatencies, CallDiagnosticMetrics, BehavioralMetrics, OperationalMetrics, BusinessMetrics, RtcMetrics, };
 export type { ClientEvent, ClientEventLeaveReason, SubmitBehavioralEvent, SubmitClientEvent, SubmitInternalEvent, SubmitMQE, SubmitOperationalEvent, SubmitBusinessEvent, PreComputedLatencies, SubmitFeatureEvent, };

package/dist/types/metrics.types.d.ts

@@ -1,4 +1,4 @@
-import type { ClientEvent as RawClientEvent, Event as RawEvent, MediaQualityEvent as RawMediaQualityEvent, FeatureEvent as RawFeatureEvent } from '@webex/event-dictionary-ts';
+import { ClientEvent as RawClientEvent, Event as RawEvent, MediaQualityEvent as RawMediaQualityEvent, FeatureEvent as RawFeatureEvent } from '@webex/event-dictionary-ts';
 export type Event = Omit<RawEvent, 'event'> & {
     event: RawClientEvent | RawMediaQualityEvent | RawFeatureEvent;
 };
@@ -73,7 +73,7 @@ export interface BusinessEventPayload {
     metricName: string;
     timestamp: number;
     context: DeviceContext;
-    browserDetails: object;
+    browserDetails: EventPayload;
     value: EventPayload;
 }
 export interface BusinessEvent {

package/dist/types/new-metrics.d.ts

@@ -3,7 +3,6 @@ import CallDiagnosticMetrics from './call-diagnostic/call-diagnostic-metrics';
 import BehavioralMetrics from './behavioral-metrics';
 import OperationalMetrics from './operational-metrics';
 import BusinessMetrics from './business-metrics';
-import PreLoginMetrics from './prelogin-metrics';
 import { RecursivePartial, MetricEventProduct, MetricEventAgent, MetricEventVerb, ClientEvent, FeatureEvent, EventPayload, MediaQualityEvent, InternalEvent, SubmitClientEventOptions, Table, DelayedClientEvent, DelayedClientFeatureEvent } from './metrics.types';
 import CallDiagnosticLatencies from './call-diagnostic/call-diagnostic-metrics-latencies';
 /**
@@ -18,7 +17,6 @@ declare class Metrics extends WebexPlugin {
     behavioralMetrics: BehavioralMetrics;
     operationalMetrics: OperationalMetrics;
     businessMetrics: BusinessMetrics;
-    preLoginMetrics: PreLoginMetrics;
     isReady: boolean;
     /**
      * Whether or not to delay the submission of client events.
@@ -107,16 +105,6 @@ declare class Metrics extends WebexPlugin {
         table?: Table;
         metadata?: EventPayload;
     }): Promise<void>;
-    /**
-     * Call Analyzer: Pre-Login Event
-     * @param args
-     */
-    submitPreLoginEvent({ name, preLoginId, payload, metadata, }: {
-        name: string;
-        preLoginId: string;
-        payload: EventPayload;
-        metadata?: EventPayload;
-    }): Promise<void>;
     /**
      * Call Analyzer: Media Quality Event
      * @param args

package/package.json

@@ -24,23 +24,23 @@
     "@sinonjs/fake-timers": "^6.0.1",
     "@webex/babel-config-legacy": "0.0.0",
     "@webex/eslint-config-legacy": "0.0.0",
-    "@webex/event-dictionary-ts": "^1.0.2138",
     "@webex/jest-config-legacy": "0.0.0",
     "@webex/legacy-tools": "0.0.0",
-    "@webex/test-helper-chai": "3.11.0-next.1",
-    "@webex/test-helper-mocha": "3.11.0-next.1",
-    "@webex/test-helper-mock-webex": "3.11.0-next.1",
-    "@webex/test-helper-test-users": "3.11.0-next.1",
+    "@webex/test-helper-chai": "3.12.0-task-refactor.1",
+    "@webex/test-helper-mocha": "3.12.0-task-refactor.1",
+    "@webex/test-helper-mock-webex": "3.12.0-task-refactor.1",
+    "@webex/test-helper-test-users": "3.12.0-task-refactor.1",
     "eslint": "^8.24.0",
     "prettier": "^2.7.1",
     "sinon": "^9.2.4"
   },
   "dependencies": {
-    "@webex/common": "3.11.0-next.1",
-    "@webex/common-timers": "3.11.0-next.1",
-    "@webex/test-helper-chai": "3.11.0-next.1",
-    "@webex/test-helper-mock-webex": "3.11.0-next.1",
-    "@webex/webex-core": "3.12.0-next.9",
+    "@webex/common": "3.12.0-task-refactor.1",
+    "@webex/common-timers": "3.12.0-task-refactor.1",
+    "@webex/event-dictionary-ts": "^1.0.1930",
+    "@webex/test-helper-chai": "3.12.0-task-refactor.1",
+    "@webex/test-helper-mock-webex": "3.12.0-task-refactor.1",
+    "@webex/webex-core": "3.12.0-task-refactor.1",
     "ip-anonymize": "^0.1.0",
     "lodash": "^4.17.21",
     "uuid": "^3.3.2"
@@ -53,5 +53,5 @@
     "test:style": "eslint ./src/**/*.*",
     "test:unit": "webex-legacy-tools test --unit --runner mocha"
   },
-  "version": "3.12.0-next.9"
+  "version": "3.12.0-task-refactor.1"
 }

package/src/call-diagnostic/call-diagnostic-metrics-latencies.ts

@@ -193,7 +193,7 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
    */
   public getShowInterstitialTime() {
     return this.getDiffBetweenTimestamps(
-      'internal.client.meeting.interstitial-window.showed',
+      'client.interstitial-window.start-launch',
       'internal.client.interstitial-window.click.joinbutton'
     );
   }
@@ -303,39 +303,10 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
    * @returns - latency
    */
   public getStayLobbyTime() {
-    return this.getDiffBetweenTimestamps('client.lobby.entered', 'client.lobby.exited');
-  }
-
-  /**
-   * Stay lobby time capped by a certain timestamp.
-   * This is to handle the case where the target end timestamp could happen before the lobby is exited,
-   * for example media-engine.ready or client.ice.end
-   * This is supposed to be called AFTER the end timestamp happens
-   * @param endTimestampKey name of the target end event
-   * @returns - latency
-   */
-  public getStayLobbyTimeCappedBy(endTimestampKey: MetricEventNames) {
-    const lobbyStartTimestamp = this.latencyTimestamps.get('client.lobby.entered'); // might not exist (some meetings don't have lobby)
-
-    if (typeof lobbyStartTimestamp !== 'number') {
-      // no lobby in the meeting, stayLobbyTime is 0
-      return 0;
-    }
-
-    const lobbyEndTimestamp = this.latencyTimestamps.get('client.lobby.exited'); // might not exist (if user still in lobby at the time of measurement)
-    const maximumEndTimestamp = this.latencyTimestamps.get(endTimestampKey); // must exist
-
-    if (typeof maximumEndTimestamp !== 'number') {
-      // the provided timestamp to be used as a cap should exist, return undefined if it doesn't
-      return undefined;
-    }
-
-    const endTimestamp =
-      typeof lobbyEndTimestamp === 'number'
-        ? Math.min(lobbyEndTimestamp, maximumEndTimestamp)
-        : maximumEndTimestamp;
-
-    return clamp(endTimestamp - lobbyStartTimestamp, 0, this.MAX_INTEGER);
+    return this.getDiffBetweenTimestamps(
+      'client.locus.join.response',
+      'internal.host.meeting.participant.admitted'
+    );
   }
 
   /**
@@ -422,7 +393,11 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
    * @returns - latency
    */
   public getCallInitMediaEngineReady() {
-    return this.getInterstitialToMediaOKJMT();
+    return this.getDiffBetweenTimestamps(
+      'internal.client.interstitial-window.click.joinbutton',
+      'client.media-engine.ready',
+      {maximum: 1200000}
+    );
   }
 
   /**
@@ -430,21 +405,20 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
    * @returns - latency
    */
   public getInterstitialToMediaOKJMT() {
-    const interstitialClickJoinToIceEnd = this.getDiffBetweenTimestamps(
-      'internal.client.interstitial-window.click.joinbutton',
-      'client.ice.end'
+    const interstitialJoinClickTimestamp = this.latencyTimestamps.get(
+      'internal.client.interstitial-window.click.joinbutton'
     );
-    const stayLobbyTimeCappedByIceEnd = this.getStayLobbyTimeCappedBy('client.ice.end');
 
-    if (
-      typeof interstitialClickJoinToIceEnd === 'number' &&
-      typeof stayLobbyTimeCappedByIceEnd === 'number'
-    ) {
-      return clamp(
-        interstitialClickJoinToIceEnd - stayLobbyTimeCappedByIceEnd,
-        0,
-        this.MAX_INTEGER
-      );
+    // get the first timestamp
+    const connectedMedia = this.latencyTimestamps.get('client.ice.end');
+
+    const lobbyTimeLatency = this.getStayLobbyTime();
+    const lobbyTime = typeof lobbyTimeLatency === 'number' ? lobbyTimeLatency : 0;
+
+    if (interstitialJoinClickTimestamp && connectedMedia) {
+      const interstitialToMediaOKJmt = connectedMedia - interstitialJoinClickTimestamp - lobbyTime;
+
+      return clamp(interstitialToMediaOKJmt, 0, this.MAX_INTEGER);
     }
 
     return undefined;
@@ -456,20 +430,10 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
    */
   public getTotalJMT() {
     const clickToInterstitial = this.getClickToInterstitial();
-    const interstitialClickJoinToJoinLocusResponse = this.getDiffBetweenTimestamps(
-      'internal.client.interstitial-window.click.joinbutton',
-      'client.locus.join.response'
-    );
+    const interstitialToJoinOk = this.getInterstitialToJoinOK();
 
-    if (
-      typeof clickToInterstitial === 'number' &&
-      typeof interstitialClickJoinToJoinLocusResponse === 'number'
-    ) {
-      return clamp(
-        clickToInterstitial + interstitialClickJoinToJoinLocusResponse,
-        0,
-        this.MAX_INTEGER
-      );
+    if (typeof clickToInterstitial === 'number' && typeof interstitialToJoinOk === 'number') {
+      return clamp(clickToInterstitial + interstitialToJoinOk, 0, this.MAX_INTEGER);
     }
 
     return undefined;
@@ -481,20 +445,13 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
    */
   public getTotalJMTWithUserDelay() {
     const clickToInterstitialWithUserDelay = this.getClickToInterstitialWithUserDelay();
-    const interstitialShowedToJoinLocusResponse = this.getDiffBetweenTimestamps(
-      'internal.client.meeting.interstitial-window.showed',
-      'client.locus.join.response'
-    );
+    const interstitialToJoinOk = this.getInterstitialToJoinOK();
 
     if (
       typeof clickToInterstitialWithUserDelay === 'number' &&
-      typeof interstitialShowedToJoinLocusResponse === 'number'
+      typeof interstitialToJoinOk === 'number'
     ) {
-      return clamp(
-        clickToInterstitialWithUserDelay + interstitialShowedToJoinLocusResponse,
-        0,
-        this.MAX_INTEGER
-      );
+      return clamp(clickToInterstitialWithUserDelay + interstitialToJoinOk, 0, this.MAX_INTEGER);
     }
 
     return undefined;
@@ -521,26 +478,21 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
    */
   public getTotalMediaJMT() {
     const clickToInterstitial = this.getClickToInterstitial();
-    const interstitialClickJoinToMediaEngineReady = this.getDiffBetweenTimestamps(
-      'internal.client.interstitial-window.click.joinbutton',
-      'client.media-engine.ready'
-    );
-    const stayLobbyTimeCappedByMediaEngineReady = this.getStayLobbyTimeCappedBy(
-      'client.media-engine.ready'
-    );
+    const interstitialToJoinOk = this.getInterstitialToJoinOK();
+    const joinConfJMT = this.getJoinConfJMT();
+    const lobbyTime = this.getStayLobbyTime();
 
-    if (
-      typeof clickToInterstitial === 'number' &&
-      typeof interstitialClickJoinToMediaEngineReady === 'number' &&
-      typeof stayLobbyTimeCappedByMediaEngineReady === 'number'
-    ) {
-      return clamp(
-        clickToInterstitial +
-          interstitialClickJoinToMediaEngineReady -
-          stayLobbyTimeCappedByMediaEngineReady,
+    if (clickToInterstitial && interstitialToJoinOk && joinConfJMT) {
+      const totalMediaJMT = clamp(
+        clickToInterstitial + interstitialToJoinOk + joinConfJMT,
         0,
-        this.MAX_INTEGER
+        Infinity
       );
+      if (this.getMeeting()?.allowMediaInLobby) {
+        return clamp(totalMediaJMT, 0, this.MAX_INTEGER);
+      }
+
+      return clamp(totalMediaJMT - lobbyTime, 0, this.MAX_INTEGER);
     }
 
     return undefined;
@@ -552,17 +504,12 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
    */
   public getTotalMediaJMTWithUserDelay() {
     const clickToInterstitialWithUserDelay = this.getClickToInterstitialWithUserDelay();
-    const interstitialShowedToMediaEngineReady = this.getDiffBetweenTimestamps(
-      'internal.client.meeting.interstitial-window.showed',
-      'client.media-engine.ready'
-    );
+    const interstitialToJoinOk = this.getInterstitialToJoinOK();
+    const joinConfJMT = this.getJoinConfJMT();
 
-    if (
-      typeof clickToInterstitialWithUserDelay === 'number' &&
-      typeof interstitialShowedToMediaEngineReady === 'number'
-    ) {
+    if (clickToInterstitialWithUserDelay && interstitialToJoinOk && joinConfJMT) {
       return clamp(
-        clickToInterstitialWithUserDelay + interstitialShowedToMediaEngineReady,
+        clickToInterstitialWithUserDelay + interstitialToJoinOk + joinConfJMT,
         0,
         this.MAX_INTEGER
       );

package/src/call-diagnostic/call-diagnostic-metrics.ts

@@ -190,11 +190,6 @@ export default class CallDiagnosticMetrics extends StatelessWebexPlugin {
 
       // if ConvergedArchitecture enable and isConvergedWebinarWebcast -- then webcast
       if (meetingInfo?.enableConvergedArchitecture && meetingInfo?.enableEvent) {
-        // if enableConvergedWebinarLargeScale - then large scale webinar
-        if (meetingInfo?.enableConvergedWebinarLargeScale) {
-          return WEBEX_SUB_SERVICE_TYPES.LARGE_SCALE_WEBINAR;
-        }
-
         return meetingInfo?.isConvergedWebinarWebcast
           ? WEBEX_SUB_SERVICE_TYPES.WEBCAST
           : WEBEX_SUB_SERVICE_TYPES.WEBINAR;
@@ -371,7 +366,6 @@ export default class CallDiagnosticMetrics extends StatelessWebexPlugin {
     if (meeting?.locusInfo?.fullState) {
       identifiers.locusUrl = meeting.locusUrl;
       identifiers.locusId = meeting.locusUrl && meeting.locusUrl.split('/').pop();
-      identifiers.locusSessionId = meeting.locusInfo.fullState.sessionId;
       identifiers.locusStartTime =
         meeting.locusInfo.fullState && meeting.locusInfo.fullState.lastActive;
     }

package/src/call-diagnostic/call-diagnostic-metrics.util.ts

@@ -179,43 +179,6 @@ export const isSdpOfferCreationError = (rawError: any) => {
   return false;
 };
 
-export const isWebrtcApiNotAvailableError = (
-  rawError: {code: number; message: string; name: string} | unknown
-) => {
-  if ((rawError as {name: string}).name === ERROR_DESCRIPTIONS.WEBRTC_API_NOT_AVAILABLE) {
-    return true;
-  }
-
-  return false;
-};
-
-/**
- * Checks if the given error is a browser media error by its name.
- * Returns true if the error name matches any known browser media error name in the mapping.
- *
- * @param {Object} rawError - The error object to check.
- * @returns {boolean} True if the error is a browser media error, false otherwise.
- */
-export const isBrowserMediaError = (rawError) => {
-  // eslint-disable-next-line no-use-before-define
-  if (isBrowserMediaErrorName(rawError.name)) {
-    return true;
-  }
-
-  return false;
-};
-
-/**
- * Returns the client error code mapped to the given browser media error name.
- * If the error name is not found in the mapping, returns undefined.
- *
- * @param {Object} rawError - The error object containing the error name.
- * @returns {string|undefined} The mapped client error code, or undefined if not found.
- */
-export const getBrowserMediaErrorCode = (rawError) => {
-  return BROWSER_MEDIA_ERROR_NAME_TO_CLIENT_ERROR_CODES_MAP[rawError.name];
-};
-
 /**
  * MDN Media Devices getUserMedia() method returns a name if it errs
  * Documentation can be found here: https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia
@@ -284,8 +247,7 @@ export const prepareDiagnosticMetricItem = (webex: any, item: any) => {
         devicePairingType: webex.devicemanager.getPairedMethod(),
         deviceURL: pairedDevice.url,
         isPersonalDevice: pairedDevice.mode === 'personal',
-        productName:
-          pairedDevice.devices?.length > 0 ? pairedDevice.devices[0]?.productName : undefined,
+        productName: pairedDevice.devices[0]?.productName,
       };
       item.eventPayload.event.pairingState = 'paired';
       item.eventPayload.event.pairedDevice = devicePayload;
@@ -362,6 +324,7 @@ export const prepareDiagnosticMetricItem = (webex: any, item: any) => {
       joinTimes.totalMediaJMT = cdl.getTotalMediaJMT();
       joinTimes.interstitialToMediaOKJMT = cdl.getInterstitialToMediaOKJMT();
       joinTimes.callInitMediaEngineReady = cdl.getCallInitMediaEngineReady();
+      joinTimes.stayLobbyTime = cdl.getStayLobbyTime();
       joinTimes.totalMediaJMTWithUserDelay = cdl.getTotalMediaJMTWithUserDelay();
       joinTimes.totalJMTWithUserDelay = cdl.getTotalJMTWithUserDelay();
       break;
@@ -369,11 +332,6 @@ export const prepareDiagnosticMetricItem = (webex: any, item: any) => {
     case 'client.media.tx.start':
       audioSetupDelay.joinRespTxStart = cdl.getAudioJoinRespTxStart();
       videoSetupDelay.joinRespTxStart = cdl.getVideoJoinRespTxStart();
-      break;
-
-    case 'client.lobby.exited':
-      joinTimes.stayLobbyTime = cdl.getStayLobbyTime();
-      break;
   }
 
   if (!isEmpty(joinTimes)) {

package/src/call-diagnostic/config.ts

@@ -26,7 +26,6 @@ export const WEBEX_SUB_SERVICE_TYPES: Record<string, ClientSubServiceType> = {
   SCHEDULED_MEETING: 'ScheduledMeeting',
   WEBINAR: 'Webinar',
   WEBCAST: 'Webcast',
-  LARGE_SCALE_WEBINAR: 'LargeScaleWebinar',
 };
 
 // Found in https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia
@@ -134,7 +133,6 @@ export const ERROR_DESCRIPTIONS = {
   MULTISTREAM_NOT_AVAILABLE: 'MultistreamNotAvailable',
   SDP_OFFER_CREATION_ERROR: 'SdpOfferCreationError',
   SDP_OFFER_CREATION_ERROR_MISSING_CODEC: 'SdpOfferCreationErrorMissingCodec',
-  WEBRTC_API_NOT_AVAILABLE: 'WebrtcApiNotAvailableError',
   WDM_RESTRICTED_REGION: 'WdmRestrictedRegion',
   USER_NOT_ALLOWED_JOIN_WEBINAR: 'UserNotAllowedJoinWebinar',
 };

package/src/generic-metrics.ts

@@ -79,7 +79,7 @@ export default abstract class GenericMetrics extends StatelessWebexPlugin {
       device: {
         id: this.getDeviceId(),
       },
-      locale: window?.navigator.language,
+      locale: window.navigator.language,
       os: {
         name: getOSNameInternal(),
         version: getOSVersion(),
@@ -94,12 +94,12 @@ export default abstract class GenericMetrics extends StatelessWebexPlugin {
   protected getBrowserDetails(): object {
     return {
       browser: getBrowserName(),
-      browserHeight: window?.innerHeight,
+      browserHeight: window.innerHeight,
       browserVersion: getBrowserVersion(),
-      browserWidth: window?.innerWidth,
-      domain: window?.location.hostname,
-      inIframe: window?.self !== window?.top,
-      locale: window?.navigator.language,
+      browserWidth: window.innerWidth,
+      domain: window.location.hostname,
+      inIframe: window.self !== window.top,
+      locale: window.navigator.language,
       os: getOSNameInternal(),
     };
   }

package/src/index.ts

@@ -28,7 +28,6 @@ import BehavioralMetrics from './behavioral-metrics';
 import OperationalMetrics from './operational-metrics';
 import BusinessMetrics from './business-metrics';
 import RtcMetrics from './rtcMetrics';
-import PreLoginMetrics from './prelogin-metrics';
 
 registerInternalPlugin('metrics', Metrics, {
   config,
@@ -52,7 +51,6 @@ export {
   OperationalMetrics,
   BusinessMetrics,
   RtcMetrics,
-  PreLoginMetrics,
 };
 export type {
   ClientEvent,

package/src/metrics.types.ts

@@ -1,4 +1,4 @@
-import type {
+import {
   ClientEvent as RawClientEvent,
   Event as RawEvent,
   MediaQualityEvent as RawMediaQualityEvent,
@@ -197,7 +197,7 @@ export interface BusinessEventPayload {
   metricName: string;
   timestamp: number;
   context: DeviceContext;
-  browserDetails: object;
+  browserDetails: EventPayload;
   value: EventPayload;
 }