@webex/internal-plugin-metrics 3.12.0-next.1 → 3.12.0-next.11

package/test/unit/spec/call-diagnostic/call-diagnostic-metrics-latencies.ts

@@ -406,7 +406,7 @@ describe('internal-plugin-metrics', () => {
     });
 
     it('calculates getShowInterstitialTime correctly', () => {
-      cdl.saveTimestamp({key: 'client.interstitial-window.start-launch', value: 10});
+      cdl.saveTimestamp({key: 'internal.client.meeting.interstitial-window.showed', value: 10});
       cdl.saveTimestamp({key: 'internal.client.interstitial-window.click.joinbutton', value: 20});
       assert.deepEqual(cdl.getShowInterstitialTime(), 10);
     });
@@ -509,7 +509,7 @@ describe('internal-plugin-metrics', () => {
 
     it('calculates getStayLobbyTime correctly', () => {
       cdl.saveTimestamp({
-        key: 'client.locus.join.response',
+        key: 'client.lobby.entered',
         value: 10,
       });
       cdl.saveTimestamp({
@@ -519,6 +519,50 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getStayLobbyTime(), 10);
     });
 
+    describe('getStayLobbyTimeCappedBy', () => {
+      it('returns 0 when lobbyStartTimestamp is missing', () => {
+        cdl.saveTimestamp({key: 'client.media-engine.ready', value: 100});
+        assert.deepEqual(cdl.getStayLobbyTimeCappedBy('client.media-engine.ready'), 0);
+      });
+
+      it('returns undefined when endTimestampKey is missing', () => {
+        cdl.saveTimestamp({key: 'client.lobby.entered', value: 10});
+        assert.deepEqual(cdl.getStayLobbyTimeCappedBy('client.media-engine.ready'), undefined);
+      });
+
+      it('uses maximumEndTimestamp when lobby end does not exist', () => {
+        cdl.saveTimestamp({key: 'client.lobby.entered', value: 10});
+        cdl.saveTimestamp({key: 'client.media-engine.ready', value: 50});
+        assert.deepEqual(cdl.getStayLobbyTimeCappedBy('client.media-engine.ready'), 40);
+      });
+
+      it('uses lobby end when it is before maximumEndTimestamp', () => {
+        cdl.saveTimestamp({key: 'client.lobby.entered', value: 10});
+        cdl.saveTimestamp({key: 'client.lobby.exited', value: 30});
+        cdl.saveTimestamp({key: 'client.media-engine.ready', value: 50});
+        assert.deepEqual(cdl.getStayLobbyTimeCappedBy('client.media-engine.ready'), 20);
+      });
+
+      it('uses maximumEndTimestamp when lobby end is after it', () => {
+        cdl.saveTimestamp({key: 'client.lobby.entered', value: 10});
+        cdl.saveTimestamp({key: 'client.lobby.exited', value: 60});
+        cdl.saveTimestamp({key: 'client.media-engine.ready', value: 50});
+        assert.deepEqual(cdl.getStayLobbyTimeCappedBy('client.media-engine.ready'), 40);
+      });
+
+      it('clamps to 0 when result would be negative', () => {
+        cdl.saveTimestamp({key: 'client.lobby.entered', value: 100});
+        cdl.saveTimestamp({key: 'client.media-engine.ready', value: 50});
+        assert.deepEqual(cdl.getStayLobbyTimeCappedBy('client.media-engine.ready'), 0);
+      });
+
+      it('clamps to MAX_INTEGER when result is very large', () => {
+        cdl.saveTimestamp({key: 'client.lobby.entered', value: 0});
+        cdl.saveTimestamp({key: 'client.media-engine.ready', value: 2147483648});
+        assert.deepEqual(cdl.getStayLobbyTimeCappedBy('client.media-engine.ready'), 2147483647);
+      });
+    });
+
     it('calculates getPageJMT correctly', () => {
       cdl.saveLatency('internal.client.pageJMT', 10);
       assert.deepEqual(cdl.getPageJMT(), 10);
@@ -530,71 +574,31 @@ describe('internal-plugin-metrics', () => {
     });
 
     it('calculates getClickToInterstitial correctly', () => {
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.click.joinbutton',
-        value: 10,
-      });
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.interstitial-window.showed',
-        value: 20,
-      });
-      assert.deepEqual(cdl.getClickToInterstitial(), 10);
-    });
-
-    it('calculates getClickToInterstitial without join button timestamp', () => {
       cdl.saveLatency('internal.click.to.interstitial', 5);
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.interstitial-window.showed',
-        value: 20,
-      });
       assert.deepEqual(cdl.getClickToInterstitial(), 5);
     });
 
-    it('calculates getClickToInterstitial without join button timestamp when it is 0', () => {
+    it('calculates getClickToInterstitial correctly when it is 0', () => {
       cdl.saveLatency('internal.click.to.interstitial', 0);
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.interstitial-window.showed',
-        value: 20,
-      });
       assert.deepEqual(cdl.getClickToInterstitial(), 0);
     });
 
-    it('calculates getClickToInterstitial without join button timestamp when it is greater than MAX_INTEGER', () => {
+    it('calculates getClickToInterstitial correctly when it is greater than MAX_INTEGER', () => {
       cdl.saveLatency('internal.click.to.interstitial', 2147483648);
       assert.deepEqual(cdl.getClickToInterstitial(), 2147483647);
     });
 
     it('calculates getClickToInterstitialWithUserDelay correctly', () => {
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.click.joinbutton',
-        value: 10,
-      });
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.interstitial-window.showed',
-        value: 20,
-      });
-      assert.deepEqual(cdl.getClickToInterstitialWithUserDelay(), 10);
-    });
-
-    it('calculates getClickToInterstitialWithUserDelay without join button timestamp', () => {
       cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 5);
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.interstitial-window.showed',
-        value: 20,
-      });
       assert.deepEqual(cdl.getClickToInterstitialWithUserDelay(), 5);
     });
 
-    it('calculates getClickToInterstitialWithUserDelay without join button timestamp when it is 0', () => {
+    it('calculates getClickToInterstitialWithUserDelay correctly when it is 0', () => {
       cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 0);
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.interstitial-window.showed',
-        value: 20,
-      });
       assert.deepEqual(cdl.getClickToInterstitialWithUserDelay(), 0);
     });
 
-    it('calculates getClickToInterstitialWithUserDelay without join button timestamp when it is greater than MAX_INTEGER', () => {
+    it('calculates getClickToInterstitialWithUserDelay correctly when it is greater than MAX_INTEGER', () => {
       cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 2147483648);
       assert.deepEqual(cdl.getClickToInterstitialWithUserDelay(), 2147483647);
     });
@@ -624,30 +628,16 @@ describe('internal-plugin-metrics', () => {
     });
 
     it('calculates getCallInitMediaEngineReady correctly', () => {
-      cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
-        value: 10,
-      });
-      cdl.saveTimestamp({
-        key: 'client.media-engine.ready',
-        value: 20,
-      });
-      assert.deepEqual(cdl.getCallInitMediaEngineReady(), 10);
+      sinon.stub(cdl, 'getInterstitialToMediaOKJMT').returns(42);
+      assert.deepEqual(cdl.getCallInitMediaEngineReady(), 42);
     });
 
     it('calculates getTotalJMT correctly', () => {
+      cdl.saveLatency('internal.click.to.interstitial', 10);
       cdl.saveTimestamp({
         key: 'internal.client.interstitial-window.click.joinbutton',
         value: 5,
       });
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.click.joinbutton',
-        value: 10,
-      });
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.interstitial-window.showed',
-        value: 20,
-      });
       cdl.saveTimestamp({
         key: 'client.locus.join.response',
         value: 40,
@@ -668,7 +658,7 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getTotalJMT(), 20);
     });
 
-    it('calculates getTotalJMT correctly when interstitialToJoinOk is 0', () => {
+    it('calculates getTotalJMT correctly when interstitialClickJoinToJoinLocusResponse is 0', () => {
       cdl.saveTimestamp({
         key: 'internal.client.interstitial-window.click.joinbutton',
         value: 40,
@@ -681,7 +671,7 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getTotalJMT(), 12);
     });
 
-    it('calculates getTotalJMT correctly when both clickToInterstitial and interstitialToJoinOk are 0', () => {
+    it('calculates getTotalJMT correctly when both clickToInterstitial and interstitialClickJoinToJoinLocusResponse are 0', () => {
       cdl.saveTimestamp({
         key: 'internal.client.interstitial-window.click.joinbutton',
         value: 40,
@@ -721,14 +711,7 @@ describe('internal-plugin-metrics', () => {
     });
 
     it('calculates getTotalJMTWithUserDelay correctly', () => {
-      cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
-        value: 5,
-      });
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.click.joinbutton',
-        value: 10,
-      });
+      cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 10);
       cdl.saveTimestamp({
         key: 'internal.client.meeting.interstitial-window.showed',
         value: 20,
@@ -737,13 +720,13 @@ describe('internal-plugin-metrics', () => {
         key: 'client.locus.join.response',
         value: 40,
       });
-      assert.deepEqual(cdl.getTotalJMTWithUserDelay(), 45);
+      assert.deepEqual(cdl.getTotalJMTWithUserDelay(), 30);
     });
 
     it('calculates getTotalJMTWithUserDelay correctly when clickToInterstitialWithUserDelay is 0', () => {
       cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 0);
       cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
+        key: 'internal.client.meeting.interstitial-window.showed',
         value: 20,
       });
       cdl.saveTimestamp({
@@ -753,9 +736,9 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getTotalJMTWithUserDelay(), 20);
     });
 
-    it('calculates getTotalJMTWithUserDelay correctly when interstitialToJoinOk is 0', () => {
+    it('calculates getTotalJMTWithUserDelay correctly when interstitialShowedToJoinLocusResponse is 0', () => {
       cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
+        key: 'internal.client.meeting.interstitial-window.showed',
         value: 40,
       });
       cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 12);
@@ -766,9 +749,9 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getTotalJMTWithUserDelay(), 12);
     });
 
-    it('calculates getTotalJMTWithUserDelay correctly when both clickToInterstitialWithUserDelay and interstitialToJoinOk are 0', () => {
+    it('calculates getTotalJMTWithUserDelay correctly when both clickToInterstitialWithUserDelay and interstitialShowedToJoinLocusResponse are 0', () => {
       cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
+        key: 'internal.client.meeting.interstitial-window.showed',
         value: 40,
       });
       cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 0);
@@ -781,7 +764,7 @@ describe('internal-plugin-metrics', () => {
 
     it('calculates getTotalJMTWithUserDelay correctly when both clickToInterstitialWithUserDelay is not a number', () => {
       cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
+        key: 'internal.client.meeting.interstitial-window.showed',
         value: 40,
       });
       cdl.saveLatency(
@@ -798,7 +781,7 @@ describe('internal-plugin-metrics', () => {
     it('calculates getTotalJMTWithUserDelay correctly when it is greater than MAX_INTEGER', () => {
       cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 2147483648);
       cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
+        key: 'internal.client.meeting.interstitial-window.showed',
         value: 20,
       });
       cdl.saveTimestamp({
@@ -808,215 +791,101 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getTotalJMTWithUserDelay(), 2147483647);
     });
 
-    it('calculates getTotalMediaJMT correctly', () => {
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.click.joinbutton',
-        value: 5,
-      });
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.interstitial-window.showed',
-        value: 8,
-      });
-      cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
-        value: 10,
-      });
-      cdl.saveTimestamp({
-        key: 'client.locus.join.request',
-        value: 12,
-      });
-      cdl.saveTimestamp({
-        key: 'client.locus.join.response',
-        value: 20,
-      });
-      cdl.saveTimestamp({
-        key: 'client.lobby.exited',
-        value: 24,
-      });
-      cdl.saveTimestamp({
-        key: 'client.ice.start',
-        value: 30,
-      });
-      cdl.saveTimestamp({
-        key: 'client.ice.end',
-        value: 40,
-      });
-      assert.deepEqual(cdl.getTotalMediaJMT(), 27);
+    it('calculates getTotalMediaJMT correctly with lobby exiting before media-engine.ready', () => {
+      cdl.saveLatency('internal.click.to.interstitial', 3);
+      // clickToInterstitial = 3
+      cdl.saveTimestamp({key: 'internal.client.interstitial-window.click.joinbutton', value: 10});
+      cdl.saveTimestamp({key: 'client.media-engine.ready', value: 50});
+      // interstitialClickJoinToMediaEngineReady = 50 - 10 = 40
+      cdl.saveTimestamp({key: 'client.lobby.entered', value: 20});
+      cdl.saveTimestamp({key: 'client.lobby.exited', value: 30});
+      // stayLobbyTimeCappedByMediaEngineReady = min(30, 50) - 20 = 10
+      // total = 3 + 40 - 10 = 33
+      assert.deepEqual(cdl.getTotalMediaJMT(), 33);
+    });
+
+    it('calculates getTotalMediaJMT correctly without lobby', () => {
+      cdl.saveLatency('internal.click.to.interstitial', 3);
+      // clickToInterstitial = 3
+      cdl.saveTimestamp({key: 'internal.client.interstitial-window.click.joinbutton', value: 10});
+      cdl.saveTimestamp({key: 'client.media-engine.ready', value: 50});
+      // interstitialClickJoinToMediaEngineReady = 40
+      // no client.lobby.entered → stayLobbyTimeCappedByMediaEngineReady = 0
+      // total = 3 + 40 - 0 = 43
+      assert.deepEqual(cdl.getTotalMediaJMT(), 43);
+    });
+
+    it('calculates getTotalMediaJMT correctly with lobby exiting after media-engine.ready', () => {
+      cdl.saveLatency('internal.click.to.interstitial', 3);
+      // clickToInterstitial = 3
+      cdl.saveTimestamp({key: 'internal.client.interstitial-window.click.joinbutton', value: 10});
+      cdl.saveTimestamp({key: 'client.media-engine.ready', value: 50});
+      // interstitialClickJoinToMediaEngineReady = 40
+      cdl.saveTimestamp({key: 'client.lobby.entered', value: 20});
+      cdl.saveTimestamp({key: 'client.lobby.exited', value: 60});
+      // stayLobbyTimeCappedByMediaEngineReady = min(60, 50) - 20 = 30
+      // total = 3 + 40 - 30 = 13
+      assert.deepEqual(cdl.getTotalMediaJMT(), 13);
     });
 
     it('calculates getTotalMediaJMT correctly when it is greater than MAX_INTEGER', () => {
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.click.joinbutton',
-        value: 5,
-      });
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.interstitial-window.showed',
-        value: 8,
-      });
-      cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
-        value: 10,
-      });
-      cdl.saveTimestamp({
-        key: 'client.locus.join.request',
-        value: 12,
-      });
-      cdl.saveTimestamp({
-        key: 'client.locus.join.response',
-        value: 2147483700,
-      });
-      cdl.saveTimestamp({
-        key: 'client.lobby.exited',
-        value: 2147483800,
-      });
-      cdl.saveTimestamp({
-        key: 'client.ice.start',
-        value: 30,
-      });
-      cdl.saveTimestamp({
-        key: 'client.ice.end',
-        value: 100,
-      });
+      cdl.saveLatency('internal.click.to.interstitial', 3);
+      cdl.saveTimestamp({key: 'internal.client.interstitial-window.click.joinbutton', value: 10});
+      cdl.saveTimestamp({key: 'client.media-engine.ready', value: 4294967400});
+      cdl.saveTimestamp({key: 'client.lobby.entered', value: 28});
+      cdl.saveTimestamp({key: 'client.lobby.exited', value: 30});
       assert.deepEqual(cdl.getTotalMediaJMT(), 2147483647);
     });
 
-    it('calculates getTotalMediaJMT correctly with allowMediaInLobby true', () => {
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.click.joinbutton',
-        value: 5,
-        options: {meetingId: 'meeting-id'},
-      });
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.interstitial-window.showed',
-        value: 8,
-      });
-      cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
-        value: 10,
-      });
-      cdl.saveTimestamp({
-        key: 'client.locus.join.request',
-        value: 12,
-      });
-      cdl.saveTimestamp({
-        key: 'client.locus.join.response',
-        value: 20,
-      });
-      cdl.saveTimestamp({
-        key: 'client.lobby.exited',
-        value: 24,
-      });
-      cdl.saveTimestamp({
-        key: 'client.ice.start',
-        value: 30,
-      });
-      cdl.saveTimestamp({
-        key: 'client.ice.end',
-        value: 40,
-      });
-      assert.deepEqual(cdl.getTotalMediaJMT(), 31);
+    it('returns undefined for getTotalMediaJMT when media-engine.ready is missing', () => {
+      cdl.saveLatency('internal.click.to.interstitial', 3);
+      cdl.saveTimestamp({key: 'internal.client.interstitial-window.click.joinbutton', value: 10});
+      cdl.saveTimestamp({key: 'client.locus.join.response', value: 20});
+      assert.deepEqual(cdl.getTotalMediaJMT(), undefined);
     });
 
-    it('calculates getTotalMediaJMT correctly with allowMediaInLobby true and it is greater than MAX_INTEGER', () => {
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.click.joinbutton',
-        value: 5,
-        options: {meetingId: 'meeting-id'},
-      });
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.interstitial-window.showed',
-        value: 100,
-      });
-      cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
-        value: 1000,
-      });
-      cdl.saveTimestamp({
-        key: 'client.locus.join.request',
-        value: 2000,
-      });
-      cdl.saveTimestamp({
-        key: 'client.locus.join.response',
-        value: 2147483700,
-      });
-      cdl.saveTimestamp({
-        key: 'client.lobby.exited',
-        value: 2147483800,
-      });
-      cdl.saveTimestamp({
-        key: 'client.ice.start',
-        value: 2147483900,
-      });
-      cdl.saveTimestamp({
-        key: 'client.ice.end',
-        value: 4294967400,
-      });
-      assert.deepEqual(cdl.getTotalMediaJMT(), 2147483647);
+    it('calculates getTotalMediaJMT correctly when there is no lobby and stayLobbyTime defaults to 0', () => {
+      cdl.saveLatency('internal.click.to.interstitial', 3);
+      // clickToInterstitial = 3
+      cdl.saveTimestamp({key: 'internal.client.interstitial-window.click.joinbutton', value: 10});
+      cdl.saveTimestamp({key: 'client.media-engine.ready', value: 50});
+      // interstitialClickJoinToMediaEngineReady = 50 - 10 = 40
+      // no client.lobby.entered → stayLobbyTimeCappedByMediaEngineReady = 0
+      // total = 3 + 40 - 0 = 43
+      assert.deepEqual(cdl.getTotalMediaJMT(), 43);
     });
 
     it('calculates getTotalMediaJMTWithUserDelay correctly', () => {
       cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 7);
-      cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
-        value: 10,
-      });
-      cdl.saveTimestamp({
-        key: 'client.locus.join.request',
-        value: 12,
-      });
-      cdl.saveTimestamp({
-        key: 'client.locus.join.response',
-        value: 20,
-      });
-      cdl.saveTimestamp({
-        key: 'internal.host.meeting.participant.admitted',
-        value: 24,
-      });
-      cdl.saveTimestamp({
-        key: 'client.ice.start',
-        value: 30,
-      });
-      cdl.saveTimestamp({
-        key: 'client.ice.end',
-        value: 40,
-      });
-      assert.deepEqual(cdl.getTotalMediaJMTWithUserDelay(), 35);
+      // clickToInterstitialWithUserDelay = 7
+      cdl.saveTimestamp({key: 'internal.client.meeting.interstitial-window.showed', value: 10});
+      cdl.saveTimestamp({key: 'client.media-engine.ready', value: 50});
+      // interstitialShowedToMediaEngineReady = 50 - 10 = 40
+      // total = 7 + 40 = 47
+      assert.deepEqual(cdl.getTotalMediaJMTWithUserDelay(), 47);
     });
 
     it('calculates getTotalMediaJMTWithUserDelay correctly for guest join', () => {
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.click.joinbutton',
-        value: 5,
-      });
-      cdl.saveTimestamp({
-        key: 'internal.client.meeting.interstitial-window.showed',
-        value: 8,
-      });
-      cdl.saveTimestamp({
-        key: 'internal.client.interstitial-window.click.joinbutton',
-        value: 10,
-      });
-      cdl.saveTimestamp({
-        key: 'client.locus.join.request',
-        value: 12,
-      });
-      cdl.saveTimestamp({
-        key: 'client.locus.join.response',
-        value: 20,
-      });
-      cdl.saveTimestamp({
-        key: 'internal.host.meeting.participant.admitted',
-        value: 24,
-      });
-      cdl.saveTimestamp({
-        key: 'client.ice.start',
-        value: 30,
-      });
-      cdl.saveTimestamp({
-        key: 'client.ice.end',
-        value: 40,
-      });
-      assert.deepEqual(cdl.getTotalMediaJMTWithUserDelay(), 31);
+      cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 3);
+      // clickToInterstitialWithUserDelay = 3
+      cdl.saveTimestamp({key: 'internal.client.meeting.interstitial-window.showed', value: 8});
+      cdl.saveTimestamp({key: 'client.media-engine.ready', value: 50});
+      // interstitialShowedToMediaEngineReady = 50 - 8 = 42
+      // total = 3 + 42 = 45
+      assert.deepEqual(cdl.getTotalMediaJMTWithUserDelay(), 45);
+    });
+
+    it('returns undefined for getTotalMediaJMTWithUserDelay when media-engine.ready is missing', () => {
+      cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 7);
+      cdl.saveTimestamp({key: 'internal.client.meeting.interstitial-window.showed', value: 10});
+      assert.deepEqual(cdl.getTotalMediaJMTWithUserDelay(), undefined);
+    });
+
+    it('calculates getTotalMediaJMTWithUserDelay correctly when it is greater than MAX_INTEGER', () => {
+      cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 2147483648);
+      cdl.saveTimestamp({key: 'internal.client.meeting.interstitial-window.showed', value: 10});
+      cdl.saveTimestamp({key: 'client.media-engine.ready', value: 50});
+      assert.deepEqual(cdl.getTotalMediaJMTWithUserDelay(), 2147483647);
     });
 
     it('calculates getJoinConfJMT correctly', () => {
@@ -1062,6 +931,7 @@ describe('internal-plugin-metrics', () => {
     });
 
     it('calculates getClientJMT correctly', () => {
+      cdl.saveLatency('internal.click.to.interstitial.for.client.jmt', 5);
       cdl.saveTimestamp({
         key: 'internal.client.interstitial-window.click.joinbutton',
         value: 2,
@@ -1070,19 +940,25 @@ describe('internal-plugin-metrics', () => {
         key: 'client.locus.join.request',
         value: 6,
       });
+      // clickToInterstitialForClientJmt (5) + interstitialJoinToLocusJoinRequest (6 - 2 = 4) = 9
+      assert.deepEqual(cdl.getClientJMT(), 9);
+    });
+
+    it('returns undefined for getClientJMT when clickToInterstitialForClientJmt is missing', () => {
       cdl.saveTimestamp({
-        key: 'client.locus.join.response',
-        value: 8,
-      });
-      cdl.saveTimestamp({
-        key: 'client.ice.start',
-        value: 10,
+        key: 'internal.client.interstitial-window.click.joinbutton',
+        value: 2,
       });
       cdl.saveTimestamp({
-        key: 'client.ice.end',
-        value: 11,
+        key: 'client.locus.join.request',
+        value: 6,
       });
-      assert.deepEqual(cdl.getClientJMT(), 3);
+      assert.deepEqual(cdl.getClientJMT(), undefined);
+    });
+
+    it('returns undefined for getClientJMT when interstitialJoinToLocusJoinRequest is missing', () => {
+      cdl.saveLatency('internal.click.to.interstitial.for.client.jmt', 5);
+      assert.deepEqual(cdl.getClientJMT(), undefined);
     });
 
     it('calculates getAudioJoinRespRxStart correctly', () => {
@@ -1139,7 +1015,7 @@ describe('internal-plugin-metrics', () => {
         value: 4,
       });
       cdl.saveTimestamp({
-        key: 'client.locus.join.response',
+        key: 'client.lobby.entered',
         value: 10,
       });
       cdl.saveTimestamp({
@@ -1159,12 +1035,12 @@ describe('internal-plugin-metrics', () => {
         value: 4,
       });
       cdl.saveTimestamp({
-        key: 'client.locus.join.response',
+        key: 'client.lobby.entered',
         value: 10,
       });
       cdl.saveTimestamp({
         key: 'client.lobby.exited',
-        value: 12,
+        value: 10,
       });
       cdl.saveTimestamp({
         key: 'client.ice.end',
@@ -1182,6 +1058,22 @@ describe('internal-plugin-metrics', () => {
         key: 'client.ice.end',
         value: 14,
       });
+      // no client.lobby.entered → stayLobbyTimeCappedByIceEnd = 0
+      // result = (14 - 4) - 0 = 10
+      assert.deepEqual(cdl.getInterstitialToMediaOKJMT(), 10);
+    });
+
+    it('calculates getInterstitialToMediaOKJMT correctly when there is no lobby and stayLobbyTime defaults to 0', () => {
+      cdl.saveTimestamp({
+        key: 'internal.client.interstitial-window.click.joinbutton',
+        value: 4,
+      });
+      cdl.saveTimestamp({
+        key: 'client.ice.end',
+        value: 14,
+      });
+      // no client.lobby.entered → stayLobbyTimeCappedByIceEnd = 0
+      // result = (14 - 4) - 0 = 10
       assert.deepEqual(cdl.getInterstitialToMediaOKJMT(), 10);
     });
 

package/test/unit/spec/call-diagnostic/call-diagnostic-metrics.ts

@@ -3680,6 +3680,15 @@ describe('internal-plugin-metrics', () => {
         assert.deepEqual(cd.getSubServiceType(fakeMeeting), 'Webcast');
       });
 
+      it('returns subServicetype as LargeScaleWebinar when meeting is converged Webinar and enable large scale', () => {
+        fakeMeeting.meetingInfo = {
+          enableEvent: true,
+          enableConvergedArchitecture: true,
+          enableConvergedWebinarLargeScale: true,
+        };
+        assert.deepEqual(cd.getSubServiceType(fakeMeeting), 'LargeScaleWebinar');
+      });
+
       it('returns subServicetype as undefined when correct parameters are not found', () => {
         fakeMeeting.meetingInfo = {};
         assert.deepEqual(cd.getSubServiceType(fakeMeeting), undefined);