@webex/internal-plugin-metrics 3.12.0-auth-prejoin-fetch.1 → 3.12.0-llmrefactor.10

package/README.md

@@ -9,6 +9,7 @@ This is an internal Cisco Webex plugin. As such, it does not strictly adhere to
 - [Install](#install)
 - [Usage](#usage)
 - [Unhandled exception telemetry](#unhandled-exception-telemetry)
+- [Network request telemetry](#network-request-telemetry)
 - [Contribute](#contribute)
 - [Maintainers](#maintainers)
 - [License](#license)
@@ -47,7 +48,7 @@ Telemetry is disabled by default. Enable it with
 include application context such as `orgId` and `dataCenter`. Metadata must not contain personally
 identifiable information or credentials.
 
-```js
+````js
 import Webex from 'webex';
 
 const webex = Webex.init({
@@ -63,6 +64,243 @@ const webex = Webex.init({
     },
   },
 });
+## Network request telemetry
+
+Network request telemetry is disabled by default. Enable it with
+`metrics.networkTelemetry.enabled: true`. When enabled, the metrics plugin summarizes requests
+made through the Webex SDK request pipeline. The reporting interval is configurable with
+`metrics.networkTelemetry.intervalMs` and defaults to ten minutes. It listens to the SDK-wide `request:start`,
+`request:success`, and `request:failure` events, so individual plugins do not need to wrap or
+replace `webex.request()`.
+
+For example, to collect one-minute windows:
+
+```js
+const webex = Webex.init({
+  config: {
+    metrics: {
+      networkTelemetry: {
+        enabled: true,
+        intervalMs: 60 * 1_000,
+      },
+    },
+  },
+});
+```
+
+The listeners are installed once for each Webex instance when `webex.internal.metrics` is
+constructed and the feature is enabled. The metrics package must be imported before constructing
+the Webex instance. Standard Webex SDK bundles already import and register the metrics plugin.
+
+### Scope
+
+The collector counts request and response outcomes that pass through `webex.request()` and its interceptors. For failures, it also records aggregated error details covering:
+
+- HTTP responses rejected by the SDK, such as `4xx` and `5xx` responses.
+- Network or CORS failures where no HTTP response is available.
+- Aborted and timed-out SDK requests when the error exposes that information.
+- Request preparation failures that emit `request:failure`.
+
+It does not monitor arbitrary application `fetch()`, `XMLHttpRequest`, WebSocket, or other traffic outside the SDK request pipeline. It also does not use `PerformanceObserver` or browser-wide request interception.
+
+### Event flow
+
+```text
+webex.request()
+  -> SDK request interceptors
+  -> request:start(options)
+  -> request:success(options, response) or request:failure(options, reason)
+  -> metrics request outcome listeners
+  -> aggregate host, endpoint, response, and error counts
+  -> every configured interval, submit JS_SDK_NETWORK_REQUEST_SUMMARY
+````
+
+The listeners and ten-minute accumulator are registered during metrics plugin initialization:
+
+```js
+initialize(...args) {
+  WebexPlugin.prototype.initialize.call(this, ...args);
+  if (this.webex.config.metrics.networkTelemetry.enabled !== true) {
+    return;
+  }
+  this.networkTelemetry = createNetworkTelemetryCollector(/* submission callbacks */);
+  this.listenTo(this.webex, 'request:start', this.recordNetworkRequestStart);
+  this.listenTo(this.webex, 'request:success', this.recordNetworkRequestSuccess);
+  this.listenTo(this.webex, 'request:failure', this.recordNetworkRequestFailure);
+}
+```
+
+The metrics plugin exposes `flushNetworkTelemetry()` for callers that need to submit the current
+non-empty window immediately, such as after an early call failure. When the metrics plugin is
+stopped, any non-empty partial window is submitted once before the collector is disposed. Empty
+windows are not submitted during shutdown, and the shutdown hook waits for the submission attempt
+to settle.
+
+```js
+await webex.internal.metrics.flushNetworkTelemetry();
+```
+
+### Metric schema
+
+One operational client metric named `JS_SDK_NETWORK_REQUEST_SUMMARY` is submitted at the configured
+interval. Its `eventPayload` has this shape:
+
+```ts
+type NetworkTelemetry = {
+  metricsSummary: {
+    totalSendRequest: number;
+    totalFailedRequest: number;
+    totalRecvdResponse: number;
+    totalFailedResponse: number;
+  };
+  metrics: Array<{
+    host: string;
+    endPoint: string;
+    countSendRequest: number;
+    countFailedRequest: number;
+    countRecvdResponse: number;
+    countFailedResponse: number;
+    averageNetworkDurationMs: number;
+    maxNetworkDurationP90Ms: number;
+    maxNetworkDurationP99Ms: number;
+  }>;
+  errorMetrics: Array<{
+    host: string;
+    endPoint: string;
+    statusCode: number;
+    errorCode: string;
+    method: string;
+    errorType: string;
+    errorMessage: string;
+    trackingIds: string[];
+    countError: number;
+  }>;
+  errorMetricsSummary: Record<string, {count: number}>;
+};
+```
+
+The SDK adds application metadata to the outer client metric when it wraps this `eventPayload`:
+
+| Property             | Source                                                                      |
+| -------------------- | --------------------------------------------------------------------------- |
+| `tags.app_name`      | `webex.config.appName`, or `unknown`                                        |
+| `tags.app_version`   | `webex.config.appVersion`, or `unknown`                                     |
+| `tags.app_url`       | Browser origin without path/query data, hostname fallback, or `non-browser` |
+| `fields.sdk_version` | `webex.version`                                                             |
+
+Counter mapping:
+
+| Event or outcome                                    | Summary and endpoint counters                                               |
+| --------------------------------------------------- | --------------------------------------------------------------------------- |
+| `request:start`                                     | `totalSendRequest`, `countSendRequest`                                      |
+| `request:success`                                   | `totalRecvdResponse`, `countRecvdResponse`                                  |
+| `request:failure` without an HTTP response          | `totalFailedRequest`, `countFailedRequest`                                  |
+| `request:failure` with an HTTP status (`4xx`/`5xx`) | Received-response counters plus `totalFailedResponse`/`countFailedResponse` |
+
+The `metrics` array is grouped by `host` and `endPoint`. For service-based SDK requests, `host` is the normalized logical service name. Direct-URI requests use the URI host. `endPoint` is a sanitized resource or URI path. `averageNetworkDurationMs` is the average measured network duration for completed requests in the group, while `maxNetworkDurationP90Ms` and `maxNetworkDurationP99Ms` are the maximum durations at the nearest-rank 90th and 99th percentiles. All values are in milliseconds.
+
+The `errorMetrics` array groups identical failures by host, endpoint, status code, error code, method, error type, and error message. `countError` records the number of occurrences, while `trackingIds` retains at most ten unique identifiers. `errorMetricsSummary` counts errors by status code; status `0` means no HTTP response was available.
+
+Example:
+
+```js
+{
+  metricName: 'JS_SDK_NETWORK_REQUEST_SUMMARY',
+  type: 'operational',
+  fields: {
+    totalSendRequest: 14,
+    totalFailedRequest: 1,
+    totalRecvdResponse: 13,
+    totalFailedResponse: 1
+  },
+  eventPayload: {
+    metricsSummary: {
+      totalSendRequest: 14,
+      totalFailedRequest: 1,
+      totalRecvdResponse: 13,
+      totalFailedResponse: 1
+    },
+    metrics: [{
+      host: 'hydra',
+      endPoint: 'rooms/:id/messages',
+      countSendRequest: 2,
+      countFailedRequest: 0,
+      countRecvdResponse: 2,
+      countFailedResponse: 1,
+      averageNetworkDurationMs: 410,
+      maxNetworkDurationP90Ms: 510,
+      maxNetworkDurationP99Ms: 640
+    }],
+    errorMetrics: [{
+      host: 'hydra',
+      endPoint: 'rooms/:id/messages',
+      statusCode: 503,
+      errorCode: 'SERVICE_UNAVAILABLE',
+      method: 'POST',
+      errorType: 'server_error',
+      errorMessage: 'Service unavailable',
+      trackingIds: ['example-tracking-id'],
+      countError: 1
+    }],
+    errorMetricsSummary: {
+      503: {count: 1}
+    }
+  }
+}
+```
+
+### Failure classification
+
+Classification is evaluated in the following order:
+
+| Condition                                                                                                 | `errorType`     |
+| --------------------------------------------------------------------------------------------------------- | --------------- |
+| Error name is `AbortError`                                                                                | `aborted`       |
+| Status is `408` or `504`, timeout appears in the error details, or the configured request timeout elapsed | `timeout`       |
+| Status is `429`                                                                                           | `rate_limited`  |
+| Status is `5xx`                                                                                           | `server_error`  |
+| Status is `4xx`                                                                                           | `client_error`  |
+| No response status is available, or the error name contains `network`                                     | `network_error` |
+| Any other SDK request failure                                                                             | `request_error` |
+
+### Telemetry request exclusion
+
+Requests to the `metrics` and `unifiedTelemetry` services are excluded from both success and failure collection. The exclusion also covers the legacy `api: 'metrics'` request option. This prevents a telemetry upload from affecting its own summary.
+
+The exclusion is centralized in the collector; telemetry request call sites do not require special flags.
+
+### Endpoint normalization and cardinality
+
+The `endPoint` value is derived from `options.resource`, or from the URI path for a direct-URI request:
+
+- Query parameters and fragments are removed.
+- Numeric, percent-encoded, uppercase, and otherwise non-route-looking segments are replaced with `:id`.
+
+For example:
+
+```text
+rooms/Y2lzY29zcGFyazovL3VzL1JPT00/messages?personId=secret
+```
+
+becomes:
+
+```text
+rooms/:id/messages
+```
+
+Endpoint normalization is heuristic. A short lowercase alphabetic identifier can resemble a static route segment. Do not place sensitive values directly in a resource path; use normal SDK resource identifiers and avoid embedding credentials or personal data in route names. Error messages are included because they are part of the requested error aggregate schema; callers should not put credentials or personal data in thrown error messages.
+
+### Submission behavior
+
+Each ten-minute summary uses the existing `submitClientMetrics()` batching and transport path. The accumulator resets at the reporting boundary before asynchronous submission, so requests received while a summary is being sent belong to the next window. A telemetry submission failure is caught and logged.
+
+### Tests
+
+Run the focused unit tests with Node.js 22.14:
+
+```bash
+nvm use 22.14
+yarn workspace @webex/internal-plugin-metrics test:unit --targets network-telemetry.ts
 ```
 
 ## Maintainers

package/dist/call-diagnostic/call-diagnostic-metrics.js

@@ -49,6 +49,10 @@ var _BrowserDetection = (0, _common.BrowserDetection)(),
   getOSVersion = _BrowserDetection.getOSVersion,
   getBrowserName = _BrowserDetection.getBrowserName,
   getBrowserVersion = _BrowserDetection.getBrowserVersion;
+var LOCUS_HTTP_STATUS_TO_CLIENT_ERROR_CODE = {
+  429: _config2.LOCUS_RATE_LIMITED_OUTGOING_CLIENT_CODE,
+  503: _config2.LOCUS_UNAVAILABLE_CLIENT_CODE
+};
 /**
  * @description Util class to handle Call Analyzer Metrics
  * @export
@@ -354,6 +358,22 @@ var CallDiagnosticMetrics = exports.default = /*#__PURE__*/function (_StatelessW
       throw new Error("ClientType and SubClientType can't be undefined");
     }
 
+    /**
+     * Returns the signed-in user's CI ID derived from credentials tokens.
+     * Used as a fallback when no device is registered.
+     * @returns the userId, or undefined if it can't be determined
+     */
+  }, {
+    key: "getUserIdFromCredentials",
+    value: function getUserIdFromCredentials() {
+      try {
+        // @ts-ignore
+        return this.webex.credentials.getUserId();
+      } catch (_unused) {
+        return undefined;
+      }
+    }
+
     /**
      * Gather identifier details for call diagnostic payload.
      * @throws Error if initialization fails.
@@ -362,7 +382,7 @@ var CallDiagnosticMetrics = exports.default = /*#__PURE__*/function (_StatelessW
   }, {
     key: "getIdentifiers",
     value: function getIdentifiers(options) {
-      var _meeting$locusInfo, _meeting$meetingInfo2, _meeting$meetingInfo3, _meeting$meetingInfo6, _meeting$meetingInfo8;
+      var _this$device, _meeting$locusInfo, _meeting$meetingInfo2, _meeting$meetingInfo3, _meeting$meetingInfo6, _meeting$meetingInfo8;
       var meeting = options.meeting,
         mediaConnections = options.mediaConnections,
         correlationId = options.correlationId,
@@ -395,7 +415,6 @@ var CallDiagnosticMetrics = exports.default = /*#__PURE__*/function (_StatelessW
         var device = this.device;
         var _ref3 = (device === null || device === void 0 ? void 0 : device.config) || {},
           installationId = _ref3.installationId;
-        identifiers.userId = (device === null || device === void 0 ? void 0 : device.userId) || preLoginId;
         identifiers.deviceId = device === null || device === void 0 ? void 0 : device.url;
         identifiers.orgId = device === null || device === void 0 ? void 0 : device.orgId;
         // @ts-ignore
@@ -404,6 +423,10 @@ var CallDiagnosticMetrics = exports.default = /*#__PURE__*/function (_StatelessW
           identifiers.machineId = installationId;
         }
       }
+
+      // Prefer the device's userId, but fall back to the signed-in user's ID from
+      // credentials when no device is registered, then to the pre-login ID.
+      identifiers.userId = ((_this$device = this.device) === null || _this$device === void 0 ? void 0 : _this$device.userId) || this.getUserIdFromCredentials() || preLoginId;
       if (meeting !== null && meeting !== void 0 && (_meeting$locusInfo = meeting.locusInfo) !== null && _meeting$locusInfo !== void 0 && _meeting$locusInfo.fullState) {
         identifiers.locusUrl = meeting.locusUrl;
         identifiers.locusId = meeting.locusUrl && meeting.locusUrl.split('/').pop();
@@ -651,7 +674,7 @@ var CallDiagnosticMetrics = exports.default = /*#__PURE__*/function (_StatelessW
      * @param arg.clientErrorCode
      * @param arg.serviceErrorCode
      * @param arg.payloadOverrides
-     * @param arg.httpStatusCode
+     * @param arg.httpCode
      * @returns
      */
   }, {
@@ -662,7 +685,7 @@ var CallDiagnosticMetrics = exports.default = /*#__PURE__*/function (_StatelessW
         serviceErrorName = _ref7.serviceErrorName,
         rawErrorMessage = _ref7.rawErrorMessage,
         payloadOverrides = _ref7.payloadOverrides,
-        httpStatusCode = _ref7.httpStatusCode;
+        httpCode = _ref7.httpCode;
       var error;
       if (clientErrorCode) {
         var partialParsedError = _config2.CLIENT_ERROR_CODE_TO_ERROR_PAYLOAD[clientErrorCode];
@@ -684,8 +707,8 @@ var CallDiagnosticMetrics = exports.default = /*#__PURE__*/function (_StatelessW
             serviceErrorCode: serviceErrorCode
           }, {
             rawErrorMessage: rawErrorMessage
-          }, httpStatusCode === undefined ? {} : {
-            httpStatusCode: httpStatusCode
+          }, httpCode === undefined ? {} : {
+            httpCode: httpCode
           }, partialParsedError, payloadOverrides || {});
           return error;
         }
@@ -831,13 +854,14 @@ var CallDiagnosticMetrics = exports.default = /*#__PURE__*/function (_StatelessW
   }, {
     key: "generateClientEventErrorPayload",
     value: function generateClientEventErrorPayload(rawError) {
-      var _rawError$error, _rawError$error$body, _rawError$body, _rawError$body2, _rawError$body3, _rawError$body3$reaso;
+      var _rawError$error, _rawError$error$body, _rawError$body, _rawError$body2, _rawError$body3, _rawError$body3$reaso, _rawError$options, _rawError$options2;
       var cachedError = this.eventErrorCache.get(rawError);
       if (cachedError) {
         return [cachedError, true];
       }
       var rawErrorMessage = rawError.message;
-      var httpStatusCode = rawError.statusCode;
+      var httpCode = rawError.statusCode;
+      var serviceErrorCode = (rawError === null || rawError === void 0 ? void 0 : (_rawError$error = rawError.error) === null || _rawError$error === void 0 ? void 0 : (_rawError$error$body = _rawError$error.body) === null || _rawError$error$body === void 0 ? void 0 : _rawError$error$body.errorCode) || (rawError === null || rawError === void 0 ? void 0 : (_rawError$body = rawError.body) === null || _rawError$body === void 0 ? void 0 : _rawError$body.errorCode) || (rawError === null || rawError === void 0 ? void 0 : (_rawError$body2 = rawError.body) === null || _rawError$body2 === void 0 ? void 0 : _rawError$body2.code) || (rawError === null || rawError === void 0 ? void 0 : (_rawError$body3 = rawError.body) === null || _rawError$body3 === void 0 ? void 0 : (_rawError$body3$reaso = _rawError$body3.reason) === null || _rawError$body3$reaso === void 0 ? void 0 : _rawError$body3$reaso.reasonCode);
       var payload;
       if (rawError.name) {
         if ((0, _callDiagnosticMetrics.isBrowserMediaErrorName)(rawError.name)) {
@@ -846,7 +870,7 @@ var CallDiagnosticMetrics = exports.default = /*#__PURE__*/function (_StatelessW
             clientErrorCode: _config2.BROWSER_MEDIA_ERROR_NAME_TO_CLIENT_ERROR_CODES_MAP[rawError.name],
             serviceErrorName: rawError.name,
             rawErrorMessage: rawErrorMessage,
-            httpStatusCode: httpStatusCode
+            httpCode: httpCode
           });
         }
       }
@@ -859,10 +883,9 @@ var CallDiagnosticMetrics = exports.default = /*#__PURE__*/function (_StatelessW
           clientErrorCode: _config2.SDP_OFFER_CREATION_ERROR_MAP[causeType] || _config2.SDP_OFFER_CREATION_ERROR_MAP.GENERAL,
           serviceErrorName: rawError.name,
           rawErrorMessage: rawErrorMessage,
-          httpStatusCode: httpStatusCode
+          httpCode: httpCode
         });
       }
-      var serviceErrorCode = (rawError === null || rawError === void 0 ? void 0 : (_rawError$error = rawError.error) === null || _rawError$error === void 0 ? void 0 : (_rawError$error$body = _rawError$error.body) === null || _rawError$error$body === void 0 ? void 0 : _rawError$error$body.errorCode) || (rawError === null || rawError === void 0 ? void 0 : (_rawError$body = rawError.body) === null || _rawError$body === void 0 ? void 0 : _rawError$body.errorCode) || (rawError === null || rawError === void 0 ? void 0 : (_rawError$body2 = rawError.body) === null || _rawError$body2 === void 0 ? void 0 : _rawError$body2.code) || (rawError === null || rawError === void 0 ? void 0 : (_rawError$body3 = rawError.body) === null || _rawError$body3 === void 0 ? void 0 : (_rawError$body3$reaso = _rawError$body3.reason) === null || _rawError$body3$reaso === void 0 ? void 0 : _rawError$body3$reaso.reasonCode);
       if (serviceErrorCode) {
         var clientErrorCode = _config2.SERVICE_ERROR_CODES_TO_CLIENT_ERROR_CODES_MAP[serviceErrorCode];
         if (clientErrorCode && !payload) {
@@ -870,17 +893,28 @@ var CallDiagnosticMetrics = exports.default = /*#__PURE__*/function (_StatelessW
             clientErrorCode: clientErrorCode,
             serviceErrorCode: serviceErrorCode,
             rawErrorMessage: rawErrorMessage,
-            httpStatusCode: httpStatusCode
+            httpCode: httpCode
           });
         }
-
+      }
+      var locusHttpClientErrorCode = LOCUS_HTTP_STATUS_TO_CLIENT_ERROR_CODE[httpCode];
+      var requestUrl = ((_rawError$options = rawError.options) === null || _rawError$options === void 0 ? void 0 : _rawError$options.uri) || ((_rawError$options2 = rawError.options) === null || _rawError$options2 === void 0 ? void 0 : _rawError$options2.url);
+      if (locusHttpClientErrorCode && !payload && requestUrl !== null && requestUrl !== void 0 && requestUrl.includes('locus')) {
+        payload = this.getErrorPayloadForClientErrorCode({
+          clientErrorCode: locusHttpClientErrorCode,
+          serviceErrorCode: serviceErrorCode,
+          rawErrorMessage: rawErrorMessage,
+          httpCode: httpCode
+        });
+      }
+      if (serviceErrorCode) {
         // by default, if it is locus error, return new locus err
         if ((0, _callDiagnosticMetrics.isLocusServiceErrorCode)(serviceErrorCode) && !payload) {
           payload = this.getErrorPayloadForClientErrorCode({
             clientErrorCode: _config2.NEW_LOCUS_ERROR_CLIENT_CODE,
             serviceErrorCode: serviceErrorCode,
             rawErrorMessage: rawErrorMessage,
-            httpStatusCode: httpStatusCode
+            httpCode: httpCode
           });
         }
       }
@@ -889,7 +923,7 @@ var CallDiagnosticMetrics = exports.default = /*#__PURE__*/function (_StatelessW
           clientErrorCode: _config2.MEETING_INFO_LOOKUP_ERROR_CLIENT_CODE,
           serviceErrorCode: serviceErrorCode,
           rawErrorMessage: rawErrorMessage,
-          httpStatusCode: httpStatusCode
+          httpCode: httpCode
         });
       }
       if ((0, _callDiagnosticMetrics.isNetworkError)(rawError) && !payload) {
@@ -898,7 +932,7 @@ var CallDiagnosticMetrics = exports.default = /*#__PURE__*/function (_StatelessW
           serviceErrorCode: serviceErrorCode,
           payloadOverrides: rawError.payloadOverrides,
           rawErrorMessage: rawErrorMessage,
-          httpStatusCode: httpStatusCode
+          httpCode: httpCode
         });
       }
       if ((0, _callDiagnosticMetrics.isUnauthorizedError)(rawError) && !payload) {
@@ -907,7 +941,7 @@ var CallDiagnosticMetrics = exports.default = /*#__PURE__*/function (_StatelessW
           serviceErrorCode: serviceErrorCode,
           payloadOverrides: rawError.payloadOverrides,
           rawErrorMessage: rawErrorMessage,
-          httpStatusCode: httpStatusCode
+          httpCode: httpCode
         });
       }
       if (!payload) {
@@ -918,7 +952,7 @@ var CallDiagnosticMetrics = exports.default = /*#__PURE__*/function (_StatelessW
           serviceErrorName: rawError === null || rawError === void 0 ? void 0 : rawError.name,
           payloadOverrides: rawError.payloadOverrides,
           rawErrorMessage: rawErrorMessage,
-          httpStatusCode: httpStatusCode
+          httpCode: httpCode
         });
       }