@webex/internal-plugin-metrics 3.0.0-next.1 → 3.0.0-next.10

package/test/unit/spec/call-diagnostic/call-diagnostic-metrics.util.ts

@@ -301,6 +301,12 @@ describe('internal-plugin-metrics', () => {
 
     [
       ['client.exit.app', {}],
+      ['client.login.end', {
+        joinTimes: {
+          otherAppApiReqResp: undefined,
+          exchangeCITokenJMT: undefined,
+        }
+      }],
       ['client.webexapp.launched', {
         joinTimes: {
           downloadTime: undefined,
@@ -312,6 +318,8 @@ describe('internal-plugin-metrics', () => {
           joinTimes: {
             clickToInterstitial: undefined,
             meetingInfoReqResp: undefined,
+            refreshCaptchaServiceReqResp: undefined,
+            downloadIntelligenceModelsReqResp: undefined,
           },
         },
       ],
@@ -322,6 +330,8 @@ describe('internal-plugin-metrics', () => {
             showInterstitialTime: undefined,
             meetingInfoReqResp: undefined,
             registerWDMDeviceJMT: undefined,
+            getU2CTime: undefined,
+            getReachabilityClustersReqResp: undefined,
           },
         },
       ],
@@ -332,13 +342,12 @@ describe('internal-plugin-metrics', () => {
             meetingInfoReqResp: undefined,
             callInitJoinReq: undefined,
             joinReqResp: undefined,
-            joinReqSentReceived: undefined,
             pageJmt: undefined,
             clickToInterstitial: undefined,
             interstitialToJoinOK: undefined,
             totalJmt: undefined,
             clientJmt: undefined,
-            downloadTime: undefined
+            downloadTime: undefined,
           },
         },
       ],

package/test/unit/spec/metrics.js

@@ -104,6 +104,13 @@ describe('plugin-metrics', () => {
       };
       webex.config.metrics.type = ['operational'];
       webex.config.metrics.appType = 'sdk';
+      webex.meetings = {
+        config: {
+          metrics: {
+            clientVersion: '43.0.105'
+          }
+        }
+      }
 
       sinon.spy(webex, 'request');
       sinon.spy(metrics, 'postPreLoginMetric');
@@ -180,6 +187,7 @@ describe('plugin-metrics', () => {
           },
           metricName: 'test',
           tags: {
+            appVersion: '43.0.105',
             browser: '',
             domain: 'whatever',
             os: 'other',

package/test/unit/spec/new-metrics.ts

@@ -1,29 +1,31 @@
 import {assert} from '@webex/test-helper-chai';
-import {NewMetrics} from '@webex/internal-plugin-metrics';
+import {NewMetrics, CallDiagnosticLatencies} from '@webex/internal-plugin-metrics';
 import MockWebex from '@webex/test-helper-mock-webex';
 import sinon from 'sinon';
 import {Utils} from '@webex/internal-plugin-metrics';
 
 describe('internal-plugin-metrics', () => {
 
+  const mockWebex = () => new MockWebex({
+    children: {
+      newMetrics: NewMetrics,
+    },
+    meetings: {
+      meetingCollection: {
+        get: sinon.stub(),
+      },
+    },
+    request: sinon.stub().resolves({}),
+    logger: {
+      log: sinon.stub(),
+      error: sinon.stub(),
+    }
+  });
+
   describe('check submitClientEvent when webex is not ready', () => {
     let webex;
     //@ts-ignore
-    webex = new MockWebex({
-      children: {
-        newMetrics: NewMetrics,
-      },
-      meetings: {
-        meetingCollection: {
-          get: sinon.stub(),
-        },
-      },
-      request: sinon.stub().resolves({}),
-      logger: {
-        log: sinon.stub(),
-        error: sinon.stub(),
-      }
-    });
+    webex = mockWebex();
 
     it('checks the log', () => {
       webex.internal.newMetrics.submitClientEvent({
@@ -38,26 +40,22 @@ describe('internal-plugin-metrics', () => {
       );
     });
   });
+
+  describe('new-metrics contstructor', () => {
+    it('checks callDiagnosticLatencies is defined before ready emit', () => {
+
+      const webex = mockWebex();
+
+      assert.instanceOf(webex.internal.newMetrics.callDiagnosticLatencies, CallDiagnosticLatencies);
+    });
+  });
+
   describe('new-metrics', () => {
     let webex;
 
     beforeEach(() => {
       //@ts-ignore
-      webex = new MockWebex({
-        children: {
-          newMetrics: NewMetrics,
-        },
-        meetings: {
-          meetingCollection: {
-            get: sinon.stub(),
-          },
-        },
-        request: sinon.stub().resolves({}),
-        logger: {
-          log: sinon.stub(),
-          error: sinon.stub(),
-        }
-      });
+      webex = mockWebex();
 
       webex.emit('ready');
 

package/test/unit/spec/prelogin-metrics-batcher.ts

@@ -74,6 +74,8 @@ describe('internal-plugin-metrics', () => {
                     joinTimes: {
                       meetingInfoReqResp: undefined,
                       clickToInterstitial: undefined,
+                      refreshCaptchaServiceReqResp: undefined,
+                      downloadIntelligenceModelsReqResp: undefined,
                     },
                     name: 'client.interstitial-window.launched',
                   },
@@ -148,7 +150,8 @@ describe('internal-plugin-metrics', () => {
       });
 
       it('fails if preLoinId is not set', async () => {
-        webex.internal.newMetrics.callDiagnosticMetrics.preLoginMetricsBatcher.preLoginId = undefined;
+        webex.internal.newMetrics.callDiagnosticMetrics.preLoginMetricsBatcher.preLoginId =
+          undefined;
 
         const promise =
           webex.internal.newMetrics.callDiagnosticMetrics.submitToCallDiagnosticsPreLogin(
@@ -176,7 +179,7 @@ describe('internal-plugin-metrics', () => {
 
     describe('prepareItem', () => {
       it('calls prepareDiagnosticMetricItem correctly', async () => {
-         // avoid setting .sent timestamp
+        // avoid setting .sent timestamp
         webex.internal.newMetrics.callDiagnosticMetrics.preLoginMetricsBatcher.prepareRequest = (q) =>
           Promise.resolve(q);