@webex/internal-plugin-mercury 3.8.1 → 3.9.0-multipleLLM.1

package/src/socket/socket-base.js

@@ -33,6 +33,8 @@ export default class Socket extends EventEmitter {
     this._domain = 'unknown-domain';
     this.onmessage = this.onmessage.bind(this);
     this.onclose = this.onclose.bind(this);
+    // Increase max listeners to avoid memory leak warning in tests
+    this.setMaxListeners(5);
   }
 
   /**
@@ -358,9 +360,20 @@ export default class Socket extends EventEmitter {
       return Promise.reject(new Error('`event.data.id` is required'));
     }
 
+    // Don't try to acknowledge if socket is not in open state
+    if (this.readyState !== 1) {
+      return Promise.resolve(); // Silently ignore acknowledgment for closed sockets
+    }
+
     return this.send({
       messageId: event.data.id,
       type: 'ack',
+    }).catch((error) => {
+      // Gracefully handle send errors (like INVALID_STATE_ERROR) to prevent test issues
+      if (error.message === 'INVALID_STATE_ERROR') {
+        return Promise.resolve(); // Socket was closed, ignore the acknowledgment
+      }
+      throw error; // Re-throw other errors
     });
   }
 

package/test/unit/spec/mercury-events.js

@@ -38,14 +38,31 @@ describe('plugin-mercury', () => {
         },
         timestamp: Date.now(),
         trackingId: `suffix_${uuid.v4()}_${Date.now()}`,
+        sessionId: 'mercury-default-session',
       };
 
       beforeEach(() => {
         clock = FakeTimers.install({now: Date.now()});
       });
 
-      afterEach(() => {
+      afterEach(async () => {
         clock.uninstall();
+        // Clean up mercury socket and mockWebSocket
+        if (mercury && mercury.socket) {
+          try {
+            await mercury.socket.close();
+          } catch (e) {}
+        }
+        if (mockWebSocket && typeof mockWebSocket.close === 'function') {
+          mockWebSocket.close();
+        }
+        // Restore stubs
+        if (Socket.getWebSocketConstructor.restore) {
+          Socket.getWebSocketConstructor.restore();
+        }
+        if (socketOpenStub && socketOpenStub.restore) {
+          socketOpenStub.restore();
+        }
       });
 
       beforeEach(() => {
@@ -56,6 +73,7 @@ describe('plugin-mercury', () => {
         });
 
         webex.internal.metrics.submitClientMetrics = sinon.stub();
+        webex.internal.newMetrics.callDiagnosticMetrics.setMercuryConnectedStatus = sinon.stub();
         webex.trackingId = 'fakeTrackingId';
         webex.config.mercury = mercuryConfig.mercury;
 
@@ -75,6 +93,7 @@ describe('plugin-mercury', () => {
         });
 
         mercury = webex.internal.mercury;
+        mercury.defaultSessionId = 'mercury-default-session';
       });
 
       afterEach(() => {
@@ -300,7 +319,7 @@ describe('plugin-mercury', () => {
                 })
                 .then(() => {
                   assert.called(offlineSpy);
-                  assert.calledWith(offlineSpy, {code, reason});
+                  assert.calledWith(offlineSpy, {code, reason, sessionId: 'mercury-default-session'});
                   switch (action) {
                     case 'close':
                       assert.called(permanentSpy);

package/test/unit/spec/mercury.js

@@ -77,6 +77,7 @@ describe('plugin-mercury', () => {
         markFailedUrl: sinon.stub().returns(Promise.resolve()),
       };
       webex.internal.metrics.submitClientMetrics = sinon.stub();
+      webex.internal.newMetrics.callDiagnosticMetrics.setMercuryConnectedStatus = sinon.stub();
       webex.trackingId = 'fakeTrackingId';
       webex.config.mercury = mercuryConfig.mercury;
 
@@ -96,9 +97,32 @@ describe('plugin-mercury', () => {
       });
 
       mercury = webex.internal.mercury;
+      mercury.defaultSessionId = 'mercury-default-session';
     });
 
-    afterEach(() => {
+    afterEach(async () => {
+      // Clean up Mercury connections and internal state
+      if (mercury) {
+        try {
+          await mercury.disconnectAll();
+        } catch (e) {
+          // Ignore cleanup errors
+        }
+        // Clear any remaining connection promises
+        if (mercury._connectPromises) {
+          mercury._connectPromises.clear();
+        }
+      }
+
+      // Ensure mock socket is properly closed
+      if (mockWebSocket && typeof mockWebSocket.close === 'function') {
+        try {
+          mockWebSocket.close();
+        } catch (e) {
+          // Ignore cleanup errors
+        }
+      }
+
       if (socketOpenStub) {
         socketOpenStub.restore();
       }
@@ -106,21 +130,38 @@ describe('plugin-mercury', () => {
       if (Socket.getWebSocketConstructor.restore) {
         Socket.getWebSocketConstructor.restore();
       }
+
+      // Small delay to ensure all async operations complete
+      await new Promise(resolve => setTimeout(resolve, 10));
     });
 
     describe('#listen()', () => {
       it('proxies to #connect()', () => {
-        sinon.stub(mercury, 'connect');
-        mercury.listen();
-        assert.called(mercury.connect);
+        const connectStub = sinon.stub(mercury, 'connect').callThrough();
+        return mercury.listen().then(() => {
+          assert.called(connectStub);
+          assert.calledWith(
+            webex.internal.newMetrics.callDiagnosticMetrics.setMercuryConnectedStatus,
+            true
+          );
+        });
       });
     });
 
     describe('#stopListening()', () => {
       it('proxies to #disconnect()', () => {
-        sinon.stub(mercury, 'connect');
-        mercury.listen();
-        assert.called(mercury.connect);
+        return mercury.connect().then(() => {
+          webex.internal.newMetrics.callDiagnosticMetrics.setMercuryConnectedStatus.resetHistory();
+          const disconnectStub = sinon.stub(mercury, 'disconnect').callThrough();
+
+          mercury.stopListening();
+          assert.called(disconnectStub);
+          mockWebSocket.emit('close', {code: 1000, reason: 'test'});
+          assert.calledWith(
+            webex.internal.newMetrics.callDiagnosticMetrics.setMercuryConnectedStatus,
+            false
+          );
+        });
       });
     });
 
@@ -421,9 +462,13 @@ describe('plugin-mercury', () => {
 
         // skipping due to apparent bug with lolex in all browsers but Chrome.
         skipInBrowser(it)('does not continue attempting to connect', () => {
-          mercury.connect();
+          const promise = mercury.connect();
 
-          return promiseTick(2)
+          // Wait for the connection to be established before proceeding
+          mockWebSocket.open();
+
+          return promise.then(() =>
+            promiseTick(2)
             .then(() => {
               clock.tick(6 * webex.internal.mercury.config.backoffTimeReset);
 
@@ -431,7 +476,8 @@ describe('plugin-mercury', () => {
             })
             .then(() => {
               assert.calledOnce(Socket.prototype.open);
-            });
+              })
+          );
         });
       });
 
@@ -506,11 +552,11 @@ describe('plugin-mercury', () => {
     });
 
     describe('#logout()', () => {
-      it('calls disconnect and logs', () => {
+      it('calls disconnectAll and logs', () => {
         sinon.stub(mercury.logger, 'info');
-        sinon.stub(mercury, 'disconnect');
+        sinon.stub(mercury, 'disconnectAll');
         mercury.logout();
-        assert.called(mercury.disconnect);
+        assert.called(mercury.disconnectAll);
         assert.calledTwice(mercury.logger.info);
 
         assert.calledWith(mercury.logger.info.getCall(0), 'Mercury: logout() called');
@@ -522,24 +568,24 @@ describe('plugin-mercury', () => {
       });
 
       it('uses the config.beforeLogoutOptionsCloseReason to disconnect and will send code 3050 for logout', () => {
-        sinon.stub(mercury, 'disconnect');
+        sinon.stub(mercury, 'disconnectAll');
         mercury.config.beforeLogoutOptionsCloseReason = 'done (permanent)';
         mercury.logout();
-        assert.calledWith(mercury.disconnect, {code: 3050, reason: 'done (permanent)'});
+        assert.calledWith(mercury.disconnectAll, {code: 3050, reason: 'done (permanent)'});
       });
 
       it('uses the config.beforeLogoutOptionsCloseReason to disconnect and will send code 3050 for logout if the reason is different than standard', () => {
-        sinon.stub(mercury, 'disconnect');
+        sinon.stub(mercury, 'disconnectAll');
         mercury.config.beforeLogoutOptionsCloseReason = 'test';
         mercury.logout();
-        assert.calledWith(mercury.disconnect, {code: 3050, reason: 'test'});
+        assert.calledWith(mercury.disconnectAll, {code: 3050, reason: 'test'});
       });
 
       it('uses the config.beforeLogoutOptionsCloseReason to disconnect and will send undefined for logout if the reason is same as standard', () => {
-        sinon.stub(mercury, 'disconnect');
+        sinon.stub(mercury, 'disconnectAll');
         mercury.config.beforeLogoutOptionsCloseReason = 'done (forced)';
         mercury.logout();
-        assert.calledWith(mercury.disconnect, undefined);
+        assert.calledWith(mercury.disconnectAll, undefined);
       });
     });
 
@@ -645,12 +691,12 @@ describe('plugin-mercury', () => {
           return promiseTick(webex.internal.mercury.config.backoffTimeReset).then(() => {
             // By this time backoffCall and mercury socket should be defined by the
             // 'connect' call
-            assert.isDefined(mercury.backoffCall, 'Mercury backoffCall is not defined');
+            assert.isDefined(mercury.backoffCalls.get('mercury-default-session'), 'Mercury backoffCall is not defined');
             assert.isDefined(mercury.socket, 'Mercury socket is not defined');
             // Calling disconnect will abort the backoffCall, close the socket, and
             // reject the connect
             mercury.disconnect();
-            assert.isUndefined(mercury.backoffCall, 'Mercury backoffCall is still defined');
+            assert.isUndefined(mercury.backoffCalls.get('mercury-default-session'), 'Mercury backoffCall is still defined');
             // The socket will never be unset (which seems bad)
             assert.isDefined(mercury.socket, 'Mercury socket is not defined');
 
@@ -668,15 +714,15 @@ describe('plugin-mercury', () => {
 
           let reason;
 
-          mercury.backoffCall = undefined;
-          mercury._attemptConnection('ws://example.com', (_reason) => {
+          mercury.backoffCalls.clear();
+          mercury._attemptConnection('ws://example.com', 'mercury-default-session',(_reason) => {
             reason = _reason;
           });
 
           return promiseTick(webex.internal.mercury.config.backoffTimeReset).then(() => {
             assert.equal(
               reason.message,
-              'Mercury: prevent socket open when backoffCall no longer defined'
+              `Mercury: prevent socket open when backoffCall no longer defined for ${mercury.defaultSessionId}`
             );
           });
         });
@@ -698,7 +744,7 @@ describe('plugin-mercury', () => {
             return assert.isRejected(promise).then((error) => {
               const lastError = mercury.getLastError();
 
-              assert.equal(error.message, 'Mercury Connection Aborted');
+              assert.equal(error.message, `Mercury Connection Aborted for ${mercury.defaultSessionId}`);
               assert.isDefined(lastError);
               assert.equal(lastError, realError);
             });
@@ -792,7 +838,7 @@ describe('plugin-mercury', () => {
           },
         };
         assert.isUndefined(mercury.mercuryTimeOffset);
-        mercury._setTimeOffset(event);
+        mercury._setTimeOffset('mercury-default-session', event);
         assert.isDefined(mercury.mercuryTimeOffset);
         assert.isTrue(mercury.mercuryTimeOffset > 0);
       });
@@ -802,7 +848,7 @@ describe('plugin-mercury', () => {
             wsWriteTimestamp: Date.now() + 60000,
           },
         };
-        mercury._setTimeOffset(event);
+        mercury._setTimeOffset('mercury-default-session', event);
         assert.isTrue(mercury.mercuryTimeOffset < 0);
       });
       it('handles invalid wsWriteTimestamp', () => {
@@ -813,7 +859,7 @@ describe('plugin-mercury', () => {
               wsWriteTimestamp: invalidTimestamp,
             },
           };
-          mercury._setTimeOffset(event);
+          mercury._setTimeOffset('mercury-default-session', event);
           assert.isUndefined(mercury.mercuryTimeOffset);
         });
       });