@webex/internal-plugin-conversation 3.0.0-bnr.5 → 3.0.0-next.2

package/test/unit/spec/conversation.js

@@ -5,7 +5,6 @@
 import {assert} from '@webex/test-helper-chai';
 import MockWebex from '@webex/test-helper-mock-webex';
 import sinon from 'sinon';
-
 import Conversation from '@webex/internal-plugin-conversation';
 
 import {
@@ -32,7 +31,48 @@ describe('plugin-conversation', () => {
 
       webex.internal.services = {};
       webex.internal.services.get = sinon.stub().returns(Promise.resolve(convoUrl));
-      webex.internal.services.getServiceFromClusterId = sinon.stub().returns({url: convoUrl});
+      webex.internal.services.getServiceUrlFromClusterId = sinon.stub().returns(convoUrl);
+    });
+
+    describe('addReaction()', () => {
+      it('should add recipients to the payload if provided', () => {
+        const {conversation} = webex.internal;
+        const recipientId = 'example-recipient-id';
+        const expected = {items: [{id: recipientId, objectType: 'person'}]}
+        conversation.sendReaction = sinon.stub().returns(Promise.resolve())
+        conversation.createReactionHmac = sinon.stub().returns(Promise.resolve('hmac'))
+        
+        return conversation.addReaction({}, 'example-display-name', {}, recipientId)
+          .then(() => {
+            assert.deepEqual(conversation.sendReaction.args[0][1].recipients, expected);
+          });
+      });
+    });
+
+    describe('deleteReaction()', () => {
+      it('should add recipients to the payload if provided', () => {
+        const {conversation} = webex.internal;
+        const recipientId = 'example-recipient-id';
+        const expected = {items: [{id: recipientId, objectType: 'person'}]}
+        conversation.sendReaction = sinon.stub().returns(Promise.resolve())
+        
+        return conversation.deleteReaction({}, 'example-reaction-id', recipientId)
+          .then(() => {
+            assert.deepEqual(conversation.sendReaction.args[0][1].recipients, expected);
+          });
+      });
+    });
+
+    describe('prepare()', () => {
+      it('should ammend activity recipients to the returned object', () => {
+        const {conversation} = webex.internal;
+        const activity = { recipients: 'example-recipients' };
+
+        return conversation.prepare(activity)
+          .then((results) => {
+            assert.deepEqual(results.recipients, activity.recipients);
+        });
+      });
     });
 
     describe('addReaction()', () => {
@@ -180,27 +220,21 @@ describe('plugin-conversation', () => {
       it('should convert a "us" cluster to WEBEX_CONVERSATION_DEFAULT_CLUSTER cluster', async () => {
         await webex.internal.conversation.getUrlFromClusterId({cluster: 'us'});
 
-        sinon.assert.calledWith(webex.internal.services.getServiceFromClusterId, {
-          clusterId: process.env.WEBEX_CONVERSATION_DEFAULT_CLUSTER,
-        });
+        sinon.assert.calledWith(webex.internal.services.getServiceUrlFromClusterId, {cluster: 'us'});
       });
 
       it('should add the cluster service when missing', async () => {
         await webex.internal.conversation.getUrlFromClusterId({cluster: 'urn:TEAM:us-west-2_r'});
 
-        sinon.assert.calledWith(webex.internal.services.getServiceFromClusterId, {
-          clusterId: 'urn:TEAM:us-west-2_r:identityLookup',
-        });
+        sinon.assert.calledWith(webex.internal.services.getServiceUrlFromClusterId, {cluster: 'urn:TEAM:us-west-2_r'});
       });
     });
 
     describe('paginate', () => {
       it('should throw an error if a page is passed with no links', () => {
-        try {
-          webex.internal.conversation.paginate({page: {}});
-        } catch (error) {
+        webex.internal.conversation.paginate({page: {}}).catch((error) => {
           assert.equal(error.message, 'No link to follow for the provided page');
-        }
+        });
       });
     });
 
@@ -375,14 +409,12 @@ describe('plugin-conversation', () => {
               conversationUrl: convoUrl,
             });
 
-            try {
-              jumpToActivity();
-            } catch (e) {
+            jumpToActivity().catch((e) => {
               assert.equal(
                 e.message,
                 'Search must be an activity object from conversation service'
               );
-            }
+            });
           });
 
           it('should throw an error if activity.target.url is missing', () => {
@@ -390,11 +422,9 @@ describe('plugin-conversation', () => {
               conversationUrl: convoUrl,
             });
 
-            try {
-              assert.throws(jumpToActivity({target: null}));
-            } catch (e) {
-              //
-            }
+            jumpToActivity({target: null}).catch((e) => {
+              assert.equal(e.message, 'Search object must have a target url!');
+            });
           });
 
           it('should implement the iterator protocol', () => {

package/test/unit/spec/encryption-transforms.js

@@ -36,6 +36,29 @@ describe('plugin-conversation', () => {
           });
       });
 
+      it('does not transform when object type is "policies" for a "meetingContainer" activity', async () => {
+        const transform = transforms.find((t) => t.name === 'encryptActivity');
+        const transformStub = sinon.stub().resolves();
+
+        const ctx = {
+          transform: transformStub,
+        };
+        const key = null;
+        const activity = {
+          object: {
+            objectType: 'policies',
+          },
+          objectType: 'activity',
+          target: {
+            objectType: 'meetingContainer',
+          },
+          verb: 'update',
+        };
+
+        const results = await transform.fn(ctx, key, activity);
+        assert.equal(results, undefined);
+      });
+
       it('does transfom when created is not True', async () => {
         const transform = transforms.find((t) => t.name === 'encryptActivity');
         const transformStub = sinon.stub().resolves();

package/dist/internal-plugin-conversation.d.ts

@@ -1,21 +0,0 @@
-declare const Conversation: any;
-export default Conversation;
-
-/**
- * General conversation error
- */
-export declare class ConversationError {
-}
-
-/**
- * InvalidUserCreation thrown when failed to create conversation with invalid user
- */
-export declare class InvalidUserCreation extends ConversationError {
-}
-
-/**
- * @class
- */
-export declare const ShareActivity: any;
-
-export { }

package/dist/tsdoc-metadata.json

@@ -1,11 +0,0 @@
-// This file is read by tools that parse documentation comments conforming to the TSDoc standard.
-// It should be published with your NPM package.  It should not be tracked by Git.
-{
-  "tsdocVersion": "0.12",
-  "toolPackages": [
-    {
-      "packageName": "@microsoft/api-extractor",
-      "packageVersion": "7.34.4"
-    }
-  ]
-}

package/dist/types/activities.d.ts

@@ -1,32 +0,0 @@
-export const OLDER: "older";
-export const NEWER: "newer";
-export const MID: "mid";
-export const INITIAL: "initial";
-export namespace ACTIVITY_TYPES {
-    const REPLY: string;
-    const EDIT: string;
-    const REACTION: string;
-    const REACTION_SELF: string;
-    const ROOT: string;
-    const CREATE: string;
-    const TOMBSTONE: string;
-    const DELETE: string;
-    const REPLY_EDIT: string;
-}
-export function getActivityType(activity: any): string;
-export function getPublishedDate(activity?: {}): number;
-export function isNewer(activity1: any, activity2: any): boolean;
-export function sortActivitiesByPublishedDate(activities: any): any[];
-export function getParentId(activity: any): any;
-export function isRootActivity(act: any): boolean;
-export function isReplyActivity(act: any): boolean;
-export function isEditActivity(act: any): boolean;
-export function isCreateActivity(act: any): boolean;
-export function isDeleteActivity(act: any): boolean;
-export function sanitizeActivity(activity: any): any;
-export function getIsActivityOrphaned(activity: any, activities: any): boolean;
-export function determineActivityType(activity: any, activities: any): string;
-export function createRootActivity(activity: any): any;
-export function createReplyActivity(activity: any): any;
-export function createEditActivity(editActivity: any, activities: any): any;
-export function createReplyEditActivity(editActivity: any, activities: any): any;

package/dist/types/activity-thread-ordering.d.ts

@@ -1,18 +0,0 @@
-export const defaultMinDisplayableActivities: 20;
-export const minBatchSize: 10;
-export const fetchLoopCountMax: 100;
-export const batchSizeIncrementCount: 10;
-export function setValue(destination: Map<any, any>, key: string, value: any): Map<any, any>;
-export function getValue(source: Map<any, any>, key: string): Map<any, any>;
-export function getActivityObjectsFromMap(hashMap: any): any[];
-export function activityManager(): object;
-export function bookendManager(): object;
-export function noMoreActivitiesManager(): object;
-export function rootActivityManager(): object;
-export function getLoopCounterFailsafe(): () => void;
-export function getQuery(type: string, queryOptions: {
-    newestPublishedDate?: string;
-    oldestPublishedDate?: string;
-    batchSize?: number;
-    activityToSearch?: object;
-}): object;

package/dist/types/config.d.ts

@@ -1,19 +0,0 @@
-declare namespace _default {
-    namespace conversation {
-        const allowedInboundTags: {
-            'webex-mention': string[];
-        };
-        const allowedOutboundTags: {
-            'webex-mention': string[];
-        };
-        function inboundProcessFunc(): void;
-        function outboundProcessFunc(): void;
-        const allowedInboundStyles: any[];
-        const allowedOutboundStyles: any[];
-        const thumbnailMaxHeight: number;
-        const thumbnailMaxWidth: number;
-        const keepEncryptedProperties: boolean;
-        const decryptionFailureMessage: string;
-    }
-}
-export default _default;

package/dist/types/constants.d.ts

@@ -1,5 +0,0 @@
-export const KEY_ROTATION_REQUIRED: 1400087;
-export const KEY_ALREADY_ROTATED: 1409004;
-export const ENCRYPTION_KEY_URL_MISMATCH: 1400049;
-export const DEFAULT_CLUSTER: "urn:TEAM:us-east-2_a";
-export const DEFAULT_CLUSTER_SERVICE: "identityLookup";

package/dist/types/conversation.d.ts

@@ -1,2 +0,0 @@
-export default Conversation;
-declare const Conversation: any;

package/dist/types/convo-error.d.ts

@@ -1,10 +0,0 @@
-/**
- * General conversation error
- */
-export class ConversationError {
-}
-/**
- * InvalidUserCreation thrown when failed to create conversation with invalid user
- */
-export class InvalidUserCreation extends ConversationError {
-}

package/dist/types/decryption-transforms.d.ts

@@ -1 +0,0 @@
-export const transforms: any[];

package/dist/types/encryption-transforms.d.ts

@@ -1 +0,0 @@
-export const transforms: any[];

package/dist/types/index.d.ts

@@ -1,3 +0,0 @@
-export { default } from "./conversation";
-export { default as ShareActivity } from "./share-activity";
-export { ConversationError, InvalidUserCreation } from "./convo-error";

package/dist/types/share-activity.d.ts

@@ -1,7 +0,0 @@
-export const EMITTER_SYMBOL: unique symbol;
-export const FILE_SYMBOL: unique symbol;
-export default ShareActivity;
-/**
- * @class
- */
-declare const ShareActivity: any;

package/dist/types/to-array.d.ts

@@ -1,9 +0,0 @@
-/**
- * Helper to convert objects into arrays of transforms. probably belongs in
- * webex-core
- * @param {string} direction "inbound"|"outbound"
- * @param {Object} obj
- * @private
- * @returns {Array}
- */
-export default function toArray(direction: string, obj: any): any[];