@webex/internal-plugin-conversation 2.59.8 → 2.60.0-next.2

package/test/integration/spec/get.js

@@ -154,6 +154,7 @@ describe('plugin-conversation', function () {
             scr: {
               loc: makeLocalUrl('/sample-image-small-one.png'),
             },
+            url: makeLocalUrl('/sample-image-small-one.png')
           })
           .then((f) =>
             fh.isMatchingFile(f, sampleImageSmallOnePng).then((result) => assert.isTrue(result))
@@ -467,7 +468,8 @@ describe('plugin-conversation', function () {
             }));
       });
 
-      describe('with conversation from remote clusters', () => {
+      // SPARK-413317
+      describe.skip('with conversation from remote clusters', () => {
         let conversation3, conversation4;
 
         before('create conversations in EU cluster', () =>
@@ -959,7 +961,7 @@ describe('plugin-conversation', function () {
           .then(({edit}) => {
             assert.include(edit, parent.id);
           }));
-
+      
       it('retrieves parent IDs for reactions', () =>
         webex.internal.conversation
           .addReaction(conversation, 'heart', parent)

package/test/unit/spec/conversation.js

@@ -34,6 +34,88 @@ describe('plugin-conversation', () => {
       webex.internal.services.getServiceUrlFromClusterId = sinon.stub().returns(convoUrl);
     });
 
+    describe('addReaction()', () => {
+      it('should add recipients to the payload if provided', () => {
+        const {conversation} = webex.internal;
+        const recipientId = 'example-recipient-id';
+        const expected = {items: [{id: recipientId, objectType: 'person'}]}
+        conversation.sendReaction = sinon.stub().returns(Promise.resolve())
+        conversation.createReactionHmac = sinon.stub().returns(Promise.resolve('hmac'))
+        
+        return conversation.addReaction({}, 'example-display-name', {}, recipientId)
+          .then(() => {
+            assert.deepEqual(conversation.sendReaction.args[0][1].recipients, expected);
+          });
+      });
+    });
+
+    describe('deleteReaction()', () => {
+      it('should add recipients to the payload if provided', () => {
+        const {conversation} = webex.internal;
+        const recipientId = 'example-recipient-id';
+        const expected = {items: [{id: recipientId, objectType: 'person'}]}
+        conversation.sendReaction = sinon.stub().returns(Promise.resolve())
+        
+        return conversation.deleteReaction({}, 'example-reaction-id', recipientId)
+          .then(() => {
+            assert.deepEqual(conversation.sendReaction.args[0][1].recipients, expected);
+          });
+      });
+    });
+
+    describe('prepare()', () => {
+      it('should ammend activity recipients to the returned object', () => {
+        const {conversation} = webex.internal;
+        const activity = { recipients: 'example-recipients' };
+
+        return conversation.prepare(activity)
+          .then((results) => {
+            assert.deepEqual(results.recipients, activity.recipients);
+        });
+      });
+    });
+
+    describe('addReaction()', () => {
+      it('should add recipients to the payload if provided', () => {
+        const {conversation} = webex.internal;
+        const recipientId = 'example-recipient-id';
+        const expected = {items: [{id: recipientId, objectType: 'person'}]}
+        conversation.sendReaction = sinon.stub().returns(Promise.resolve())
+        conversation.createReactionHmac = sinon.stub().returns(Promise.resolve('hmac'))
+        
+        return conversation.addReaction({}, 'example-display-name', {}, recipientId)
+          .then(() => {
+            assert.deepEqual(conversation.sendReaction.args[0][1].recipients, expected);
+          });
+      });
+    });
+
+    describe('deleteReaction()', () => {
+      it('should add recipients to the payload if provided', () => {
+        const {conversation} = webex.internal;
+        const recipientId = 'example-recipient-id';
+        const expected = {items: [{id: recipientId, objectType: 'person'}]}
+        conversation.sendReaction = sinon.stub().returns(Promise.resolve())
+        
+        return conversation.deleteReaction({}, 'example-reaction-id', recipientId)
+          .then(() => {
+            assert.deepEqual(conversation.sendReaction.args[0][1].recipients, expected);
+          });
+      });
+    });
+
+    describe('prepare()', () => {
+      it('should ammend activity recipients to the returned object', () => {
+        const {conversation} = webex.internal;
+        const activity = { recipients: 'example-recipients' };
+
+        return conversation.prepare(activity)
+          .then((results) => {
+            assert.deepEqual(results.recipients, activity.recipients);
+        });
+      });
+    });
+
     describe('processInmeetingchatEvent()', () => {
       beforeEach(() => {
         webex.transform = sinon.stub().callsFake((obj) => Promise.resolve(obj));

package/test/unit/spec/encryption-transforms.js

@@ -36,6 +36,29 @@ describe('plugin-conversation', () => {
           });
       });
 
+      it('does not transform when object type is "policies" for a "meetingContainer" activity', async () => {
+        const transform = transforms.find((t) => t.name === 'encryptActivity');
+        const transformStub = sinon.stub().resolves();
+
+        const ctx = {
+          transform: transformStub,
+        };
+        const key = null;
+        const activity = {
+          object: {
+            objectType: 'policies',
+          },
+          objectType: 'activity',
+          target: {
+            objectType: 'meetingContainer',
+          },
+          verb: 'update',
+        };
+
+        const results = await transform.fn(ctx, key, activity);
+        assert.equal(results, undefined);
+      });
+
       it('does transfom when created is not True', async () => {
         const transform = transforms.find((t) => t.name === 'encryptActivity');
         const transformStub = sinon.stub().resolves();