@webex/internal-plugin-conversation 2.42.0 → 2.43.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@webex/internal-plugin-conversation",
-  "version": "2.42.0",
+  "version": "2.43.0",
   "description": "",
   "license": "MIT",
   "main": "dist/index.js",
@@ -20,26 +20,26 @@
     ]
   },
   "dependencies": {
-    "@webex/common": "2.42.0",
-    "@webex/helper-html": "2.42.0",
-    "@webex/helper-image": "2.42.0",
-    "@webex/internal-plugin-conversation": "2.42.0",
-    "@webex/internal-plugin-encryption": "2.42.0",
-    "@webex/internal-plugin-user": "2.42.0",
-    "@webex/webex-core": "2.42.0",
+    "@webex/common": "2.43.0",
+    "@webex/helper-html": "2.43.0",
+    "@webex/helper-image": "2.43.0",
+    "@webex/internal-plugin-conversation": "2.43.0",
+    "@webex/internal-plugin-encryption": "2.43.0",
+    "@webex/internal-plugin-user": "2.43.0",
+    "@webex/webex-core": "2.43.0",
     "crypto-js": "^4.1.1",
     "lodash": "^4.17.21",
     "node-scr": "^0.3.0",
     "uuid": "^3.3.2"
   },
   "devDependencies": {
-    "@webex/test-helper-chai": "2.42.0",
-    "@webex/test-helper-file": "2.42.0",
-    "@webex/test-helper-make-local-url": "2.42.0",
-    "@webex/test-helper-mocha": "2.42.0",
-    "@webex/test-helper-mock-webex": "2.42.0",
-    "@webex/test-helper-retry": "2.42.0",
-    "@webex/test-helper-test-users": "2.42.0",
+    "@webex/test-helper-chai": "2.43.0",
+    "@webex/test-helper-file": "2.43.0",
+    "@webex/test-helper-make-local-url": "2.43.0",
+    "@webex/test-helper-mocha": "2.43.0",
+    "@webex/test-helper-mock-webex": "2.43.0",
+    "@webex/test-helper-retry": "2.43.0",
+    "@webex/test-helper-test-users": "2.43.0",
     "sinon": "^9.2.4"
   }
 }

package/test/unit/spec/conversation.js

@@ -5,7 +5,6 @@
 import {assert} from '@webex/test-helper-chai';
 import MockWebex from '@webex/test-helper-mock-webex';
 import sinon from 'sinon';
-
 import Conversation from '@webex/internal-plugin-conversation';
 
 import {
@@ -139,9 +138,7 @@ describe('plugin-conversation', () => {
       it('should convert a "us" cluster to WEBEX_CONVERSATION_DEFAULT_CLUSTER cluster', async () => {
         await webex.internal.conversation.getUrlFromClusterId({cluster: 'us'});
 
-        sinon.assert.calledWith(webex.internal.services.getServiceFromClusterId, {
-          clusterId: process.env.WEBEX_CONVERSATION_DEFAULT_CLUSTER,
-        });
+        sinon.assert.calledWith(webex.internal.services.getServiceFromClusterId, {clusterId: 'urn:TEAM:us-east-2_a:identityLookup'});
       });
 
       it('should add the cluster service when missing', async () => {
@@ -155,11 +152,9 @@ describe('plugin-conversation', () => {
 
     describe('paginate', () => {
       it('should throw an error if a page is passed with no links', () => {
-        try {
-          webex.internal.conversation.paginate({page: {}});
-        } catch (error) {
+        webex.internal.conversation.paginate({page: {}}).catch((error) => {
           assert.equal(error.message, 'No link to follow for the provided page');
-        }
+        });
       });
     });
 
@@ -334,14 +329,12 @@ describe('plugin-conversation', () => {
               conversationUrl: convoUrl,
             });
 
-            try {
-              jumpToActivity();
-            } catch (e) {
+            jumpToActivity().catch((e) => {
               assert.equal(
                 e.message,
                 'Search must be an activity object from conversation service'
               );
-            }
+            });
           });
 
           it('should throw an error if activity.target.url is missing', () => {
@@ -349,11 +342,9 @@ describe('plugin-conversation', () => {
               conversationUrl: convoUrl,
             });
 
-            try {
-              assert.throws(jumpToActivity({target: null}));
-            } catch (e) {
-              //
-            }
+            jumpToActivity({target: null}).catch((e) => {
+              assert.equal(e.message, 'Search object must have a target url!');
+            });
           });
 
           it('should implement the iterator protocol', () => {