@webex/contact-center 3.12.0-llmrefactor.7 → 3.12.0-llmrefactor.8

package/test/unit/spec/services/task/state-machine/TaskStateMachine.ts

@@ -199,7 +199,7 @@ describe('Task state machine', () => {
       expect(emitTaskEnd).not.toHaveBeenCalled();
     });
 
-    it('terminates CONNECTED when an out-of-order participant leave identifies the current agent', () => {
+    it('ignores PARTICIPANT_LEAVE in CONNECTED even when it identifies the current agent', () => {
       const {service, emitTaskEnd} = startMachineWithEndSpy();
       const taskData = createActiveMainCallTaskData();
 
@@ -213,53 +213,71 @@ describe('Task state machine', () => {
         taskData: createPartialMainCallTaskData(false, true),
       });
 
+      expect(service.getSnapshot().value).toBe(TaskState.CONNECTED);
+      expect(emitTaskEnd).not.toHaveBeenCalled();
+    });
+
+    it('ignores PARTICIPANT_LEAVE in HOLD_INITIATING when a remote Drop identifies the current agent', () => {
+      const {service, emitTaskEnd} = startMachineWithEndSpy();
+      const taskData = createActiveMainCallTaskData();
+
+      enterTransientHoldState(service, TaskState.HOLD_INITIATING, taskData);
+      service.send({
+        type: TaskEvent.PARTICIPANT_LEAVE,
+        participantId: 'agent-1',
+        taskData: createPartialMainCallTaskData(false, true),
+      });
+
+      expect(service.getSnapshot().value).toBe(TaskState.HOLD_INITIATING);
+      expect(emitTaskEnd).not.toHaveBeenCalled();
+    });
+
+    it('terminates RESUME_INITIATING when a remote Drop identifies the current agent', () => {
+      const {service, emitTaskEnd} = startMachineWithEndSpy();
+      const taskData = createActiveMainCallTaskData(true);
+
+      enterTransientHoldState(service, TaskState.RESUME_INITIATING, taskData);
+      service.send({
+        type: TaskEvent.PARTICIPANT_LEAVE,
+        participantId: 'agent-1',
+        taskData: createPartialMainCallTaskData(true, true),
+      });
+
       expect(service.getSnapshot().value).toBe(TaskState.TERMINATED);
       expect(emitTaskEnd).toHaveBeenCalledTimes(1);
     });
 
-    it.each([TaskState.HOLD_INITIATING, TaskState.RESUME_INITIATING])(
-      'terminates %s when a remote Drop identifies the current agent',
-      (state) => {
-        const {service, emitTaskEnd} = startMachineWithEndSpy();
-        const taskData = createActiveMainCallTaskData(state === TaskState.RESUME_INITIATING);
-
-        enterTransientHoldState(service, state, taskData);
-        service.send({
-          type: TaskEvent.PARTICIPANT_LEAVE,
-          participantId: 'agent-1',
-          taskData: createPartialMainCallTaskData(
-            state === TaskState.RESUME_INITIATING,
-            true
-          ),
-        });
-
-        expect(service.getSnapshot().value).toBe(TaskState.TERMINATED);
-        expect(emitTaskEnd).toHaveBeenCalledTimes(1);
-      }
-    );
-
-    it.each([TaskState.HOLD_INITIATING, TaskState.RESUME_INITIATING])(
-      'keeps %s when ParticipantLeftConference identifies another participant',
-      (state) => {
-        const {service, emitTaskEnd} = startMachineWithEndSpy();
-        const taskData = createActiveMainCallTaskData(state === TaskState.RESUME_INITIATING);
-
-        enterTransientHoldState(service, state, taskData);
-        service.send({
-          type: TaskEvent.PARTICIPANT_LEAVE,
-          participantId: 'agent-2',
-          taskData: createPartialMainCallTaskData(
-            state === TaskState.RESUME_INITIATING,
-            true
-          ),
-        });
-
-        expect(service.getSnapshot().value).toBe(state);
-        expect(emitTaskEnd).not.toHaveBeenCalled();
-      }
-    );
+    it('keeps HOLD_INITIATING when ParticipantLeftConference identifies another participant', () => {
+      const {service, emitTaskEnd} = startMachineWithEndSpy();
+      const taskData = createActiveMainCallTaskData();
 
-    it('keeps HELD when another participant leave event omits self from its roster', () => {
+      enterTransientHoldState(service, TaskState.HOLD_INITIATING, taskData);
+      service.send({
+        type: TaskEvent.PARTICIPANT_LEAVE,
+        participantId: 'agent-2',
+        taskData: createPartialMainCallTaskData(false, true),
+      });
+
+      expect(service.getSnapshot().value).toBe(TaskState.HOLD_INITIATING);
+      expect(emitTaskEnd).not.toHaveBeenCalled();
+    });
+
+    it('terminates RESUME_INITIATING when another participant leave omits self from the roster', () => {
+      const {service, emitTaskEnd} = startMachineWithEndSpy();
+      const taskData = createActiveMainCallTaskData(true);
+
+      enterTransientHoldState(service, TaskState.RESUME_INITIATING, taskData);
+      service.send({
+        type: TaskEvent.PARTICIPANT_LEAVE,
+        participantId: 'agent-2',
+        taskData: createPartialMainCallTaskData(true, true),
+      });
+
+      expect(service.getSnapshot().value).toBe(TaskState.TERMINATED);
+      expect(emitTaskEnd).toHaveBeenCalledTimes(1);
+    });
+
+    it('terminates HELD when another participant leave event omits self from its roster', () => {
       const {service, emitTaskEnd} = startMachineWithEndSpy();
       const taskData = createActiveMainCallTaskData(true);
 
@@ -275,8 +293,8 @@ describe('Task state machine', () => {
         taskData: createPartialMainCallTaskData(true, true),
       });
 
-      expect(service.getSnapshot().value).toBe(TaskState.HELD);
-      expect(emitTaskEnd).not.toHaveBeenCalled();
+      expect(service.getSnapshot().value).toBe(TaskState.TERMINATED);
+      expect(emitTaskEnd).toHaveBeenCalledTimes(1);
     });
 
     it('keeps HELD when CONSULT_END has a partial mainCall', () => {
@@ -2064,7 +2082,15 @@ describe('Task state machine', () => {
 
     it('transitions to CONNECTED on CONSULT_END without isTerminated during CONF_INITIATING', () => {
       const service = startMachine();
-      const taskData = createTaskData({consultingAgentId: 'agent-1'});
+      const taskData = createTaskData({
+        consultingAgentId: 'agent-1',
+        interaction: {
+          participants: {
+            'agent-1': {id: 'agent-1', pType: 'Agent', hasLeft: false},
+            'customer-1': {id: 'customer-1', pType: 'Customer', hasLeft: false},
+          },
+        } as any,
+      });
 
       service.send({type: TaskEvent.TASK_INCOMING, taskData});
       service.send({type: TaskEvent.ASSIGN, taskData});

package/test/unit/spec/services/task/state-machine/guards.ts

@@ -636,7 +636,7 @@ describe('State Machine Guards', () => {
       expect(guards.didCurrentAgentLeaveMainInteraction(createParams(context, event))).toBe(true);
     });
 
-    it('returns true when the current participant is marked as departed', () => {
+    it('returns false when the current participant is marked hasLeft but remains in the map', () => {
       const context = createContext({taskData: activeTaskData});
       const updatedTaskData = createTaskData({
         interaction: {
@@ -652,10 +652,10 @@ describe('State Machine Guards', () => {
         guards.didCurrentAgentLeaveMainInteraction(
           createParams(context, createEventWithTaskData(updatedTaskData))
         )
-      ).toBe(true);
+      ).toBe(false);
     });
 
-    it('uses mainCall membership for nested CONSULT_END cleanup', () => {
+    it('does not infer departure from CONSULT_END mainCall membership', () => {
       const context = createContext({taskData: activeTaskData, consultFromConference: true});
       const updatedTaskData = createTaskData({
         interaction: {
@@ -690,10 +690,10 @@ describe('State Machine Guards', () => {
 
       expect(
         guards.didCurrentAgentLeaveMainInteraction(createParams(context, event))
-      ).toBe(true);
+      ).toBe(false);
     });
 
-    it('does not infer self departure when another participant leaves and the map omits self', () => {
+    it('returns true when another participant leaves and the map omits self', () => {
       const context = createContext({taskData: activeTaskData});
       const partialTaskData = createTaskData({
         interaction: {
@@ -718,7 +718,7 @@ describe('State Machine Guards', () => {
         taskData: partialTaskData,
       } as TaskEventPayload;
 
-      expect(guards.didCurrentAgentLeaveMainInteraction(createParams(context, event))).toBe(false);
+      expect(guards.didCurrentAgentLeaveMainInteraction(createParams(context, event))).toBe(true);
     });
 
     it.each(['connected', 'held'])(