@webda/core 2.4.2 → 3.0.0

package/lib/stores/store.js

@@ -4,16 +4,17 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
     else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
     return c > 3 && r && Object.defineProperty(target, key, r), r;
 };
-import { Counter, Histogram, WebdaError } from "../core.js";
+import { Counter, Histogram } from "../core.js";
+import { ModelMapLoaderImplementation, Throttler, WebdaError } from "../index.js";
 import { CoreModel } from "../models/coremodel.js";
 import { Route, Service, ServiceParameters } from "../services/service.js";
 import { WebdaQL } from "./webdaql/query.js";
-export class StoreNotFoundError extends WebdaError {
+export class StoreNotFoundError extends WebdaError.CodeError {
     constructor(uuid, storeName) {
         super("STORE_NOTFOUND", `Item not found ${uuid} Store(${storeName})`);
     }
 }
-export class UpdateConditionFailError extends WebdaError {
+export class UpdateConditionFailError extends WebdaError.CodeError {
     constructor(uuid, conditionField, condition) {
         super("STORE_UPDATE_CONDITION_FAILED", `UpdateCondition not met on ${uuid}.${conditionField} === ${condition instanceof Date ? condition.toISOString() : condition}`);
     }
@@ -26,7 +27,6 @@ export class StoreParameters extends ServiceParameters {
         var _a;
         super(params);
         this.model ?? (this.model = "Webda/CoreModel");
-        this.models ?? (this.models = []);
         let expose = params.expose;
         if (typeof expose == "boolean") {
             expose = {};
@@ -56,6 +56,7 @@ export class StoreParameters extends ServiceParameters {
         this.defaultModel ?? (this.defaultModel = true);
         this.forceModel ?? (this.forceModel = false);
         this.slowQueryThreshold ?? (this.slowQueryThreshold = 30000);
+        this.modelAliases ?? (this.modelAliases = {});
     }
 }
 /**
@@ -100,9 +101,9 @@ class Store extends Service {
          */
         this._reverseMap = [];
         /**
-         * Models of this store
+         * Store teh manager hierarchy with their depth
          */
-        this._models = [];
+        this._modelsHierarchy = {};
         /**
          * Contain the model uuid field
          */
@@ -115,19 +116,32 @@ class Store extends Service {
      */
     computeParameters() {
         super.computeParameters();
+        const app = this.getWebda().getApplication();
         const p = this.parameters;
-        this._model = this._webda.getModel(p.model);
-        this._models = [
-            this._model,
-            ...this.parameters.models.map(m => this._webda.getModel(m))
-        ];
-        this._modelType = this._webda.getApplication().getModelFromConstructor(this._model);
+        this._model = app.getModel(p.model);
+        this._modelType = this._model.getIdentifier();
         this._uuidField = this._model.getUuidField();
-        this._lastUpdateField = this._model.getLastUpdateField();
-        this._creationDateField = this._model.getCreationField();
         this._cacheStore?.computeParameters();
         this.cacheStorePatchException();
-        this.parent = this.parameters.parent ? this.getService(this.parameters.parent.name) : undefined;
+        const recursive = (tree, depth) => {
+            var _a;
+            for (let i in tree) {
+                (_a = this._modelsHierarchy)[i] ?? (_a[i] = depth);
+                this._modelsHierarchy[i] = Math.min(depth, this._modelsHierarchy[i]);
+                this._modelsHierarchy[app.completeNamespace(i)] = this._modelsHierarchy[i];
+                recursive(app.getModelHierarchy(i).children, depth + 1);
+            }
+        };
+        // Compute the hierarchy
+        this._modelsHierarchy[this._model.getIdentifier(false)] = 0;
+        this._modelsHierarchy[this._model.getIdentifier()] = 0;
+        // Strict Store only store their model
+        if (!this.parameters.strict) {
+            recursive(this._model.getHierarchy().children, 1);
+        }
+        if (this.getParameters().expose) {
+            this.log("WARN", "Exposing a store is not recommended, use a DomainService instead to expose all your CoreModel");
+        }
     }
     logSlowQuery(_query, _reason, _time) {
         // TODO Need to implement: https://github.com/loopingz/webda.io/issues/202
@@ -146,7 +160,10 @@ class Store extends Service {
             name: "store_slow_queries",
             help: "Number of slow queries encountered"
         });
-        this.metrics.queries = this.getMetric(Histogram, { name: "store_queries", help: "Query duration" });
+        this.metrics.queries = this.getMetric(Histogram, {
+            name: "store_queries",
+            help: "Query duration"
+        });
     }
     /**
      * Return Store current model
@@ -155,9 +172,6 @@ class Store extends Service {
     getModel() {
         return this._model;
     }
-    getLastUpdateField() {
-        return this._model.getLastUpdateField();
-    }
     /**
      * Return if a model is handled by the store
      * @param model
@@ -165,29 +179,8 @@ class Store extends Service {
      *
      */
     handleModel(model) {
-        let finalDepth;
-        // @ts-ignore
-        let inst = model.__class ? model : new model();
-        this._models
-            .filter(m => inst instanceof m)
-            .forEach(m => {
-            let next = model instanceof CoreModel ? model.__class : model;
-            let depth = 0;
-            while (next && next.name !== "") {
-                if (next === m) {
-                    finalDepth = finalDepth !== undefined ? Math.min(depth, finalDepth) : depth;
-                    return;
-                }
-                // If Store strictly managed one Model
-                if (this.parameters.strict) {
-                    return;
-                }
-                depth++;
-                next = Object.getPrototypeOf(next);
-            }
-        });
-        finalDepth ?? (finalDepth = -1);
-        return finalDepth;
+        const name = this.getWebda().getApplication().getModelName(model);
+        return this._modelsHierarchy[name] ?? -1;
     }
     /**
      * Get From Cache or main
@@ -214,22 +207,6 @@ class Store extends Service {
         this.metrics.operations_total.inc({ operation: "get" });
         return this._getFromCache(uid);
     }
-    /**
-     * Get the full url with the nested parent
-     * @param url
-     * @param methods
-     * @param depth
-     */
-    getParentUrl(depth = 0) {
-        if (!this.parameters.expose) {
-            throw new Error(`Parent store need to be exposed ${this.getName()}`);
-        }
-        let res = `${this.parameters.url}/{P${depth}uuid}`;
-        if (this.parent) {
-            res = this.parent.getParentUrl(depth + 1) + res;
-        }
-        return res;
-    }
     /**
      * @override
      */
@@ -250,8 +227,7 @@ class Store extends Service {
             (url === "." && methods.includes("PUT") && expose.restrict.query)) {
             return undefined;
         }
-        let parentUrl = this.parent ? this.parent.getParentUrl() : "";
-        return parentUrl + super.getUrl(url, methods);
+        return super.getUrl(url, methods);
     }
     /**
      * @inheritdoc
@@ -290,7 +266,7 @@ class Store extends Service {
                     requestBody,
                     responses: {
                         "200": {
-                            description: "Retrieve models",
+                            description: `Retrieve models ${this._model.name}`,
                             content: {
                                 "application/json": {
                                     schema: {
@@ -331,7 +307,6 @@ class Store extends Service {
                 if (action.global) {
                     // By default will grab the object and then call the action
                     if (!this._model[name] && !this._model["_" + name]) {
-                        console.log(this._model);
                         throw Error("Action static method /_?" + name + "/ does not exist");
                     }
                     executer = this.httpGlobalAction;
@@ -378,7 +353,7 @@ class Store extends Service {
             "_patch",
             "_update",
             "_delete",
-            "_incrementAttribute",
+            "_incrementAttributes",
             "_upsertItemToCollection",
             "_deleteItemFromCollection",
             "_removeAttribute"
@@ -397,7 +372,7 @@ class Store extends Service {
     initModel(object = {}) {
         var _a;
         if (object instanceof CoreModel) {
-            object.__type = this.getWebda().getApplication().getModelFromInstance(object);
+            object.__type ?? (object.__type = this.getWebda().getApplication().getModelFromInstance(object) || this._modelType);
         }
         else {
             object.__type ?? (object.__type = this._modelType);
@@ -407,7 +382,9 @@ class Store extends Service {
             // Dynamic load type
             if (object.__type && !this.getParameters().forceModel) {
                 try {
-                    const modelType = this.getWebda().getApplication().getModel(object.__type);
+                    const modelType = this.getWebda()
+                        .getApplication()
+                        .getModel(this.parameters.modelAliases[object.__type] || object.__type);
                     object = new modelType().load(object, true);
                 }
                 catch (err) {
@@ -428,6 +405,9 @@ class Store extends Service {
         for (let i in this._reverseMap) {
             object[_a = this._reverseMap[i].property] ?? (object[_a] = []);
             for (let j in object[this._reverseMap[i].property]) {
+                if (object[this._reverseMap[i].property][j] instanceof ModelMapLoaderImplementation) {
+                    continue;
+                }
                 // Use Partial
                 object[this._reverseMap[i].property][j] = this._reverseMap[i].mapper.newModel(object[this._reverseMap[i].property][j]);
                 object[this._reverseMap[i].property][j].setContext(object.getContext());
@@ -458,27 +438,52 @@ class Store extends Service {
             mapper: store
         });
     }
-    async incrementAttribute(uid, prop, value) {
+    /**
+     * Increment attributes of an object
+     *
+     * @param uid
+     * @param info
+     * @returns
+     */
+    async incrementAttributes(uid, info) {
+        let params = info.filter(i => i.value !== 0);
         // If value === 0 no need to update anything
-        if (value === 0) {
-            return Promise.resolve();
+        if (params.length === 0) {
+            return;
         }
         let updateDate = new Date();
         this.metrics.operations_total.inc({ operation: "increment" });
-        await this._incrementAttribute(uid, prop, value, updateDate);
-        await this._cacheStore?._incrementAttribute(uid, prop, value, updateDate);
+        await this._incrementAttributes(uid, params, updateDate);
+        await this._cacheStore?._incrementAttributes(uid, params, updateDate);
         return this.emitSync("Store.PartialUpdated", {
             object_id: uid,
             store: this,
             updateDate,
             partial_update: {
-                increment: {
-                    value: value,
-                    property: prop
-                }
+                increments: params
             }
         });
     }
+    /**
+     * Helper function that call incrementAttributes
+     * @param uid
+     * @param prop
+     * @param value
+     * @returns
+     */
+    async incrementAttribute(uid, prop, value) {
+        return this.incrementAttributes(uid, [{ property: prop, value }]);
+    }
+    /**
+     * Add or update an item to an array in the model
+     *
+     * @param uid of the model
+     * @param prop of the model to add in
+     * @param item to add in the array
+     * @param index if specified update item in this index
+     * @param itemWriteCondition value of the condition to test (in case of update)
+     * @param itemWriteConditionField field to read the condition from (in case of update)
+     */
     async upsertItemToCollection(uid, prop, item, index = undefined, itemWriteCondition = undefined, itemWriteConditionField = this._uuidField) {
         let updateDate = new Date();
         this.metrics.operations_total.inc({ operation: "collectionUpsert" });
@@ -497,6 +502,15 @@ class Store extends Service {
             }
         });
     }
+    /**
+     * Remove an item from an array in the model
+     *
+     * @param uid of the model
+     * @param prop of the model to remove from
+     * @param index of the item to remove in the array
+     * @param itemWriteCondition value of the condition
+     * @param itemWriteConditionField field to read the condition from
+     */
     async deleteItemFromCollection(uid, prop, index, itemWriteCondition, itemWriteConditionField = this._uuidField) {
         let updateDate = new Date();
         this.metrics.operations_total.inc({ operation: "collectionDelete" });
@@ -536,6 +550,14 @@ class Store extends Service {
         } while (continuationToken);
         return res;
     }
+    /**
+     * Check that __type Comparison is only used with = and CONTAINS
+     * If CONTAINS is used, move __type to __types
+     * If __type = store._model, remove it
+     */
+    queryTypeUpdater(query) {
+        return query;
+    }
     /**
      * Query store with WebdaQL
      * @param query
@@ -560,7 +582,9 @@ class Store extends Service {
         let queryValidator = new WebdaQL.QueryValidator(fullQuery);
         let offset = queryValidator.getOffset();
         const limit = queryValidator.getLimit();
-        const parsedQuery = queryValidator.getQuery();
+        const parsedQuery = this.queryTypeUpdater(queryValidator.getQuery());
+        parsedQuery.limit = limit;
+        // __type is a special field to filter on the type of the object
         // Emit the default event
         await this.emitSync("Store.Query", {
             query,
@@ -587,7 +611,10 @@ class Store extends Service {
         let duration = Date.now();
         this.metrics.operations_total.inc({ operation: "query" });
         while (result.results.length < limit) {
-            let tmpResults = await this.find({ ...parsedQuery, continuationToken: mainOffset });
+            let tmpResults = await this.find({
+                ...parsedQuery,
+                continuationToken: mainOffset
+            });
             // If no filter is returned assume it is by mistake and apply filtering
             if (tmpResults.filter === undefined) {
                 tmpResults.filter = queryValidator.getExpression();
@@ -595,6 +622,7 @@ class Store extends Service {
             }
             let subOffsetCount = 0;
             for (let item of tmpResults.results) {
+                item.setContext(context);
                 // Because of dynamic filter and permission we need to suboffset the pagination
                 subOffsetCount++;
                 if (subOffsetCount <= secondOffset) {
@@ -603,13 +631,8 @@ class Store extends Service {
                 if (tmpResults.filter !== true && !tmpResults.filter.eval(item)) {
                     continue;
                 }
-                if (context && partialPermission) {
-                    try {
-                        await item.canAct(context, "get");
-                    }
-                    catch (err) {
-                        continue;
-                    }
+                if (context && partialPermission && (await item.canAct(context, "get")) !== true) {
+                    continue;
                 }
                 result.results.push(item);
                 if (result.results.length >= limit) {
@@ -663,7 +686,7 @@ class Store extends Service {
         catch (err) {
             if (err instanceof SyntaxError) {
                 this.log("INFO", "Query syntax error");
-                throw 400;
+                throw new WebdaError.BadRequest("Query syntax error");
             }
             throw err;
         }
@@ -678,9 +701,7 @@ class Store extends Service {
      * Might want to rename to create
      */
     async save(object, ctx = undefined) {
-        if (object instanceof this._model &&
-            object[this._creationDateField] !== undefined &&
-            object[this._lastUpdateField] !== undefined) {
+        if (object instanceof this._model && object._creationDate !== undefined && object._lastUpdate !== undefined) {
             if (ctx) {
                 object.setContext(ctx);
             }
@@ -688,12 +709,19 @@ class Store extends Service {
         }
         return this.create(object, ctx);
     }
+    /**
+     *
+     * @param object
+     * @param ctx
+     * @returns
+     */
     async create(object, ctx = undefined) {
-        var _a;
         object = this.initModel(object);
         // Dates should be store by the Store
-        object[_a = this._creationDateField] ?? (object[_a] = new Date());
-        object[this._lastUpdateField] = new Date();
+        object._creationDate ?? (object._creationDate = new Date());
+        object._lastUpdate = new Date();
+        const ancestors = this.getWebda().getApplication().getModelHierarchy(object.__type).ancestors;
+        object.__types = [object.__type, ...ancestors].filter(i => i !== "Webda/CoreModel" && i !== "CoreModel");
         if (ctx) {
             object.setContext(ctx);
         }
@@ -806,7 +834,7 @@ class Store extends Service {
         else {
             model[prop][index] = item;
         }
-        model[this._lastUpdateField] = updateDate;
+        model._lastUpdate = updateDate;
         await this._save(model);
     }
     /**
@@ -833,7 +861,7 @@ class Store extends Service {
         if (Object.keys(object).length < 2) {
             return undefined;
         }
-        object[this._lastUpdateField] = new Date();
+        object._lastUpdate = new Date();
         this.metrics.operations_total.inc({ operation: "get" });
         let load = await this._getFromCache(object[this._uuidField], true);
         if (load.__type !== this._modelType && this.parameters.strict) {
@@ -861,13 +889,13 @@ class Store extends Service {
         await loaded._onUpdate(object);
         let res;
         if (conditionField !== null) {
-            conditionField ?? (conditionField = this._lastUpdateField);
+            conditionField ?? (conditionField = "_lastUpdate");
             conditionValue ?? (conditionValue = load[conditionField]);
         }
         if (partial) {
             this.metrics.operations_total.inc({ operation: "partialUpdate" });
             await this._patch(object, object[this._uuidField], conditionValue, conditionField);
-            await this._cacheStore?._patch(object, object[this._uuidField], load[this._lastUpdateField], this._lastUpdateField);
+            await this._cacheStore?._patch(object, object[this._uuidField], load._lastUpdate, "_lastUpdate");
             res = object;
         }
         else {
@@ -878,7 +906,7 @@ class Store extends Service {
             object = this.initModel(object);
             this.metrics.operations_total.inc({ operation: "update" });
             res = await this._update(object, object[this._uuidField], conditionValue, conditionField);
-            await this._cacheStore?._update(object, object[this._uuidField], load[this._lastUpdateField], this._lastUpdateField);
+            await this._cacheStore?._update(object, object[this._uuidField], load._lastUpdate, "_lastUpdate");
         }
         // Return updated
         for (let i in res) {
@@ -903,6 +931,138 @@ class Store extends Service {
         await saved._onUpdated();
         return saved;
     }
+    /**
+     * Manage the store migration for __type case sensitivity
+     */
+    async v3Migration() {
+        // Compute case for all object
+        await this.recomputeTypeCase();
+        // Compute all __types
+        await this.recomputeTypes();
+        // We do not move to short id as it is not compatible with v2
+    }
+    /**
+     *
+     */
+    async recomputeTypeShortId() {
+        this.log("INFO", "Ensuring __type is using its short id form");
+        const app = this.getWebda().getApplication();
+        // We need to be laxist for migration
+        this.parameters.strict = false;
+        await this.migration("typesShortId", async (item) => {
+            if (item.__type !== undefined && item.__type.includes("/")) {
+                const model = app.getWebdaObject("models", item.__type);
+                const name = app.getShortId(app.getModelName(model));
+                if (name !== item.__type) {
+                    this.log("INFO", "Migrating type " + item.__type + " to " + name);
+                    return {
+                        __type: name
+                    };
+                }
+            }
+        });
+    }
+    /**
+     * Ensure model aliases are not used in this store
+     *
+     * So alias can be cleaned
+     */
+    async cleanModelAliases() {
+        this.log("INFO", "Ensuring __type is not using any aliases");
+        // We need to be laxist for migration
+        this.parameters.strict = false;
+        await this.migration("cleanAliases", async (item) => {
+            if (this.parameters.modelAliases[item.__type]) {
+                this.log("INFO", "Migrating type " + item.__type + " to " + this.parameters.modelAliases[item.__type]);
+                return {
+                    __type: this.parameters.modelAliases[item.__type]
+                };
+            }
+        });
+    }
+    /**
+     * Recompute type case
+     */
+    async recomputeTypeCase() {
+        this.log("INFO", "Ensuring __type is case sensitive from migration from v2.x");
+        const app = this.getWebda().getApplication();
+        // We need to be laxist for migration
+        this.parameters.strict = false;
+        await this.migration("typesCase", async (item) => {
+            if (item.__type !== undefined) {
+                if (!app.hasWebdaObject("models", item.__type, true) && app.hasWebdaObject("models", item.__type, false)) {
+                    const model = app.getWebdaObject("models", item.__type, false);
+                    const name = app.getModelName(model);
+                    if (model) {
+                        this.log("INFO", "Migrating type " + item.__type + " to " + name);
+                        return {
+                            __type: name
+                        };
+                    }
+                }
+            }
+        });
+    }
+    /**
+     * Recompute the __types for all objects (storeMigration.Registry.typesCompute)
+     */
+    async recomputeTypes() {
+        this.log("INFO", "Ensuring __types is correct from migration from v2.x");
+        // Update __types for each __type will be more efficient
+        await this.migration("typesCompute", async (item) => {
+            let __types = this.getWebda().getApplication().getModelTypes(item);
+            if (!item.__types ||
+                item.__types.length !== __types.length ||
+                !__types.every((element, index) => element === item.__types[index])) {
+                this.log("INFO", "Migrating types " + JSON.stringify(item.__types) + " to " + JSON.stringify(__types), "for", item.__type, item.getUuid());
+                return {
+                    __types
+                };
+            }
+        });
+    }
+    /**
+     * Delete a migration
+     * @param name
+     */
+    async cancelMigration(name) {
+        await this.getWebda().getRegistry().delete(`storeMigration.${this.getName()}.${name}`);
+    }
+    /**
+     * Get a migration
+     * @param name
+     */
+    async getMigration(name) {
+        return await this.getWebda().getRegistry().get(`storeMigration.${this.getName()}.${name}`);
+    }
+    /**
+     * Add a migration mechanism to store
+     * @param name
+     * @param patcher
+     */
+    async migration(name, patcher, batchSize = 500) {
+        let status = await this.getWebda().getRegistry().get(`storeMigration.${this.getName()}.${name}`, undefined, {});
+        status.count ?? (status.count = 0);
+        status.updated ?? (status.updated = 0);
+        const worker = new Throttler(20);
+        do {
+            const res = await this.query(status.continuationToken ? `LIMIT ${batchSize} OFFSET "${status.continuationToken}"` : `LIMIT ${batchSize}`);
+            status.count += res.results.length;
+            for (let item of res.results) {
+                let updated = await patcher(item);
+                if (updated !== undefined) {
+                    status.updated++;
+                    worker.queue(async () => {
+                        await item.patch(updated, null);
+                    });
+                }
+            }
+            this.log("INFO", `storeMigration.${this.getName()}.${name}: Migrated ${status.count} items: ${status.updated} updated`);
+            status.continuationToken = res.continuationToken;
+            await worker.waitForCompletion();
+            await status.save();
+        } while (status.continuationToken);
+    }
     /**
      * Remove an attribute from an object
      *
@@ -918,7 +1078,8 @@ class Store extends Service {
             object_id: uuid,
             partial_update: {
                 deleteAttribute: attribute
-            }
+            },
+            store: this
         });
     }
     /**
@@ -1023,7 +1184,7 @@ class Store extends Service {
         }
         let result = {};
         for (let i in object) {
-            if (i === this._uuidField || i === this._lastUpdateField || i.startsWith("_")) {
+            if (i === this._uuidField || i === "_lastUpdate" || i.startsWith("_")) {
                 continue;
             }
             result[i] = object[i];
@@ -1039,7 +1200,7 @@ class Store extends Service {
         if (await this.exists(uuid)) {
             return this.update({ ...data, uuid });
         }
-        return this.save({ ...data, uuid });
+        return this.save(data instanceof CoreModel ? data.setUuid(uuid) : { ...data, uuid });
     }
     /**
      * Get an object
@@ -1157,19 +1318,28 @@ class Store extends Service {
      * @param ctx
      */
     async httpCreate(ctx) {
-        let body = await ctx.getRequestBody();
-        let object = this._model.factory(this._model, body, ctx);
-        object[this._creationDateField] = new Date();
-        await object.canAct(ctx, "create");
+        return this.operationCreate(ctx, this.parameters.model);
+    }
+    /**
+     * Create a new object based on the context
+     * @param ctx
+     * @param model
+     */
+    async operationCreate(ctx, model) {
+        let body = await ctx.getInput();
+        const modelPrototype = this.getWebda().getApplication().getModel(model);
+        let object = modelPrototype.factory(modelPrototype, body, ctx);
+        object._creationDate = new Date();
+        await object.checkAct(ctx, "create");
         try {
             await object.validate(ctx, body);
         }
         catch (err) {
             this.log("INFO", "Object is not valid", err);
-            throw 400;
+            throw new WebdaError.BadRequest("Object is not valid");
         }
         if (object[this._uuidField] && (await this.exists(object[this._uuidField]))) {
-            throw 409;
+            throw new WebdaError.Conflict("Object already exists");
         }
         await this.save(object, ctx);
         ctx.write(object);
@@ -1188,22 +1358,16 @@ class Store extends Service {
         let action = ctx.getHttpContext().getUrl().split("/").pop();
         let object = await this.get(ctx.parameter("uuid"), ctx);
         if (object === undefined || object.__deleted) {
-            throw 404;
+            throw new WebdaError.NotFound("Object not found or is deleted");
         }
-        await object.canAct(ctx, action);
+        await object.checkAct(ctx, action);
         await this.emitSync("Store.Action", {
             action: action,
             object: object,
             store: this,
             context: ctx
         });
-        let res;
-        if (object["_" + action]) {
-            res = await object["_" + action](ctx);
-        }
-        else {
-            res = await object[action](ctx);
-        }
+        const res = await object[action](ctx);
         if (res) {
             ctx.write(res);
         }
@@ -1219,20 +1383,15 @@ class Store extends Service {
      * Handle collection action
      * @param ctx
      */
-    async httpGlobalAction(ctx) {
+    async httpGlobalAction(ctx, model = this._model) {
         let action = ctx.getHttpContext().getUrl().split("/").pop();
         await this.emitSync("Store.Action", {
             action: action,
             store: this,
-            context: ctx
+            context: ctx,
+            model
         });
-        let res;
-        if (this._model["_" + action]) {
-            res = await this._model["_" + action](ctx);
-        }
-        else {
-            res = await this._model[action](ctx);
-        }
+        const res = await model[action](ctx);
         if (res) {
             ctx.write(res);
         }
@@ -1240,7 +1399,8 @@ class Store extends Service {
             action: action,
             store: this,
             context: ctx,
-            result: res
+            result: res,
+            model
         });
     }
     /**
@@ -1249,20 +1409,20 @@ class Store extends Service {
      * @param ctx context of the request
      */
     async httpUpdate(ctx) {
-        let body = await ctx.getRequestBody();
-        let uuid = ctx.parameter("uuid");
+        const { uuid } = ctx.getParameters();
+        const body = await ctx.getInput();
         body[this._uuidField] = uuid;
         let object = await this.get(uuid, ctx);
         if (!object || object.__deleted)
-            throw 404;
-        await object.canAct(ctx, "update");
+            throw new WebdaError.NotFound("Object not found or is deleted");
+        await object.checkAct(ctx, "update");
         if (ctx.getHttpContext().getMethod() === "PATCH") {
             try {
                 await object.validate(ctx, body, true);
             }
             catch (err) {
                 this.log("INFO", "Object invalid", err, object);
-                throw 400;
+                throw new WebdaError.BadRequest("Object is not valid");
             }
             let updateObject = new this._model();
             // Clean any default attributes from the model
@@ -1291,7 +1451,7 @@ class Store extends Service {
             }
             catch (err) {
                 this.log("INFO", "Object invalid", err);
-                throw 400;
+                throw new WebdaError.BadRequest("Object is not valid");
             }
             // Add mappers back to
             object = await this.update(updateObject);
@@ -1319,9 +1479,9 @@ class Store extends Service {
             store: this
         });
         if (object === undefined || object.__deleted) {
-            throw 404;
+            throw new WebdaError.NotFound("Object not found or is deleted");
         }
-        await object.canAct(ctx, "get");
+        await object.checkAct(ctx, "get");
         ctx.write(object);
         await this.emitSync("Store.WebGet", {
             context: ctx,
@@ -1336,16 +1496,16 @@ class Store extends Service {
      * @param ctx context of the request
      * @returns
      */
-    async httpRoute(ctx) {
+    async httpDelete(ctx) {
         let uuid = ctx.parameter("uuid");
         let object = await this.get(uuid, ctx);
         if (!object || object.__deleted)
-            throw 404;
-        await object.canAct(ctx, "delete");
+            throw new WebdaError.NotFound("Object not found or is deleted");
+        await object.checkAct(ctx, "delete");
         // http://stackoverflow.com/questions/28684209/huge-delay-on-delete-requests-with-204-response-and-no-content-in-objectve-c#
         // IOS don't handle 204 with Content-Length != 0 it seems
-        // Have trouble to handle the Content-Length on API Gateway so returning an empty object for now
-        ctx.write({});
+        // Might still run into: Have trouble to handle the Content-Length on API Gateway so returning an empty object for now
+        ctx.writeHead(204, { "Content-Length": "0" });
         await this.delete(uuid);
         await this.emitSync("Store.WebDelete", {
             context: ctx,
@@ -1359,9 +1519,20 @@ class Store extends Service {
     getUuidField() {
         return this._uuidField;
     }
+    /**
+     * Check if an object exists
+     * @abstract
+     * @params {String} uuid of the object or the object
+     */
+    async exists(uid) {
+        if (typeof uid !== "string") {
+            uid = uid.getUuid();
+        }
+        return this._exists(uid);
+    }
 }
 __decorate([
-    Route(".", ["POST"], false, {
+    Route(".", ["POST"], {
         post: {
             description: "The way to create a new ${modelName} model",
             summary: "Create a new ${modelName}",
@@ -1400,7 +1571,7 @@ __decorate([
     })
 ], Store.prototype, "httpCreate", null);
 __decorate([
-    Route("./{uuid}", ["PUT", "PATCH"], false, {
+    Route("./{uuid}", ["PUT", "PATCH"], {
         put: {
             description: "Update a ${modelName} if the permissions allow",
             summary: "Update a ${modelName}",
@@ -1447,7 +1618,7 @@ __decorate([
     })
 ], Store.prototype, "httpUpdate", null);
 __decorate([
-    Route("./{uuid}", ["GET"], false, {
+    Route("./{uuid}", ["GET"], {
         get: {
             description: "Retrieve ${modelName} model if permissions allow",
             summary: "Retrieve a ${modelName}",
@@ -1471,7 +1642,7 @@ __decorate([
     })
 ], Store.prototype, "httpGet", null);
 __decorate([
-    Route("./{uuid}", ["DELETE"], false, {
+    Route("./{uuid}", ["DELETE"], {
         delete: {
             operationId: "delete${modelName}",
             description: "Delete ${modelName} if the permissions allow",
@@ -1489,6 +1660,6 @@ __decorate([
             }
         }
     })
-], Store.prototype, "httpRoute", null);
+], Store.prototype, "httpDelete", null);
 export { Store };
 //# sourceMappingURL=store.js.map