@web-ts-toolkit/express-response-handler 0.42.2 → 0.44.0

package/responses/csv.mjs

@@ -1,7 +1,6 @@
 // src/responses/csv.ts
 import { format } from "@fast-csv/format";
 import { castArray, isBoolean, isPlainObject } from "@web-ts-toolkit/utils";
-import { once } from "events";
 var CONTROL_CHARACTER_PATTERN = /[\u0000-\u001f\u007f]/u;
 var isIterable = (value) => typeof value === "object" && value !== null && Symbol.iterator in value;
 var isAsyncIterable = (value) => typeof value === "object" && value !== null && Symbol.asyncIterator in value;
@@ -65,28 +64,66 @@ var CSVResponse = class {
       this.headers = isPlainObject(this.dataset);
     }
   }
+  /**
+   * Streams the dataset as CSV into `res`.
+   *
+   * Contract choice (B-ERH-06): minimal runtime-safe fallback, no breaking
+   * signature change. `onBeforeOutputError` stays optional.
+   *
+   * - Pre-output failure (invalid filename, failed first read, first-row
+   *   processor throw, before headers are sent) with an error owner:
+   *   the owner is invoked exactly once with the normalized failure and owns
+   *   destination termination (the handler owner renders a single redacted
+   *   JSON error; direct callers must end/destroy `res` themselves). A
+   *   throwing owner is contained and the destination is then destroyed with
+   *   the original failure so it never stays open.
+   * - Pre-output failure without an error owner: deterministic fallback —
+   *   the destination is destroyed with the normalized failure (or ended
+   *   when `destroy` is unavailable), observable via `error` + `close`.
+   * - Post-output failure (after piping starts): the destination is always
+   *   destroyed with the failure, with or without an owner.
+   *
+   * Non-`Error` failures are wrapped in an `Error` with the original kept as
+   * `cause`. A throwing owner never displaces the original failure and never
+   * escapes as a process-level error.
+   */
   streamCsv(res, onBeforeOutputError) {
     const stream = format({ headers: this.headers });
     let outputStarted = false;
     let failed = false;
     let finished = false;
+    let cleaned = false;
     let activeIterator = null;
-    let abortStreaming = () => void 0;
-    const abortSignal = new Promise((_, reject) => {
-      abortStreaming = reject;
-    });
-    abortSignal.catch(() => void 0);
+    const abortWaiters = /* @__PURE__ */ new Set();
+    const notifyAborted = () => {
+      for (const notify of Array.from(abortWaiters)) {
+        abortWaiters.delete(notify);
+        try {
+          notify();
+        } catch {
+        }
+      }
+    };
     const cleanup = () => {
+      if (cleaned) {
+        return;
+      }
+      cleaned = true;
       stream.off("error", fail);
       res.off?.("error", fail);
-      res.off?.("close", abort);
-      res.off?.("finish", markFinished);
+      res.off?.("close", handleClose);
+      res.off?.("finish", handleFinish);
     };
     const closeActiveIterator = () => {
       const iterator = activeIterator;
       activeIterator = null;
-      if (iterator?.return) {
+      if (!iterator?.return) {
+        return;
+      }
+      try {
         void Promise.resolve(iterator.return()).catch(() => void 0);
+      } catch {
+        return;
       }
     };
     const closeResponse = (error) => {
@@ -101,58 +138,129 @@ var CSVResponse = class {
         return;
       }
       failed = true;
-      cleanup();
-      const normalizedError = error instanceof Error ? error : new Error("CSV response streaming failed");
-      abortStreaming(normalizedError);
+      notifyAborted();
+      const normalizedError = error instanceof Error ? error : (() => {
+        const wrapped = new Error("CSV response streaming failed");
+        try {
+          wrapped.cause = error;
+        } catch {
+        }
+        return wrapped;
+      })();
       closeActiveIterator();
       if (!outputStarted && !res.headersSent) {
-        onBeforeOutputError?.(normalizedError);
+        stream.destroy();
+        if (onBeforeOutputError) {
+          cleanup();
+          try {
+            onBeforeOutputError(normalizedError);
+          } catch {
+            try {
+              res.on?.("error", () => void 0);
+            } catch {
+            }
+            try {
+              closeResponse(normalizedError);
+            } catch {
+            }
+          }
+          return;
+        }
+        try {
+          closeResponse(normalizedError);
+        } catch {
+          cleanup();
+        }
         return;
       }
       stream.destroy();
       closeResponse(normalizedError);
     };
-    const abort = () => {
-      if (!finished) {
+    const handleClose = () => {
+      if (!finished && !failed) {
         fail(new Error("CSV response streaming aborted"));
+        cleanup();
+        return;
       }
+      cleanup();
     };
-    const markFinished = () => {
+    const handleFinish = () => {
       finished = true;
+      cleanup();
     };
     const writeRow = async (row) => {
+      if (failed) {
+        return;
+      }
       outputStarted = true;
       if (!stream.write(row)) {
-        await Promise.race([once(stream, "drain"), abortSignal]);
+        await new Promise((resolve) => {
+          if (failed) {
+            resolve();
+            return;
+          }
+          const onDrain = () => {
+            stream.off("drain", onDrain);
+            abortWaiters.delete(onAbort);
+            resolve();
+          };
+          const onAbort = () => {
+            stream.off("drain", onDrain);
+            resolve();
+          };
+          abortWaiters.add(onAbort);
+          stream.once("drain", onDrain);
+        });
       }
     };
     stream.on("error", fail);
-    stream.on("end", cleanup);
     res.on?.("error", fail);
-    res.on?.("close", abort);
-    res.on?.("finish", markFinished);
+    res.on?.("close", handleClose);
+    res.on?.("finish", handleFinish);
     const pump = async () => {
       try {
         const iterator = createAsyncIterator(this.dataset);
         activeIterator = iterator;
         const first = await iterator.next();
-        const firstRow = first.done ? void 0 : this.processor(first.value);
+        if (failed) {
+          return;
+        }
+        let firstRow;
+        if (!first.done) {
+          firstRow = this.processor(first.value);
+          if (failed) {
+            return;
+          }
+        }
         const contentDisposition = createAttachmentContentDisposition(this.filename);
+        if (failed) {
+          return;
+        }
         res.set("Content-Type", "text/csv");
         res.set("Content-Disposition", contentDisposition);
         stream.pipe(res);
-        if (!first.done) {
-          await writeRow(firstRow);
+        if (first.done) {
+          if (!failed) {
+            stream.end();
+          }
+          return;
         }
+        await writeRow(firstRow);
         while (!failed) {
-          const row = await Promise.race([iterator.next(), abortSignal]);
-          if (row.done) {
+          const result = await iterator.next();
+          if (failed) {
+            return;
+          }
+          if (result.done) {
             break;
           }
-          await writeRow(this.processor(row.value));
+          const processed = this.processor(result.value);
+          if (failed) {
+            return;
+          }
+          await writeRow(processed);
         }
         if (!failed) {
-          finished = true;
           stream.end();
         }
       } catch (error) {
@@ -161,7 +269,7 @@ var CSVResponse = class {
         activeIterator = null;
       }
     };
-    void pump();
+    void pump().then(void 0, () => void 0);
   }
 };
 export {