@weareikko/code-review 0.8.5 → 0.8.6

package/dist/{cli-DmzA9PxS.js → cli-BbR1oftT.js}

@@ -166,6 +166,7 @@ var REVIEW_THREADS_QUERY = `
           pageInfo { hasNextPage endCursor }
           nodes {
             isResolved
+            isOutdated
             comments(first: 100) { nodes { databaseId } }
           }
         }
@@ -338,14 +339,22 @@ var GitHubClient = class {
 		return parsed.data;
 	}
 	/**
-	* Return the database IDs of review comments that belong to a **resolved**
-	* review thread. GitHub's REST comment endpoints omit thread-resolution state;
-	* it is only exposed via GraphQL `reviewThreads.isResolved`. Callers use this
-	* set to mark normalized notes resolved so resolved threads are excluded from
-	* summary carry-over and prior-thread context. Paginates over threads.
+	* Return the database IDs of review comments that belong to a **settled**
+	* review thread — one that is either resolved or outdated. GitHub's REST
+	* comment endpoints omit both states; they are only exposed via GraphQL
+	* `reviewThreads.isResolved` / `isOutdated`. Callers use this set to mark
+	* normalized notes resolved so settled threads are excluded from summary
+	* carry-over and prior-thread context. Paginates over threads.
+	*
+	* Outdated counts as settled because GitHub, unlike GitLab, does not
+	* auto-resolve a thread when the line it anchors to changes: fixing a finding
+	* flips the thread to outdated but leaves `isResolved` false until someone
+	* manually resolves it. Treating outdated as settled mirrors GitLab's
+	* "automatically resolve outdated diff discussions" behaviour, so a fixed
+	* finding stops being re-listed under "Still open from earlier reviews" (#133).
 	*/
-	async listResolvedReviewCommentIds(owner, repo, pull) {
-		const resolved = /* @__PURE__ */ new Set();
+	async listSettledReviewCommentIds(owner, repo, pull) {
+		const settled = /* @__PURE__ */ new Set();
 		let cursor = null;
 		let hasNext = true;
 		while (hasNext) {
@@ -357,14 +366,14 @@ var GitHubClient = class {
 			})).repository?.pullRequest?.reviewThreads;
 			if (!threads) break;
 			for (const thread of threads.nodes ?? []) {
-				if (!thread.isResolved) continue;
-				for (const comment of thread.comments?.nodes ?? []) if (typeof comment.databaseId === "number") resolved.add(comment.databaseId);
+				if (!thread.isResolved && !thread.isOutdated) continue;
+				for (const comment of thread.comments?.nodes ?? []) if (typeof comment.databaseId === "number") settled.add(comment.databaseId);
 			}
 			hasNext = threads.pageInfo?.hasNextPage ?? false;
 			cursor = threads.pageInfo?.endCursor ?? null;
 			if (!cursor) hasNext = false;
 		}
-		return resolved;
+		return settled;
 	}
 };
 //#endregion
@@ -551,7 +560,7 @@ function buildSummaryBody(summary, costFooter, options = {}) {
 	return `${withFooter}\n\n${buildSummaryHistoryBlock(historyEntries)}`;
 }
 function buildReviewedCommitFooter(commitSha) {
-	return `Reviewed by ${PRODUCT_LINK} v0.8.5 for commit ${commitSha}.`;
+	return `Reviewed by ${PRODUCT_LINK} v0.8.6 for commit ${commitSha}.`;
 }
 function extractReviewedCommitSha(body) {
 	return REVIEWED_COMMIT_FOOTER_PATTERN.exec(body)?.[1] ?? null;
@@ -3681,8 +3690,15 @@ async function loadReviewContext(cwd, skillNames = [], warn, options = {}) {
 	]);
 	const skills = [...discovered];
 	const discoveredNames = new Set(discovered.map((s) => s.name));
-	const named = await Promise.all(skillNames.filter((n) => !discoveredNames.has(n)).map((n) => loadNamedSkill(n, cwd, { refresh: options.refreshGitSkills })));
-	skills.push(...named);
+	const named = await Promise.all(skillNames.filter((n) => !discoveredNames.has(n)).map(async (n) => {
+		try {
+			return await loadNamedSkill(n, cwd, { refresh: options.refreshGitSkills });
+		} catch (error) {
+			warn?.(`Skipping skill "${n}": ${formatError(error)}`);
+			return null;
+		}
+	}));
+	skills.push(...named.filter((s) => s !== null));
 	return {
 		conventions,
 		reviewRules,
@@ -5199,7 +5215,7 @@ async function loadDefaultRuntime() {
 	const [sdkNode, resources, semconv] = modules;
 	const serviceResource = resources.resourceFromAttributes({
 		[semconv.ATTR_SERVICE_NAME ?? "service.name"]: SERVICE_NAME,
-		[semconv.ATTR_SERVICE_VERSION ?? "service.version"]: "0.8.5"
+		[semconv.ATTR_SERVICE_VERSION ?? "service.version"]: "0.8.6"
 	});
 	process.env.OTEL_METRICS_EXPORTER = process.env.OTEL_METRICS_EXPORTER ?? "otlp";
 	process.env.OTEL_LOGS_EXPORTER = process.env.OTEL_LOGS_EXPORTER ?? "otlp";
@@ -5631,7 +5647,7 @@ function boldCommentTitle(body) {
 */
 function buildCommentBody(body, commitSha, confidence) {
 	const confidenceLine = `_Confidence: ${confidence}._`;
-	const footer = `<sub>Reviewed by ${PRODUCT_LINK} v0.8.5 for commit ${commitSha}.</sub>`;
+	const footer = `<sub>Reviewed by ${PRODUCT_LINK} v0.8.6 for commit ${commitSha}.</sub>`;
 	return `${boldCommentTitle(body.trim())}\n\n${confidenceLine}\n\n---\n\n${footer}`;
 }
 function buildPayload(comment, body, refs, resolved) {
@@ -5795,11 +5811,14 @@ function reviewCommentPosition(comment) {
 * comments that render identically on GitHub, so `extractExistingFingerprints`,
 * `findExistingSummaryNote`, and the reviewed-commit scan all work as-is.
 *
-* `resolvedCommentIds` carries the database ids of comments in resolved review
-* threads (from the GraphQL `reviewThreads` query, since REST omits resolution),
-* so each note gets a `resolved` flag mirroring GitLab's per-note field.
+* `settledCommentIds` carries the database ids of comments in settled review
+* threads — resolved or outdated (from the GraphQL `reviewThreads` query, since
+* REST omits both). Each such note gets a `resolved` flag mirroring GitLab's
+* per-note field: an outdated GitHub thread maps to `resolved: true` because
+* GitHub, unlike GitLab, does not auto-resolve a thread when its anchored line
+* changes, so treating outdated as resolved matches GitLab's behaviour (#133).
 */
-function normalizeGitHubDiscussions(reviewComments, issueComments, resolvedCommentIds = /* @__PURE__ */ new Set()) {
+function normalizeGitHubDiscussions(reviewComments, issueComments, settledCommentIds = /* @__PURE__ */ new Set()) {
 	const threads = /* @__PURE__ */ new Map();
 	const order = [];
 	for (const comment of reviewComments) {
@@ -5813,7 +5832,7 @@ function normalizeGitHubDiscussions(reviewComments, issueComments, resolvedComme
 		notes.push({
 			id: comment.id,
 			body: comment.body ?? "",
-			resolved: resolvedCommentIds.has(comment.id),
+			resolved: settledCommentIds.has(comment.id),
 			position: reviewCommentPosition(comment)
 		});
 	}
@@ -5880,12 +5899,12 @@ var GitHubPlatform = class {
 		return refs;
 	}
 	async getDiscussions() {
-		const [reviewComments, issueComments, resolvedCommentIds] = await Promise.all([
+		const [reviewComments, issueComments, settledCommentIds] = await Promise.all([
 			this.client.listReviewComments(this.owner, this.repo, this.pull),
 			this.client.listIssueComments(this.owner, this.repo, this.pull),
-			this.client.listResolvedReviewCommentIds(this.owner, this.repo, this.pull)
+			this.client.listSettledReviewCommentIds(this.owner, this.repo, this.pull)
 		]);
-		return normalizeGitHubDiscussions(reviewComments, issueComments, resolvedCommentIds);
+		return normalizeGitHubDiscussions(reviewComments, issueComments, settledCommentIds);
 	}
 	buildComments(comments, diff, refs, existingFingerprints) {
 		this.commitId = refs.head_sha;
@@ -6725,10 +6744,10 @@ async function main(argv = process.argv.slice(2)) {
 		return;
 	}
 	if (argv.includes("--version") || argv.includes("-v")) {
-		console.log("0.8.5");
+		console.log("0.8.6");
 		return;
 	}
-	process.stderr.write(`[code-review] @weareikko/code-review v0.8.5\n`);
+	process.stderr.write(`[code-review] @weareikko/code-review v0.8.6\n`);
 	assertNodeVersion();
 	applyCodeReviewEnvPrefix();
 	applyDefaultCacheRetention();
@@ -6751,4 +6770,4 @@ if (isDirectRun()) main().catch((error) => {
 //#endregion
 export { normalizeBody as $, SUMMARY_HISTORY_END as A, buildSummaryHistoryEntries as B, createDiagnosticContext as C, traceDiagnosticPhase as D, traceDiagnostic as E, SUMMARY_MARKER as F, findExistingSummaryNoteId as G, extractSummaryHistoryEntries as H, buildArchivedSummaryEntry as I, upsertSummaryNote as J, stripSummaryHistory as K, buildReviewedCommitFooter as L, SUMMARY_HISTORY_ENTRY_START as M, SUMMARY_HISTORY_LIMIT as N, normalizeSeverity as O, SUMMARY_HISTORY_START as P, fingerprints as Q, buildSizeNoticeBlock as R, DIAGNOSTIC_CHANNEL_PREFIX as S, diagnosticChannels as T, findExistingReviewedCommitSha as U, extractReviewedCommitSha as V, findExistingSummaryNote as W, extractDiffHunkContext as X, appendFingerprintMarkers as Y, extractExistingFingerprints as Z, resolveNpmSkillDir as _, main as a, parseReviewMarkdownWithWarnings as b, buildGeneratedComments as c, startOtelBridge as d, sha256 as et, filterDiff as f, parseSkillSpec as g, loadNamedSkill as h, formatUsageLine as i, SUMMARY_HISTORY_ENTRY_END as j, toGitLabReviewSeverity as k, buildPayload as l, gitSkillCacheKey as m, formatPerModelUsage as n, run as o, runReview as p, stripSummaryMarker as q, formatSkillsFooter as r, withHttpStamping as s, countPostedBySeverity as t, isOtelEnabled as u, resolveSkillCacheDir as v, createDiagnosticRunId as w, DIAGNOSTIC_CHANNEL_NAMES as x, parseReviewMarkdown as y, buildSummaryBody as z };
 
-//# sourceMappingURL=cli-DmzA9PxS.js.map
+//# sourceMappingURL=cli-BbR1oftT.js.map