@wbce-d9/storage-driver-s3 10.0.4 → 10.0.6

package/dist/index.js

@@ -61,7 +61,7 @@ export class DriverS3 {
         if (!stream || !isReadableStream(stream)) {
             throw new Error(`No stream returned for file "${filepath}"`);
         }
-        stream.on('finished', () => client.destroy());
+        stream.once('close', () => client.destroy());
         return stream;
     }
     async stat(filepath) {

package/dist/index.test.js

@@ -285,6 +285,19 @@ describe('#read', () => {
         expect(driver['client'].send).toHaveBeenCalledWith(mockGetObjectCommand);
         expect(stream).toBe(sample.stream);
     });
+    test('Destroys the per-read S3 client when the stream is closed', async () => {
+        const stream = new Readable({ read() { } });
+        const client = {
+            send: vi.fn().mockResolvedValue({ Body: stream }),
+            destroy: vi.fn(),
+        };
+        vi.spyOn(driver, 'getClient').mockReturnValue(client);
+        await driver.read(sample.path.input);
+        const closed = new Promise((resolve) => stream.once('close', resolve));
+        stream.destroy();
+        await closed;
+        expect(client.destroy).toHaveBeenCalledOnce();
+    });
 });
 describe('#stat', () => {
     beforeEach(() => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wbce-d9/storage-driver-s3",
-  "version": "10.0.4",
+  "version": "10.0.6",
   "type": "module",
   "description": "S3 file storage abstraction for `@wbce-d9/storage`",
   "repository": {
@@ -28,15 +28,15 @@
     "@aws-sdk/client-s3": "3.1062.0",
     "@aws-sdk/lib-storage": "3.1062.0",
     "@wbce-d9/storage": "10.0.0",
-    "@wbce-d9/utils": "10.0.4"
+    "@wbce-d9/utils": "10.0.5"
   },
   "devDependencies": {
     "@ngneat/falso": "6.4.0",
     "@types/node": "22.15.29",
-    "@vitest/coverage-v8": "4.1.11",
+    "@vitest/coverage-v8": "4.1.12",
     "@wbce-d9/tsconfig": "2.0.0",
     "typescript": "5.0.4",
-    "vitest": "4.1.11"
+    "vitest": "4.1.12"
   },
   "scripts": {
     "build": "tsc --build",