@wazo/sdk 0.37.31 → 0.37.35

package/src/domain/__tests__/CallSession.test.js

@@ -1,5 +1,7 @@
 import CallSession from '../CallSession';
 
+const stringify = cs => JSON.parse(JSON.stringify(cs));
+
 describe('CallSession domain', () => {
   it('should update from another CallSession without data loss', () => {
     const callSession = new CallSession({
@@ -38,7 +40,7 @@ describe('CallSession domain', () => {
     expect(cs2.is(cs1)).toBeTruthy();
   });
 
-  it('should set answerTime when setting answered', () => {
+  it('should set answerTime when setting answered to true', () => {
     const cs1 = new CallSession({});
     cs1.answered = true;
 
@@ -47,11 +49,37 @@ describe('CallSession domain', () => {
 
     const cs3 = new CallSession({ answered: true });
 
-    expect(cs1.answered).toBeTruthy();
+    expect(cs1.answered).toEqual(true);
     expect(cs1.answerTime).not.toBeNull();
-    expect(cs2.answered).toBeTruthy();
+    expect(cs2.answered).toEqual(true);
     expect(cs2.answerTime).not.toBeNull();
-    expect(cs3.answered).toBeTruthy();
+    expect(cs3.answered).toEqual(true);
     expect(cs3.answerTime).not.toBeNull();
+
+    const cs4 = stringify(cs1);
+    const cs5 = stringify(cs2);
+    const cs6 = stringify(cs3);
+
+    expect(cs4.answered).toEqual(true);
+    expect(cs5.answered).toEqual(true);
+    expect(cs6.answered).toEqual(true);
+  });
+
+  it('should reset answerTime when setting answered to false', () => {
+    const cs1 = new CallSession({});
+    cs1.answered = false;
+
+    const cs2 = new CallSession({ answered: false });
+
+    expect(cs1.answered).toEqual(false);
+    expect(cs1.answerTime).toBeNull();
+    expect(cs2.answered).toEqual(false);
+    expect(cs2.answerTime).toBeNull();
+
+    const cs4 = stringify(cs1);
+    const cs5 = stringify(cs2);
+
+    expect(cs4.answered).toEqual(false);
+    expect(cs5.answered).toEqual(false);
   });
 });

package/src/web-rtc-client.js

@@ -75,7 +75,7 @@ export const events = [REGISTERED, UNREGISTERED, REGISTRATION_FAILED, INVITE];
 export const transportEvents = [CONNECTED, DISCONNECTED, TRANSPORT_ERROR, MESSAGE];
 export class CanceledCallError extends Error {}
 
-const MAX_REGISTER_TRIES = 10;
+const MAX_REGISTER_TRIES = 5;
 
 type MediaConfig = {
   audio: Object & boolean,
@@ -129,6 +129,7 @@ export default class WebRTCClient extends Emitter {
   skipRegister: boolean;
   networkMonitoringInterval: { [string]: IntervalID };
   sessionNetworkStats: { [string]: Object };
+  forceClosed: boolean;
 
   // sugar
   ON_USER_AGENT: string;
@@ -191,6 +192,7 @@ export default class WebRTCClient extends Emitter {
     this.conferences = {};
     this.networkMonitoringInterval = {};
     this.sessionNetworkStats = {};
+    this.forceClosed = false;
 
     this._boundOnHeartbeat = this._onHeartbeat.bind(this);
     this.heartbeat = new Heartbeat(config.heartbeatDelay, config.heartbeatTimeout, config.maxHeartbeats);
@@ -312,6 +314,8 @@ export default class WebRTCClient extends Emitter {
       skipRegister: this.skipRegister,
     };
 
+    this.forceClosed = false;
+
     if (this.skipRegister) {
       logger.info('sdk webrtc skip register...', logInfo);
       return Promise.resolve();
@@ -336,7 +340,15 @@ export default class WebRTCClient extends Emitter {
     const registerOptions = this._isWeb() ? {} : { extraContactHeaderParams: ['mobility=mobile'] };
 
     const onRegisterFailed = () => {
-      logger.info('sdk webrtc registering failed', { tries, registerer: !!this.registerer });
+      logger.info('sdk webrtc registering failed', {
+        tries,
+        registerer: !!this.registerer,
+        forceClosed: this.forceClosed,
+      });
+      if (this.forceClosed) {
+        return;
+      }
+
       this.connectionPromise = null;
       if (this.registerer && this.registerer.waiting) {
         this.registerer.waitingToggle(false);
@@ -614,8 +626,9 @@ export default class WebRTCClient extends Emitter {
     }
   }
 
-  async close() {
-    logger.info('sdk webrtc closing client', { userAgent: !!this.userAgent });
+  async close(force: boolean = false) {
+    logger.info('sdk webrtc closing client', { userAgent: !!this.userAgent, force });
+    this.forceClosed = force;
     this._cleanupMedia();
     this.connectionPromise = null;
 
@@ -634,7 +647,7 @@ export default class WebRTCClient extends Emitter {
     this.userAgent.delegate = null;
     this.userAgent.stateChange.removeAllListeners();
 
-    await this._disconnectTransport();
+    await this._disconnectTransport(force);
 
     this._cleanupRegister();
 
@@ -2070,7 +2083,15 @@ export default class WebRTCClient extends Emitter {
     return UserAgent.makeURI(`sip:${target}@${this.config.host}`);
   }
 
-  async _disconnectTransport() {
+  async _disconnectTransport(force: boolean = false) {
+    if (force) {
+      // Bypass sip.js state machine that prevent to close WS with the state `Connecting`
+      this.userAgent.transport.disconnectResolve = () => {};
+      // eslint-disable-next-line
+      this.userAgent.transport._ws.close(1000);
+      return;
+    }
+
     // Check if `disconnectPromise` is not present to avoid `Disconnect promise must not be defined` errors.
     if (this.userAgent && this.userAgent.transport && !this.userAgent.transport.disconnectPromise) {
       try {