@wazo/sdk 0.37.21 → 0.37.25

package/esm/web-rtc-client.js

@@ -724,10 +724,6 @@ const getSrflxOrRelay = (candidates          )           =>
   candidates
     .filter(candidate => candidate && (candidate.type === 'srflx' || candidate.type === 'relay'));
 
-const areCandidateValid = (candidates          )          =>
-  getSrflxOrRelay(candidates)
-    .length > 0;
-
 const getVideoDirection = (sdp        )          => {
   const parsedSdp = sdpParser.parse(sdp);
   const videoMedia = parsedSdp.media.find(media => media.type === 'video');
@@ -780,8 +776,6 @@ const fixSdp = (sdp        , candidates          , forcePort          = true)
 /* global RTCSessionDescriptionInit, navigator */
 
 const wazoLogger = IssueReporter$1 ? IssueReporter$1.loggerFor('webrtc-sdh') : console;
-const MAX_WAIT_FOR_ICE_TRIES = 20;
-const WAIT_FOR_ICE_TIMEOUT = 500;
 
 // Customized mediaStreamFactory allowing to send screensharing stream directory when upgrading
 const wazoMediaStreamFactory = (constraints        )                       => {
@@ -971,38 +965,6 @@ class WazoSessionDescriptionHandler extends SessionDescriptionHandler {
     this._peerConnection = undefined;
   }
 
-  async _waitForValidGatheredIce()         {
-    let tries = 0;
-
-    while (!areCandidateValid(this.gatheredCandidates) && tries < MAX_WAIT_FOR_ICE_TRIES) {
-      wazoLogger.trace('SessionDescriptionHandler._waitForValidGatheredIce, waiting for ice', {
-        tries,
-        max: MAX_WAIT_FOR_ICE_TRIES,
-      });
-
-      tries++;
-
-      // eslint-disable-next-line no-await-in-loop
-      await new Promise(resolve => setTimeout(resolve, WAIT_FOR_ICE_TIMEOUT));
-    }
-
-    if (tries >= MAX_WAIT_FOR_ICE_TRIES) {
-      const errorMsg = 'No valid candidates found, can\'t answer the call';
-      const error = new Error(errorMsg);
-      wazoLogger.error(errorMsg, { tries, max: MAX_WAIT_FOR_ICE_TRIES });
-
-      // Emit an error, because sip.js catches the exception and switch to status Terminated.
-      this.eventEmitter.emit('error', error);
-
-      wazoLogger.error('No valid candidates found', { tries, candidates: JSON.stringify(this.gatheredCandidates) });
-    }
-
-    // eslint-disable-next-line
-    wazoLogger.trace('Found valid candidates', { tries, candidates: JSON.stringify(this.gatheredCandidates) });
-
-    return this.getLocalSessionDescription();
-  }
-
   // Overridden to send `inactive` in conference
   updateDirection(options                                   , isConference          = false,
     audioOnly          = false)                {
@@ -2112,6 +2074,9 @@ class Contact {
   }
 
   static parseMany(response                  )                 {
+    if (!response || !response.results) {
+      return [];
+    }
     return response.results.map(r => Contact.parse(r, response.column_types));
   }
 
@@ -3189,8 +3154,9 @@ class ExternalApp {
                              
                
                
-                 
+                
                       
+                        
  
 
 class Meeting {
@@ -3201,9 +3167,10 @@ class Meeting {
                
                
                
-                 
+                    
                       
                             
+                     
 
   static parse(plain                         )          {
     return new Meeting({
@@ -3213,12 +3180,16 @@ class Meeting {
       ownerUuids: plain.owner_uuids,
       port: plain.port,
       uuid: plain.uuid,
-      number: plain.number,
+      extension: plain.exten,
       persistent: plain.persistent,
+      creationTime: moment(plain.creation_time).toDate(),
     });
   }
 
   static parseMany(items                           )                 {
+    if (!items) {
+      return [];
+    }
     return items.map(plain => Meeting.parse(plain));
   }
 
@@ -3233,8 +3204,9 @@ class Meeting {
     ownerUuids,
     port,
     uri,
-    number,
+    extension,
     persistent,
+    creationTime,
   }         = {}) {
     this.guestSipAuthorization = guestSipAuthorization;
     this.uri = uri;
@@ -3242,8 +3214,9 @@ class Meeting {
     this.ownerUuids = ownerUuids;
     this.port = port;
     this.uuid = uuid;
-    this.number = number;
+    this.extension = extension;
     this.persistent = persistent;
+    this.creationTime = creationTime;
 
     // Useful to compare instead of instanceof with minified code
     this.type = 'Meeting';
@@ -3421,6 +3394,10 @@ class ChatMessage {
                 
 
   static parseMany(plain                         )                     {
+    if (!plain || !plain.items) {
+      return [];
+    }
+
     return plain.items.map(item => ChatMessage.parse(item));
   }
 
@@ -3530,6 +3507,9 @@ class Voicemail {
   }
 
   static parseMany(plain          )                   {
+    if (!plain) {
+      return [];
+    }
     const plainUnread = plain.folders.filter(folder => folder.type === 'new')[0].messages;
     const plainRead = plain.folders.filter(folder => folder.type === 'old')[0].messages;
 
@@ -3639,6 +3619,9 @@ class Call {
                      
 
   static parseMany(plain                     )              {
+    if (!plain) {
+      return [];
+    }
     return plain.map((plainCall              ) => Call.parse(plainCall));
   }
 
@@ -3811,6 +3794,9 @@ class Recording {
                
 
   static parseMany(recordings                      = [])              {
+    if (!recordings) {
+      return [];
+    }
     return recordings.map(item => Recording.parse(item));
   }
 
@@ -3912,6 +3898,10 @@ class CallLog {
   }
 
   static parseMany(plain          )                 {
+    if (!plain || !plain.items) {
+      return [];
+    }
+
     return plain.items.map(item => CallLog.parse(item));
   }
 
@@ -4484,6 +4474,9 @@ class ChatRoom {
                          
 
   static parseMany(plain                  )                  {
+    if (!plain || !plain.items) {
+      return [];
+    }
     return plain.items.map(item => ChatRoom.parse(item));
   }
 
@@ -5715,7 +5708,7 @@ class WebRTCClient extends Emitter {
   }
 
   call(number        , enableVideo          , audioOnly          = false, conference          = false)          {
-    logger.info('sdk webrtc creating call', { number, enableVideo, audioOnly });
+    logger.info('sdk webrtc creating call', { number, enableVideo, audioOnly, conference });
     const inviterOptions         = {
       sessionDescriptionHandlerOptionsReInvite: {
         conference,
@@ -6791,6 +6784,7 @@ class WebRTCClient extends Emitter {
     const screenSharing = constraints && 'screen' in constraints ? constraints.screen : false;
     const isDesktop = constraints && 'desktop' in constraints ? constraints.desktop : false;
     const withAudio = constraints && 'audio' in constraints ? constraints.audio : true;
+    const mandatoryVideo = constraints && typeof constraints.video === 'object' ? constraints.video.mandatory : {};
 
     logger.info('Retrieving media a configuration', { enableVideo, screenSharing, isDesktop, withAudio, constraints });
 
@@ -6798,7 +6792,8 @@ class WebRTCClient extends Emitter {
       constraints: {
         // Exact constraint are not supported with `getDisplayMedia` and we must have a video=false in desktop screenshare
         audio: screenSharing ? !isDesktop : (withAudio ? this._getAudioConstraints() : false),
-        video: screenSharing ? (isDesktop ? ({ mandatory: { chromeMediaSource: 'desktop' } }) : { cursor: 'always' })
+        video: screenSharing ? (isDesktop
+          ? ({ mandatory: { chromeMediaSource: 'desktop', ...(mandatoryVideo || {}) } }) : { cursor: 'always' })
           : this._getVideoConstraints(enableVideo),
         screen: screenSharing,
         desktop: isDesktop,
@@ -7133,11 +7128,14 @@ class WebRTCClient extends Emitter {
 
     session.sessionDescriptionHandler.remoteMediaStream.onaddtrack = onTrack;
 
-    pc.oniceconnectionstatechange = () => {
-      if (pc.iceConnectionState === 'disconnected') {
-        this.eventEmitter.emit(ON_DISCONNECTED);
-      }
-    };
+    if (pc) {
+      pc.oniceconnectionstatechange = () => {
+        logger.info('on ice connection state changed', { state: pc.iceConnectionState });
+        if (pc.iceConnectionState === 'disconnected') {
+          this.eventEmitter.emit(ON_DISCONNECTED);
+        }
+      };
+    }
 
     if (withEvent) {
       this.eventEmitter.emit(ACCEPTED, session, sessionDialog);
@@ -7347,13 +7345,17 @@ class WebRTCClient extends Emitter {
     const nbStats = this.sessionNetworkStats[sessionId].length;
     const lastNetworkStats = this.sessionNetworkStats[sessionId][nbStats - 1];
     const lastAudioSent = lastNetworkStats ? lastNetworkStats.audioBytesSent : 0;
+    const lastAudioContentSent = lastNetworkStats ? lastNetworkStats.audioContentSent : 0;
     const lastVideoSent = lastNetworkStats ? lastNetworkStats.videoBytesSent : 0;
     const lastAudioReceived = lastNetworkStats ? lastNetworkStats.audioBytesReceived : 0;
+    const lastAudioContentReceived = lastNetworkStats ? lastNetworkStats.audioContentReceived : 0;
     const lastVideoReceived = lastNetworkStats ? lastNetworkStats.videoBytesReceived : 0;
     const lastTransportSent = lastNetworkStats ? lastNetworkStats.transportSent : 0;
     const lastTransportReceived = lastNetworkStats ? lastNetworkStats.transportReceived : 0;
-    let audioBytesSent = 0;
-    let audioBytesReceived = 0;
+    let audioBytesSent = 0; // content + header
+    let audioBytesReceived = 0; // content + header
+    let audioContentSent = 0; // useful to detect blank call
+    let audioContentReceived = 0;
     let videoBytesSent = 0;
     let videoBytesReceived = 0;
     let transportSent = 0;
@@ -7362,25 +7364,27 @@ class WebRTCClient extends Emitter {
 
     stats.forEach(report => {
       if (report.type === 'outbound-rtp' && report.kind === 'audio') {
-        audioBytesSent += report.bytesSent + report.headerBytesSent;
+        audioBytesSent += Number(report.bytesSent) + Number(report.headerBytesSent);
+        audioContentSent += Number(report.bytesSent);
       }
       if (report.type === 'remote-outbound-rtp' && report.kind === 'audio') {
-        audioBytesSent += report.bytesSent;
+        audioBytesSent += Number(report.bytesSent);
       }
       if (report.type === 'outbound-rtp' && report.kind === 'video') {
-        videoBytesSent += report.bytesSent + report.headerBytesSent;
+        videoBytesSent += Number(report.bytesSent) + Number(report.headerBytesSent);
       }
       if (report.type === 'inbound-rtp' && report.kind === 'audio') {
-        packetsLost += report.packetsLost;
-        networkStats.packetsReceived = report.packetsReceived;
-        audioBytesReceived += report.bytesReceived + report.headerBytesReceived;
+        packetsLost += Number(report.packetsLost);
+        networkStats.packetsReceived = Number(report.packetsReceived);
+        audioBytesReceived += Number(report.bytesReceived) + Number(report.headerBytesReceived);
+        audioContentReceived += Number(report.bytesReceived);
       }
       if (report.type === 'inbound-rtp' && report.kind === 'video') {
-        videoBytesReceived += report.bytesReceived + report.headerBytesReceived;
+        videoBytesReceived += Number(report.bytesReceived) + Number(report.headerBytesReceived);
       }
       if (report.type === 'outbound-rtp' && report.kind === 'video') {
         if ('framesPerSecond' in report) {
-          networkStats.framesPerSecond = report.framesPerSecond;
+          networkStats.framesPerSecond = Number(report.framesPerSecond);
         }
         if ('framerateMean' in report) {
           // framerateMean is only available in FF
@@ -7388,24 +7392,31 @@ class WebRTCClient extends Emitter {
         }
       }
       if (report.type === 'remote-inbound-rtp' && report.kind === 'audio') {
-        packetsLost += report.packetsLost;
-        networkStats.roundTripTime = report.roundTripTime;
-        networkStats.jitter = report.jitter;
+        packetsLost += Number(report.packetsLost);
+        networkStats.roundTripTime = Number(report.roundTripTime);
+        networkStats.jitter = Number(report.jitter);
       }
       if (report.type === 'remote-inbound-rtp' && report.kind === 'video') {
-        packetsLost += report.packetsLost;
+        packetsLost += Number(report.packetsLost);
       }
       if (report.type === 'transport') {
-        transportSent += report.bytesSent;
-        transportReceived += report.bytesReceived;
+        transportSent += Number(report.bytesSent);
+        transportReceived += Number(report.bytesReceived);
       }
     });
 
     networkStats.packetsLost = packetsLost;
+
     networkStats.totalAudioBytesSent = audioBytesSent;
     networkStats.audioBytesSent = audioBytesSent - lastAudioSent;
     networkStats.totalAudioBytesReceived = audioBytesReceived - lastAudioReceived;
     networkStats.audioBytesReceived = audioBytesReceived;
+
+    networkStats.totalAudioContentSent = audioContentSent;
+    networkStats.audioContentSent = audioContentSent - lastAudioContentSent;
+    networkStats.totalAudioBytesReceived = audioContentReceived - lastAudioContentReceived;
+    networkStats.audioContentReceived = audioContentReceived;
+
     networkStats.totalVideoBytesSent = videoBytesSent;
     networkStats.videoBytesSent = videoBytesSent - lastVideoSent;
     networkStats.totalVideoBytesReceived = videoBytesReceived;

package/lib/__tests__/api-client.test.js

@@ -1537,6 +1537,9 @@ class Contact {
   }
 
   static parseMany(response                  )                 {
+    if (!response || !response.results) {
+      return [];
+    }
     return response.results.map(r => Contact.parse(r, response.column_types));
   }
 
@@ -2614,8 +2617,9 @@ class ExternalApp {
                              
                
                
-                 
+                
                       
+                        
  
 
 class Meeting {
@@ -2626,9 +2630,10 @@ class Meeting {
                
                
                
-                 
+                    
                       
                             
+                     
 
   static parse(plain                         )          {
     return new Meeting({
@@ -2638,12 +2643,16 @@ class Meeting {
       ownerUuids: plain.owner_uuids,
       port: plain.port,
       uuid: plain.uuid,
-      number: plain.number,
+      extension: plain.exten,
       persistent: plain.persistent,
+      creationTime: moment__default['default'](plain.creation_time).toDate(),
     });
   }
 
   static parseMany(items                           )                 {
+    if (!items) {
+      return [];
+    }
     return items.map(plain => Meeting.parse(plain));
   }
 
@@ -2658,8 +2667,9 @@ class Meeting {
     ownerUuids,
     port,
     uri,
-    number,
+    extension,
     persistent,
+    creationTime,
   }         = {}) {
     this.guestSipAuthorization = guestSipAuthorization;
     this.uri = uri;
@@ -2667,8 +2677,9 @@ class Meeting {
     this.ownerUuids = ownerUuids;
     this.port = port;
     this.uuid = uuid;
-    this.number = number;
+    this.extension = extension;
     this.persistent = persistent;
+    this.creationTime = creationTime;
 
     // Useful to compare instead of instanceof with minified code
     this.type = 'Meeting';
@@ -2846,6 +2857,10 @@ class ChatMessage {
                 
 
   static parseMany(plain                         )                     {
+    if (!plain || !plain.items) {
+      return [];
+    }
+
     return plain.items.map(item => ChatMessage.parse(item));
   }
 
@@ -2955,6 +2970,9 @@ class Voicemail {
   }
 
   static parseMany(plain          )                   {
+    if (!plain) {
+      return [];
+    }
     const plainUnread = plain.folders.filter(folder => folder.type === 'new')[0].messages;
     const plainRead = plain.folders.filter(folder => folder.type === 'old')[0].messages;
 
@@ -3064,6 +3082,9 @@ class Call {
                      
 
   static parseMany(plain                     )              {
+    if (!plain) {
+      return [];
+    }
     return plain.map((plainCall              ) => Call.parse(plainCall));
   }
 
@@ -3236,6 +3257,9 @@ class Recording {
                
 
   static parseMany(recordings                      = [])              {
+    if (!recordings) {
+      return [];
+    }
     return recordings.map(item => Recording.parse(item));
   }
 
@@ -3337,6 +3361,10 @@ class CallLog {
   }
 
   static parseMany(plain          )                 {
+    if (!plain || !plain.items) {
+      return [];
+    }
+
     return plain.items.map(item => CallLog.parse(item));
   }
 
@@ -3909,6 +3937,9 @@ class ChatRoom {
                          
 
   static parseMany(plain                  )                  {
+    if (!plain || !plain.items) {
+      return [];
+    }
     return plain.items.map(item => ChatRoom.parse(item));
   }