@waterx/sdk 4.3.2 → 5.0.0

package/dist/cjs/src/oracle/aggregate.js

@@ -3,12 +3,12 @@
  * Oracle aggregation — the orchestrator that composes rules into the shared
  * `Oracle`. This is the ONE file that knows about every rule: it builds a
  * `PriceCollector`, feeds whichever rules a ticker is configured for
- * (Pyth / Lazer / Supra / Constant), then `aggregate`s.
+ * (Lazer / Waterx / Supra / Constant), then `aggregate`s.
  *
  * Per ticker:
  *   collector = oracle::new_collector(ticker)
- *   [pyth_rule::feed]       when the ticker has a pyth_rule.feeds entry
  *   [pyth_lazer_rule::feed] when the update leg produced a verified lazer Update
+ *   [waterx_rule::collect_*] when the update leg fetched signed waterx data
  *   [supra_rule::feed]      when supra is enabled + wired
  *   [constant_rule::feed]   when the ticker is a constant ticker
  *   oracle::aggregate(oracle, collector)
@@ -25,18 +25,16 @@
  */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.aggregateTicker = aggregateTicker;
-exports.aggregateTickerWithPyth = aggregateTickerWithPyth;
 exports.aggregateTickerWithConstant = aggregateTickerWithConstant;
 exports.refreshOraclePrices = refreshOraclePrices;
 const oracle_ts_1 = require("../generated/waterx_oracle/oracle.js");
-const record_ts_1 = require("../utils/record.js");
-const pyth_ts_1 = require("./pyth.js");
+const price_update_rule_ts_1 = require("./price-update-rule.js");
 const rule_registry_ts_1 = require("./rule-registry.js");
 const constant_rule_ts_1 = require("./rules/constant-rule.js");
 const pyth_lazer_rule_ts_1 = require("./rules/pyth-lazer-rule.js");
-const pyth_rule_ts_1 = require("./rules/pyth-rule.js");
 const supra_rule_ts_1 = require("./rules/supra-rule.js");
 const waterx_rule_ts_1 = require("./rules/waterx-rule.js");
+const validate_ts_1 = require("./validate.js");
 /**
  * Resolve one group's off-chain update payload for {@link refreshOraclePrices}:
  * try `provider.get(source, tickers)` first (when a provider is configured),
@@ -48,60 +46,53 @@ const waterx_rule_ts_1 = require("./rules/waterx-rule.js");
  * provider commonly caches one whole-universe payload per source — see
  * {@link UpdateDataProvider}), so it is narrowed to exactly `group.tickers`
  * via `rule.narrowUpdateData` before use. This is load-bearing, not
- * defensive: without it a Pyth Core hit would emit an
- * `update_single_price_feed` — and charge its fee — for every cached feed
- * instead of just this group's, and a payload that cannot cover the group
- * (`narrowUpdateData` → `null`) would never reach the live-fetch fallback.
- * Each rule owns its own subsetting (Core subsets per-feed entries; Lazer's
- * indivisible payload passes whole iff fully covered), so the orchestrator
- * never branches on `kind` here. A hit whose `kind` doesn't match the
- * group's rule is a caller bug (the provider handed back a different rule's
- * payload), so that throws — via `narrowUpdateData`'s own
+ * defensive: a payload that cannot cover the group (`narrowUpdateData` →
+ * `null`) would never reach the live-fetch fallback without it, and a
+ * divisible payload (waterx leaves) is subset instead of fanned out whole.
+ * Each rule owns its own subsetting (waterx subsets per-symbol leaves;
+ * Lazer's indivisible payload passes whole iff fully covered), so the
+ * orchestrator never branches on `kind` here. A hit whose `kind` doesn't
+ * match the group's rule is a caller bug (the provider handed back a
+ * different rule's payload), so that throws — via `narrowUpdateData`'s own
  * `assertRuleUpdateData` guard — instead of silently falling back.
  */
-async function resolveGroupUpdateData(host, group, provider) {
-    if (provider) {
-        let cached = null;
-        try {
-            cached = await provider.get(group.source, group.tickers);
-        }
-        catch {
-            // Provider errors must never break the money path — fall through to
-            // the live fetch below exactly as a cache miss (`null`) would.
-        }
-        if (cached !== null) {
-            // Wrong-kind hit throws inside narrowUpdateData (assertRuleUpdateData);
-            // a hit that can't cover the group narrows to null → live-fetch below.
-            const narrowed = group.rule.narrowUpdateData(host, cached, group.tickers);
-            if (narrowed !== null)
-                return narrowed;
-        }
+async function resolveCachedUpdateData(host, group, provider) {
+    if (!provider)
+        return null;
+    let cached;
+    try {
+        cached = await provider.get(group.source, group.tickers);
     }
-    return group.rule.fetchUpdateData(host, group.tickers);
+    catch {
+        // Provider errors must never break the money path — report a miss and let
+        // the caller live-fetch, exactly as a `null` return would.
+        return null;
+    }
+    if (cached === null)
+        return null;
+    // Wrong-kind hit throws inside narrowUpdateData (assertRuleUpdateData); a
+    // hit that can't cover the group narrows to null, i.e. a miss.
+    return group.rule.narrowUpdateData(host, cached, group.tickers);
 }
 /**
  * Aggregate one ticker's price into the shared `Oracle`: build a collector, feed
  * every rule the ticker is configured for, then `aggregate`.
  *
- * - **Pyth** — fed when `priceInfoObjectId` is supplied (i.e. the ticker has a
- *   `pyth_rule.feeds` entry). When this PTB's update leg refreshed the
- *   `PriceInfoObject` it contributes a fresh price; when it did not (a
- *   lazer-routed ticker), the on-chain rule only READS the object and abstains
- *   if it is stale — it never aborts — so the call stays mandatory while
- *   `pyth_rule` remains in the ticker's on-chain weighted set
- *   (`EMissingPriceSource` requires every weighted rule to appear).
  * - **Lazer** — fed when `lazerUpdate` is supplied: the verified update this
  *   PTB's lazer update leg produced with the network's verify entry
  *   (`update_v2::Update` on mainnet, `update::Update` on testnet — see
  *   `PythLazerRule.buildUpdateCalls`). If the ticker's aggregator does
  *   not (yet) weight `PythLazerRule`, the contribution is silently dropped
  *   on-chain — feeding ahead of the weight migration is harmless.
- * - **Supra** — fed alongside Pyth/Lazer when supra is enabled + wired
+ * - **Waterx** — fed when `waterxLeaf` (default shape) or `waterxEnvelope`
+ *   (fallback shape) is supplied; verify AND feed are bundled into the one
+ *   collect call per collector.
+ * - **Supra** — fed alongside the sources when supra is enabled + wired
  *   (abstains on-chain for symbols it has no pair for).
  * - **Constant** — fed when the ticker is a constant ticker
  *   ({@link OracleHost.isConstantTicker}).
  *
- * "Dual-feed" (Pyth + Constant, or Pyth + Lazer) and "constant-only" are not
+ * "Dual-feed" (Lazer + Constant, or Lazer + Waterx) and "constant-only" are not
  * special cases — they fall out of which rules the ticker is in. Throws if no
  * rule applies.
  */
@@ -112,25 +103,29 @@ function aggregateTicker(tx, host, args) {
         arguments: { symbol: args.ticker },
     })(tx);
     let fed = false;
-    if (args.priceInfoObjectId) {
-        (0, pyth_rule_ts_1.feedPythRule)(tx, host, collector, args.priceInfoObjectId);
-        fed = true;
-    }
     if (args.lazerUpdate !== undefined) {
         (0, pyth_lazer_rule_ts_1.feedLazerRule)(tx, host, collector, args.lazerUpdate);
         fed = true;
     }
-    if (args.waterxEnvelope !== undefined) {
-        // waterx_rule::collect_batch_latest verifies the batch signature and feeds
-        // this collector's symbol from the batch. If the ticker's aggregator does
-        // not (yet) weight `WaterxRule`, the contribution is silently dropped
-        // on-chain — feeding ahead of the weight migration is safe for THIS tx.
-        // CAVEAT (unlike lazer): the feed call records a per-symbol signed-
-        // timestamp high-water mark REGARDLESS of weights, and a replayed
-        // timestamp ABORTS (`EReplayedSignature`, audit F-014) — so two PTBs
-        // carrying the same envelope for the same symbol cannot both land; the
-        // second aborts even where waterx is unweighted. See WaterxRule's module
-        // header.
+    // One waterx leg at most, and the leaf shape wins: both entries record the
+    // same per-symbol signed-timestamp high-water mark and feed the same rule
+    // witness into this collector, so emitting both would make the second one
+    // abstain on its own predecessor's mark for no gain. `refreshOraclePrices`
+    // only ever supplies one; a caller that passes both gets the cheaper leg.
+    if (args.waterxLeaf !== undefined) {
+        // waterx_rule::collect_single_with_proof re-derives the snapshot root from
+        // this leaf + its proof, verifies the enclave signature over that root, and
+        // feeds the price. If the ticker's aggregator does not (yet) weight
+        // `WaterxRule`, the contribution is silently dropped on-chain — feeding
+        // ahead of the weight migration is safe. See WaterxRule's module header for
+        // the abort-vs-abstain split.
+        (0, waterx_rule_ts_1.feedWaterxRuleWithProof)(tx, host, collector, args.waterxLeaf);
+        fed = true;
+    }
+    else if (args.waterxEnvelope !== undefined) {
+        // Fallback shape: collect_batch_latest re-verifies the WHOLE batch
+        // signature (every item rebuilt in-PTB) and feeds this collector's symbol
+        // out of it. Only reached against a quote-center with no leaf route.
         (0, waterx_rule_ts_1.feedWaterxRule)(tx, host, collector, args.waterxEnvelope);
         fed = true;
     }
@@ -143,7 +138,7 @@ function aggregateTicker(tx, host, args) {
         fed = true;
     }
     if (!fed) {
-        throw new Error(`no oracle rule configured for ticker '${args.ticker}' (no pyth feed, no lazer update, not a constant ticker)`);
+        throw new Error(`no oracle rule configured for ticker '${args.ticker}' (no lazer update, no waterx data, not a constant ticker)`);
     }
     (0, oracle_ts_1.aggregate)({
         package: oraclePkg,
@@ -154,33 +149,20 @@ function aggregateTicker(tx, host, args) {
     })(tx);
 }
 /**
- * Thin wrapper over {@link aggregateTicker} for a Pyth-fed ticker. Kept for
- * back-compat (e.g. WLP mint builds). Caller must run the Pyth update first.
- */
-function aggregateTickerWithPyth(tx, host, args) {
-    aggregateTicker(tx, host, args);
-}
-/**
- * {@link aggregateTicker} for a **constant-only** ticker (no Pyth update needed —
- * the price comes from the on-chain `constant_rule::Config`).
- *
- * Throws if the ticker ALSO has a `pyth_rule.feeds` entry (a dual-feed transition
- * ticker): feeding only the constant leg would leave the still-weighted Pyth rule
- * absent from the collector and abort `aggregate` with `EMissingPriceSource`. Such
- * tickers must go through {@link aggregateTicker} with a `priceInfoObjectId` (or
- * {@link refreshOraclePrices}), which feeds both.
+ * {@link aggregateTicker} for a **constant-only** ticker (no source update
+ * needed — the price comes from the on-chain `constant_rule::Config`). Kept as
+ * a named entry so constant-only call sites (e.g. WLP builders refreshing the
+ * USDCUSD pool token) read as what they are; it adds nothing over
+ * `aggregateTicker(tx, host, { ticker })`.
  */
 function aggregateTickerWithConstant(tx, host, args) {
-    if ((0, record_ts_1.ownEntry)(host.config.packages.pyth_rule?.feeds, args.ticker) !== undefined) {
-        throw new Error(`'${args.ticker}' is in pyth_rule.feeds (dual-feed) — feed both via aggregateTicker({ priceInfoObjectId }) / refreshOraclePrices, not aggregateTickerWithConstant`);
-    }
     aggregateTicker(tx, host, { ticker: args.ticker });
 }
 /**
  * Refresh multiple tickers in one PTB. For each ticker {@link aggregateTicker}
- * feeds whichever rules it is configured for (Pyth if it has a `pyth_rule.feeds`
- * entry, Lazer if the lazer update leg served it — see below — Supra when
- * enabled, Constant when it's a constant ticker).
+ * feeds whichever rules it is configured for (Lazer if the lazer update leg
+ * served it, Waterx if the waterx leg fetched signed data for it — see below —
+ * Supra when enabled, Constant when it's a constant ticker).
  *
  * Before that, the on-chain price *update* leg is routed by the
  * `host.oracleSources` fed set (see `rule-registry.ts`): EVERY listed source
@@ -194,11 +176,15 @@ function aggregateTickerWithConstant(tx, host, args) {
  * source's feeds is caught here.
  *
  * Each source's fetch + build runs against its own infra, guaranteeing
- * per-rule PTB atomicity. A fee-source pre-check runs first (any listed
- * source's `requiresFeeSource`) BEFORE any off-chain fetch or PTB mutation —
- * so a fee-charging source with no `opts.feeSource` throws
- * `OracleFeeSourceUnavailable` with zero wasted network calls and zero stray
- * moveCalls. Only once that check passes do the off-chain fetches run — in
+ * per-rule PTB atomicity. A credential pre-check runs early: any group that
+ * still needs to fetch, whose rule declares a `credential` the host does not
+ * carry while `host.pyth.api_key` is unset, throws `LazerApiKeyMissing`
+ * BEFORE any ORACLE fetch or PTB mutation — zero wasted oracle calls, zero
+ * stray moveCalls. (With an `updateDataProvider` configured, its per-source
+ * lookups run first so the check can be scoped to the groups the cache did
+ * NOT serve; a consumer-implemented provider may do I/O of its own, so the
+ * guarantee is about oracle fetches, not about every possible round trip.)
+ * Only once that check passes do the off-chain fetches run — in
  * parallel across sources — and ALL settle before the first PTB mutation;
  * on-chain reads inside `buildUpdateCalls` can still fail mid-append for
  * other reasons — callers discard the tx on any throw.
@@ -207,35 +193,24 @@ function aggregateTickerWithConstant(tx, host, args) {
  * `buildUpdateCalls` returns the verified `Update` PTB value
  * ({@link RuleUpdateHandle}), and every ticker in that group is aggregated
  * with `lazerUpdate` set so {@link aggregateTicker} appends
- * `pyth_lazer_rule::feed` against it. A lazer-routed ticker that still has a
- * `pyth_rule.feeds` entry ALSO keeps its `pyth_rule::feed` leg — required
- * on-chain while `pyth_rule` stays in the ticker's weighted set
- * (`aggregator::remove_outliers` aborts `EMissingPriceSource` unless every
- * weighted rule appears in the collector; an abstention counts as
- * appearing), and safe: `pyth_rule::feed` only READS the `PriceInfoObject`
- * this PTB never refreshed and abstains when it is stale rather than
- * aborting. Conversely, a lazer feed call on an aggregator that does not
- * (yet) weight `PythLazerRule` is silently dropped on-chain — so
- * lazer-routing a ticker ahead of its on-chain weight migration prices it
- * from the remaining weighted rules instead of failing.
+ * `pyth_lazer_rule::feed` against it. A waterx-served group's signed data is
+ * carried straight from its fetched payload to the per-ticker collect call.
+ * A feed call on an aggregator that does not (yet) weight that rule is
+ * silently dropped on-chain — so routing a ticker ahead of its on-chain
+ * weight migration prices it from the remaining weighted rules instead of
+ * failing.
  */
 async function refreshOraclePrices(tx, host, tickers, opts = {}) {
     if (tickers.length === 0)
-        return;
+        return { refreshed: [], skipped: [] };
     // Dedupe the caller's list (order-preserving): a repeated ticker would
-    // otherwise aggregate TWICE in this one PTB — wasted gas for every rule,
-    // and a hard ABORT under waterx: the second `collect_batch_latest` carries
-    // the same envelope, and the on-chain per-symbol replay guard rejects an
-    // already-accepted signed timestamp (`EReplayedSignature`, F-014) even
-    // inside a single transaction.
+    // otherwise aggregate TWICE in this one PTB — wasted gas for every rule, and
+    // under waterx the second collect would be dead weight on top of that: the
+    // on-chain per-symbol replay guard (F-014) sees its own predecessor's
+    // high-water mark from earlier in this same transaction and abstains, so the
+    // repeat pays full verification cost to contribute nothing.
     tickers = [...new Set(tickers)];
-    // price_info_object lookup for every ticker with a pyth_rule.feeds entry —
-    // needed by aggregateTicker's (unchanged) Pyth feed step below regardless of
-    // which rule performed the on-chain update for that ticker.
-    const pythTickers = tickers.filter((t) => (0, record_ts_1.ownEntry)(host.config.packages.pyth_rule?.feeds, t) !== undefined);
-    const priceInfoByTicker = new Map();
-    pythTickers.forEach((t) => priceInfoByTicker.set(t, host.getPythFeed(t).price_info_object));
-    // The fed set is a LIST (`host.oracleSources`, normalized + deduped at
+    // The fed set is a LIST (`host.oracleSources`, derived from the config at
     // client creation): ONE build carries every listed source's data, and the
     // chain's per-ticker weight tables decide which contributions count —
     // feeding an unweighted rule's PRICE is dropped on-chain, while starving a
@@ -245,8 +220,8 @@ async function refreshOraclePrices(tx, host, tickers, opts = {}) {
     // burns a per-symbol signed-timestamp high-water mark regardless of
     // weights — see aggregateTicker's waterx branch.) Still NO fallback
     // BETWEEN sources: each group serves only the tickers its own feeds list.
-    // Zero-ticker groups are dropped here so everything downstream (fee check,
-    // fetch fan-out, update-leg build) can assume every group has work.
+    // Zero-ticker groups are dropped here so everything downstream (credential
+    // check, fetch fan-out, update-leg build) can assume every group has work.
     const groups = host.oracleSources
         .map((source) => {
         const rule = (0, rule_registry_ts_1.resolveOracleRule)(source, opts.ruleOverrides);
@@ -254,66 +229,99 @@ async function refreshOraclePrices(tx, host, tickers, opts = {}) {
         return { source, rule, tickers: tickers.filter((t) => supported.has(t)) };
     })
         .filter((group) => group.tickers.length > 0);
-    // Fail the tx-build (NOT client init, NOT a silent reroute) when NO listed
-    // source has a feed for a requested ticker that actually needs a price
-    // update. Only a CONSTANT-ONLY ticker is exempt — priced entirely by
-    // `constant_rule`, it needs no update leg from any source. A DUAL-FEED ticker
-    // (constant AND pyth) still needs its Pyth leg refreshed, so `isConstantTicker`
-    // alone must NOT exempt it: with no source able to serve it, feeding an
-    // unrefreshed Pyth leg would price it stale (or abort on a missing weighted
-    // source). `priceInfoByTicker.has(t)` ⇔ the ticker has a `pyth_rule.feeds`
-    // entry, so `constant && !hasPyth` is exactly constant-only. This catches a
-    // MISSING feed; a present-but-WRONG feed id is deliberately not validated
-    // here (it aborts on-chain at dry-run).
+    // A ticker no listed source can price is SKIPPED, not thrown on, and named
+    // in the returned summary.
+    //
+    // This is a broad primitive: callers sweep whole market lists through it, and
+    // losing 29 tickers because the 30th is unconfigured is the wrong trade — the
+    // 29 still need their prices on chain. Safety lives one level up, where the
+    // ACTION is known: the `build*Tx` composers fail closed on the tickers their
+    // specific call actually depends on (`assertTickersRefreshed` /
+    // `assertWlpPoolRefreshed` in `perp/tx-builders/common.ts`). A bare
+    // `refreshOraclePrices` caller composing its own PTB reads `skipped` and
+    // decides for itself.
+    //
+    // Exemption: a CONSTANT-ONLY ticker needs no update leg from any source, so
+    // it counts as refreshed with just its constant feed.
+    //
+    // "Constant-only" is deliberately stricter than "constant-pinned". A ticker
+    // that constant_rule pins AND some other rule also has a feed for is NOT
+    // exempt, even when that other rule is outside the fed set: the on-chain
+    // aggregator very likely weights the rule whose feed the config carries, and
+    // aggregating a constant-only collector for it aborts `EMissingPriceSource`.
+    // Exempting on `isConstantTicker` alone would be correct only while the fed
+    // set covers every ticker's weighted set — an operator-maintained property
+    // this function cannot verify without reading chain state. So the strict
+    // reading fails SAFE: the ticker is skipped, named, and the composers turn
+    // that into a build error instead of an opaque on-chain abort.
+    //
+    // Catches a MISSING feed only; a present-but-WRONG feed id is deliberately
+    // left to abort on-chain at dry-run.
     const covered = new Set(groups.flatMap((group) => group.tickers));
-    const isConstantOnly = (t) => host.isConstantTicker(t) && !priceInfoByTicker.has(t);
-    const unservable = tickers.filter((t) => !covered.has(t) && !isConstantOnly(t));
-    if (unservable.length > 0) {
-        const sources = host.oracleSources.join(", ");
-        throw new Error(`oracleSource [${sources}] has no feed configured for ticker(s): ` +
-            `${unservable.join(", ")}. Sources are self-contained with no fallback — add ` +
-            `feeds for them under a listed source, or list a source that serves them.`);
-    }
-    // Fee-source pre-check, hoisted ABOVE the off-chain fetches and PTB build
-    // below. It consults only `rule.requiresFeeSource` — known before any fetch
-    // or PTB mutation — so a fee-charging source (Pyth Core) in the fed set with
-    // no `feeSource` throws with ZERO wasted network calls and zero PTB
-    // commands, rather than waiting for `buildPythPriceUpdateCalls`'s own
-    // per-call guard to fire after the off-chain fetches already ran.
-    if (!opts.feeSource && groups.some((group) => group.rule.requiresFeeSource)) {
-        throw new pyth_ts_1.OracleFeeSourceUnavailableError();
+    const { servable: refreshed, unservable: skipped } = (0, validate_ts_1.partitionServableTickers)(host, tickers, covered);
+    // Credential pre-check, hoisted ABOVE the oracle fetches and PTB build below
+    // (the position the retired fee-source pre-check held). It consults only
+    // `rule.credential` — known without fetching anything — so a keyless build
+    // against an auth-first source (Lazer) in the fed set throws with ZERO
+    // wasted ORACLE calls and zero PTB commands, rather than waiting for that
+    // group's own fetch guard to fire after sibling groups' fetches already ran.
+    // Fully generic: the kind→value mapping is the port's
+    // (`oracleCredentialsFromHost`) and the ERROR is the rule's own, so this
+    // loop names neither a credential kind nor a rule.
+    //
+    // It does NOT run before absolutely everything, and cannot: scoping it to
+    // the groups that still need to fetch means knowing which ones the cache
+    // served, and `UpdateDataProvider` is consumer-implemented, so its lookup
+    // may do I/O. That is the trade — a provider round trip may precede the
+    // throw, an oracle fetch never does — and it buys the scoping below.
+    //
+    // The check is scoped to the groups that will actually FETCH. An
+    // `updateDataProvider` is a per-SOURCE cache (`get(source, tickers)`), so a
+    // consumer holding the credential out-of-band for one source must not
+    // exempt the whole fed set — with a waterx-only cache and a keyless Lazer
+    // group, a blanket skip would let the quote-center GET fire before the
+    // Lazer group failed. So cache lookups (no network) run first, and only the
+    // groups that missed are credential-checked.
+    //
+    // Phase 0 — resolve cache hits. Cheap and network-free by contract.
+    const cachedByGroup = await Promise.all(groups.map((group) => resolveCachedUpdateData(host, group, opts.updateDataProvider)));
+    const needsFetch = groups.filter((_, i) => cachedByGroup[i] === null);
+    const credentials = (0, price_update_rule_ts_1.oracleCredentialsFromHost)(host);
+    for (const { rule } of needsFetch) {
+        if (rule.credential && !credentials[rule.credential.kind]) {
+            throw rule.credential.missing();
+        }
     }
-    // Phase 1 — resolve every group's update data IN PARALLEL: the per-source
-    // fetches (Hermes VAA / Lazer POST / quote-center GET) are independent
-    // network calls on the tx-build money path, so a multi-source fed set must
-    // not pay one RTT per source sequentially. ALL fetches settle before the
-    // first PTB mutation below, so a fetch failure never strands moveCalls in a
+    // Phase 1 — live-fetch whatever the cache did not serve, IN PARALLEL: the
+    // per-source fetches (Lazer POST / quote-center GET) are independent network
+    // calls on the tx-build money path, so a multi-source fed set must not pay
+    // one RTT per source sequentially. ALL of them settle before the first PTB
+    // mutation below, so a fetch failure never strands moveCalls in a
     // caller-owned tx — and a failure in ANY group fails the whole build (a
     // listed source is load-bearing; silently building without it would starve
     // its weighted tickers on-chain).
-    const dataByGroup = await Promise.all(groups.map((group) => resolveGroupUpdateData(host, group, opts.updateDataProvider)));
+    const fetched = new Map();
+    await Promise.all(needsFetch.map(async (group) => {
+        fetched.set(group.source, await group.rule.fetchUpdateData(host, group.tickers));
+    }));
+    const dataByGroup = groups.map((group, i) => cachedByGroup[i] ?? fetched.get(group.source) ?? null);
     // Phase 2 — build each group's update leg sequentially, in list order, so
     // PTB command order stays deterministic. The carry step below is an
     // exhaustive switch over the group's rule kind: a future source whose feed
     // leg needs per-ticker data from its update leg must decide its carry here
     // — falling through silently would starve its weighted tickers on-chain.
     const lazerUpdateByTicker = new Map();
-    // Signed batch envelope per waterx-served ticker. Unlike Lazer's shared PTB
-    // handle, waterx's verify+feed is bundled into `collect_batch_latest` in the
-    // per-ticker feed leg, so its `buildUpdateCalls` emits nothing and the
-    // envelope is carried straight from the group's fetched data.
+    // Signed waterx data per served ticker — a per-symbol Merkle leaf normally, a
+    // shared batch envelope on the fallback shape. Unlike Lazer's shared PTB
+    // handle, waterx's verify+feed is bundled into the per-ticker collect call, so
+    // its `buildUpdateCalls` emits nothing and the signed data is carried straight
+    // from the group's fetched data.
+    const waterxLeafByTicker = new Map();
     const waterxEnvelopeByTicker = new Map();
     for (const [i, group] of groups.entries()) {
         const data = dataByGroup[i] ?? null;
-        const handle = (await group.rule.buildUpdateCalls(tx, host, data, {
-            cache: opts.cache,
-            feeSource: opts.feeSource,
-        })) ?? undefined;
+        const handle = (await group.rule.buildUpdateCalls(tx, host, data)) ?? undefined;
         switch (group.rule.kind) {
-            case "pyth_rule":
-                // Core's update leg wrote the PriceInfoObjects in place — the feed
-                // leg reads them by id (`priceInfoByTicker`), nothing to carry.
-                break;
             case "pyth_lazer_rule":
                 // Route by the handle's kind discriminant — the tag exists so a
                 // non-lazer handle can never be silently fed into
@@ -325,12 +333,45 @@ async function refreshOraclePrices(tx, host, tickers, opts = {}) {
                 break;
             case "waterx_rule": {
                 // waterx_rule emits no shared handle (verify+feed is bundled into the
-                // per-ticker `collect_batch_latest`), so the envelope is carried
-                // straight from this group's fetched data to the feed leg below.
-                const envelope = (0, waterx_rule_ts_1.waterxEnvelopeOf)(data);
-                if (envelope) {
-                    for (const ticker of group.tickers)
-                        waterxEnvelopeByTicker.set(ticker, envelope);
+                // per-ticker collect call), so the signed data is carried straight from
+                // this group's fetched data to the feed leg below. Leaves are per-symbol
+                // and indexed BY symbol — never fanned out across the group like the
+                // envelope, since each leaf only verifies for its own symbol
+                // (`ECollectorSymbolMismatch`). A leaf for a symbol outside this group is
+                // dropped rather than carried: the feed leg is keyed by ticker anyway.
+                const leaves = (0, waterx_rule_ts_1.waterxLeavesOf)(data);
+                // `length > 0` matters: `{ leaves: [] }` is shape-valid (`[].every(...)`
+                // is `true`), so a bare truthiness test would TAKE this branch, carry
+                // nothing, and `break` past the envelope branch below.
+                if (leaves && leaves.length > 0) {
+                    const served = new Set(group.tickers);
+                    for (const leaf of leaves) {
+                        if (served.has(leaf.symbol))
+                            waterxLeafByTicker.set(leaf.symbol, leaf);
+                    }
+                }
+                else {
+                    const envelope = (0, waterx_rule_ts_1.waterxEnvelopeOf)(data);
+                    if (envelope) {
+                        for (const ticker of group.tickers)
+                            waterxEnvelopeByTicker.set(ticker, envelope);
+                    }
+                }
+                // Fail the BUILD, not the chain. Both suppliers of `data` already
+                // guarantee full coverage — the live fetch through `assertCoverage`, a
+                // cached payload through `narrowUpdateData` (which returns `null`, i.e.
+                // "miss → live fetch", rather than a partial) — so reaching here with a
+                // ticker uncarried means one of those invariants broke. Left alone it
+                // emits a collector with no waterx leg, which surfaces MUCH later as an
+                // opaque on-chain `EMissingPriceSource` (or, if the rule is unweighted
+                // for that ticker, as a silently thinner weighted set). This names the
+                // tickers instead.
+                const uncarried = group.tickers.filter((t) => !waterxLeafByTicker.has(t) && !waterxEnvelopeByTicker.has(t));
+                if (uncarried.length > 0) {
+                    throw new Error(`waterx_rule update data carries no signed price for ticker(s): ${uncarried.join(", ")}. ` +
+                        "Expected one signed leaf per ticker (or a batch envelope covering all of " +
+                        "them) — a payload that serves none of a group's tickers must be reported " +
+                        "as a miss, not fed.");
                 }
                 break;
             }
@@ -340,13 +381,16 @@ async function refreshOraclePrices(tx, host, tickers, opts = {}) {
             }
         }
     }
-    // Aggregate each ticker, feeding whichever rules it is configured for.
-    for (const ticker of tickers) {
+    // Aggregate each REFRESHED ticker, feeding whichever rules it is configured
+    // for. A skipped ticker gets no collector at all — aggregating one with no
+    // feed leg would write an empty collector and abort `EMissingPriceSource`.
+    for (const ticker of refreshed) {
         aggregateTicker(tx, host, {
             ticker,
-            priceInfoObjectId: priceInfoByTicker.get(ticker),
             lazerUpdate: lazerUpdateByTicker.get(ticker),
+            waterxLeaf: waterxLeafByTicker.get(ticker),
             waterxEnvelope: waterxEnvelopeByTicker.get(ticker),
         });
     }
+    return { refreshed, skipped };
 }