@warren-dean/code-kit 0.4.1 → 0.5.0

package/hooks/mod/register.test.ts

@@ -336,7 +336,9 @@ test('ACT-1 and BAND-3 approving with the prefilled reason grants it for the lan
   const confirm = await pane($, APPROVE);
   const reason = 'Approve dayjs for the web lane: npm install dayjs';
   expect((await confirm.find({ key: 'approve-reason' }))?.props.value).toBe(reason);
-  expect(await confirm.find({ type: 'Text', text: /for 60 minutes/ })).toBeDefined();
+  expect(
+    await confirm.find({ type: 'Text', text: /until the install is committed \(at most 7 days\)/ }),
+  ).toBeDefined();
   await press($, 'approve-confirm', APPROVE);
   expect(w.acts).toEqual([
     ['approve', 'dep-dayjs', '--lane', 'web', '--reason', reason, '--via', 'pane'],
@@ -558,7 +560,7 @@ test('CARD-1 a refused write is drawn as a card, its text a press away', async (
 test('CARD-1 a refusal an approval would allow has Approve…, which opens the confirmation', async ($, on) => {
   const w = project();
   w.refusal =
-    'Blocked: a new dependency (dayjs) needs a person\'s approval. Write a short change request for the lead.\n  ! echo "<what you are approving>" > .claude/approvals/web/dep-dayjs\n(a person runs it; it allows installing it for the web lane, for 60 minutes)\nCommand: npm install dayjs';
+    'Blocked: a new dependency (dayjs) needs a person\'s approval. Write a short change request for the lead.\n  ! echo "<what you are approving>" > .claude/approvals/web/dep-dayjs\n(a person runs it; it allows installing it for the web lane, until the install is committed, at most 7 days)\nCommand: npm install dayjs';
   await start($, on, w);
   await $.tool.call({ tool: 'Bash', tool_use_id: 'tu-2', command: 'npm install dayjs' } as any);
   const ui = await toolResult($, 'tu-2', 'Bash');
@@ -622,7 +624,7 @@ test('CARD-4 outside a code-kit project, /approvals and /verify-branch say so',
 });
 
 const install =
-  'Blocked: a new dependency (dayjs) needs a person\'s approval. Write a short change request for the lead.\n  ! echo "<what you are approving>" > .claude/approvals/dep-dayjs\n(a person runs it; it allows installing it for any agent, for 60 minutes)\nCommand: npm install dayjs';
+  'Blocked: a new dependency (dayjs) needs a person\'s approval. Write a short change request for the lead.\n  ! echo "<what you are approving>" > .claude/approvals/dep-dayjs\n(a person runs it; it allows installing it for any agent, until the install is committed, at most 7 days)\nCommand: npm install dayjs';
 
 test('CARD-1 a group holding a refusal unfolds, so its row can be the card', async ($, on) => {
   const w = project();

package/hooks/mod/view.mjs

@@ -34,6 +34,7 @@ export function readyFrom(next) {
  * One lane's row (PANE-2): the story it's on, its branch and its state.
  *   building   a branch for the story and, if it has commits, the lane's agent still at work on it;
  *   in review  commits on the branch (status's `review`) and the agent no longer at work;
+ *   sent back  a review sent the branch back, and the lane hasn't committed its fix yet;
  *   blocked    the lane's next story waits on another;
  *   idle       none of these.
  * `status` can't tell a finished branch from one still being built, so the agent at work decides.
@@ -41,7 +42,9 @@ export function readyFrom(next) {
 function laneRow(name, agent, stories, atWork) {
   const own = stories.filter((s) => s.lane === name);
   const active = Boolean(agent && atWork.has(agent));
-  const story = own.find((s) => ['in progress', 'review'].includes(s.state));
+  const story = own.find((s) => ['in progress', 'review', 'sent back'].includes(s.state));
+  if (story?.state === 'sent back')
+    return { name, agent, active, story, branch: story.branch, state: 'sent back' };
   if (story) {
     const state = story.state === 'review' && !active ? 'in review' : 'building';
     return { name, agent, active, story, branch: story.branch, state };
@@ -77,7 +80,13 @@ export function projectState(check, status, next = null, atWork = new Set()) {
   return { kind: 'ok', lanes, ready, planGaps: status ? (status.problems ?? []).length : null };
 }
 
-const STATE_COLOR = { building: 'blue', 'in review': 'yellow', blocked: 'red', idle: undefined };
+const STATE_COLOR = {
+  building: 'blue',
+  'in review': 'yellow',
+  'sent back': 'magenta',
+  blocked: 'red',
+  idle: undefined,
+};
 
 /** The Lanes pane's body, drawn with the elements `$.ui.resolve(e)` returned. */
 export function lanesPane(state, { Box, Text }) {
@@ -263,7 +272,7 @@ export function approvePane(
       Text({ bold: true, children: [`Approve ${request.names.join(', ')}`] }),
       Text({
         children: [
-          `For ${request.lane ? `the ${request.lane} lane` : 'any agent'}, for 60 minutes. Asked for: ${request.what}`,
+          `For ${request.lane ? `the ${request.lane} lane` : 'any agent'}, ${request.names.every((n) => n.startsWith('dep-')) ? 'until the install is committed (at most 7 days)' : 'for 60 minutes'}. Asked for: ${request.what}`,
         ],
       }),
       Input({
@@ -348,7 +357,7 @@ export function refusalCard(raw) {
       kind: 'dependency',
       title: `Install refused: ${m[1]}`,
       why: "A new dependency needs a person's approval.",
-      todo: 'A person approves it, here or with the `!` command, for 60 minutes.',
+      todo: 'A person approves it, here or with the `!` command, until the install is committed (at most 7 days).',
       request: request(command ?? `install ${m[1]}`),
       raw: text,
     };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@warren-dean/code-kit",
-  "version": "0.4.1",
+  "version": "0.5.0",
   "description": "Keeps AI coding agents inside your project's rules: lanes, layer rules, protected paths and proof before finish, enforced by Claude Code hooks and in CI",
   "license": "MIT",
   "author": "Warren Langeveldt",

package/skills/init/SKILL.md

@@ -31,7 +31,7 @@ Say which one applies and why before you start.
    - **Design-first rules:** screens designed before they are built, and where approvals are listed.
    - **Commands:** test, lint, typecheck, database and deploy commands, and which must never run locally.
 2. **The repository.** Map the real layout: `git ls-files | cut -d/ -f1-3 | sort | uniq -c`, package manifests (`package.json`, `pyproject.toml`, `go.mod`, `Cargo.toml`), workspace files, existing lint, format and test scripts, CI workflows and CODEOWNERS.
-3. **Existing kit.** If the project has `.claude/hooks`, agents or skills, read them. The kit replaces local hooks; agents and skills are kept and adapted, not rewritten.
+3. **Existing kit.** If the project has `.claude/hooks`, agents or skills, read them. The kit replaces local hooks; agents and skills are kept and adapted, not rewritten. On an update (section 4), skills that came from the docs' recipes follow those recipes as they are now.
 4. **Other tools.** Run `adapters --config .claude/code-kit.draft.json` once the draft exists. It lists the tools code-kit has an adapter for (such as Context Graph, found by its `.ctx/` folder), what each adds to the rules, and the setup each needs. Don't copy an adapter's paths into the config; they're added automatically while the tool is present.
 
 **Brownfield, in addition:**
@@ -97,6 +97,8 @@ Draft, alongside the config:
   - Drop the spec-check lines if the config has no `docs.specs`.
 - **CLAUDE.md:** add the section from `${CLAUDE_PLUGIN_ROOT}/templates/claude-md.md`.
 - **Project skills** (recipes like "new migration" or "new endpoint"): list the recipes the docs describe step by step, and offer to write them. Don't write them unasked, and never write an empty one.
+  - Write each as `.claude/skills/<name>/SKILL.md`, saying in its description which recipe in which doc it comes from, so an update can find it again.
+  - List it under **Skills to use** on every lane agent whose paths the recipe touches, not only one: a recipe that adds a migration and the endpoint that uses it belongs to both lanes. A recipe only the lead follows goes in the CLAUDE.md section instead.
 
 Show the person:
 
@@ -144,10 +146,16 @@ Re-run whenever the build has moved on: new apps or packages, folders that moved
 
 4. **Also propose:**
    - agent files for new lanes, and updates to agents whose paths changed;
+   - **project skills**, by reading the recipes in the docs again and comparing them with `.claude/skills/`:
+     - a new skill for each recipe the docs now describe that has none;
+     - an update to each skill whose recipe changed, showing what changed;
+     - removing a skill whose recipe is gone from the docs (ask first: the person may want it kept);
+     - the matching **Skills to use** changes on every lane agent whose paths each recipe touches;
+     - skills the person wrote themselves, with no recipe behind them, stay as they are;
    - a smaller baseline when `baseline` shows violations were fixed. It only ever shrinks.
 5. **On approval:**
    1. Replace `.claude/code-kit.json` with the draft and delete the draft.
-   2. Write or update the agents.
+   2. Write or update the agents, and write, update or remove the project skills as approved.
    3. Run `baseline --write` if it shrank.
    4. Run `check` and `unowned`.
    5. Commit on a branch.

package/skills/review/SKILL.md

@@ -50,8 +50,16 @@ Read the story, every requirement it cites, and the full diff (`git diff <base>.
 
 Report the table, `verify`'s result and one of:
 
+- **Files any agent may write** (`anyActor`, such as a lockfile or recorded decisions) have no owning lane, but they have a reviewer: `trace <file>` names it (the lead unless the config names a lane). Review those changes as that reviewer would, or ask that lane's agent.
 - **Merge.** Everything passes. The lead merges the branch into its own branch (`git merge --no-ff <branch>`), sets the story's `**Status:**` to `done` in the plan, and commits. `main` and the other protected branches are merged by a person, through a pull request, after `verify` passes in CI. When the branch is merged, remove its worktree.
-- **Send back.** List each problem, where it is, and what "fixed" looks like. Send the list to the same lane agent if it's still running (SendMessage), or dispatch the story again with the list added to the brief. Set the story's status to `in progress`.
+- **Send back.** List each problem, where it is, and what "fixed" looks like. Record the send-back, so `status` and `next` read the branch as waiting for its fix rather than finished:
+
+  ```bash
+  node "${CLAUDE_PLUGIN_ROOT}/bin/code-kit.mjs" sent-back <branch> --reason "<the problems, in one line>"
+  ```
+
+  Send the list to the same lane agent if it's still running (SendMessage), or dispatch the story again with the list added to the brief. Set the story's status to `in progress`.
+
 - **Ask the person.** When the right answer is a product or scope decision (the spec is silent, or the lane found a real conflict), put the question to the person with your recommendation. Don't merge around it.
 
 Keep the report short: the verdict first, then the table, then the problems.

package/templates/agent.md

@@ -9,7 +9,7 @@ You are the {{lane}} engineer for this repository.
 **Owned paths:** {{lane paths from .claude/code-kit.json}}
 **Layers:** {{the layers in these paths, and what each may depend on}}
 **Specs:** {{the spec files this lane reads}}
-**Skills to use:** spec-check{{, project skills for this lane}}
+**Skills to use:** spec-check{{, every project skill whose recipe touches this lane's paths}}
 **Prove your work with:** `{{the command that proves this lane's work}}`
 
 Lane rules: