@warpgogol/forge 2.9.13 → 2.9.25

package/os/core/handlers/lifecycle-handlers.test.ts

@@ -1,524 +0,0 @@
-/*
-<MODULE_CONTRACT>
-<purpose>Unit tests for RFC-0674/RFC-0677/RFC-0678/RFC-0679 lifecycle handlers — profile resolution, dry-run, build execution, validate with --artifact and violation parsing, determinism check, asset management.</purpose>
-</MODULE_CONTRACT>
-<CHANGE_SUMMARY>
-  <item>RFC-0674: initial lifecycle handler tests — profile resolution, dry-run, build execution.</item>
-  <item>RFC-0677: added tests for --artifact filtering, violation parsing (json/plain), allPassed, empty-state.</item>
-  <item>RFC-0678: added tests for determinism check — dry-run, --artifact, no-hashable, cache hit, non-deterministic detection.</item>
-  <item>RFC-0679: added tests for asset list/check — dry-run, --type, missing, orphaned, --strict.</item>
-  <item>RFC-0680: added tests for release prepare/publish — dry-run, manifest generation, publish dry-run, no-release-config.</item>
-</CHANGE_SUMMARY>
-*/
-
-import { test, expect, beforeEach, afterEach } from "vitest";
-import { join } from "node:path";
-import { writeFileSync, mkdirSync, rmSync } from "node:fs";
-import { tmpdir } from "node:os";
-import type { ForgeCommandInput, ForgeRuntimeContext } from "../../../src/types.ts";
-import { resolveActiveProfile } from "./profile-resolve.ts";
-import { runBuild } from "./build.ts";
-import { runValidate, parseViolations } from "./validate.ts";
-import { runDeterminismCheck } from "./determinism-check.ts";
-import { runAssetsList } from "./assets-list.ts";
-import { runAssetsCheck } from "./assets-check.ts";
-import { runReleasePrepare } from "./release-prepare.ts";
-import { runReleasePublish } from "./release-publish.ts";
-import { runDev } from "./dev.ts";
-
-const FORGE_ROOT = join(import.meta.dirname, "..", "..", "..");
-
-function makeTempWorkspace(profileYaml?: string): string {
-  const dir = join(
-    tmpdir(),
-    `forge-lifecycle-test-${Date.now()}-${Math.random().toString(36).slice(2)}`,
-  );
-  mkdirSync(dir, { recursive: true });
-
-  if (profileYaml) {
-    writeFileSync(join(dir, "forge.yaml"), profileYaml);
-  }
-
-  return dir;
-}
-
-function makeContext(workspaceRoot: string): ForgeRuntimeContext {
-  return {
-    workspaceRoot,
-    logger: {
-      section: () => {},
-      info: () => {},
-      warn: () => {},
-      error: () => {},
-      success: () => {},
-    },
-    dryRun: false,
-    outputFormat: "pretty",
-    forgeRoot: FORGE_ROOT,
-  };
-}
-
-const input = (flags: Record<string, unknown> = {}): ForgeCommandInput => ({
-  argv: [],
-  flags: flags as Record<string, boolean | string | string[]>,
-});
-
-const godotYaml = `profile: godot-csharp\n`;
-
-let tmpDir: string;
-
-beforeEach(() => {
-  tmpDir = makeTempWorkspace(godotYaml);
-});
-
-afterEach(() => {
-  rmSync(tmpDir, { recursive: true, force: true });
-});
-
-// ── resolveActiveProfile ──────────────────────────────────────────────────
-
-test("resolveActiveProfile returns the godot-csharp profile when forge.yaml declares it", () => {
-  const resolved = resolveActiveProfile(tmpDir, FORGE_ROOT);
-  expect(resolved).not.toBeNull();
-  expect(resolved!.profile.id).toBe("godot-csharp");
-});
-
-test("resolveActiveProfile returns null when forge.yaml has no profile field", () => {
-  const dir = makeTempWorkspace(`project:\n  name: test\n`);
-  const resolved = resolveActiveProfile(dir, FORGE_ROOT);
-  expect(resolved).toBeNull();
-  rmSync(dir, { recursive: true, force: true });
-});
-
-test("resolveActiveProfile returns null when forge.yaml is missing", () => {
-  const dir = makeTempWorkspace();
-  const resolved = resolveActiveProfile(dir, FORGE_ROOT);
-  expect(resolved).toBeNull();
-});
-
-test("resolveActiveProfile uses profileIdOverride when provided", () => {
-  const resolved = resolveActiveProfile(tmpDir, FORGE_ROOT, "godot-csharp");
-  expect(resolved).not.toBeNull();
-  expect(resolved!.profile.id).toBe("godot-csharp");
-});
-
-// ── runBuild ───────────────────────────────────────────────────────────────
-
-test("runBuild --dry-run does not execute child process and prints resolved commands", async () => {
-  const result = await runBuild(input({ "dry-run": true }), makeContext(tmpDir));
-  expect(result.exitCode).toBeUndefined();
-  expect(result.data?.profileId).toBe("godot-csharp");
-  expect(result.data?.artifacts.length).toBeGreaterThan(0);
-  const game = result.data?.artifacts.find((a) => a.id === "game");
-  expect(game).toBeDefined();
-});
-
-test("runBuild returns exit 1 when no active profile found", async () => {
-  const dir = makeTempWorkspace();
-  const result = await runBuild(input({}), makeContext(dir));
-  expect(result.exitCode).toBe(1);
-  rmSync(dir, { recursive: true, force: true });
-});
-
-test("runBuild --dry-run resolves commands without execution", async () => {
-  const result = await runBuild(input({ "dry-run": true }), makeContext(tmpDir));
-  expect(result.data?.artifacts.length).toBeGreaterThan(0);
-  expect(result.summary).toContain("[dry-run]");
-});
-
-// ── runValidate ─────────────────────────────────────────────────────────────
-
-test("runValidate --dry-run does not execute child process and prints resolved commands", async () => {
-  const result = await runValidate(input({ "dry-run": true }), makeContext(tmpDir));
-  expect(result.data?.profileId).toBe("godot-csharp");
-  expect(result.data?.artifacts.length).toBeGreaterThan(0);
-  const game = result.data?.artifacts.find((a) => a.id === "game");
-  expect(game).toBeDefined();
-  expect(game!.command).toBe("godot --path . --headless --quit");
-});
-
-test("runValidate returns exit 1 when no active profile found", async () => {
-  const dir = makeTempWorkspace();
-  const result = await runValidate(input({}), makeContext(dir));
-  expect(result.exitCode).toBe(1);
-  rmSync(dir, { recursive: true, force: true });
-});
-
-// ── runValidate RFC-0677: --artifact, violation parsing, allPassed ─────────
-
-test("runValidate --artifact game filters to a single artifact in dry-run", async () => {
-  const result = await runValidate(
-    input({ "dry-run": true, artifact: "game" }),
-    makeContext(tmpDir),
-  );
-  expect(result.data?.artifacts.length).toBe(1);
-  expect(result.data?.artifacts[0].id).toBe("game");
-});
-
-test("runValidate --artifact unknown returns exit 1 with not-declared message", async () => {
-  const result = await runValidate(
-    input({ "dry-run": true, artifact: "nonexistent" }),
-    makeContext(tmpDir),
-  );
-  expect(result.exitCode).toBe(1);
-  expect(result.summary).toContain("not declared");
-});
-
-test("runValidate --dry-run includes passed and violations fields", async () => {
-  const result = await runValidate(input({ "dry-run": true }), makeContext(tmpDir));
-  expect(result.data?.allPassed).toBe(true);
-  const game = result.data?.artifacts.find((a) => a.id === "game");
-  expect(game?.passed).toBe(true);
-  expect(game?.violations).toEqual([]);
-});
-
-test("parseViolations extracts structured violations from JSON output", () => {
-  const jsonOutput = JSON.stringify([
-    { file: "Main.tscn", line: 12, severity: "error", message: "missing script" },
-    { file: "Player.cs", line: 5, severity: "warning", message: "deprecated method" },
-  ]);
-  const violations = parseViolations(jsonOutput, "json", undefined);
-  expect(violations.length).toBe(2);
-  expect(violations[0].file).toBe("Main.tscn");
-  expect(violations[0].line).toBe(12);
-  expect(violations[0].severity).toBe("error");
-  expect(violations[1].severity).toBe("warning");
-});
-
-test("parseViolations extracts structured violations from plain text with regex", () => {
-  const plainOutput = [
-    "Scenes/Main.tscn:12: error: scene missing script attribute",
-    "Scripts/Player.cs:5: warning: deprecated method call",
-  ].join("\n");
-  const pattern =
-    "^(?<file>[^:]+):(?<line>\\d+):\\s*(?<severity>error|warning):\\s*(?<message>.+)$";
-  const violations = parseViolations(plainOutput, "plain", pattern);
-  expect(violations.length).toBe(2);
-  expect(violations[0].file).toBe("Scenes/Main.tscn");
-  expect(violations[0].line).toBe(12);
-  expect(violations[0].severity).toBe("error");
-  expect(violations[0].message).toContain("missing script");
-  expect(violations[1].severity).toBe("warning");
-});
-
-test("parseViolations returns empty array when outputFormat is not set", () => {
-  const violations = parseViolations("some output", undefined, undefined);
-  expect(violations).toEqual([]);
-});
-
-test("parseViolations returns empty array on malformed JSON", () => {
-  const violations = parseViolations("not json", "json", undefined);
-  expect(violations).toEqual([]);
-});
-
-test("parseViolations returns empty array on malformed regex pattern", () => {
-  const violations = parseViolations("some output", "plain", "[invalid(");
-  expect(violations).toEqual([]);
-});
-
-// ── runDev ──────────────────────────────────────────────────────────────────
-
-test("runDev --dry-run does not spawn child process and prints resolved command", async () => {
-  const result = await runDev(input({ "dry-run": true }), makeContext(tmpDir));
-  expect(result.data?.profileId).toBe("godot-csharp");
-  expect(result.data?.devServerCommand).toBe("godot --path . --editor");
-  expect(result.data?.port).toBe(6005);
-  expect(result.data?.exitCode).toBe(0);
-});
-
-test("runDev returns exit 1 when profile has no devServer", async () => {
-  // forge-shell profile has no devServer
-  const dir = makeTempWorkspace(`profile: forge-shell\n`);
-  const result = await runDev(input({}), makeContext(dir));
-  expect(result.exitCode).toBe(1);
-  expect(result.summary).toContain("does not declare a devServer");
-  rmSync(dir, { recursive: true, force: true });
-});
-
-test("runDev returns exit 1 when no active profile found", async () => {
-  const dir = makeTempWorkspace();
-  const result = await runDev(input({}), makeContext(dir));
-  expect(result.exitCode).toBe(1);
-  rmSync(dir, { recursive: true, force: true });
-});
-
-// ── runDeterminismCheck RFC-0678 ─────────────────────────────────────────────
-
-test("runDeterminismCheck --dry-run prints resolved inputs without executing builds", async () => {
-  const result = await runDeterminismCheck(input({ "dry-run": true }), makeContext(tmpDir));
-  expect(result.data?.profileId).toBe("godot-csharp");
-  expect(result.data?.artifacts.length).toBe(1);
-  expect(result.data?.artifacts[0].artifactId).toBe("game");
-  expect(result.data?.artifacts[0].inputs).toContain("Scenes/**/*.tscn");
-  expect(result.data?.artifacts[0].inputs).toContain("project.godot");
-  expect(result.summary).toContain("[dry-run]");
-});
-
-test("runDeterminismCheck --artifact game filters to a single artifact", async () => {
-  const result = await runDeterminismCheck(
-    input({ "dry-run": true, artifact: "game" }),
-    makeContext(tmpDir),
-  );
-  expect(result.data?.artifacts.length).toBe(1);
-  expect(result.data?.artifacts[0].artifactId).toBe("game");
-});
-
-test("runDeterminismCheck --artifact unknown returns exit 1", async () => {
-  const result = await runDeterminismCheck(
-    input({ "dry-run": true, artifact: "nonexistent" }),
-    makeContext(tmpDir),
-  );
-  expect(result.exitCode).toBe(1);
-  expect(result.summary).toContain("not declared");
-});
-
-test("runDeterminismCheck returns exit 1 when no active profile found", async () => {
-  const dir = makeTempWorkspace();
-  const result = await runDeterminismCheck(input({}), makeContext(dir));
-  expect(result.exitCode).toBe(1);
-  rmSync(dir, { recursive: true, force: true });
-});
-
-test("runDeterminismCheck returns exit 0 when profile has no hashable artifacts", async () => {
-  // Create a custom profile with an artifact that has no determinism field
-  // We can't easily do this without modifying forge profiles, so instead
-  // test with a profile that has no artifacts at all — the handler returns
-  // exit 1 for "no artifacts" and exit 0 for "no hashable artifacts".
-  // Since forge-shell has no artifacts, we test the no-artifacts path.
-  const dir = makeTempWorkspace(`profile: forge-shell\n`);
-  const result = await runDeterminismCheck(input({}), makeContext(dir));
-  expect(result.exitCode).toBe(1);
-  expect(result.summary).toContain("does not declare any artifacts");
-  rmSync(dir, { recursive: true, force: true });
-});
-
-test("runDeterminismCheck cache hit skips double-build", async () => {
-  // Create input files matching the glob patterns
-  mkdirSync(join(tmpDir, "Scenes"), { recursive: true });
-  writeFileSync(join(tmpDir, "Scenes", "Main.tscn"), "[gd_scene]");
-  mkdirSync(join(tmpDir, "Scripts"), { recursive: true });
-  writeFileSync(join(tmpDir, "Scripts", "Main.cs"), "using Godot;");
-  writeFileSync(join(tmpDir, "project.godot"), "[application]\n");
-
-  // Create the output file that the produce command would create
-  mkdirSync(join(tmpDir, "bin"), { recursive: true });
-  writeFileSync(join(tmpDir, "bin", "Debug"), "fake-build-content");
-
-  // First run: the produce command "dotnet build" will fail, but the input hash
-  // is computed before the build. We can read it from the result.
-  const result1 = await runDeterminismCheck(input({}), makeContext(tmpDir));
-  expect(result1.exitCode).toBe(1); // build fails
-  const inputHash = result1.data?.artifacts[0].inputHash;
-  expect(inputHash).toBeTruthy();
-
-  // Write a cache entry with the correct input hash
-  const cachePath = join(tmpDir, "dist", ".determinism-cache.json");
-  mkdirSync(join(tmpDir, "dist"), { recursive: true });
-  const cache = {
-    entries: {
-      [`game:${inputHash}:dotnet build`]: {
-        inputHash,
-        produceCommand: "dotnet build",
-        outputHash: "sha256:cached-hash",
-        deterministic: true,
-      },
-    },
-  };
-  writeFileSync(cachePath, JSON.stringify(cache, null, 2) + "\n");
-
-  // Second run: should hit the cache and skip the build
-  const result2 = await runDeterminismCheck(input({}), makeContext(tmpDir));
-  expect(result2.exitCode).toBe(0); // cached as deterministic
-  expect(result2.data?.artifacts[0].cached).toBe(true);
-  expect(result2.data?.artifacts[0].deterministic).toBe(true);
-  expect(result2.data?.artifacts[0].firstBuildHash).toBe("sha256:cached-hash");
-}, 15000);
-
-// ── runAssetsList RFC-0679 ───────────────────────────────────────────────────
-
-test("runAssetsList --dry-run lists assets without hashing", async () => {
-  // Create asset files
-  mkdirSync(join(tmpDir, "Assets", "images"), { recursive: true });
-  writeFileSync(join(tmpDir, "Assets", "images", "bg.png"), "fake-png");
-  mkdirSync(join(tmpDir, "Assets", "audio"), { recursive: true });
-  writeFileSync(join(tmpDir, "Assets", "audio", "narration.wav"), "fake-wav");
-
-  const result = await runAssetsList(input({ "dry-run": true }), makeContext(tmpDir));
-  expect(result.data?.profileId).toBe("godot-csharp");
-  expect(result.data?.assets.length).toBe(2);
-  const image = result.data?.assets.find((a) => a.type === "image");
-  expect(image).toBeDefined();
-  expect(image!.path).toBe("Assets/images/bg.png");
-  expect(image!.hash).toBe(""); // dry-run skips hashing
-  expect(image!.size).toBe(0);
-});
-
-test("runAssetsList --type image filters by type", async () => {
-  mkdirSync(join(tmpDir, "Assets", "images"), { recursive: true });
-  writeFileSync(join(tmpDir, "Assets", "images", "bg.png"), "fake-png");
-  mkdirSync(join(tmpDir, "Assets", "audio"), { recursive: true });
-  writeFileSync(join(tmpDir, "Assets", "audio", "narration.wav"), "fake-wav");
-
-  const result = await runAssetsList(
-    input({ "dry-run": true, type: "image" }),
-    makeContext(tmpDir),
-  );
-  expect(result.data?.assets.length).toBe(1);
-  expect(result.data?.assets[0].type).toBe("image");
-});
-
-test("runAssetsList returns exit 1 when no active profile found", async () => {
-  const dir = makeTempWorkspace();
-  const result = await runAssetsList(input({}), makeContext(dir));
-  expect(result.exitCode).toBe(1);
-  rmSync(dir, { recursive: true, force: true });
-});
-
-test("runAssetsList returns exit 0 when profile has no assets declaration", async () => {
-  const dir = makeTempWorkspace(`profile: forge-shell\n`);
-  const result = await runAssetsList(input({}), makeContext(dir));
-  expect(result.exitCode).toBe(0);
-  expect(result.summary).toContain("does not declare assets");
-  rmSync(dir, { recursive: true, force: true });
-});
-
-// ── runAssetsCheck RFC-0679 ──────────────────────────────────────────────────
-
-test("runAssetsCheck detects missing assets referenced by scenes", async () => {
-  // Create a scene that references a non-existent asset
-  mkdirSync(join(tmpDir, "Scenes"), { recursive: true });
-  writeFileSync(join(tmpDir, "Scenes", "Main.tscn"), '"res://Assets/images/missing.png"');
-
-  const result = await runAssetsCheck(input({ "dry-run": true }), makeContext(tmpDir));
-  expect(result.exitCode).toBe(1);
-  expect(result.data?.check.missing.length).toBeGreaterThan(0);
-  const missing = result.data?.check.missing.find((m) => m.path.includes("missing.png"));
-  expect(missing).toBeDefined();
-  expect(missing!.referencedBy).toContain("Scenes/Main.tscn");
-});
-
-test("runAssetsCheck detects orphaned assets not referenced by any scene", async () => {
-  // Create an asset with no scene referencing it
-  mkdirSync(join(tmpDir, "Assets", "audio"), { recursive: true });
-  writeFileSync(join(tmpDir, "Assets", "audio", "unused.wav"), "fake-wav");
-
-  const result = await runAssetsCheck(input({ "dry-run": true }), makeContext(tmpDir));
-  // Without --strict, orphaned assets are warnings (exit 0)
-  expect(result.data?.check.orphaned.length).toBeGreaterThan(0);
-  const orphaned = result.data?.check.orphaned.find((o) => o.path.includes("unused.wav"));
-  expect(orphaned).toBeDefined();
-  expect(orphaned!.type).toBe("audio");
-});
-
-test("runAssetsCheck --strict exits non-zero when orphaned assets are found", async () => {
-  mkdirSync(join(tmpDir, "Assets", "audio"), { recursive: true });
-  writeFileSync(join(tmpDir, "Assets", "audio", "unused.wav"), "fake-wav");
-
-  const result = await runAssetsCheck(
-    input({ "dry-run": true, strict: true }),
-    makeContext(tmpDir),
-  );
-  expect(result.exitCode).toBe(1);
-  expect(result.data?.check.orphaned.length).toBeGreaterThan(0);
-});
-
-test("runAssetsCheck --dry-run only checks file existence", async () => {
-  mkdirSync(join(tmpDir, "Assets", "images"), { recursive: true });
-  writeFileSync(join(tmpDir, "Assets", "images", "bg.png"), "fake-png");
-  mkdirSync(join(tmpDir, "Scenes"), { recursive: true });
-  writeFileSync(join(tmpDir, "Scenes", "Main.tscn"), '"Assets/images/bg.png"');
-
-  const result = await runAssetsCheck(input({ "dry-run": true }), makeContext(tmpDir));
-  expect(result.exitCode).toBe(0);
-  expect(result.data?.check.missing).toEqual([]);
-  expect(result.data?.check.orphaned).toEqual([]);
-  expect(result.data?.allOk).toBe(true);
-});
-
-test("runAssetsCheck returns exit 1 when no active profile found", async () => {
-  const dir = makeTempWorkspace();
-  const result = await runAssetsCheck(input({}), makeContext(dir));
-  expect(result.exitCode).toBe(1);
-  rmSync(dir, { recursive: true, force: true });
-});
-
-// ── runReleasePrepare RFC-0680 ───────────────────────────────────────────────
-
-test("runReleasePrepare --dry-run prints resolved release steps", async () => {
-  // Create a built artifact at the produce.output path
-  mkdirSync(join(tmpDir, "bin"), { recursive: true });
-  writeFileSync(join(tmpDir, "bin", "Debug"), "fake-build-content");
-
-  const result = await runReleasePrepare(input({ "dry-run": true }), makeContext(tmpDir));
-  expect(result.data?.profileId).toBe("godot-csharp");
-  expect(result.data?.manifest.schemaVersion).toBe("1");
-  expect(result.data?.manifest.artifacts.length).toBeGreaterThan(0);
-  expect(result.data?.manifest.artifacts[0].artifactId).toBe("game");
-  expect(result.data?.manifest.determinismChecked).toBe(false);
-  expect(result.data?.manifest.validationPassed).toBe(true);
-});
-
-test("runReleasePrepare generates manifest with artifact hashes", async () => {
-  mkdirSync(join(tmpDir, "bin"), { recursive: true });
-  writeFileSync(join(tmpDir, "bin", "Debug"), "fake-build-content");
-
-  const result = await runReleasePrepare(input({}), makeContext(tmpDir));
-  expect(result.exitCode ?? 0).toBe(0);
-  expect(result.data?.manifest.artifacts.length).toBeGreaterThan(0);
-  expect(result.data?.manifest.artifacts[0].hash).toBeTruthy();
-  expect(result.data?.manifest.artifacts[0].size).toBeGreaterThan(0);
-  expect(result.data?.manifest.releaseId).toContain("godot-csharp-");
-  expect(result.data?.manifest.schemaVersion).toBe("1");
-});
-
-test("runReleasePrepare returns exit 1 when no release config", async () => {
-  const dir = makeTempWorkspace(`profile: forge-shell\n`);
-  const result = await runReleasePrepare(input({}), makeContext(dir));
-  expect(result.exitCode).toBe(1);
-  expect(result.summary).toContain("does not declare a release");
-  rmSync(dir, { recursive: true, force: true });
-});
-
-test("runReleasePrepare returns exit 1 when no active profile", async () => {
-  const dir = makeTempWorkspace();
-  const result = await runReleasePrepare(input({}), makeContext(dir));
-  expect(result.exitCode).toBe(1);
-  rmSync(dir, { recursive: true, force: true });
-});
-
-test("runReleasePrepare returns exit 1 when build output not found", async () => {
-  // No build/ directory created
-  const result = await runReleasePrepare(input({}), makeContext(tmpDir));
-  expect(result.exitCode).toBe(1);
-  expect(result.summary).toContain("no built output");
-});
-
-// ── runReleasePublish RFC-0680 ───────────────────────────────────────────────
-
-test("runReleasePublish --dry-run does not upload anything", async () => {
-  // Prepare a release first
-  mkdirSync(join(tmpDir, "bin"), { recursive: true });
-  writeFileSync(join(tmpDir, "bin", "Debug"), "fake-build-content");
-  await runReleasePrepare(input({}), makeContext(tmpDir));
-
-  const result = await runReleasePublish(input({ "dry-run": true }), makeContext(tmpDir));
-  expect(result.exitCode ?? 0).toBe(0);
-  expect(result.data?.target).toBe("local");
-  expect(result.data?.publishedFiles.length).toBeGreaterThan(0);
-  // Should not have created a published/ directory
-  expect(result.summary).toContain("[dry-run]");
-});
-
-test("runReleasePublish returns exit 1 when no manifest found", async () => {
-  // No release prepared — release dir doesn't exist
-  const result = await runReleasePublish(input({}), makeContext(tmpDir));
-  expect(result.exitCode).toBe(1);
-  expect(result.summary).toContain("No release manifest found");
-});
-
-test("runReleasePublish returns exit 1 when no active profile", async () => {
-  const dir = makeTempWorkspace();
-  const result = await runReleasePublish(input({}), makeContext(dir));
-  expect(result.exitCode).toBe(1);
-  rmSync(dir, { recursive: true, force: true });
-});