@warpgogol/forge 2.9.13 → 2.9.23

package/src/tests/plugin-manifest.test.ts

@@ -0,0 +1,226 @@
+import { test, expect, describe } from "vitest";
+import { forgePluginManifestSchema } from "../plugin/ForgePluginManifest.ts";
+
+describe("forgePluginManifestSchema (RFC-0941, RFC-0943)", () => {
+  test("accepts valid manifest with id and version", () => {
+    const result = forgePluginManifestSchema.safeParse({
+      id: "wg",
+      version: "1.0.0",
+    });
+    expect(result.success).toBe(true);
+  });
+
+  test("accepts hyphenated kebab-case id", () => {
+    const result = forgePluginManifestSchema.safeParse({
+      id: "my-cool-pack",
+      version: "0.1.0",
+    });
+    expect(result.success).toBe(true);
+  });
+
+  test("accepts semver pre-release version", () => {
+    const result = forgePluginManifestSchema.safeParse({
+      id: "wg",
+      version: "1.0.0-beta.1",
+    });
+    expect(result.success).toBe(true);
+  });
+
+  test("rejects missing id", () => {
+    const result = forgePluginManifestSchema.safeParse({
+      version: "1.0.0",
+    });
+    expect(result.success).toBe(false);
+  });
+
+  test("rejects missing version", () => {
+    const result = forgePluginManifestSchema.safeParse({
+      id: "wg",
+    });
+    expect(result.success).toBe(false);
+  });
+
+  test("rejects non-kebab-case id (uppercase)", () => {
+    const result = forgePluginManifestSchema.safeParse({
+      id: "Wg",
+      version: "1.0.0",
+    });
+    expect(result.success).toBe(false);
+  });
+
+  test("rejects id with underscores", () => {
+    const result = forgePluginManifestSchema.safeParse({
+      id: "my_pack",
+      version: "1.0.0",
+    });
+    expect(result.success).toBe(false);
+  });
+
+  test("rejects id starting with digit", () => {
+    const result = forgePluginManifestSchema.safeParse({
+      id: "1wg",
+      version: "1.0.0",
+    });
+    expect(result.success).toBe(false);
+  });
+
+  test("rejects invalid semver version", () => {
+    const result = forgePluginManifestSchema.safeParse({
+      id: "wg",
+      version: "1.0",
+    });
+    expect(result.success).toBe(false);
+  });
+
+  test("rejects extra fields (strict schema)", () => {
+    const result = forgePluginManifestSchema.safeParse({
+      id: "wg",
+      version: "1.0.0",
+      unexpectedField: true,
+    });
+    expect(result.success).toBe(false);
+  });
+
+  test("rejects non-string id", () => {
+    const result = forgePluginManifestSchema.safeParse({
+      id: 123,
+      version: "1.0.0",
+    });
+    expect(result.success).toBe(false);
+  });
+
+  test("rejects empty object", () => {
+    const result = forgePluginManifestSchema.safeParse({});
+    expect(result.success).toBe(false);
+  });
+
+  // RFC-0943: extensionPoints.compass.contract
+
+  test("accepts manifest with extensionPoints.compass.contract", () => {
+    const result = forgePluginManifestSchema.safeParse({
+      id: "wg",
+      version: "1.0.0",
+      extensionPoints: {
+        compass: {
+          contract: {
+            blocks: [
+              {
+                blockId: "api-contract",
+                requiredFor: ["packages/my-pack/**/*.ts"],
+              },
+            ],
+          },
+        },
+      },
+    });
+    expect(result.success).toBe(true);
+  });
+
+  test("accepts manifest with extensionPoints.compass.contract and requiredTags", () => {
+    const result = forgePluginManifestSchema.safeParse({
+      id: "wg",
+      version: "1.0.0",
+      extensionPoints: {
+        compass: {
+          contract: {
+            blocks: [
+              {
+                blockId: "api-contract",
+                requiredFor: ["packages/my-pack/**/*.ts"],
+                requiredTags: [{ name: "endpoints", minWords: 5 }],
+              },
+            ],
+          },
+        },
+      },
+    });
+    expect(result.success).toBe(true);
+  });
+
+  test("accepts manifest with empty extensionPoints.compass.contract.blocks", () => {
+    const result = forgePluginManifestSchema.safeParse({
+      id: "wg",
+      version: "1.0.0",
+      extensionPoints: {
+        compass: {
+          contract: {
+            blocks: [],
+          },
+        },
+      },
+    });
+    expect(result.success).toBe(true);
+  });
+
+  test("rejects extensionPoints.compass.contract with non-kebab-case blockId", () => {
+    const result = forgePluginManifestSchema.safeParse({
+      id: "wg",
+      version: "1.0.0",
+      extensionPoints: {
+        compass: {
+          contract: {
+            blocks: [
+              {
+                blockId: "API_Contract",
+                requiredFor: ["packages/**/*.ts"],
+              },
+            ],
+          },
+        },
+      },
+    });
+    expect(result.success).toBe(false);
+  });
+
+  test("rejects extensionPoints.compass.contract with empty requiredFor", () => {
+    const result = forgePluginManifestSchema.safeParse({
+      id: "wg",
+      version: "1.0.0",
+      extensionPoints: {
+        compass: {
+          contract: {
+            blocks: [
+              {
+                blockId: "api-contract",
+                requiredFor: [],
+              },
+            ],
+          },
+        },
+      },
+    });
+    expect(result.success).toBe(false);
+  });
+
+  test("rejects extensionPoints.compass.contract with negative minWords", () => {
+    const result = forgePluginManifestSchema.safeParse({
+      id: "wg",
+      version: "1.0.0",
+      extensionPoints: {
+        compass: {
+          contract: {
+            blocks: [
+              {
+                blockId: "api-contract",
+                requiredFor: ["packages/**/*.ts"],
+                requiredTags: [{ name: "endpoints", minWords: -1 }],
+              },
+            ],
+          },
+        },
+      },
+    });
+    expect(result.success).toBe(false);
+  });
+
+  test("rejects extensionPoints with unknown extension point key", () => {
+    const result = forgePluginManifestSchema.safeParse({
+      id: "wg",
+      version: "1.0.0",
+      extensionPoints: {
+        unknown: { foo: "bar" },
+      },
+    });
+    expect(result.success).toBe(false);
+  });
+});

package/src/tests/upgrade.test.ts

@@ -253,6 +253,11 @@ test("RFC-0552: forge.upgrade returns skippedSkills field and syncs non-conflict
     "---\nname: wg-custom\n---\n# wg-custom (should be synced)\n",
     "utf8",
   );
+  await writeFile(
+    join(tempDir, "packages", "wg-skills", "skills", "forge.plugin.yaml"),
+    "id: wg-skills\nversion: 1.0.0\n",
+    "utf8",
+  );
 
   // Write forge.yaml with skillPacks config and null syncedVersion
   const yaml = `schema: forge/config@1

package/src/validators/port-validate.ts

@@ -22,10 +22,10 @@ interface PortValidateResult {
 
 // RFC-0556: removed @warpgogol/site-kernel-checks and @warpgogol/site-kernel-handoff
 // from this list — os/compass and os/werkstatt no longer import them (handlers inlined).
-// RFC-0776: @warpgogol/site-kernel replaced by @warpgogol/werkstatt/kernel.
-// @warpgogol/werkstatt/kernel remains forbidden for src/ portability.
+// RFC-0776: @warpgogol/site-kernel replaced by @warpgogol/werkstatt-engine/kernel.
+// @warpgogol/werkstatt-engine/kernel remains forbidden for src/ portability.
 const FORBIDDEN_IMPORTS = [
-  "@warpgogol/werkstatt/kernel",
+  "@warpgogol/werkstatt-engine/kernel",
   "@warpgogol/werkstatt-site/ui",
   "@warpgogol/werkstatt-shared/share/page",
 ];