@warpgogol/forge 0.24.0 → 0.26.0

package/skills/fo/fo-idea-plan/SKILL.md

@@ -70,7 +70,7 @@ If the RFC is `draft` or `reviewing` and has `enhancedAt` — the user's instruc
    rfc: accept RFC-XXXX <short title>
 
    Transition RFC-XXXX to accepted status for planning.
-   ```
+```
 
 5. Stage only the RFC file.
 
@@ -143,7 +143,7 @@ Step ordering follows the contract-first pattern:
 5. **Validation** — run `rfc.validate`, `build:check`, acceptance probes.
 6. **Evidence** — run `rfc.verification.emit`, commit evidence file.
 7. **Review & Fix** — `fo-review` on all session code changes, `fo-fix` if findings (MANDATORY — do not omit from the plan).
-8. **Stamp implemented** — run `rfc.implement.stamp --id RFC-XXXX --implementation-commit <sha>` to transition `accepted → implemented` (RFC). For ADRs, manually set `status: implemented` and `implementedAt` per `fo-idea-implement` step 4.10.
+8. **Stamp implemented** — run `rfc.implement.stamp --id RFC-XXXX --implementation-commit <sha>` to transition `accepted → implemented` (RFC). For ADRs, run `adr.implement.stamp --id ADR-XXXX --implementation-commit <sha>` per `fo-idea-implement` step 4.10.
 
 Mark **human review points** on steps that:
 

package/skills/fo/fo-review/SKILL.md

@@ -97,6 +97,7 @@ Beyond what the mechanical floor catches:
 - **No magic numbers or untyped data** — flag literal constants that should be named, enums, or config; flag strings standing in for domain concepts.
 - **Minimalism** — flag over-engineered abstractions, speculative generality, duplicated logic, or middle-man modules that can be simplified.
 - **Dead code** — flag unreachable branches, unused exports, commented-out code blocks.
+- **Unjustified removals** — flag any deletion (field, prop, function, config entry, schema property) where the diff does not show investigation of why the artifact was added. Read `_shared/fo-pipeline-conventions.md` §Removal discipline. A validation error is not justification for removal — it's justification for schema extension. Check `git log`, RFCs, and ADRs for the artifact's origin before accepting the deletion.
 - **Error handling** — flag swallowed errors, bare `catch` blocks without context, missing error types.
 - **Fowler code smells** — the following baseline (from _Refactoring_, ch.3) applies always, even when a repo documents nothing. Each smell is a labelled heuristic ("possible Feature Envy"), never a hard violation. A documented repo standard overrides the baseline; skip anything tooling already enforces.
   - **Mysterious Name** — a function, variable, or type whose name doesn't reveal what it does or holds. → rename it; if no honest name comes, the design's murky.