@warlock.js/cascade 5.25.0 → 5.26.0

package/esm/migration/migration.mjs

@@ -1,5 +1,6 @@
 import { ColumnBuilder } from "./column-builder.mjs";
 import { ForeignKeyBuilder } from "./foreign-key-builder.mjs";
+import { log } from "@warlock.js/logger";
 
 //#region ../cascade/src/migration/migration.ts
 /**
@@ -244,6 +245,7 @@ var Migration = class {
 	* @internal
 	*/
 	async execute() {
+		this.assertNoGeneratedIndexNameCollisions();
 		for (const op of this.pendingOperations) await this.executeOperation(op);
 		this.pendingOperations.length = 0;
 	}
@@ -280,6 +282,7 @@ var Migration = class {
 	* @internal
 	*/
 	toSteps() {
+		this.assertNoGeneratedIndexNameCollisions();
 		const serializer = this.driver.driver.getSQLSerializer();
 		const steps = [];
 		let schemaRun = [];
@@ -427,6 +430,40 @@ var Migration = class {
 		}
 	}
 	/**
+	* Reject two unnamed indexes that a driver would give the same name before
+	* either DDL command is sent. MongoDB's default names include directions;
+	* PostgreSQL's include the table and columns.
+	*/
+	assertNoGeneratedIndexNameCollisions() {
+		const engine = this.databaseEngine;
+		if (engine !== "mongodb" && engine !== "postgres") return;
+		const unnamedIndexes = this.pendingOperations.flatMap((operation) => {
+			if (operation.type === "createIndex") {
+				const index = operation.payload;
+				return index.name ? [] : [index];
+			}
+			if (operation.type === "createUniqueIndex") {
+				const { columns, name } = operation.payload;
+				return name ? [] : [{
+					columns,
+					unique: true
+				}];
+			}
+			return [];
+		});
+		const seen = /* @__PURE__ */ new Map();
+		for (const index of unnamedIndexes) {
+			const generatedName = engine === "mongodb" ? index.columns.map((column, i) => `${column}_${index.directions?.[i] === "desc" ? -1 : 1}`).join("_") : `idx_${this.table}_${index.columns.join("_")}`;
+			const first = seen.get(generatedName);
+			if (first) throw new Error(`Migration queued two ${engine} indexes with the generated name "${generatedName}": ${this.describeIndex(first)} and ${this.describeIndex(index)}. Give one index an explicit name, for example { name: "..." }.`);
+			seen.set(generatedName, index);
+		}
+	}
+	describeIndex(index) {
+		const partial = index.where ? JSON.stringify(index.where) : "none";
+		return `columns [${index.columns.join(", ")}] (unique: ${!!index.unique}, partial: ${partial})`;
+	}
+	/**
 	* Check if a table exists.
 	*
 	* Useful for conditional migrations and idempotent operations.
@@ -2133,13 +2170,18 @@ Migration.create = function createMigration(model, columns, options = {}) {
 */
 Migration.alter = function alterMigration(model, schema, options = {}) {
 	const { order = 0, createdAt, transactional } = options;
-	return class AlterMigration extends Migration {
+	let missingDownWarningEmitted = false;
+	class AlterMigration extends Migration {
 		static order = order;
 		static createdAt = createdAt;
 		static transactional = transactional;
 		table = model.table;
 		dataSource = model.dataSource;
 		async up() {
+			if (options.up && !options.down && !missingDownWarningEmitted) {
+				missingDownWarningEmitted = true;
+				log.warn("database", "migration", `Migration "${AlterMigration.migrationName ?? this.table}" defines a custom up() without a down() rollback.`);
+			}
 			if (schema.add) wireColumns(this, schema.add);
 			if (schema.drop) for (const col of schema.drop) this.dropColumn(col);
 			if (schema.rename) for (const [from, to] of Object.entries(schema.rename)) this.renameColumn(from, to);
@@ -2192,7 +2234,8 @@ Migration.alter = function alterMigration(model, schema, options = {}) {
 		async down() {
 			if (options.down) await options.down.call(this);
 		}
-	};
+	}
+	return AlterMigration;
 };
 Migration.__declarativeFactoriesAttached = true;