@warlock.js/cascade 5.16.0 → 5.17.1

package/cjs/index.cjs

@@ -411,6 +411,42 @@ var TransactionRollbackError = class TransactionRollbackError extends Error {
 	}
 };
 
+//#endregion
+//#region ../cascade/src/errors/undefined-where-value.error.ts
+/**
+* Error thrown when a `where()`-family call is given `undefined` as the
+* bound value.
+*
+* A bound `undefined` reaches SQL drivers as `= NULL`, which never matches
+* any row (SQL's three-valued logic — `NULL = NULL` is `NULL`, not `true`) —
+* and reaches the MongoDB driver as a filter that matches every document
+* missing the field. Either way the query silently returns the wrong rows
+* instead of failing loudly, which usually means the caller forgot to guard
+* an id/value that turned out to be missing (e.g. `User.find(post.authorId)`
+* when `authorId` came back `undefined`).
+*
+* To match `NULL` explicitly, pass `null` — `where("deletedAt", null)` is a
+* valid, intentional query. To skip the query entirely when there's no
+* value, guard the call site instead of calling `where()`.
+*/
+var UndefinedWhereValueError = class UndefinedWhereValueError extends Error {
+	/**
+	* The field whose value was `undefined`.
+	*/
+	field;
+	/**
+	* Creates a new UndefinedWhereValueError.
+	*
+	* @param field - The field name whose value was rejected
+	*/
+	constructor(field) {
+		super(`where("${field}", undefined) — a bound "undefined" value silently becomes a NULL comparison that never matches, hiding the real bug. Pass null to match NULL explicitly, or skip the query when there's no value for "${field}".`);
+		this.name = "UndefinedWhereValueError";
+		this.field = field;
+		if (Error.captureStackTrace) Error.captureStackTrace(this, UndefinedWhereValueError);
+	}
+};
+
 //#endregion
 //#region ../cascade/src/errors/unsafe-filter.error.ts
 /**
@@ -3504,32 +3540,51 @@ const assertNoOperatorKeys = (value, field) => {
 	}
 };
 /**
-* Assert a single equality-position value carries no `$`-prefixed keys.
-* Scalars, `Date`s and other non-plain objects pass through untouched;
-* plain objects/arrays are checked recursively.
+* Reject a bound `undefined` value in an equality position. `undefined`
+* silently becomes `= NULL` (SQL) / "field missing" (MongoDB) — a query that
+* never matches what the caller meant, instead of failing loudly. `null` is
+* the explicit, intentional way to match NULL and is never rejected here.
+*
+* @param value - The equality value to check
+* @param field - The field name, used for the error message
+* @throws UndefinedWhereValueError when `value` is `undefined`
+*/
+const assertDefined = (value, field) => {
+	if (value === void 0) throw new UndefinedWhereValueError(field);
+};
+/**
+* Assert a single equality-position value carries no `$`-prefixed keys and
+* is not `undefined`. Scalars, `Date`s and other non-plain objects pass
+* through untouched; plain objects/arrays are checked recursively for
+* operator keys.
 *
 * @param value - The equality value to check
 * @param field - The field name, used for the error message
 * @returns The value, unchanged
 * @throws UnsafeFilterError when a `$`-prefixed key is found
+* @throws UndefinedWhereValueError when `value` is `undefined`
 */
 function sanitizeFilterValue(value, field) {
+	assertDefined(value, field);
 	assertNoOperatorKeys(value, field);
 	return value;
 }
 /**
 * Assert a `{ field: value }` equality filter carries no `$`-prefixed keys —
 * neither as top-level field names (`{ $where: … }`) nor inside any value
-* (`{ password: { $ne: null } }`). Dotted field paths ("profile.name") and
-* plain nested documents remain valid.
+* (`{ password: { $ne: null } }`) — and that no field's value is `undefined`.
+* Dotted field paths ("profile.name") and plain nested documents remain
+* valid.
 *
 * @param filter - The filter object to check
 * @returns The filter, unchanged
 * @throws UnsafeFilterError when a `$`-prefixed key is found
+* @throws UndefinedWhereValueError when a field's value is `undefined`
 */
 function sanitizeFilter(filter) {
 	for (const [field, value] of Object.entries(filter)) {
 		if (field.startsWith("$")) rejectOperatorKey(field, field);
+		assertDefined(value, field);
 		assertNoOperatorKeys(value, field);
 	}
 	return filter;
@@ -8887,11 +8942,17 @@ var QueryBuilder = class QueryBuilder {
 			operator: "=",
 			value: sanitizeFilterValue(args[1], String(args[0]))
 		});
-		else this.addOperation("where", {
-			field: args[0],
-			operator: args[1],
-			value: args[1] === "=" ? sanitizeFilterValue(args[2], String(args[0])) : args[2]
-		});
+		else {
+			const field = String(args[0]);
+			const operator = args[1];
+			const value = operator === "=" ? sanitizeFilterValue(args[2], field) : args[2];
+			if (operator !== "=") assertDefined(value, field);
+			this.addOperation("where", {
+				field: args[0],
+				operator,
+				value
+			});
+		}
 		return this;
 	}
 	orWhere(...args) {
@@ -8909,11 +8970,17 @@ var QueryBuilder = class QueryBuilder {
 			operator: "=",
 			value: sanitizeFilterValue(args[1], String(args[0]))
 		});
-		else this.addOperation("orWhere", {
-			field: args[0],
-			operator: args[1],
-			value: args[1] === "=" ? sanitizeFilterValue(args[2], String(args[0])) : args[2]
-		});
+		else {
+			const field = String(args[0]);
+			const operator = args[1];
+			const value = operator === "=" ? sanitizeFilterValue(args[2], field) : args[2];
+			if (operator !== "=") assertDefined(value, field);
+			this.addOperation("orWhere", {
+				field: args[0],
+				operator,
+				value
+			});
+		}
 		return this;
 	}
 	/**
@@ -12150,11 +12217,17 @@ var MongoQueryBuilder = class MongoQueryBuilder extends QueryBuilder {
 			operator: "=",
 			value: sanitizeFilterValue(args[1], String(args[0]))
 		});
-		else if (args.length === 3) this.operationsHelper.addMatchOperation(prefix, {
-			field: args[0],
-			operator: args[1],
-			value: args[1] === "=" ? sanitizeFilterValue(args[2], String(args[0])) : args[2]
-		});
+		else if (args.length === 3) {
+			const field = String(args[0]);
+			const operator = args[1];
+			const value = operator === "=" ? sanitizeFilterValue(args[2], field) : args[2];
+			if (operator !== "=") assertDefined(value, field);
+			this.operationsHelper.addMatchOperation(prefix, {
+				field: args[0],
+				operator,
+				value
+			});
+		}
 	}
 	/**
 	* Internal helper for adding raw where clauses.
@@ -17898,7 +17971,8 @@ function buildPostgresPoolConfig(config) {
 		max: config.max ?? 10,
 		min: config.min ?? 0,
 		idleTimeoutMillis: config.idleTimeoutMillis ?? 3e4,
-		connectionTimeoutMillis: config.connectionTimeoutMillis ?? 2e3,
+		connectionTimeoutMillis: config.connectionTimeoutMillis ?? 1e4,
+		keepAlive: config.keepAlive ?? true,
 		application_name: config.application_name ?? "cascade",
 		ssl: config.ssl
 	};
@@ -18072,6 +18146,9 @@ var PostgresDriver = class {
 			const poolConfig = buildPostgresPoolConfig(this.config);
 			_warlock_js_logger.log.info("database.postgres", "connection", `Connecting to database ${_mongez_copper.colors.bold(_mongez_copper.colors.yellowBright(poolConfig.database ?? ""))}`);
 			this._pool = new pg.Pool(poolConfig);
+			this._pool.on("error", (error) => {
+				_warlock_js_logger.log.error("database.postgres", "pool", `Unexpected error on an idle client: ${error.message}`);
+			});
 			(await this._pool.connect()).release();
 			_warlock_js_logger.log.success("database.postgres", "connection", `Connected to database ${_mongez_copper.colors.bold(_mongez_copper.colors.yellowBright(this.config.database))}`);
 			this._isConnected = true;
@@ -18595,19 +18672,34 @@ var PostgresDriver = class {
 	*/
 	async beginTransaction(options) {
 		const client = await this.pool.connect();
-		let beginSql = "BEGIN";
-		if (options?.isolationLevel) beginSql += ` ISOLATION LEVEL ${options.isolationLevel.toUpperCase()}`;
-		if (options?.readOnly) beginSql += " READ ONLY";
-		if (options?.deferrable) beginSql += " DEFERRABLE";
-		await client.query(beginSql);
+		try {
+			let beginSql = "BEGIN";
+			if (options?.isolationLevel) beginSql += ` ISOLATION LEVEL ${options.isolationLevel.toUpperCase()}`;
+			if (options?.readOnly) beginSql += " READ ONLY";
+			if (options?.deferrable) beginSql += " DEFERRABLE";
+			await client.query(beginSql);
+		} catch (error) {
+			client.release(error instanceof Error ? error : new Error(String(error)));
+			throw error;
+		}
 		return {
 			context: client,
 			commit: async () => {
-				await client.query("COMMIT");
+				try {
+					await client.query("COMMIT");
+				} catch (error) {
+					client.release(error instanceof Error ? error : new Error(String(error)));
+					throw error;
+				}
 				client.release();
 			},
 			rollback: async () => {
-				await client.query("ROLLBACK");
+				try {
+					await client.query("ROLLBACK");
+				} catch (error) {
+					client.release(error instanceof Error ? error : new Error(String(error)));
+					throw error;
+				}
 				client.release();
 			}
 		};
@@ -18630,13 +18722,20 @@ var PostgresDriver = class {
 		if (databaseTransactionContext.hasActiveTransaction()) return fn(ctx);
 		const tx = await this.beginTransaction(options);
 		databaseTransactionContext.enter({ session: tx.context });
+		let commitStarted = false;
 		try {
 			const result = await fn(ctx);
+			commitStarted = true;
 			await tx.commit();
 			return result;
 		} catch (error) {
-			await tx.rollback();
-			_warlock_js_logger.log.error(`database.postgress`, "transaction", "Transaction operation failed, rolled back everything");
+			if (commitStarted) _warlock_js_logger.log.error(`database.postgress`, "transaction", "Transaction COMMIT failed; client discarded, no rollback issued");
+			else try {
+				await tx.rollback();
+				_warlock_js_logger.log.error(`database.postgress`, "transaction", "Transaction operation failed, rolled back everything");
+			} catch (rollbackError) {
+				_warlock_js_logger.log.error(`database.postgress`, "transaction", rollbackError);
+			}
 			throw error;
 		} finally {
 			databaseTransactionContext.exit();
@@ -23653,6 +23752,7 @@ exports.RelationLoader = RelationLoader;
 exports.SyncContextManager = SyncContextManager;
 exports.SyncManager = SyncManager;
 exports.TransactionRollbackError = TransactionRollbackError;
+exports.UndefinedWhereValueError = UndefinedWhereValueError;
 exports.UnsafeFilterError = UnsafeFilterError;
 exports.UnsafeRawExpressionError = UnsafeRawExpressionError;
 exports.UnsupportedLeanOperationError = UnsupportedLeanOperationError;
@@ -23668,6 +23768,7 @@ exports.arrayJson = arrayJson;
 exports.arrayText = arrayText;
 exports.arrayTimestamp = arrayTimestamp;
 exports.arrayUuid = arrayUuid;
+exports.assertDefined = assertDefined;
 exports.bigInt = bigInt;
 exports.bigInteger = bigInteger;
 exports.binary = binary;