@wardby/cli 0.5.3 → 0.7.0

package/dist/core/merge-order-check.js

@@ -0,0 +1,343 @@
+import { CODING_CODE_PROVIDER, normalizeGitHubRepository } from "../coding/protocol.js";
+import { logger } from "./logger.js";
+import { maybeMarkReady } from "./mark-ready.js";
+import { collectRelatedPullRequests, runTreeRoot } from "./related-pull-requests.js";
+const moduleLog = logger.child({ module: "merge-order-check" });
+export const MERGE_ORDER_CHECK_NAME = "wardby merge order";
+/**
+ * `set` may include or omit `self`: self's own order always counts toward
+ * the distinct orders, and self is never its own dependency (dependencies
+ * have a strictly lower order). `self` need not be the same object instance
+ * as its entry in `set`; only `mergeOrder` is read from it.
+ */
+export function mergeOrderVerdict(self, set) {
+    const distinctOrders = new Set();
+    if (self.mergeOrder !== null)
+        distinctOrders.add(self.mergeOrder);
+    for (const m of set)
+        if (m.mergeOrder !== null)
+            distinctOrders.add(m.mergeOrder);
+    if (distinctOrders.size < 2)
+        return { status: "skip" };
+    if (self.mergeOrder === null)
+        return { status: "skip" };
+    const selfOrder = self.mergeOrder;
+    const dependencies = set.filter((m) => m.mergeOrder !== null && m.mergeOrder < selfOrder);
+    const closedUnmerged = dependencies.filter((m) => m.state === "closed");
+    if (closedUnmerged.length > 0)
+        return { status: "failure", closedUnmerged };
+    const waitingFor = dependencies.filter((m) => m.state !== "merged");
+    if (waitingFor.length > 0)
+        return { status: "in_progress", waitingFor };
+    return { status: "success", dependencies };
+}
+const prUrl = (repository, number) => `https://github.com/${repository}/pull/${number}`;
+/** `repository#number` as a link: never a title or any other free text from the host. */
+const prLink = (m) => `[${m.repository}#${m.number}](${prUrl(m.repository, m.number)})`;
+const keyOf = (repository, number) => `${repository}#${number}`;
+function safeRepository(value) {
+    try {
+        return normalizeGitHubRepository(value);
+    }
+    catch {
+        return undefined;
+    }
+}
+function originState(origin) {
+    if (origin.merged)
+        return "merged";
+    if (origin.state !== "open")
+        return "closed";
+    return origin.draft ? "draft" : "open";
+}
+/**
+ * The check run's text for one verdict: step label, then the pull requests
+ * it depends on, as links. While the delegating run is still running
+ * (`leadRunning`) it may still add or reorder steps, so a success for any
+ * step above the set's lowest is posted as in_progress, waiting for it.
+ */
+export function mergeOrderCheckInput(self, verdict, steps, headSha, leadRunning = false) {
+    const step = `Step ${steps.indexOf(self.mergeOrder) + 1} of ${steps.length} in the merge order set by the delegating agent.`;
+    const base = { headSha, name: MERGE_ORDER_CHECK_NAME };
+    const lines = (members) => members.map(prLink).join(", ");
+    if (verdict.status === "success" && leadRunning && self.mergeOrder !== steps[0]) {
+        return {
+            ...base,
+            status: "in_progress",
+            title: "Waiting for the delegating run to finish",
+            summary: `${step}\n\nEvery earlier step has merged, but the delegating run is still running and may change ` +
+                `the steps; waiting for it to finish.` +
+                (verdict.dependencies.length > 0 ? `\n\nMerged: ${lines(verdict.dependencies)}` : ""),
+        };
+    }
+    switch (verdict.status) {
+        case "success":
+            return {
+                ...base,
+                status: "completed",
+                conclusion: "success",
+                title: verdict.dependencies.length > 0 ? "Every earlier step has merged" : "First step: nothing to wait for",
+                summary: verdict.dependencies.length > 0 ? `${step}\n\nMerged: ${lines(verdict.dependencies)}` : step,
+            };
+        case "failure":
+            return {
+                ...base,
+                status: "completed",
+                conclusion: "failure",
+                title: "An earlier step was closed without merging",
+                summary: `${step}\n\nClosed without merging: ${lines(verdict.closedUnmerged)}`,
+            };
+        case "in_progress":
+            return {
+                ...base,
+                status: "in_progress",
+                title: `Waiting for ${verdict.waitingFor.length} earlier pull request${verdict.waitingFor.length === 1 ? "" : "s"} to merge`,
+                summary: `${step}\n\nWaiting for: ${lines(verdict.waitingFor)}`,
+            };
+    }
+}
+/**
+ * Recomputes and posts the `wardby merge order` check on every open (or
+ * draft) pull request of the set `seedRunId` belongs to (any run of the
+ * request's tree). Nothing happens unless the set has more than one
+ * distinct merge order. Each member's state is read live from the host
+ * (a stored "merged" is final and not re-read); the check is posted only on
+ * an open or draft pull request the App opened whose marker names a coding
+ * run this deployment recorded for that repository, on its current head.
+ * A member that can't be read holds back only the checks that depend on it.
+ * Never throws.
+ */
+export async function syncMergeOrderChecks(deps, seedRunId, opts = {}) {
+    const log = deps.log ?? moduleLog;
+    const host = deps.hosts?.[CODING_CODE_PROVIDER];
+    if (!host?.upsertNamedCheck || !host.pullRequestOrigin)
+        return;
+    try {
+        const group = await collectRelatedPullRequests(deps.db, seedRunId);
+        if (opts.synced) {
+            const setKey = group.pullRequests
+                .map((pr) => keyOf(pr.repository, pr.number))
+                .sort()
+                .join("\n");
+            if (opts.synced.has(setKey))
+                return;
+            opts.synced.add(setKey);
+        }
+        const steps = [
+            ...new Set(group.pullRequests.flatMap((pr) => (pr.mergeOrder !== undefined ? [pr.mergeOrder] : []))),
+        ].sort((a, b) => a - b);
+        if (steps.length < 2)
+            return;
+        // A property of the set, whichever root it was seeded from: only a native lead (a root that is
+        // not itself a coding run) declares merge order, so only one still running may change steps. A
+        // top-level coding run that continued one of the PRs never holds the check: its own later pushes
+        // re-sync through pr_updated, and nothing re-syncs when it ends.
+        const leadRunning = (group.roots ?? []).some((r) => !r.codingRun && (r.status === "pending" || r.status === "running"));
+        const reused = opts.origin ? safeRepository(opts.origin.repository) : undefined;
+        const closed = opts.closed ? safeRepository(opts.closed.repository) : undefined;
+        const members = [];
+        // Bounded by the collector's MAX_RELATED_GROUP: at most one read per member.
+        for (const pr of group.pullRequests) {
+            const base = { repository: pr.repository, number: pr.number, mergeOrder: pr.mergeOrder ?? null };
+            const key = keyOf(pr.repository, pr.number);
+            if (closed && key === keyOf(closed, opts.closed.number)) {
+                members.push({ member: { ...base, state: opts.closed.merged ? "merged" : "closed" }, known: true });
+                continue;
+            }
+            if (pr.state === "merged") {
+                members.push({ member: { ...base, state: "merged" }, known: true });
+                continue;
+            }
+            // No order: never a dependency and never checked, so its state is never needed: no read.
+            if (base.mergeOrder === null) {
+                members.push({ member: { ...base, state: "open" }, known: true });
+                continue;
+            }
+            try {
+                const origin = reused && key === keyOf(reused, opts.origin.number)
+                    ? await opts.origin.read()
+                    : await host.pullRequestOrigin(pr.repository, pr.number);
+                let headSha;
+                if (origin.markerRunId) {
+                    const opener = await deps.db.codingRun.findUnique({
+                        where: { runId: origin.markerRunId },
+                        select: { repository: true },
+                    });
+                    if (opener && opener.repository.toLowerCase() === pr.repository)
+                        headSha = origin.headSha;
+                }
+                members.push({ member: { ...base, state: originState(origin) }, known: true, ...(headSha ? { headSha } : {}) });
+            }
+            catch (err) {
+                log.warn({ err, seedRunId, repository: pr.repository, number: pr.number }, "could not read a pull request of a merge-ordered set");
+                members.push({ member: { ...base, state: "open" }, known: false });
+            }
+        }
+        const set = members.map((m) => m.member);
+        for (const target of members) {
+            const self = target.member;
+            if (!target.headSha || self.mergeOrder === null || (self.state !== "open" && self.state !== "draft"))
+                continue;
+            const order = self.mergeOrder;
+            if (members.some((m) => !m.known && m.member.mergeOrder !== null && m.member.mergeOrder < order)) {
+                log.info({ seedRunId, repository: self.repository, number: self.number }, "merge order check left as is: an earlier step could not be read");
+                continue;
+            }
+            const verdict = mergeOrderVerdict(self, set);
+            if (verdict.status === "skip")
+                continue;
+            const input = mergeOrderCheckInput(self, verdict, steps, target.headSha, leadRunning);
+            try {
+                await host.upsertNamedCheck(self.repository, input);
+                log.info({ seedRunId, repository: self.repository, number: self.number, status: verdict.status }, "merge order check posted");
+            }
+            catch (err) {
+                log.warn({ err, seedRunId, repository: self.repository, number: self.number }, "could not post the merge order check");
+                continue;
+            }
+            if (input.status === "completed" && input.conclusion === "success") {
+                // The last earlier step merged: the pull request may now be ready for review (#287).
+                await maybeMarkReady({ db: deps.db, hosts: deps.hosts, log: deps.log }, self.repository, self.number);
+            }
+        }
+    }
+    catch (err) {
+        log.warn({ err, seedRunId }, "could not sync the merge order checks");
+    }
+}
+/**
+ * At a run's end: a tree root (the lead) that delegated anything syncs its
+ * set. A run that delegated nothing costs one indexed lookup. Never throws.
+ */
+export async function syncMergeOrderChecksAfterRun(deps, run) {
+    if (run.parentRunId !== null)
+        return;
+    const host = deps.hosts?.[CODING_CODE_PROVIDER];
+    if (!host?.upsertNamedCheck || !host.pullRequestOrigin)
+        return;
+    try {
+        if (!(await deps.db.run.findFirst({ where: { parentRunId: run.id }, select: { id: true } })))
+            return;
+    }
+    catch (err) {
+        (deps.log ?? moduleLog).warn({ err, runId: run.id }, "could not sync the merge order checks");
+        return;
+    }
+    await syncMergeOrderChecks(deps, run.id);
+}
+/** Most coding runs (seeds) looked up per pull request event or sweep pass. */
+const MAX_SEEDS = 20;
+/** Coding runs with a merge order whose outcome is pull request `repository#number`. */
+async function orderedSeeds(db, repository, number) {
+    const rows = await db.$queryRaw `
+    SELECT cr."runId"
+    FROM "CodingRun" cr
+    WHERE cr."mergeOrder" IS NOT NULL
+      AND lower(cr."repository") = lower(${repository})
+      AND cr."result"->>'outcome' IN ('pull_request_opened', 'pull_request_updated')
+      AND lower(cr."result"->>'repository') = lower(${repository})
+      AND cr."result"->>'pullRequestNumber' = ${String(number)}
+    ORDER BY cr."updatedAt" DESC
+    LIMIT ${MAX_SEEDS}`;
+    return rows.map((r) => r.runId);
+}
+/**
+ * A pull request closed or got a new head: syncs every set it is an
+ * ordered member of. Only a pull request a coding run with a merge order
+ * opened or continued can change any verdict (a member without an order is
+ * no one's dependency and gets no check), so anything else costs one query
+ * and no host call. Never throws.
+ */
+export async function syncMergeOrderChecksForPullRequest(deps, pr, opts = {}) {
+    const log = deps.log ?? moduleLog;
+    const host = deps.hosts?.[CODING_CODE_PROVIDER];
+    if (!host?.upsertNamedCheck || !host.pullRequestOrigin)
+        return;
+    const repository = safeRepository(pr.repository);
+    if (!repository || !Number.isSafeInteger(pr.number) || pr.number <= 0)
+        return;
+    let roots;
+    try {
+        roots = [];
+        for (const seed of await orderedSeeds(deps.db, repository, pr.number)) {
+            const root = await runTreeRoot(deps.db, seed, repository);
+            if (root && !roots.some((r) => r.id === root.id))
+                roots.push(root);
+        }
+    }
+    catch (err) {
+        log.warn({ err, repository, number: pr.number }, "could not find the merge-ordered sets of a pull request");
+        return;
+    }
+    const synced = new Set();
+    for (const root of roots)
+        await syncMergeOrderChecks(deps, root.id, { ...opts, synced });
+}
+/** The sweep runs at most this often per process (the reconciler ticks every 15 s). */
+export const MERGE_ORDER_SWEEP_INTERVAL_MS = 10 * 60_000;
+/** Coding runs with a merge order updated within this long are swept. */
+export const MERGE_ORDER_SWEEP_MAX_AGE_MS = 7 * 24 * 60 * 60_000;
+/** Most coding runs read per sweep pass. */
+const MERGE_ORDER_SWEEP_SEEDS = 50;
+/** Most sets synced per sweep pass; the least recently synced go first. */
+export const MERGE_ORDER_SWEEP_BATCH = 10;
+let lastSweepAt = Number.NEGATIVE_INFINITY;
+/** Root run id -> when this process last swept it: rotates the batch across passes. */
+const lastSyncedAt = new Map();
+export function resetMergeOrderSweepForTests() {
+    lastSweepAt = Number.NEGATIVE_INFINITY;
+    lastSyncedAt.clear();
+}
+/**
+ * The reconciler's half, for missed pr_closed/pr_updated events: syncs the
+ * sets of pull requests that coding runs with a merge order opened or
+ * continued in the last 7 days, a bounded batch per pass, at most once per
+ * MERGE_ORDER_SWEEP_INTERVAL_MS per process. Returns the number of sets
+ * synced. Never throws.
+ */
+export async function sweepMergeOrderChecks(deps, now = new Date()) {
+    const log = deps.log ?? moduleLog;
+    const host = deps.hosts?.[CODING_CODE_PROVIDER];
+    if (!host?.upsertNamedCheck || !host.pullRequestOrigin)
+        return 0;
+    if (now.getTime() - lastSweepAt < MERGE_ORDER_SWEEP_INTERVAL_MS)
+        return 0;
+    lastSweepAt = now.getTime();
+    const since = new Date(now.getTime() - MERGE_ORDER_SWEEP_MAX_AGE_MS);
+    for (const [root, at] of lastSyncedAt)
+        if (at < since.getTime())
+            lastSyncedAt.delete(root);
+    let roots;
+    try {
+        // Covers the MERGE_ORDER_SWEEP_SEEDS most recently updated coding runs with a merge order
+        // within the last 7 days; older sets rely on their pr_closed/pr_updated events alone.
+        const rows = await deps.db.$queryRaw `
+      SELECT cr."runId", cr."repository"
+      FROM "CodingRun" cr
+      WHERE cr."mergeOrder" IS NOT NULL
+        AND cr."updatedAt" >= ${since}
+        AND cr."result"->>'outcome' IN ('pull_request_opened', 'pull_request_updated')
+      ORDER BY cr."updatedAt" DESC
+      LIMIT ${MERGE_ORDER_SWEEP_SEEDS}`;
+        roots = [];
+        for (const row of rows) {
+            const root = await runTreeRoot(deps.db, row.runId, row.repository);
+            if (root && !roots.some((r) => r.id === root.id))
+                roots.push(root);
+        }
+    }
+    catch (err) {
+        log.warn({ err }, "merge order check sweep failed");
+        return 0;
+    }
+    const batch = roots
+        .map((root, index) => ({ root, index, at: lastSyncedAt.get(root.id) ?? Number.NEGATIVE_INFINITY }))
+        .sort((a, b) => a.at - b.at || a.index - b.index)
+        .slice(0, MERGE_ORDER_SWEEP_BATCH);
+    const synced = new Set();
+    for (const { root } of batch) {
+        lastSyncedAt.set(root.id, now.getTime());
+        await syncMergeOrderChecks(deps, root.id, { synced });
+    }
+    return batch.length;
+}

package/dist/core/notification-dispatcher.d.ts

@@ -0,0 +1,70 @@
+/**
+ * Delivers pending NotificationDelivery rows to chat (Slack), one thread per
+ * work item (or PR, or run) per channel.
+ *
+ * Rules:
+ * - Lease-gated: only the holder of the "notification-dispatch" SchedulerLease
+ *   delivers. The lease is renewed before every delivery and the pass ends
+ *   when renewal fails; a pass also stops after PASS_BUDGET_MS so a delivery
+ *   always starts well inside the lease TTL. Replicas therefore don't
+ *   double-post while the lease is held. Delivery is still at-least-once: a
+ *   failed "delivered" write after a successful post retries (and reposts).
+ * - Threads: the first delivery for a (provider, channel, threadKey) posts a
+ *   parent message and stores its ts in NotificationThread; every event is a
+ *   reply under it. The thread status is derived from its delivered events;
+ *   NotificationThread.status is the status last rendered on the parent, which
+ *   is re-rendered with chat.update whenever the two differ. A deleted parent
+ *   (message_not_found on update) drops the thread row; the next event posts
+ *   a fresh parent.
+ * - Ordering: within a thread, deliveries go strictly oldest-first. A thread is
+ *   only worked when its oldest pending delivery is due, and it stops at its
+ *   first failure in a pass, so a reply never overtakes an older one.
+ * - Pacing: at most one Slack call per second per channel (posts and updates).
+ * - Errors: rate_limited defers by Retry-After without counting an attempt and
+ *   holds the whole channel (every thread on it) until Retry-After passes;
+ *   transient (and any non-ChatError) backs
+ *   off exponentially and fails at MAX_ATTEMPTS; channel_unreachable fails
+ *   every pending delivery for the channel and stamps lastError on its links;
+ *   auth_failed pauses the whole dispatcher for 5 minutes (no attempt counted),
+ *   then re-checks each provider with auth.test.
+ * - Sender: with WARDBY_SLACK_CUSTOMIZE on, a message's display name is the
+ *   agent the event names (picked up, review, failure), else "wardby".
+ * - The pause and channel holds live on `deps.state` (created on first use), not in module
+ *   state: one dispatcher (or one test) per deps object.
+ */
+import { Prisma, type PrismaClient } from "#prisma";
+import { type ChatProviderRegistry } from "../providers/chat/types.js";
+export declare const DISPATCH_LEASE_SCOPE = "notification-dispatch";
+export declare const MAX_ATTEMPTS = 10;
+/** Per-dispatcher mutable state; `dispatchOnce` creates it on `deps` when absent. */
+export interface DispatcherState {
+    /** While set and in the future, passes deliver nothing. */
+    pausedUntil?: Date;
+    /** provider\0channel → no Slack call to that channel before this time (rate limit Retry-After). */
+    channelBlockedUntil?: Map<string, Date>;
+}
+export interface DispatcherDeps {
+    db: PrismaClient;
+    chat: ChatProviderRegistry;
+    holder: string;
+    now?: () => Date;
+    sleep?: (ms: number) => Promise<void>;
+    state?: DispatcherState;
+    /** Test-only: deliver only rows whose channelId starts with this (keeps parallel DB suites apart). */
+    channelIdPrefix?: string;
+}
+/** Exponential back-off: 5s · 2^(attempts-1), capped at 1h. */
+export declare function backoffMs(attempts: number): number;
+/** One pass: deliver what is due. Returns the number of deliveries attempted. */
+export declare function dispatchOnce(deps: DispatcherDeps): Promise<number>;
+/**
+ * Deletes events (and their deliveries) older than `days` with no pending
+ * delivery. `only` narrows the candidates further (tests scope it to their own rows).
+ */
+export declare function pruneWorkflowEvents(db: PrismaClient, now: Date, days?: number, only?: Prisma.WorkflowEventWhereInput): Promise<number>;
+export interface DispatcherHandle {
+    stop(): void;
+}
+export declare function startNotificationDispatcher(deps: DispatcherDeps & {
+    intervalMs?: number;
+}): DispatcherHandle;