@walwal-harness/cli 7.1.27 → 7.1.29

package/apps/harness-dashboard/lib/__tests__/harness-state.test.ts

@@ -248,6 +248,45 @@ describe("readHarnessState", () => {
     expect(missions.find((mission) => mission.missionId === "goal-1-auth-system")?.type).toBe("goal");
   });
 
+  it("reads explicit mission lifecycle state and marks the active child mission", () => {
+    const harnessDir = path.join(dir, ".harness");
+    const goalDir = path.join(harnessDir, "documents", "goal-1-auth-system");
+    const submission1Dir = path.join(goalDir, "submission-1-add-sso");
+    const submission2Dir = path.join(goalDir, "submission-2-visualization");
+    mkdirSync(submission1Dir, { recursive: true });
+    mkdirSync(submission2Dir, { recursive: true });
+    writeFileSync(path.join(goalDir, "ceo.md"), "# Auth system\n");
+    writeFileSync(path.join(submission1Dir, "ceo.md"), "# Add SSO\n");
+    writeFileSync(path.join(submission2Dir, "ceo.md"), "# Visualization\n");
+    writeFileSync(
+      path.join(submission1Dir, "mission-state.json"),
+      JSON.stringify({ lifecycle: "closed", active: false })
+    );
+    writeFileSync(
+      path.join(submission2Dir, "mission-state.json"),
+      JSON.stringify({ lifecycle: "active", active: true })
+    );
+
+    const missions = readHarnessState(dir).missions;
+    const s1 = missions.find((mission) => mission.missionId.endsWith("submission-1-add-sso"))!;
+    const s2 = missions.find((mission) => mission.missionId.endsWith("submission-2-visualization"))!;
+    expect(s1.lifecycle).toBe("closed");
+    expect(s1.active).toBe(false);
+    expect(s2.lifecycle).toBe("active");
+    expect(s2.active).toBe(true);
+  });
+
+  it("flags CXX reports that lack hired worker evidence", () => {
+    const harnessDir = path.join(dir, ".harness");
+    const missionDir = path.join(harnessDir, "documents", "goal-1-dashboard");
+    mkdirSync(missionDir, { recursive: true });
+    writeFileSync(path.join(missionDir, "ceo.md"), "# Dashboard\n");
+    writeFileSync(path.join(missionDir, "cto.md"), "# CTO\n\nImplemented directly.\n");
+
+    const mission = readHarnessState(dir).missions[0];
+    expect(mission.protocolViolations).toContain("cto:missing-worker-evidence");
+  });
+
   it("positions only hired HR-Resource workers and marks active workers", () => {
     const harnessDir = path.join(dir, ".harness");
     const missionDir = path.join(harnessDir, "documents", "goal-1-dashboard");
@@ -297,4 +336,49 @@ describe("readHarnessState", () => {
       sourcePath: ".harness/shared/HR-Resource/react-ui-worker/SKILL.md",
     });
   });
+
+  it("does not revive recently touched workers after runtime completion", () => {
+    const harnessDir = path.join(dir, ".harness");
+    const missionDir = path.join(harnessDir, "documents", "goal-1-dashboard");
+    mkdirSync(path.join(missionDir, "cto", "workers"), { recursive: true });
+    mkdirSync(path.join(harnessDir, "shared", "HR-Resource", "react-ui-worker"), { recursive: true });
+    writeFileSync(path.join(missionDir, "ceo.md"), "# Dashboard\n");
+    writeFileSync(
+      path.join(missionDir, "cto", "workers", "react-ui-worker.md"),
+      "## Status\nIN_PROGRESS\n"
+    );
+    writeFileSync(
+      path.join(harnessDir, "shared", "HR-Resource", "react-ui-worker", "SKILL.md"),
+      "# React UI Worker\n"
+    );
+    writeFileSync(
+      path.join(harnessDir, "shared", "hr-roster.json"),
+      JSON.stringify({
+        hired: [
+          {
+            worker: "react-ui-worker",
+            owner: "cto",
+            skillPath: ".harness/shared/HR-Resource/react-ui-worker/SKILL.md",
+          },
+        ],
+      })
+    );
+    writeFileSync(
+      path.join(harnessDir, "progress.json"),
+      JSON.stringify({
+        current_agent: null,
+        next_agent: "none",
+        agent_status: "completed",
+        company_state: {
+          workers: [{ agent: "react-ui-worker", status: "running", feature: "F1" }],
+        },
+      })
+    );
+
+    const workers = readHarnessState(dir).missions[0].workers;
+    expect(workers[0]).toMatchObject({
+      name: "react-ui-worker",
+      active: false,
+    });
+  });
 });

package/apps/harness-dashboard/lib/harness-state.ts

@@ -25,6 +25,7 @@ import type {
   MeetingRecord,
   MeetingsState,
   GotchaEntry,
+  ConventionEntry,
   MissionDoc,
   OperationsDashboard,
   OpsServiceHealth,
@@ -226,6 +227,7 @@ function emptySnapshot(banner: ErrorBanner | null = null, rootDir?: string): Har
     missions: [],
     ownerHistory: [],
     gotchas: [],
+    conventions: [],
     todos: [],
     events: [],
   };
@@ -791,6 +793,44 @@ interface HiredWorkerEntry {
   capability: string | null;
 }
 
+type MissionLifecycle = MissionDoc["lifecycle"];
+
+function normalizeMissionLifecycle(raw: unknown): MissionLifecycle {
+  const value = String(raw ?? "").toLowerCase().replace(/[_\s-]+/g, "-");
+  if (
+    value === "active" ||
+    value === "closed" ||
+    value === "cancelled" ||
+    value === "superseded" ||
+    value === "complete" ||
+    value === "blocked"
+  ) {
+    return value;
+  }
+  if (value === "done" || value === "completed") return "complete";
+  if (value === "canceled") return "cancelled";
+  return "unknown";
+}
+
+function readMissionState(missionPath: string): {
+  lifecycle: MissionLifecycle;
+  active: boolean | null;
+} {
+  const statePath = path.join(missionPath, "mission-state.json");
+  const state = readJsonSafe<{
+    lifecycle?: unknown;
+    status?: unknown;
+    active?: boolean;
+  }>(statePath);
+  if (!state.ok) return { lifecycle: "unknown", active: null };
+
+  const lifecycle = normalizeMissionLifecycle(state.value.lifecycle ?? state.value.status);
+  return {
+    lifecycle,
+    active: typeof state.value.active === "boolean" ? state.value.active : null,
+  };
+}
+
 function deriveWorkerProgress(worker: RawWorker): number | null {
   const status = (worker?.status ?? worker?.spawn_status ?? "").toLowerCase();
   if (status === "blocked" || status === "failed") return 0.35;
@@ -938,8 +978,20 @@ function workerDisplayName(content: string, hired: HiredWorkerEntry | undefined,
   return fallback;
 }
 
+function isHarnessRuntimeIdle(progress: RawProgress | null): boolean {
+  const status = (progress?.agent_status ?? "").toLowerCase();
+  const current = progress?.current_agent ?? null;
+  const next = progress?.next_agent ?? null;
+  return (
+    status === "completed" ||
+    status === "complete" ||
+    (status === "idle" && current === null && (next === null || String(next) === "none"))
+  );
+}
+
 function activeWorkerNames(progress: RawProgress | null): Set<string> {
   const active = new Set<string>();
+  if (isHarnessRuntimeIdle(progress)) return active;
   const workers = [
     ...(progress?.company_state?.workers ?? []),
     ...(progress?.company_state?.last_dispatch ?? []),
@@ -1109,6 +1161,7 @@ function readMissions(rootDir: string, progress: RawProgress | null = null, limi
   if (!existsSync(docsDir)) return [];
   const hiredWorkers = readHiredWorkers(rootDir);
   const activeWorkers = activeWorkerNames(progress);
+  const runtimeIdle = isHarnessRuntimeIdle(progress);
 
   const missionDirs: Array<{ rel: string; abs: string }> = [];
   const cxxDocNames = new Set(["ceo.md", "cto.md", "cqo.md", "coo.md", "cdo.md", "ops.md"]);
@@ -1143,7 +1196,7 @@ function readMissions(rootDir: string, progress: RawProgress | null = null, limi
     return "unknown";
   };
 
-  const missions = missionDirs
+  let missions = missionDirs
     .map(({ rel, abs: missionPath }) => {
       let mtime: Date;
       try { mtime = statSync(missionPath).mtime; } catch { mtime = new Date(0); }
@@ -1165,7 +1218,15 @@ function readMissions(rootDir: string, progress: RawProgress | null = null, limi
             const reportAbs = path.join(missionPath, relDir, f);
             const content = readMd(`${relDir}/${f}`) ?? "";
             const statusMatch = content.match(/##\s*Status\s*\n+([A-Z_]+)/);
-            const status = (statusMatch?.[1] as WorkerDocEntry["status"]) ?? "unknown";
+            // Worker docs sometimes omit the "## Status" block but always carry a
+            // docmeta frontmatter when the worker submitted its output. Treat the
+            // presence of a docmeta block (or a non-empty body) as COMPLETE.
+            const hasDocmeta = /^---[\s\S]*?docmeta:[\s\S]*?---/.test(content);
+            const status: WorkerDocEntry["status"] = statusMatch
+              ? (statusMatch[1] as WorkerDocEntry["status"])
+              : hasDocmeta
+              ? "COMPLETE"
+              : "unknown";
             const name = normalizeWorkerName(f);
             const hired = hiredForMission(hiredWorkers, name, owner, rel);
             let updatedAt: string | null = null;
@@ -1182,7 +1243,7 @@ function readMissions(rootDir: string, progress: RawProgress | null = null, limi
               status,
               owner: hired?.owner ?? owner,
               hired: !!hired,
-              active: activeWorkers.has(name) || (recentlyTouched && status !== "COMPLETE"),
+              active: !runtimeIdle && (activeWorkers.has(name) || (recentlyTouched && status !== "COMPLETE")),
               sourcePath: hired?.sourcePath ?? null,
               reportPath: path.relative(rootDir, reportAbs),
               updatedAt,
@@ -1206,10 +1267,10 @@ function readMissions(rootDir: string, progress: RawProgress | null = null, limi
           name: hired.name,
           displayName: workerDisplayName("", hired, hired.name),
           content: "",
-          status: activeWorkers.has(hired.name) ? "IN_PROGRESS" : "unknown",
+          status: !runtimeIdle && activeWorkers.has(hired.name) ? "IN_PROGRESS" : "unknown",
           owner: hired.owner,
           hired: true,
-          active: activeWorkers.has(hired.name),
+          active: !runtimeIdle && activeWorkers.has(hired.name),
           sourcePath: hired.sourcePath,
           reportPath: null,
           updatedAt: null,
@@ -1220,6 +1281,23 @@ function readMissions(rootDir: string, progress: RawProgress | null = null, limi
 
       const cxxRoles = ["ceo", "cto", "cqo", "coo", "cdo", "ops"] as const;
       const cxxPresent = cxxRoles.filter(role => existsSync(path.join(missionPath, `${role}.md`)));
+      const state = readMissionState(missionPath);
+      const protocolViolations: string[] = [];
+      for (const role of cxxPresent) {
+        if (role === "ceo") continue;
+        const roleWorkers = workers.filter((w) => w.owner === role);
+        const roleDoc = readMd(`${role}.md`) ?? "";
+        const hasManifest = /Worker Evidence Manifest/i.test(roleDoc);
+        const mentionsWorkerReport = new RegExp(`${role}/workers/`, "i").test(roleDoc);
+        if (roleWorkers.length === 0 || !hasManifest || !mentionsWorkerReport) {
+          protocolViolations.push(`${role}:missing-worker-evidence`);
+        }
+      }
+      for (const w of workers) {
+        if (w.owner === "unknown" || !w.hired) {
+          protocolViolations.push(`${w.owner}:${w.name}:not-hired-or-unowned`);
+        }
+      }
 
       const id = rel;
       const label = rel.split("/").pop() ?? rel;
@@ -1227,6 +1305,9 @@ function readMissions(rootDir: string, progress: RawProgress | null = null, limi
         missionId: id,
         ts: mtime.toISOString(),
         type: typeFromId(id),
+        lifecycle: state.lifecycle,
+        active: state.active ?? false,
+        protocolViolations,
         label,
         ceo: readMd("ceo.md"),
         cto: readMd("cto.md"),
@@ -1239,8 +1320,22 @@ function readMissions(rootDir: string, progress: RawProgress | null = null, limi
         cxxPresent: [...cxxPresent],
       } satisfies MissionDoc;
     })
-    .sort((a, b) => new Date(b.ts).getTime() - new Date(a.ts).getTime())
-    .slice(0, limit);
+    .sort((a, b) => new Date(b.ts).getTime() - new Date(a.ts).getTime());
+
+  const explicitActive = missions.some((m) => m.active);
+  if (!explicitActive) {
+    const latestOpen = missions.find(
+      (m) => m.lifecycle === "active" || m.lifecycle === "unknown"
+    );
+    if (latestOpen) {
+      missions = missions.map((m) => ({
+        ...m,
+        active: m.missionId === latestOpen.missionId,
+      }));
+    }
+  }
+
+  missions = missions.slice(0, limit);
 
   // When the CEO updates a goal directory in-place for a submission or hot-fix
   // (instead of creating a submission-* or hotfix-* subdirectory), the most
@@ -1293,32 +1388,51 @@ function readOwnerHistory(rootDir: string, limit = 30): OwnerPromptEntry[] {
   return entries.reverse().slice(0, limit);
 }
 
-function readGotchas(rootDir: string): GotchaEntry[] {
-  const gotchasDir = path.join(rootDir, ".harness", "gotchas");
-  if (!existsSync(gotchasDir)) return [];
+function readKnowledgeDir<T extends GotchaEntry | ConventionEntry>(
+  rootDir: string,
+  relDir: string
+): T[] {
+  const dir = path.join(rootDir, ".harness", relDir);
+  if (!existsSync(dir)) return [];
   let entries: Dirent[];
-  try { entries = readdirSync(gotchasDir, { withFileTypes: true }); } catch { return []; }
-  const results: GotchaEntry[] = [];
+  try { entries = readdirSync(dir, { withFileTypes: true }); } catch { return []; }
+  const results: T[] = [];
   for (const entry of entries) {
     if (!entry.isFile() || !entry.name.endsWith(".md")) continue;
     if (entry.name === "README.md") continue;
     const id = entry.name.replace(/\.md$/, "");
+    const abs = path.join(dir, entry.name);
     let content: string;
-    try { content = readFileSync(path.join(gotchasDir, entry.name), "utf8"); } catch { continue; }
-    // Extract title from first H1 after optional frontmatter
+    try { content = readFileSync(abs, "utf8"); } catch { continue; }
     const body = content.replace(/^---[\s\S]*?---\n+/, "");
     const h1 = body.match(/^#\s+(.+)/m);
     const title = h1 ? h1[1].trim() : id;
-    // Extract tags from docmeta frontmatter
     const tagsMatch = content.match(/^\s*tags:\s*\[([^\]]*)\]/m);
     const tags = tagsMatch
       ? tagsMatch[1].split(",").map((t) => t.trim().replace(/^['"]|['"]$/g, "")).filter(Boolean)
       : [];
-    results.push({ id, title, content, tags });
+    let updatedAt: string | null = null;
+    try { updatedAt = statSync(abs).mtime.toISOString(); } catch { /* ignore */ }
+    results.push({
+      id,
+      title,
+      content,
+      tags,
+      sourcePath: path.relative(rootDir, abs),
+      updatedAt,
+    } as T);
   }
   return results.sort((a, b) => a.id.localeCompare(b.id));
 }
 
+function readGotchas(rootDir: string): GotchaEntry[] {
+  return readKnowledgeDir<GotchaEntry>(rootDir, "gotchas");
+}
+
+function readConventions(rootDir: string): ConventionEntry[] {
+  return readKnowledgeDir<ConventionEntry>(rootDir, "conventions");
+}
+
 function normalizeTodoStatus(raw: unknown): CxxTodo["status"] {
   const value = String(raw ?? "pending").toLowerCase();
   if (["pending", "active", "paused", "blocked", "done"].includes(value)) return value;
@@ -1431,6 +1545,7 @@ export function readHarnessState(rootDir: string): HarnessSnapshot {
     snapshot.missions = readMissions(rootDir, null);
     snapshot.ownerHistory = readOwnerHistory(rootDir);
     snapshot.gotchas = readGotchas(rootDir);
+    snapshot.conventions = readConventions(rootDir);
     snapshot.todos = readTodos(rootDir);
     snapshot.events = readEvents(rootDir);
     return snapshot;
@@ -1485,6 +1600,7 @@ export function readHarnessState(rootDir: string): HarnessSnapshot {
     missions: readMissions(rootDir, progress),
     ownerHistory: readOwnerHistory(rootDir),
     gotchas: readGotchas(rootDir),
+    conventions: readConventions(rootDir),
     todos: readTodos(rootDir),
     events: readEvents(rootDir),
   };

package/apps/harness-dashboard/lib/types.ts

@@ -292,6 +292,7 @@ export interface HarnessSnapshot {
   missions: MissionDoc[];
   ownerHistory: OwnerPromptEntry[];
   gotchas: GotchaEntry[];
+  conventions: ConventionEntry[];
   todos: CxxTodo[];
   events: HarnessEvent[];
 }
@@ -339,6 +340,9 @@ export interface MissionDoc {
   missionId: string;
   ts: string;
   type: "goal" | "submission" | "hotfix" | "feature" | "unknown";
+  lifecycle: "active" | "closed" | "cancelled" | "superseded" | "complete" | "blocked" | "unknown";
+  active: boolean;
+  protocolViolations: string[];
   label: string;
   ceo: string | null;
   cto: string | null;
@@ -362,6 +366,17 @@ export interface GotchaEntry {
   title: string;
   content: string;
   tags: string[];
+  sourcePath?: string | null;
+  updatedAt?: string | null;
+}
+
+export interface ConventionEntry {
+  id: string;
+  title: string;
+  content: string;
+  tags: string[];
+  sourcePath?: string | null;
+  updatedAt?: string | null;
 }
 
 export type OrgRole = "owner" | "ceo" | "coo" | "cdo" | "cto" | "cqo" | "ops";