@waku/rln 0.1.6-16328a3.0 → 0.1.6-27c1236.0

package/bundle/index.js

@@ -1,7 +1,7 @@
 export { RLNDecoder, RLNEncoder } from './packages/rln/dist/codec.js';
 export { RLN_ABI } from './packages/rln/dist/contract/abi.js';
 export { RLNContract } from './packages/rln/dist/contract/rln_contract.js';
-export { DEFAULT_RATE_LIMIT, LINEA_CONTRACT, RATE_LIMIT_PARAMS, RATE_LIMIT_TIERS } from './packages/rln/dist/contract/constants.js';
+export { DEFAULT_Q, DEFAULT_RATE_LIMIT, LINEA_CONTRACT, RATE_LIMIT_PARAMS, RATE_LIMIT_TIERS } from './packages/rln/dist/contract/constants.js';
 export { MembershipState } from './packages/rln/dist/contract/types.js';
 export { RLNBaseContract } from './packages/rln/dist/contract/rln_base_contract.js';
 export { createRLN } from './packages/rln/dist/create.js';

package/bundle/packages/core/dist/lib/message/version_0.js

@@ -29,9 +29,6 @@ class DecodedMessage {
     get contentTopic() {
         return this.proto.contentTopic;
     }
-    get _rawTimestamp() {
-        return this.proto.timestamp;
-    }
     get timestamp() {
         // In the case we receive a value that is bigger than JS's max number,
         // we catch the error and return undefined.
@@ -53,7 +50,7 @@ class DecodedMessage {
     get version() {
         // https://rfc.vac.dev/spec/14/
         // > If omitted, the value SHOULD be interpreted as version 0.
-        return this.proto.version ?? 0;
+        return this.proto.version ?? Version;
     }
     get rateLimitProof() {
         return this.proto.rateLimitProof;

package/bundle/packages/rln/dist/contract/constants.js

@@ -22,6 +22,12 @@ const RATE_LIMIT_PARAMS = {
     MAX_TOTAL_RATE: 160_000, // Maximum total rate limit across all memberships
     EPOCH_LENGTH: 600 // Epoch length in seconds (10 minutes)
 };
+/**
+ * Default Q value for the RLN contract
+ * This is the upper bound for the ID commitment
+ * @see https://github.com/waku-org/specs/blob/master/standards/core/rln-contract.md#implementation-suggestions
+ */
+const DEFAULT_Q = BigInt("21888242871839275222246405745257275088548364400416034343698204186575808495617");
 const DEFAULT_RATE_LIMIT = RATE_LIMIT_PARAMS.MAX_RATE;
 
-export { DEFAULT_RATE_LIMIT, LINEA_CONTRACT, RATE_LIMIT_PARAMS, RATE_LIMIT_TIERS };
+export { DEFAULT_Q, DEFAULT_RATE_LIMIT, LINEA_CONTRACT, RATE_LIMIT_PARAMS, RATE_LIMIT_TIERS };

package/bundle/packages/rln/dist/contract/rln_base_contract.js

@@ -14,7 +14,7 @@ import '../../../../node_modules/multiformats/dist/src/bases/identity.js';
 import '../../../../node_modules/multiformats/dist/src/codecs/json.js';
 import { Logger } from '../../../utils/dist/logger/index.js';
 import { RLN_ABI } from './abi.js';
-import { DEFAULT_RATE_LIMIT, RATE_LIMIT_PARAMS } from './constants.js';
+import { DEFAULT_Q, DEFAULT_RATE_LIMIT, RATE_LIMIT_PARAMS } from './constants.js';
 import { MembershipState } from './types.js';
 import { Contract } from '../../../../node_modules/@ethersproject/contracts/lib.esm/index.js';
 import { BigNumber } from '../../../../node_modules/@ethersproject/bignumber/lib.esm/bignumber.js';
@@ -26,6 +26,11 @@ class RLNBaseContract {
     rateLimit;
     minRateLimit;
     maxRateLimit;
+    /**
+     * Default Q value for the RLN contract.
+     * @see https://github.com/waku-org/waku-rlnv2-contract/blob/b7e9a9b1bc69256a2a3076c1f099b50ce84e7eff/src/WakuRlnV2.sol#L25
+     */
+    idCommitmentBigIntLimit = DEFAULT_Q;
     _members = new Map();
     _membersFilter;
     _membershipErasedFilter;
@@ -64,12 +69,14 @@ class RLNBaseContract {
      */
     static async create(options) {
         const instance = new RLNBaseContract(options);
-        const [min, max] = await Promise.all([
+        const [min, max, idCommitmentBigIntLimit] = await Promise.all([
             instance.contract.minMembershipRateLimit(),
-            instance.contract.maxMembershipRateLimit()
+            instance.contract.maxMembershipRateLimit(),
+            instance.contract.Q()
         ]);
         instance.minRateLimit = BigNumber.from(min).toNumber();
         instance.maxRateLimit = BigNumber.from(max).toNumber();
+        instance.idCommitmentBigIntLimit = BigInt(idCommitmentBigIntLimit.toString());
         instance.validateRateLimit(instance.rateLimit);
         return instance;
     }

package/bundle/packages/rln/dist/credentials_manager.js

@@ -1,5 +1,5 @@
 import { hmac } from '../../../node_modules/@noble/hashes/esm/hmac.js';
-import { sha256 } from '../../../node_modules/@noble/hashes/esm/sha256.js';
+import { sha256 } from '../../../node_modules/@noble/hashes/esm/sha2.js';
 import '../../interfaces/dist/protocols.js';
 import '../../interfaces/dist/connection_manager.js';
 import '../../interfaces/dist/health_indicator.js';
@@ -20,7 +20,7 @@ import { RLNBaseContract } from './contract/rln_base_contract.js';
 import { IdentityCredential } from './identity.js';
 import { Keystore } from './keystore/keystore.js';
 import { extractMetaMaskSigner } from './utils/metamask.js';
-import { buildBigIntFromUint8Array } from './utils/bytes.js';
+import { buildBigIntFromUint8ArrayLE } from './utils/bytes.js';
 import './utils/epoch.js';
 
 const log = new Logger("waku:credentials");
@@ -95,7 +95,7 @@ class RLNCredentialsManager {
             }
             else {
                 log.info("Using local implementation to generate identity");
-                identity = this.generateSeededIdentityCredential(options.signature);
+                identity = await this.generateSeededIdentityCredential(options.signature);
             }
         }
         if (!identity) {
@@ -191,7 +191,7 @@ class RLNCredentialsManager {
      * @param seed A string seed to generate the identity from
      * @returns IdentityCredential
      */
-    generateSeededIdentityCredential(seed) {
+    async generateSeededIdentityCredential(seed) {
         log.info("Generating seeded identity credential");
         // Convert the seed to bytes
         const encoder = new TextEncoder();
@@ -200,13 +200,18 @@ class RLNCredentialsManager {
         // We use different context strings for each component to ensure they're different
         const idTrapdoor = hmac(sha256, seedBytes, encoder.encode("IDTrapdoor"));
         const idNullifier = hmac(sha256, seedBytes, encoder.encode("IDNullifier"));
-        // Generate IDSecretHash as a hash of IDTrapdoor and IDNullifier
         const combinedBytes = new Uint8Array([...idTrapdoor, ...idNullifier]);
         const idSecretHash = sha256(combinedBytes);
-        // Generate IDCommitment as a hash of IDSecretHash
         const idCommitment = sha256(idSecretHash);
-        // Convert IDCommitment to BigInt
-        const idCommitmentBigInt = buildBigIntFromUint8Array(idCommitment);
+        let idCommitmentBigInt = buildBigIntFromUint8ArrayLE(idCommitment);
+        if (!this.contract) {
+            throw Error("RLN contract is not initialized");
+        }
+        const idCommitmentBigIntLimit = this.contract.idCommitmentBigIntLimit;
+        if (idCommitmentBigInt >= idCommitmentBigIntLimit) {
+            log.warn(`ID commitment is greater than Q, reducing it by Q(idCommitmentBigIntLimit): ${idCommitmentBigInt} % ${idCommitmentBigIntLimit}`);
+            idCommitmentBigInt = idCommitmentBigInt % idCommitmentBigIntLimit;
+        }
         log.info("Successfully generated identity credential");
         return new IdentityCredential(idTrapdoor, idNullifier, idSecretHash, idCommitment, idCommitmentBigInt);
     }

package/bundle/packages/rln/dist/identity.js

@@ -1,4 +1,4 @@
-import { buildBigIntFromUint8Array } from './utils/bytes.js';
+import { buildBigIntFromUint8ArrayLE } from './utils/bytes.js';
 import './utils/epoch.js';
 
 class IdentityCredential {
@@ -22,7 +22,7 @@ class IdentityCredential {
         const idNullifier = memKeys.subarray(32, 64);
         const idSecretHash = memKeys.subarray(64, 96);
         const idCommitment = memKeys.subarray(96, 128);
-        const idCommitmentBigInt = buildBigIntFromUint8Array(idCommitment, 32);
+        const idCommitmentBigInt = buildBigIntFromUint8ArrayLE(idCommitment);
         return new IdentityCredential(idTrapdoor, idNullifier, idSecretHash, idCommitment, idCommitmentBigInt);
     }
 }

package/bundle/packages/rln/dist/keystore/keystore.js

@@ -17,7 +17,7 @@ import { Logger } from '../../../utils/dist/logger/index.js';
 import { sha256 } from '../../../../node_modules/ethereum-cryptography/esm/sha256.js';
 import { bytesToUtf8 } from '../../../../node_modules/ethereum-cryptography/esm/utils.js';
 import _ from '../../../../node_modules/lodash/lodash.js';
-import { buildBigIntFromUint8Array } from '../utils/bytes.js';
+import { buildBigIntFromUint8ArrayLE } from '../utils/bytes.js';
 import { keccak256Checksum, decryptEipKeystore } from './cipher.js';
 import { isKeystoreValid, isCredentialValid } from './schema_validator.js';
 import { __exports as lib } from '../../../../_virtual/index.js';
@@ -161,17 +161,22 @@ class Keystore {
         };
     }
     static fromBytesToIdentity(bytes) {
+        function fromLittleEndian(bytes) {
+            return new Uint8Array(bytes).reverse();
+        }
         try {
             const str = bytesToUtf8(bytes);
             const obj = JSON.parse(str);
-            // TODO: add runtime validation of nwaku credentials
+            // Use little-endian bytes directly for BigInt conversion (matches storage and contract expectation)
+            const idCommitmentLE = Keystore.fromArraylikeToBytes(_.get(obj, "identityCredential.idCommitment", []));
             return {
                 identity: {
-                    IDCommitment: Keystore.fromArraylikeToBytes(_.get(obj, "identityCredential.idCommitment", [])),
-                    IDTrapdoor: Keystore.fromArraylikeToBytes(_.get(obj, "identityCredential.idTrapdoor", [])),
-                    IDNullifier: Keystore.fromArraylikeToBytes(_.get(obj, "identityCredential.idNullifier", [])),
-                    IDCommitmentBigInt: buildBigIntFromUint8Array(Keystore.fromArraylikeToBytes(_.get(obj, "identityCredential.idCommitment", []))),
-                    IDSecretHash: Keystore.fromArraylikeToBytes(_.get(obj, "identityCredential.idSecretHash", []))
+                    IDCommitment: fromLittleEndian(idCommitmentLE),
+                    IDTrapdoor: fromLittleEndian(Keystore.fromArraylikeToBytes(_.get(obj, "identityCredential.idTrapdoor", []))),
+                    IDNullifier: fromLittleEndian(Keystore.fromArraylikeToBytes(_.get(obj, "identityCredential.idNullifier", []))),
+                    // Do NOT reverse for BigInt conversion; use little-endian as stored
+                    IDCommitmentBigInt: buildBigIntFromUint8ArrayLE(idCommitmentLE),
+                    IDSecretHash: fromLittleEndian(Keystore.fromArraylikeToBytes(_.get(obj, "identityCredential.idSecretHash", [])))
                 },
                 membership: {
                     treeIndex: _.get(obj, "treeIndex"),
@@ -208,13 +213,16 @@ class Keystore {
     // follows nwaku implementation
     // https://github.com/waku-org/nwaku/blob/f05528d4be3d3c876a8b07f9bb7dfaae8aa8ec6e/waku/waku_keystore/protocol_types.nim#L98
     static fromIdentityToBytes(options) {
+        function toLittleEndian(bytes) {
+            return new Uint8Array(bytes).reverse();
+        }
         return utf8ToBytes(JSON.stringify({
             treeIndex: options.membership.treeIndex,
             identityCredential: {
-                idCommitment: Array.from(options.identity.IDCommitment),
-                idNullifier: Array.from(options.identity.IDNullifier),
-                idSecretHash: Array.from(options.identity.IDSecretHash),
-                idTrapdoor: Array.from(options.identity.IDTrapdoor)
+                idCommitment: Array.from(toLittleEndian(options.identity.IDCommitment)),
+                idNullifier: Array.from(toLittleEndian(options.identity.IDNullifier)),
+                idSecretHash: Array.from(toLittleEndian(options.identity.IDSecretHash)),
+                idTrapdoor: Array.from(toLittleEndian(options.identity.IDTrapdoor))
             },
             membershipContract: {
                 chainId: options.membership.chainId,

package/bundle/packages/rln/dist/message.js

@@ -1,4 +1,14 @@
+import { Version } from '../../core/dist/lib/message/version_0.js';
+import '../../core/dist/lib/filter/filter.js';
+import '../../core/dist/lib/light_push/light_push.js';
+import '../../core/dist/lib/store/store.js';
+import '../../core/dist/lib/connection_manager/connection_manager.js';
+import '../../interfaces/dist/protocols.js';
+import '../../interfaces/dist/connection_manager.js';
+import '../../interfaces/dist/health_indicator.js';
 import { utf8ToBytes } from '../../utils/dist/bytes/index.js';
+import '../../../node_modules/debug/src/browser.js';
+import '../../core/dist/lib/metadata/metadata.js';
 import { epochBytesToInt } from './utils/epoch.js';
 
 function toRLNSignal(contentTopic, msg) {
@@ -10,6 +20,7 @@ class RlnMessage {
     msg;
     rateLimitProof;
     pubsubTopic = "";
+    version = Version;
     constructor(rlnInstance, msg, rateLimitProof) {
         this.rlnInstance = rlnInstance;
         this.msg = msg;

package/bundle/packages/rln/dist/utils/bytes.js

@@ -39,14 +39,8 @@ function writeUIntLE(buf, value, offset, byteLength, noAssert) {
     }
     return buf;
 }
-/**
- * Transforms Uint8Array into BigInt
- * @param array: Uint8Array
- * @returns BigInt
- */
-function buildBigIntFromUint8Array(array, byteOffset = 0) {
-    const dataView = new DataView(array.buffer);
-    return dataView.getBigUint64(byteOffset, true);
+function buildBigIntFromUint8ArrayLE(bytes) {
+    return bytes.reduce((acc, byte, i) => acc + BigInt(byte) * (1n << (8n * BigInt(i))), 0n);
 }
 /**
  * Fills with zeros to set length
@@ -62,4 +56,4 @@ function zeroPadLE(array, length) {
     return result;
 }
 
-export { buildBigIntFromUint8Array, concatenate, writeUIntLE, zeroPadLE };
+export { buildBigIntFromUint8ArrayLE, concatenate, writeUIntLE, zeroPadLE };