@wairon/cli 5.1.1-dev.35 → 5.1.1-dev.36

package/dist/index.js

@@ -1113,7 +1113,7 @@ var init_defaults = __esm({
       copilot: ".github/prompts",
       codex: ".codex/agents"
     };
-    WAIRON_VERSION = "5.1.1-dev.35";
+    WAIRON_VERSION = "5.1.1-dev.36";
     GITHUB_REPO = "SYW-Apps/Waffle-AIron";
     ARCHITECT_AGENT_ID = "agent-architect";
     ARCHITECT_TEMPLATE_ID = "architect";
@@ -2530,13 +2530,34 @@ var init_step_graph = __esm({
 });
 
 // src/models/step-config.ts
+function stepFieldsFor(type) {
+  const own = STEP_TYPE_FIELDS[type] ?? [];
+  const allowed = /* @__PURE__ */ new Set([...STEP_COMMON_FIELDS, ...own]);
+  for (const field of own) {
+    const twin = STEP_LABEL_TWINS[field];
+    if (twin) allowed.add(twin);
+  }
+  return allowed;
+}
+function isSet(step, field) {
+  const v = step[field];
+  if (v === void 0 || v === null) return false;
+  if (Array.isArray(v) && v.length === 0) return false;
+  return true;
+}
 function flowConfigOn(step) {
-  return FLOW_FIELDS.filter((f) => {
-    const v = step[f];
-    if (v === void 0) return false;
-    if (Array.isArray(v) && v.length === 0) return false;
-    return true;
-  });
+  return FLOW_FIELDS.filter((f) => isSet(step, f));
+}
+function narrativeStepForeignFields(step) {
+  const type = step.type;
+  if (!Object.prototype.hasOwnProperty.call(STEP_TYPE_FIELDS, type)) return [];
+  const allowed = stepFieldsFor(type);
+  return Object.keys(step).filter((f) => !allowed.has(f) && isSet(step, f));
+}
+function listFields(fields) {
+  const quoted = fields.map((f) => `"${f}"`);
+  if (quoted.length === 1) return quoted[0];
+  return `${quoted.slice(0, -1).join(", ")} and ${quoted[quoted.length - 1]}`;
 }
 function stepConfigVerdict(method) {
   const steps = method.narrative ?? [];
@@ -2573,8 +2594,10 @@ function stepConfigVerdict(method) {
     return i !== void 0 && i + 1 < nums.length ? nums[i + 1] : void 0;
   };
   for (const s of steps) {
+    const alreadyNamed = /* @__PURE__ */ new Set();
     if (s.detach && s.type !== "call" && s.type !== "dispatch") {
       malformed(s.stepNumber, `step ${s.stepNumber} (${s.type}) carries "detach" \u2014 fire-and-forget applies to call/dispatch steps only.`);
+      alreadyNamed.add("detach");
     }
     switch (s.type) {
       case "local":
@@ -2582,7 +2605,10 @@ function stepConfigVerdict(method) {
       case "register":
       case "dispatch": {
         const extra = flowConfigOn(s);
-        if (extra.length) malformed(s.stepNumber, `step ${s.stepNumber} (${s.type}) carries flow config (${extra.join(", ")}) \u2014 use a flow step type instead.`);
+        if (extra.length) {
+          malformed(s.stepNumber, `step ${s.stepNumber} (${s.type}) carries flow config (${extra.join(", ")}) \u2014 use a flow step type instead.`);
+          for (const f of extra) alreadyNamed.add(f);
+        }
         break;
       }
       case "branch":
@@ -2625,6 +2651,14 @@ function stepConfigVerdict(method) {
         if (s.toStep === void 0) malformed(s.stepNumber, `jump step ${s.stepNumber} requires "toStep".`);
         break;
     }
+    const foreign = narrativeStepForeignFields(s).filter((f) => !alreadyNamed.has(f));
+    if (foreign.length) {
+      problems.push({
+        stepNumber: s.stepNumber,
+        code: "FOREIGN_STEP_FIELD",
+        detail: `step ${s.stepNumber} (${s.type}) carries ${listFields(foreign)}, which a ${s.type} step cannot \u2014 left over from an edit that changed the step's type, configuring nothing. \`wairon doctor --fix\` drops them; give the step the type that carries them instead if that is what it does.`
+      });
+    }
     for (const [field, target] of jumpFieldsOf(s)) {
       if (byNum.has(target)) continue;
       sound = false;
@@ -2650,24 +2684,43 @@ function jumpFieldsOf(s) {
   (s.branches ?? []).forEach((b, i) => fields.push([`branches[${i}].step`, b.step]));
   return fields;
 }
-var FLOW_FIELDS;
+var STEP_TYPE_FIELDS, STEP_COMMON_FIELDS, STEP_LABEL_TWINS, FLOW_STEP_TYPES, FLOW_FIELDS;
 var init_step_config = __esm({
   "src/models/step-config.ts"() {
     "use strict";
+    STEP_TYPE_FIELDS = {
+      local: [],
+      call: ["targetComponent", "targetMethod", "auth", "detach"],
+      register: ["targetComponent", "targetMethod"],
+      dispatch: ["targetComponent", "capability", "auth", "detach"],
+      branch: ["condition", "onTrueStep", "onFalseStep"],
+      switch: ["on", "cases", "defaultStep"],
+      loop: ["loopKind", "over", "condition", "endStep"],
+      try: ["endStep", "catches", "finallyStep"],
+      parallel: ["endStep", "branches"],
+      jump: ["toStep"],
+      return: ["outcome"],
+      throw: ["error"]
+    };
+    STEP_COMMON_FIELDS = [
+      "stepNumber",
+      "label",
+      "description",
+      "type",
+      "assertsGuarantees",
+      "assertsInvariants"
+    ];
+    STEP_LABEL_TWINS = {
+      onTrueStep: "onTrueLabel",
+      onFalseStep: "onFalseLabel",
+      defaultStep: "defaultLabel",
+      endStep: "endLabel",
+      finallyStep: "finallyLabel",
+      toStep: "toLabel"
+    };
+    FLOW_STEP_TYPES = ["branch", "switch", "loop", "try", "parallel", "jump"];
     FLOW_FIELDS = [
-      "condition",
-      "onTrueStep",
-      "onFalseStep",
-      "on",
-      "cases",
-      "defaultStep",
-      "loopKind",
-      "over",
-      "endStep",
-      "catches",
-      "finallyStep",
-      "branches",
-      "toStep"
+      ...new Set(FLOW_STEP_TYPES.flatMap((t) => [...STEP_TYPE_FIELDS[t]]))
     ];
   }
 });
@@ -9744,20 +9797,22 @@ var init_narrative_step_config = __esm({
     init_models();
     narrativeStepConfigRule = {
       name: "narrative-step-config",
-      description: 'The step configuration of L5 narratives: every flow step (branch, switch, loop, try, parallel, jump) carries the config its type requires and no simple step carries flow config, "detach" (fire-and-forget) is legal on call/dispatch steps only, a parallel body is covered by contiguous, ordered arms (>= 2), no two steps share a step number or a label, and every jump field targets an existing step number in the same narrative.',
+      description: 'The step configuration of L5 narratives: every flow step (branch, switch, loop, try, parallel, jump) carries the config its type requires and no simple step carries flow config, "detach" (fire-and-forget) is legal on call/dispatch steps only, no step carries a field foreign to its type, a parallel body is covered by contiguous, ordered arms (>= 2), no two steps share a step number or a label, and every jump field targets an existing step number in the same narrative.',
       codes: [
         { code: "MALFORMED_FLOW_STEP", defaultSeverity: "error", summary: "Flow step missing required config (or flow config on a local/call step)" },
         { code: "INVALID_STEP_JUMP", defaultSeverity: "error", summary: "Jump field targets a step number that does not exist in the narrative" },
-        { code: "DUPLICATE_STEP_LABEL", defaultSeverity: "error", summary: "Two steps in one narrative share a label \u2014 the symbolic anchor later deltas address by" }
+        { code: "DUPLICATE_STEP_LABEL", defaultSeverity: "error", summary: "Two steps in one narrative share a label \u2014 the symbolic anchor later deltas address by" },
+        { code: "FOREIGN_STEP_FIELD", defaultSeverity: "warning", summary: "Step carries a field its own type cannot have \u2014 a leftover of an edit, meaning nothing" }
       ],
       check(ctx) {
+        const severityOf = new Map(narrativeStepConfigRule.codes.map((c) => [c.code, c.defaultSeverity]));
         for (const impl of ctx.implementations) {
           const isDraftCtx = ctx.isImplementationDraft(impl);
           for (const implMethod of impl.methods) {
             if (!implMethod.narrative.length) continue;
             const where = `Method "${implMethod.name}" in implementation "${impl.id}": `;
             for (const problem of stepConfigVerdict(implMethod).problems) {
-              ctx.addIssue("error", problem.code, where + problem.detail, impl.id, isDraftCtx);
+              ctx.addIssue(severityOf.get(problem.code) ?? "error", problem.code, where + problem.detail, impl.id, isDraftCtx);
             }
           }
         }
@@ -12348,15 +12403,16 @@ var init_unused_types = __esm({
     init_models();
     unusedTypesRule = {
       name: "unused-types",
-      description: "Flags types no field of any type and no interface method signature references. References are matched through the type-reference grammar (generic arguments, collections, qualified ids), and the declaring type's own generic parameters are left out \u2014 a type parameter is not a reference to a type.",
+      description: "Flags types no field of any type, no interface method signature and no other type's method signature references. References are matched through the type-reference grammar (generic arguments, collections, qualified ids), and the declaring type's own generic parameters are left out \u2014 a type parameter is not a reference to a type. A type named only by its OWN methods stays unused, the way a function that only calls itself is.",
       codes: [
-        { code: "UNUSED_TYPE", defaultSeverity: "warning", summary: "Type never referenced by fields or signatures" }
+        { code: "UNUSED_TYPE", defaultSeverity: "warning", summary: "Type never referenced by fields, signatures or type methods" }
       ],
       check(ctx) {
         const referencedTypes = /* @__PURE__ */ new Set();
-        const markTypeReferenced = (ref) => {
+        const markTypeReferenced = (ref, exceptId) => {
           if (ctx.isBuiltinType(ref)) return;
           for (const spec of ctx.types) {
+            if (spec.id === exceptId) continue;
             if (typeMatchesRef(spec, ref)) {
               referencedTypes.add(spec.id);
             }
@@ -12378,6 +12434,14 @@ var init_unused_types = __esm({
             }
           }
         }
+        for (const t of ctx.types) {
+          for (const m of t.methods) {
+            const refs = methodTypeRefs(m);
+            for (const ref of refs) {
+              markTypeReferenced(ref, t.id);
+            }
+          }
+        }
         for (const t of ctx.types) {
           if (!ctx.isSpecInScope(t.id)) continue;
           if (!referencedTypes.has(t.id)) {
@@ -12386,7 +12450,7 @@ var init_unused_types = __esm({
             ctx.addIssue(
               "warning",
               "UNUSED_TYPE",
-              `Type "${t.id}" is defined but never referenced by any type fields or interface methods.`,
+              `Type "${t.id}" is defined but never referenced by any type field, interface method or other type's method.`,
               t.id,
               isDraftCtx
             );
@@ -18360,15 +18424,6 @@ function identityKeyOf(field, item) {
       return str(o.name) ?? str(o.id);
   }
 }
-function stepFieldsFor(type) {
-  const own = STEP_TYPE_FIELDS[type] ?? [];
-  const allowed = /* @__PURE__ */ new Set([...STEP_COMMON_FIELDS, ...own]);
-  for (const field of own) {
-    const twin = STEP_LABEL_TWINS[field];
-    if (twin) allowed.add(twin);
-  }
-  return allowed;
-}
 function reportIdentityOf(field, item) {
   if (item !== null && typeof item === "object") {
     const step = item.stepNumber;
@@ -18644,7 +18699,7 @@ function findLegacySpecFiles() {
 function updateSpec(kind, id, delta, hooks) {
   return current().updateSpec(kind, id, delta, hooks);
 }
-var fs11, path16, NO_ROOT_SUBSYSTEMS, SIGNATURE_TTL_MS, STEP_TYPE_FIELDS, STEP_COMMON_FIELDS, STEP_LABEL_TWINS, SpecWorkspace, workspaces;
+var fs11, path16, NO_ROOT_SUBSYSTEMS, SIGNATURE_TTL_MS, SpecWorkspace, workspaces;
 var init_specs2 = __esm({
   "src/core/specs.ts"() {
     "use strict";
@@ -18662,36 +18717,6 @@ var init_specs2 = __esm({
     init_diagram();
     NO_ROOT_SUBSYSTEMS = /* @__PURE__ */ new Set();
     SIGNATURE_TTL_MS = 2e3;
-    STEP_TYPE_FIELDS = {
-      local: [],
-      call: ["targetComponent", "targetMethod", "auth", "detach"],
-      register: ["targetComponent", "targetMethod"],
-      dispatch: ["targetComponent", "capability", "auth", "detach"],
-      branch: ["condition", "onTrueStep", "onFalseStep"],
-      switch: ["on", "cases", "defaultStep"],
-      loop: ["loopKind", "over", "condition", "endStep"],
-      try: ["endStep", "catches", "finallyStep"],
-      parallel: ["endStep", "branches"],
-      jump: ["toStep"],
-      return: ["outcome"],
-      throw: ["error"]
-    };
-    STEP_COMMON_FIELDS = [
-      "stepNumber",
-      "label",
-      "description",
-      "type",
-      "assertsGuarantees",
-      "assertsInvariants"
-    ];
-    STEP_LABEL_TWINS = {
-      onTrueStep: "onTrueLabel",
-      onFalseStep: "onFalseLabel",
-      defaultStep: "defaultLabel",
-      endStep: "endLabel",
-      finallyStep: "finallyLabel",
-      toStep: "toLabel"
-    };
     SpecWorkspace = class {
       constructor(rootDir) {
         this.cachedIndex = null;
@@ -25872,6 +25897,44 @@ var init_stereotype_migration = __esm({
   }
 });
 
+// src/core/narrative-repair.ts
+function repairForeignStepFields(apply) {
+  const implementations = loadImplementationSpecs();
+  const repairs = [];
+  const changed = [];
+  for (const impl of implementations) {
+    let touched = false;
+    for (const method of impl.methods) {
+      for (const step of method.narrative) {
+        const fields = narrativeStepForeignFields(step);
+        if (!fields.length) continue;
+        repairs.push({
+          implementation: impl.id,
+          method: method.name,
+          stepNumber: step.stepNumber,
+          stepType: step.type,
+          fields
+        });
+        for (const field of fields) delete step[field];
+        touched = true;
+      }
+    }
+    if (touched) changed.push(impl);
+  }
+  if (apply && changed.length) {
+    for (const impl of changed) saveImplementationSpec(impl);
+    invalidateSpecCache();
+  }
+  return repairs;
+}
+var init_narrative_repair = __esm({
+  "src/core/narrative-repair.ts"() {
+    "use strict";
+    init_specs2();
+    init_models();
+  }
+});
+
 // src/core/approver.ts
 function gitConfig(key) {
   try {
@@ -25952,6 +26015,7 @@ var init_core = __esm({
     init_treetransfer();
     init_provision();
     init_stereotype_migration();
+    init_narrative_repair();
     init_approval();
     init_approver();
     init_specs2();
@@ -26056,6 +26120,9 @@ __export(src_exports, {
   SCAN_EXCLUDE_DIRS: () => SCAN_EXCLUDE_DIRS,
   SDD_RULES: () => SDD_RULES,
   SEMANTIC_GUARANTEES: () => SEMANTIC_GUARANTEES,
+  STEP_COMMON_FIELDS: () => STEP_COMMON_FIELDS,
+  STEP_LABEL_TWINS: () => STEP_LABEL_TWINS,
+  STEP_TYPE_FIELDS: () => STEP_TYPE_FIELDS,
   SUPPORTED_ALIASES: () => SUPPORTED_ALIASES,
   SURFACE_AUDIENCES: () => SURFACE_AUDIENCES,
   SkillResourceNotFoundError: () => SkillResourceNotFoundError,
@@ -26269,6 +26336,7 @@ __export(src_exports, {
   methodSourceFile: () => methodSourceFile,
   methodTypeRefs: () => methodTypeRefs,
   moveSubsystemProject: () => moveSubsystemProject,
+  narrativeStepForeignFields: () => narrativeStepForeignFields,
   normalizeApprover: () => normalizeApprover,
   normalizeComponentLayout: () => normalizeComponentLayout,
   packDirEntry: () => packDirEntry,
@@ -26313,6 +26381,7 @@ __export(src_exports, {
   renderDomainsDoc: () => renderDomainsDoc,
   renderTemplateInstructions: () => renderTemplateInstructions,
   renderWaironGuide: () => renderWaironGuide,
+  repairForeignStepFields: () => repairForeignStepFields,
   resolveAgentTopology: () => resolveAgentTopology,
   resolveChainingParent: () => resolveChainingParent,
   resolveDomains: () => resolveDomains,
@@ -26351,6 +26420,7 @@ __export(src_exports, {
   stateIdEquals: () => stateIdEquals,
   stateIdString: () => stateIdString,
   stepConfigVerdict: () => stepConfigVerdict,
+  stepFieldsFor: () => stepFieldsFor,
   stepGraph: () => stepGraph,
   syncContextFiles: () => syncContextFiles,
   toMarkdown: () => toMarkdown,
@@ -26777,6 +26847,9 @@ function loadProjectConfig4() {
   SCAN_EXCLUDE_DIRS,
   SDD_RULES,
   SEMANTIC_GUARANTEES,
+  STEP_COMMON_FIELDS,
+  STEP_LABEL_TWINS,
+  STEP_TYPE_FIELDS,
   SUPPORTED_ALIASES,
   SURFACE_AUDIENCES,
   SkillResourceNotFoundError,
@@ -26990,6 +27063,7 @@ function loadProjectConfig4() {
   methodSourceFile,
   methodTypeRefs,
   moveSubsystemProject,
+  narrativeStepForeignFields,
   normalizeApprover,
   normalizeComponentLayout,
   packDirEntry,
@@ -27034,6 +27108,7 @@ function loadProjectConfig4() {
   renderDomainsDoc,
   renderTemplateInstructions,
   renderWaironGuide,
+  repairForeignStepFields,
   resolveAgentTopology,
   resolveChainingParent,
   resolveDomains,
@@ -27072,6 +27147,7 @@ function loadProjectConfig4() {
   stateIdEquals,
   stateIdString,
   stepConfigVerdict,
+  stepFieldsFor,
   stepGraph,
   syncContextFiles,
   toMarkdown,