@w5s/eslint-config 3.3.0 → 3.3.2

package/dist/index.js

@@ -6,7 +6,6 @@ import process from 'process';
 import { findUp } from 'find-up';
 import parseGitignore from 'parse-gitignore';
 import prettierConfig from '@w5s/prettier-config';
-import importPlugin from 'eslint-plugin-import';
 
 var __create = Object.create;
 var __defProp = Object.defineProperty;
@@ -375,13 +374,6 @@ var require_src = __commonJS({
 
 // src/config/es.ts
 var import_js = __toESM(require_src());
-function createRules(prefix) {
-  return ESLintConfig.renameRules({
-    "no-unused-vars": ["error", { argsIgnorePattern: "^_" }]
-  }, {
-    "": prefix
-  });
-}
 
 // src/rules/esRules/bestPractices.ts
 var bestPractices = () => ({
@@ -1150,7 +1142,6 @@ async function es(options) {
       files: defaultFiles,
       rules: {
         ...import_js.default.configs.recommended.rules,
-        ...createRules(""),
         ...esRules(),
         ...rules
       }
@@ -1248,9 +1239,7 @@ var StylisticConfig = {
 
 // src/config/jsdoc.ts
 async function jsdoc(options = {}) {
-  const [jsdocPlugin] = await Promise.all([
-    interopDefault(import('eslint-plugin-jsdoc'))
-  ]);
+  const [jsdocPlugin] = await Promise.all([interopDefault(import('eslint-plugin-jsdoc'))]);
   const { rules = {}, stylistic: stylistic2 = true } = options;
   const { enabled: stylisticEnabled } = StylisticConfig.from(stylistic2);
   return [
@@ -1263,21 +1252,22 @@ async function jsdoc(options = {}) {
     {
       name: "w5s/jsdoc/rules",
       rules: {
-        ...jsdocPlugin.configs["flat/recommended"].rules,
+        ...jsdocPlugin.configs["flat/recommended-typescript-flavor"].rules,
         "jsdoc/no-undefined-types": "off",
         // https://github.com/gajus/eslint-plugin-jsdoc/issues/839
         "jsdoc/require-hyphen-before-param-description": ["warn", "always"],
         "jsdoc/require-jsdoc": "off",
         "jsdoc/require-param-description": "off",
+        "jsdoc/require-param-type": "off",
         "jsdoc/require-returns": "off",
-        "jsdoc/tag-lines": ["warn", "any", { startLines: 1 }],
         "jsdoc/valid-types": "off",
         // FIXME: reports lots of false positive
         // 'strict': ['error', 'safe'],
         ...stylisticEnabled ? {
-          // ...(jsdocPlugin.configs['flat/stylistic'].rules),
+          ...jsdocPlugin.configs["flat/stylistic-typescript"].rules,
           "jsdoc/check-alignment": "warn",
-          "jsdoc/multiline-blocks": "warn"
+          "jsdoc/multiline-blocks": "warn",
+          "jsdoc/tag-lines": ["warn", "any", { startLines: 1 }]
         } : {},
         ...rules
       },
@@ -1525,18 +1515,25 @@ function sortPackageJson() {
     }
   };
 }
-var importConfig = importPlugin.flatConfigs["recommended"];
 async function imports(options = {}) {
   const { rules = {}, stylistic: stylistic2 = true } = options;
   const { enabled: stylisticEnabled } = StylisticConfig.from(stylistic2);
+  const [importPlugin] = await Promise.all([interopDefault(import('eslint-plugin-import'))]);
   return [
     {
       name: "w5s/import/rules",
-      plugins: importConfig.plugins ?? {},
+      plugins: {
+        import: importPlugin
+      },
       rules: {
-        ...importConfig?.rules,
+        // 'import/consistent-type-specifier-style': ['error', 'prefer-inline'],
+        "import/first": "error",
+        "import/no-duplicates": "error",
+        "import/no-mutable-exports": "error",
+        "import/no-named-default": "error",
         ...stylisticEnabled ? {
           // Stylistic rules
+          "import/newline-after-import": ["error", { count: 1 }]
         } : {},
         ...rules
       }
@@ -1640,6 +1637,138 @@ async function test(options = {}) {
     }
   ];
 }
+var tsRules = () => {
+  const baseRules = esRules();
+  return ESLintConfig.renameRules(
+    {
+      // '@typescript-eslint/comma-dangle': [
+      //   baseRules['comma-dangle'][0],
+      //   {
+      //     ...baseRules['comma-dangle'][1],
+      //     enums: baseRules['comma-dangle'][1].arrays,
+      //     generics: baseRules['comma-dangle'][1].arrays,
+      //     tuples: baseRules['comma-dangle'][1].arrays,
+      //   },
+      // ],
+      "@typescript-eslint/adjacent-overload-signatures": "error",
+      "@typescript-eslint/ban-ts-comment": [
+        "warn",
+        {
+          "minimumDescriptionLength": 3,
+          "ts-check": false,
+          "ts-expect-error": "allow-with-description",
+          "ts-ignore": "allow-with-description",
+          "ts-nocheck": true
+        }
+      ],
+      // '@typescript-eslint/brace-style': baseRules['brace-style'],
+      // '@typescript-eslint/comma-dangle': [
+      //   baseRules['comma-dangle'][0],
+      //   {
+      //     ...baseRules['comma-dangle'][1],
+      //     enums: baseRules['comma-dangle'][1].arrays,
+      //     generics: baseRules['comma-dangle'][1].arrays,
+      //     tuples: baseRules['comma-dangle'][1].arrays,
+      //   },
+      // ],
+      // '@typescript-eslint/comma-spacing': baseRules['comma-spacing'],
+      "@typescript-eslint/consistent-type-assertions": [
+        "error",
+        { assertionStyle: "as", objectLiteralTypeAssertions: "never" }
+      ],
+      "@typescript-eslint/default-param-last": baseRules["default-param-last"],
+      // '@typescript-eslint/dot-notation': baseRules['dot-notation'], // TODO: Stylistic typechecked
+      "@typescript-eslint/explicit-function-return-type": "off",
+      "@typescript-eslint/explicit-module-boundary-types": "off",
+      // '@typescript-eslint/func-call-spacing': baseRules['func-call-spacing'],
+      // '@typescript-eslint/indent': baseRules.indent,
+      // '@typescript-eslint/keyword-spacing': baseRules['keyword-spacing'],
+      // '@typescript-eslint/lines-between-class-members': baseRules['lines-between-class-members'],
+      // '@typescript-eslint/member-delimiter-style': 'error', // TODO: @stylistic/member-delimiter-style
+      "@typescript-eslint/naming-convention": [
+        "error",
+        // {
+        //   format: ['PascalCase', 'camelCase'],
+        //   leadingUnderscore: 'allow',
+        //   selector: 'default',
+        //   trailingUnderscore: 'allow',
+        // },
+        {
+          format: ["PascalCase", "camelCase", "UPPER_CASE"],
+          leadingUnderscore: "allow",
+          selector: "variable",
+          trailingUnderscore: "allow"
+        },
+        // {
+        //   format: ['PascalCase', 'camelCase', 'UPPER_CASE'],
+        //   leadingUnderscore: 'allowSingleOrDouble',
+        //   selector: 'memberLike',
+        //   trailingUnderscore: 'allowDouble',
+        // },
+        {
+          format: ["PascalCase"],
+          selector: "typeLike"
+        }
+      ],
+      // '@typescript-eslint/no-array-constructor': baseRules['no-array-constructor'],
+      // '@typescript-eslint/no-base-to-string': 'error', // TODO: require type check
+      "@typescript-eslint/no-dupe-class-members": baseRules["no-dupe-class-members"],
+      "@typescript-eslint/no-empty-function": baseRules["no-empty-function"],
+      "@typescript-eslint/no-empty-interface": ["error", { allowSingleExtends: true }],
+      "@typescript-eslint/no-empty-object-type": "off",
+      "@typescript-eslint/no-explicit-any": "off",
+      // if any is explicit then it's wanted
+      "@typescript-eslint/no-extra-parens": baseRules["no-extra-parens"],
+      // '@typescript-eslint/no-extra-semi': baseRules['no-extra-semi'], // TODO: @stylistic/no-extra-semi
+      "@typescript-eslint/no-inferrable-types": "error",
+      "@typescript-eslint/no-loop-func": baseRules["no-loop-func"],
+      "@typescript-eslint/no-loss-of-precision": baseRules["no-loss-of-precision"],
+      "@typescript-eslint/no-magic-numbers": baseRules["no-magic-numbers"],
+      "@typescript-eslint/no-misused-new": "error",
+      "@typescript-eslint/no-namespace": "off",
+      // We don't agree with community, namespaces are great and not deprecated
+      "@typescript-eslint/no-non-null-assertion": "error",
+      "@typescript-eslint/no-redeclare": ESLintConfig.fixme(baseRules["no-redeclare"]),
+      "@typescript-eslint/no-require-imports": "error",
+      "@typescript-eslint/no-shadow": baseRules["no-shadow"],
+      "@typescript-eslint/no-this-alias": "error",
+      // '@typescript-eslint/no-unnecessary-condition': 'error',// TODO: require type check
+      // '@typescript-eslint/no-unsafe-argument': 'error', // TODO: recommended type check
+      "@typescript-eslint/no-unused-expressions": baseRules["no-unused-expressions"],
+      "@typescript-eslint/no-unused-vars": baseRules["no-unused-vars"],
+      "@typescript-eslint/no-use-before-define": baseRules["no-use-before-define"],
+      "@typescript-eslint/no-useless-constructor": baseRules["no-useless-constructor"],
+      "@typescript-eslint/no-var-requires": "error",
+      "@typescript-eslint/no-wrapper-object-types": "error",
+      // '@typescript-eslint/object-curly-spacing': baseRules['object-curly-spacing'],
+      // '@typescript-eslint/only-throw-error': baseRules['no-throw-literal'], //TODO: Recommended type check
+      "@typescript-eslint/prefer-namespace-keyword": "error",
+      // '@typescript-eslint/prefer-reduce-type-parameter': 'error', // TODO: strict type check
+      // '@typescript-eslint/quotes': baseRules.quotes,
+      "@typescript-eslint/require-await": baseRules["require-await"],
+      // '@typescript-eslint/return-await': baseRules['no-return-await'], // TODO: strict type check
+      // '@typescript-eslint/semi': baseRules.semi,
+      // '@typescript-eslint/space-before-function-paren': baseRules['space-before-function-paren'],
+      // '@typescript-eslint/space-infix-ops': baseRules['space-infix-ops'],
+      // '@typescript-eslint/strict-boolean-expressions': [
+      //   'error',
+      //   {
+      //     allowNullableObject: false,
+      //     allowNumber: false,
+      //     allowString: false,
+      //   },
+      // ], //TODO: require typing
+      // '@typescript-eslint/switch-exhaustiveness-check': 'error',//TODO: require type check
+      "@typescript-eslint/triple-slash-reference": "error"
+      // '@typescript-eslint/type-annotation-spacing': 'error',// TODO: @stylistic/type-annotation-spacing
+    },
+    {
+      "@typescript-eslint": "ts"
+    }
+  );
+};
+
+// src/config/ts.ts
 var defaultFiles4 = [`**/${Project.extensionsToGlob(Project.queryExtensions(["typescript", "typescriptreact"]))}`];
 async function ts(options = {}) {
   const [tsPlugin, tsParser] = await Promise.all([
@@ -1679,45 +1808,23 @@ async function ts(options = {}) {
       },
       name: "w5s/ts/rules",
       rules: {
-        ...ESLintConfig.renameRules(
-          tsRecommendedRules,
-          { "@typescript-eslint": "ts" }
-        ),
-        ...ESLintConfig.renameRules(
-          tsStrictRules,
-          { "@typescript-eslint": "ts" }
-        ),
-        "ts/ban-ts-comment": [
-          "warn",
-          {
-            "minimumDescriptionLength": 3,
-            "ts-check": false,
-            "ts-expect-error": "allow-with-description",
-            "ts-ignore": "allow-with-description",
-            "ts-nocheck": true
-          }
-        ],
-        "ts/no-empty-object-type": "off",
-        "ts/no-explicit-any": "off",
-        // if any is explicit then it's wanted
-        "ts/no-namespace": "off",
-        // We don't agree with community, namespaces are great and not deprecated
-        ...createRules("ts/"),
+        ...ESLintConfig.renameRules(tsRecommendedRules, { "@typescript-eslint": "ts" }),
+        ...ESLintConfig.renameRules(tsStrictRules, { "@typescript-eslint": "ts" }),
+        ...tsRules(),
         ...stylisticEnabled ? {} : {},
         ...rules
       }
     },
-    ...typeChecked ? [{
-      files: defaultFiles4,
-      // ignores: ignoresTypeAware,
-      name: "w5s/ts/rules-type-checked",
-      rules: {
-        ...ESLintConfig.renameRules(
-          tsTypeCheckedRules,
-          { "@typescript-eslint": "ts" }
-        )
+    ...typeChecked ? [
+      {
+        files: defaultFiles4,
+        // ignores: ignoresTypeAware,
+        name: "w5s/ts/rules-type-checked",
+        rules: {
+          ...ESLintConfig.renameRules(tsTypeCheckedRules, { "@typescript-eslint": "ts" })
+        }
       }
-    }] : []
+    ] : []
   ];
 }
 async function unicorn(options = {}) {
@@ -1843,8 +1950,10 @@ async function yml(options = {}) {
 // src/defineConfig.ts
 async function defineConfig(options = {}) {
   const stylisticOptions = typeof options.stylistic === "boolean" ? { enabled: options.stylistic } : { enabled: true, ...options.stylistic };
-  const withDefaultStylistic = (options2) => ({ stylistic: stylisticOptions, ...options2 });
-  const toOption = (optionsOrBoolean) => withDefaultStylistic(typeof optionsOrBoolean === "boolean" ? { enabled: optionsOrBoolean } : { enabled: true, ...optionsOrBoolean });
+  const withDefaultStylistic = (_options) => ({ stylistic: stylisticOptions, ..._options });
+  const toOption = (optionsOrBoolean) => withDefaultStylistic(
+    typeof optionsOrBoolean === "boolean" ? { enabled: optionsOrBoolean } : { enabled: true, ...optionsOrBoolean }
+  );
   const esOptions = toOption(options.es);
   const importOptions = toOption(options.import);
   const jsdocOptions = toOption(options.jsdoc);