@w5s/eslint-config 1.0.0-alpha.6 → 1.0.0-alpha.9

package/ignore.js

@@ -0,0 +1,3 @@
+module.exports = {
+  ignorePatterns: ['**/dist/**', '**/lib/**'],
+};

package/index.js

@@ -1,11 +1,37 @@
 // http://eslint.org/docs/user-guide/configuring
+/**
+ * @param {string} name
+ */
+function tryResolve(name) {
+  try {
+    require.resolve(name);
+    return true;
+  } catch (_error) {
+    return false;
+  }
+}
+
+/**
+ * @template T
+ * @param {boolean} condition
+ * @param {T} value
+ */
+function includeIf(condition, value) {
+  return condition ? [value] : [];
+}
+
 module.exports = {
-  extends: [require.resolve('./es'), require.resolve('./react'), require.resolve('./json')],
+  extends: [
+    require.resolve('./ignore'),
+    require.resolve('./es'),
+    require.resolve('./json'),
+    ...includeIf(tryResolve('react'), require.resolve('./react')),
+  ],
   overrides: [
-    {
+    ...includeIf(tryResolve('typescript'), {
       extends: [require.resolve('./ts')],
       files: ['*.+(ts|tsx)'],
-    },
+    }),
     {
       extends: [require.resolve('./jest')],
       files: [
@@ -13,6 +39,11 @@ module.exports = {
         '**/__tests__/**/*.+(ts|tsx|js|jsx)',
         '**/?(*.)+(spec|test).+(ts|tsx|js|jsx)',
       ],
+      settings: {
+        jest: {
+          version: 'latest',
+        },
+      },
     },
   ],
   root: true,

package/json.js

@@ -1,4 +1,5 @@
 module.exports = {
+  ignorePatterns: ['**/tsconfig.json', '.vscode/**'], // To remove warning
   plugins: ['json-format'],
   settings: {
     'json/ignore-files': ['**/package-lock.json'],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@w5s/eslint-config",
-  "version": "1.0.0-alpha.6",
+  "version": "1.0.0-alpha.9",
   "description": "ESLint configuration presets",
   "keywords": [
     "eslint",
@@ -55,7 +55,7 @@
     "eslint-plugin-prettier": "^4.0.0",
     "eslint-plugin-react": "^7.28.0",
     "eslint-plugin-total-functions": "^5.0.0",
-    "eslint-plugin-unicorn": "^40.0.0"
+    "eslint-plugin-unicorn": "^41.0.0"
   },
   "devDependencies": {
     "@babel/eslint-parser": "7.17.0",
@@ -83,5 +83,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "79cf1b971006e8a0255763db12dd46938d228c78"
+  "gitHead": "0bf05f35388f1ddb53438a017186cf64d2ce99f2"
 }

package/rules/_rule.js

@@ -72,7 +72,7 @@ module.exports = {
   concatESConfig,
   error,
   // eslint-disable-next-line no-unused-vars
-  fixme: (/** @type {'off'|'warn'|'error'} */ _status) => off,
+  fixme: (/** @type {'off'|'warn'|'error'|undefined} */ _status) => off,
   off,
   warn,
 };

package/rules/base.js

@@ -34,6 +34,12 @@ module.exports = concatESConfig(
         // @ts-ignore
         ({ selector }) => selector !== 'ForOfStatement'
       ),
+      // underscore is often used (mongodb, etc)
+      'no-underscore-dangle': off,
+      // Ignore underscore case arguments
+      'no-unused-vars': [error, { argsIgnorePattern: '^_' }],
+      // Allow in some cases https://github.com/airbnb/javascript/issues/1089#issuecomment-1024351821
+      'no-use-before-define': [error, 'nofunc'],
     },
   }
 );

package/rules/jest.js

@@ -10,26 +10,21 @@ module.exports = concatESConfig(
     rules: {
       'jest/expect-expect': off, // Disabled because it does not handle functions that does the expect
       'jest/no-alias-methods': error,
-      'jest/no-commented-out-tests': error,
-      'jest/no-deprecated-functions': off,
-      'jest/no-disabled-tests': off,
-      'jest/no-done-callback': error,
-      'jest/no-export': off,
-      'jest/no-focused-tests': error,
-      'jest/no-identical-title': error,
-      'jest/no-restricted-matchers': [
-        error,
-        {
-          toBeFalsy: 'Avoid `toBeFalsy`',
-          toBeTruthy: 'Avoid `toBeTruthy`',
-        },
-      ],
       'jest/prefer-spy-on': error,
       'jest/prefer-to-contain': error,
-      'jest/valid-expect': error,
       'jest/valid-title': [error, { ignoreTypeOfDescribeName: true }],
     },
   },
+  /**
+   * Unicorn less strict to help writing tests
+   */
+  {
+    rules: {
+      'unicorn/consistent-function-scoping': off,
+      'unicorn/no-useless-undefined': off,
+      'unicorn/prefer-module': off,
+    },
+  },
   /**
    * Typescript config is set to be less strict because we often have "hack", "mock" in tests
    */

package/rules/jsdoc.js

@@ -1,20 +1,9 @@
-const { off, warn, error } = require('./_rule');
+const { off } = require('./_rule');
 
 module.exports = {
+  extends: ['plugin:jsdoc/recommended'],
   plugins: ['jsdoc'],
   rules: {
-    'jsdoc/check-param-names': warn,
-    'jsdoc/check-tag-names': warn,
-    'jsdoc/check-types': warn,
-    'jsdoc/newline-after-description': [warn, 'always'],
-    'jsdoc/require-description': off,
-    'jsdoc/require-description-complete-sentence': off,
-    'jsdoc/require-hyphen-before-param-description': off,
-    'jsdoc/require-param': off,
-    'jsdoc/require-param-description': off,
-    'jsdoc/require-param-name': error,
-    'jsdoc/require-param-type': off,
-    'jsdoc/require-returns-description': off,
-    'jsdoc/require-returns-type': off,
+    'jsdoc/require-jsdoc': off,
   },
 };

package/rules/typescript.js

@@ -130,6 +130,18 @@ module.exports = concatESConfig(
       '@typescript-eslint/type-annotation-spacing': error,
     },
   },
+  /**
+   * JSDoc overrides
+   */
+  {
+    rules: {
+      'jsdoc/no-types': error,
+      'jsdoc/require-param': off,
+      'jsdoc/require-param-type': off,
+      'jsdoc/require-returns': off,
+      'jsdoc/require-returns-type': off,
+    },
+  },
   /**
    * Import overrides
    */
@@ -214,7 +226,7 @@ module.exports = concatESConfig(
       'no-undef': off,
       'no-unreachable': off,
       'no-unsafe-negation': off,
-      'no-unused-expression': off,
+      'no-unused-expressions': off,
       'no-unused-vars': off,
       'no-use-before-define': off,
       'no-useless-constructor': off,

package/rules/unicorn.js

@@ -49,7 +49,10 @@ module.exports = concatESConfig(
   {
     rules: {
       'unicorn/consistent-destructuring': off,
+      'unicorn/no-array-callback-reference': off, // Many false positive reported
       'unicorn/no-array-for-each': off, // This rule could change browser compatibility
+      'unicorn/no-array-method-this-argument': off, // Many false positive reported
+      'unicorn/no-array-reduce': off, // Array#reduce can be used
       'unicorn/no-object-as-default-parameter': off,
       'unicorn/prefer-default-parameters': off,
       'unicorn/prevent-abbreviations': off, // This rule is so dangerous : it potentially break code while fixing in many cases !!