@vzn/vx 0.0.640 → 0.0.642

package/src/workspace/workspace.ts

@@ -188,14 +188,19 @@ export function linkDiscoveredEdges(
       [edge.reach, reach],
     ] as const) {
       for (const target of kind) {
-        const dir = path.resolve(root, target)
-        const rel = relPosix(root, dir)
-        const where = `plugin '${edge.by}' gave project "${edge.meta.name}" an edge to ${target}`
-        if (rel === '..' || rel.startsWith('../') || path.isAbsolute(rel)) {
-          throw new UserError(`${where}: outside the workspace root`)
+        // Every project lies inside the root (`discoveredProject` refuses
+        // one that does not), so a target naming one needs no other check:
+        // a plugin hands project dirs as they are, absolute, and resolving
+        // and judging each of 5,000 edges was ~15 ms at 1,000 projects.
+        const name = byDir.get(target) ?? byDir.get(path.resolve(root, target))
+        if (name === undefined) {
+          const rel = relPosix(root, path.resolve(root, target))
+          const where = `plugin '${edge.by}' gave project "${edge.meta.name}" an edge to ${target}`
+          if (rel === '..' || rel.startsWith('../') || path.isAbsolute(rel)) {
+            throw new UserError(`${where}: outside the workspace root`)
+          }
+          throw new UserError(`${where}: not a project`)
         }
-        const name = byDir.get(dir)
-        if (name === undefined) throw new UserError(`${where}: not a project`)
         let set = into.get(edge.meta)
         if (set === undefined) into.set(edge.meta, (set = new Set()))
         set.add(name)
@@ -417,12 +422,13 @@ export function lockedProjects(
  * The project a plugin's `discover` entry names: a new meta (`added`) for a
  * directory that is not a project yet, else the project already there,
  * renamed when its name was its path's. A config's `name` wins over the
- * plugin's; a name another plugin gave is not changed. `by` names the
- * plugin in a refusal.
+ * plugin's; a name another plugin gave is not changed. `known` is the
+ * projects by directory: a scan per entry was quadratic, 106 ms of a 5,000
+ * project warm run. `by` names the plugin in a refusal.
  */
 export async function discoveredProject(
   root: string,
-  known: readonly ProjectMeta[],
+  known: ReadonlyMap<string, ProjectMeta>,
   entry: {
     readonly dir: string
     readonly name?: string
@@ -456,7 +462,7 @@ export async function discoveredProject(
     throw new UserError(`${where}${named} at ${dir}: outside the workspace root`)
   }
   const shown = rel === '' ? '.' : rel
-  const meta = known.find((p) => p.dir === dir)
+  const meta = known.get(dir)
   if (meta !== undefined) {
     const from = namedBy.get(meta)
     if (name === undefined || name === meta.name || from === 'config') return { meta, added: false }