@vzn/vx 0.0.554 → 0.0.556

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vzn/vx",
-  "version": "0.0.554",
+  "version": "0.0.556",
   "description": "The fastest task runner and build cache for JavaScript monorepos.",
   "type": "module",
   "exports": {
@@ -21,10 +21,10 @@
     "node": ">=18"
   },
   "optionalDependencies": {
-    "@vzn/vx-linux-x64": "0.0.554",
-    "@vzn/vx-linux-arm64": "0.0.554",
-    "@vzn/vx-darwin-x64": "0.0.554",
-    "@vzn/vx-darwin-arm64": "0.0.554"
+    "@vzn/vx-linux-x64": "0.0.556",
+    "@vzn/vx-linux-arm64": "0.0.556",
+    "@vzn/vx-darwin-x64": "0.0.556",
+    "@vzn/vx-darwin-arm64": "0.0.556"
   },
   "dependencies": {
     "@anthropic-ai/sandbox-runtime": "^0.0.76"

package/src/cache/inputs.ts

@@ -739,11 +739,15 @@ function stampFiles(files: readonly string[]): Map<string, OutputStamp> {
  * a current tree, so no new trust is introduced. A file the run rewrote
  * with identical bytes counts as its own (the mtime moved), which is the
  * rewrite-in-place cost the design note records.
+ *
+ * Undefined when the run REMOVED a file it found: an artifact holds what a
+ * run wrote, never what it took away, and the upstream's restore puts the
+ * file back, so no entry reproduces that run and none is saved.
  */
 export async function ownOutputsSince(
   args: { projectDir: string; outputs: string[]; nestedProjectDirs: string[] },
   before: ReadonlyMap<string, OutputStamp>,
-): Promise<string[]> {
+): Promise<string[] | undefined> {
   return changedSince(await resolveOutputs(args), before)
 }
 
@@ -751,15 +755,16 @@ export async function ownOutputsSince(
 export async function ownWorkspaceOutputsSince(
   args: { workspaceRoot: string; outputs: string[] },
   before: ReadonlyMap<string, OutputStamp>,
-): Promise<string[]> {
+): Promise<string[] | undefined> {
   return changedSince(await resolveWorkspaceOutputs(args), before)
 }
 
 function changedSince(
   after: readonly string[],
   before: ReadonlyMap<string, OutputStamp>,
-): string[] {
+): string[] | undefined {
   const own: string[] = []
+  let kept = 0
   for (const f of after) {
     const was = before.get(f)
     if (was === undefined) {
@@ -768,12 +773,13 @@ function changedSince(
     }
     try {
       const st = lstatSync(f)
+      kept++
       if (st.size !== was.size || st.mtimeMs !== was.mtimeMs) own.push(f)
     } catch {
-      // Vanished since the walk: not an output.
+      // Vanished since the walk: removed, as one the walk missed is.
     }
   }
-  return own
+  return kept < before.size ? undefined : own
 }
 
 /**

package/src/orchestrator/execute-task.ts

@@ -1213,6 +1213,7 @@ async function executeCachedTask(args: ExecuteArgs): Promise<TaskOutcome> {
 
   const wallclockEndNs = process.hrtime.bigint() - args.runStartHrTimeNs
 
+  let own: Awaited<ReturnType<typeof ownOutputs>>
   if (effectiveExitCode === 0 && willSave && deferralRequested) {
     // The outputs never landed here: no artifact, no rows. A partial local
     // record (a row with no artifact) is exactly the corrupt-entry shape
@@ -1234,18 +1235,14 @@ async function executeCachedTask(args: ExecuteArgs): Promise<TaskOutcome> {
         },
       })
     }
-  } else if (effectiveExitCode === 0 && willSave && (await keyStillTrue())) {
-    const ownOutputFiles =
-      additive && stampedBefore !== undefined
-        ? await ownOutputsSince(cleanArgs, stampedBefore)
-        : undefined
-    const ownWsOutputFiles =
-      additive && wsStampedBefore !== undefined
-        ? await ownWorkspaceOutputsSince(wsCleanArgs, wsStampedBefore)
-        : undefined
+  } else if (
+    effectiveExitCode === 0 &&
+    willSave &&
+    (await keyStillTrue()) &&
+    (own = await ownOutputs()) !== undefined
+  ) {
     const { landed } = await saveMiss({
-      ...(ownOutputFiles !== undefined ? { ownOutputFiles } : {}),
-      ...(ownWsOutputFiles !== undefined ? { ownWsOutputFiles } : {}),
+      ...own,
       node,
       hash,
       cache,
@@ -1302,6 +1299,28 @@ async function executeCachedTask(args: ExecuteArgs): Promise<TaskOutcome> {
     return true
   }
 
+  /**
+   * What an additive run saves as its own, or undefined when it removed a
+   * file it found: no entry replays a removal (`ownOutputsSince`), so the
+   * task saves nothing and runs again.
+   */
+  async function ownOutputs(): Promise<
+    { ownOutputFiles?: string[]; ownWsOutputFiles?: string[] } | undefined
+  > {
+    const mine: { ownOutputFiles?: string[]; ownWsOutputFiles?: string[] } = {}
+    if (stampedBefore !== undefined) {
+      const files = await ownOutputsSince(cleanArgs, stampedBefore)
+      if (files === undefined) return undefined
+      mine.ownOutputFiles = files
+    }
+    if (wsStampedBefore !== undefined) {
+      const files = await ownWorkspaceOutputsSince(wsCleanArgs, wsStampedBefore)
+      if (files === undefined) return undefined
+      mine.ownWsOutputFiles = files
+    }
+    return mine
+  }
+
   /**
    * The input that no longer holds what the key folded: `null` when the
    * key re-derived just before the command already differed (the file

package/src/workspace/config-schema.ts

@@ -24,6 +24,9 @@ import {
   UserError,
   BUN_GLOB_WILDCARDS,
   EXTGLOB,
+  anyTaskGlob,
+  asTrees,
+  isLiteralPattern,
 } from '../util/index.js'
 import { nonJsonMessage, nonJsonPaths } from './json-data.js'
 
@@ -722,6 +725,7 @@ export function validateProjectConfig(config: ProjectConfig, configPath: string)
       // error for the same reason. Refusing costs nothing: such a config was
       // already silently broken, so no working key changes.
       assertNotNegationOnly((inputs as { files: string[] }).files, `${where}.cache.inputs.files`)
+      assertNoLiteralTakenBack((inputs as { files: string[] }).files, `${where}.cache.inputs.files`)
       // The only CacheInputs field that reached the run unvalidated: a
       // non-string entry crashes deep in `filterUpstreamHashes` /
       // `parseDependencySpec` with a raw TypeError naming neither the task
@@ -1338,6 +1342,28 @@ function assertNotNegationOnly(globs: readonly string[], where: string): void {
   )
 }
 
+/**
+ * A `!` entry subtracts wherever it sits in the list, so a file named
+ * outright after it (`['src/**', '!src/gen/**', 'src/gen/keep.ts']`) never
+ * entered the key, and an edit to it replayed the old output. Refusing is
+ * free: the literal already selected nothing.
+ */
+function assertNoLiteralTakenBack(globs: readonly string[], where: string): void {
+  const negative = globs.filter((g) => g.startsWith('!')).map((g) => g.slice(1))
+  if (negative.length === 0) return
+  const taken = anyTaskGlob(asTrees(negative))
+  for (const g of globs) {
+    if (g.startsWith('!')) continue
+    const lit = normalizeGlob(g).replace(/\/+$/, '')
+    if (!isLiteralPattern(lit) || !taken(lit)) continue
+    const by = negative.find((n) => anyTaskGlob(asTrees([n]))(lit))
+    throw new UserError(
+      `${where}: "${g}" is taken back by "!${by}" — a \`!\` entry subtracts wherever it sits in ` +
+        `the list, so the file never enters the key. Narrow the negation so it leaves "${g}".`,
+    )
+  }
+}
+
 /**
  * `negation: false` for OUTPUT globs: a `!` entry takes a path back (A-44),
  * and a list of only negations selects nothing and is refused.
@@ -1370,8 +1396,10 @@ function validateWorkspaceGlobs(v: unknown, where: string, negation: boolean): v
     }
     assertNotDoubleNegated(g, where)
   }
-  if (negation) assertNotNegationOnly(v as string[], where)
-  else assertOutputsNotNegationOnly(v as string[], where)
+  if (negation) {
+    assertNotNegationOnly(v as string[], where)
+    assertNoLiteralTakenBack(v as string[], where)
+  } else assertOutputsNotNegationOnly(v as string[], where)
 }
 
 /**