@vzn/vx 0.0.412 → 0.0.414

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vzn/vx",
-  "version": "0.0.412",
+  "version": "0.0.414",
   "description": "The fastest task runner and build cache for JavaScript monorepos.",
   "type": "module",
   "exports": {
@@ -21,10 +21,10 @@
     "node": ">=18"
   },
   "optionalDependencies": {
-    "@vzn/vx-linux-x64": "0.0.412",
-    "@vzn/vx-linux-arm64": "0.0.412",
-    "@vzn/vx-darwin-x64": "0.0.412",
-    "@vzn/vx-darwin-arm64": "0.0.412"
+    "@vzn/vx-linux-x64": "0.0.414",
+    "@vzn/vx-linux-arm64": "0.0.414",
+    "@vzn/vx-darwin-x64": "0.0.414",
+    "@vzn/vx-darwin-arm64": "0.0.414"
   },
   "dependencies": {
     "@anthropic-ai/sandbox-runtime": "^0.0.76"

package/src/cli/select.ts

@@ -3,7 +3,6 @@
 // cwd sits in, and the interactive picker. Every read of the workspace
 // here goes through the staged load, so the answer is the run's.
 
-import readline from 'node:readline/promises'
 import path from 'node:path'
 import fs from 'node:fs'
 import {
@@ -404,6 +403,9 @@ export async function pickTask(
     const desc = e.description ? `  ${e.description}` : ''
     out.write(`  ${n}. ${id}${desc}\n`)
   })
+  // Imported here, the picker's one use: a run that never asks paid ~0.7 ms
+  // for it at every start, past the stdout stream it shares code with.
+  const readline = await import('node:readline/promises')
   const rl = readline.createInterface({
     input: io.input ?? process.stdin,
     output: io.output ?? process.stdout,

package/src/workspace/migrate-scripts.ts

@@ -661,12 +661,15 @@ export function migrateScripts(
   // the task, so `--all` never runs one check twice.
   const outsideName =
     typeof outside?.['name'] === 'string' && outside['name'] !== '' ? outside['name'] : undefined
+  // insomnia's root is named as its `packages/insomnia`: a root config made
+  // it a project, and every later run was refused for the duplicate (D-129).
+  const clash = outsideName === undefined ? undefined : metas.find((m) => m.name === outsideName)
   const rootMeta: ProjectMeta | undefined =
     root !== undefined
       ? root.configPath === null
         ? root
         : undefined
-      : outsideName !== undefined && outsideDir !== undefined
+      : outsideName !== undefined && outsideDir !== undefined && clash === undefined
         ? { name: outsideName, dir: outsideDir, packageJson: outside as never, configPath: null }
         : undefined
   const memberTasks = new Set(
@@ -774,6 +777,11 @@ export function migrateScripts(
           ? `; left out as a member's task name, so \`--all\` never runs one twice: ${listed(shared)} — one that does other work maps by hand under a name of its own`
           : ''),
     )
+  } else if (clash !== undefined && outsideDir !== undefined && unnamedMaps().length > 0) {
+    const would = unnamedMaps()
+    notes.push(
+      `${clash.name} (the workspace root) not mapped: ${path.relative(outsideDir, clash.dir).split(path.sep).join('/')} has the same "name", and vx names a project by it; rename the root's and run \`vx init\` again to map ${would.length} of its scripts (${would.slice(0, 8).join(', ')}${would.length > 8 ? ', …' : ''})`,
+    )
   } else if (rootName === 'package.json' && outsideDir !== undefined && unnamedMaps().length > 0) {
     // react's nameless root: "its scripts run the workspace" was not why,
     // and 30 of its scripts (`build`, `lint`, `test`) map once it has a

package/src/workspace/migration.ts

@@ -10,7 +10,7 @@ import { unlink } from 'node:fs/promises'
 import path from 'node:path'
 import { executablePath, relPosix, UserError } from '../util/index.js'
 import type { ProjectMeta } from './workspace.js'
-import { loadWorkspace, unreachedHint, unreachedPackages } from './workspace.js'
+import { loadWorkspace, reachesManifest, unreachedHint, unreachedPackages } from './workspace.js'
 import { WORKSPACE_CONFIG_FILENAMES } from './project-loader.js'
 
 /**
@@ -357,8 +357,10 @@ export async function applyMigration(args: ApplyMigrationArgs): Promise<number>
   // Globs that reach no package: "no scripts" was true and named nothing
   // to fix (M-42).
   const globs = workspace?.packageGlobs.filter((g) => g !== '.') ?? []
+  // Asked of the globs, not of `metas`: a nameless or shared-name member
+  // is matched yet absent from `metas` (M-46).
   const noMembers =
-    globs.length > 0 && metas.every((m) => path.resolve(m.dir) === path.resolve(root))
+    workspace !== undefined && globs.length > 0 && !(await reachesManifest(workspace))
       ? [
           `the workspace globs (${globs.map((g) => `"${g}"`).join(', ')}) match no package.json: add a package under one, or fix the glob`,
         ]

package/src/workspace/workspace.ts

@@ -395,6 +395,28 @@ export function memberBaseDirs(workspace: Workspace): string[] {
   return [...bases]
 }
 
+/**
+ * True when a member glob reaches a `package.json` other than the root's,
+ * addressable or not: a nameless manifest, or two sharing a name, is
+ * matched and left out, not unmatched (M-46).
+ */
+export async function reachesManifest(workspace: Workspace): Promise<boolean> {
+  const { positive, negative } = splitPackageGlobs(workspace.packageGlobs)
+  const root = path.resolve(workspace.root)
+  for (const pattern of positive) {
+    for (const dir of await memberDirs(workspace.root, pattern)) {
+      if (path.resolve(dir) === root) continue
+      if (negative.length > 0 && excludedBy(relPosix(workspace.root, dir), negative)) continue
+      try {
+        if ((await stat(path.join(dir, 'package.json'))).isFile()) return true
+      } catch (err) {
+        absent(err, undefined)
+      }
+    }
+  }
+  return false
+}
+
 /**
  * The directories a workspace glob names. For the `<dir>/*` shape this is
  * one readdir of `<dir>` — the same answer `Bun.Glob` gives, at a third of