@vzn/vx 0.0.325 → 0.0.327

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vzn/vx",
-  "version": "0.0.325",
+  "version": "0.0.327",
   "description": "A fast, correct task runner and build cache for JavaScript monorepos.",
   "type": "module",
   "exports": {
@@ -21,10 +21,10 @@
     "node": ">=18"
   },
   "optionalDependencies": {
-    "@vzn/vx-linux-x64": "0.0.325",
-    "@vzn/vx-linux-arm64": "0.0.325",
-    "@vzn/vx-darwin-x64": "0.0.325",
-    "@vzn/vx-darwin-arm64": "0.0.325"
+    "@vzn/vx-linux-x64": "0.0.327",
+    "@vzn/vx-linux-arm64": "0.0.327",
+    "@vzn/vx-darwin-x64": "0.0.327",
+    "@vzn/vx-darwin-arm64": "0.0.327"
   },
   "dependencies": {
     "@anthropic-ai/sandbox-runtime": "^0.0.76"

package/src/cli/task-verb.ts

@@ -4,7 +4,7 @@
 // does it. It stays a refusal: a verb that runs whatever task shares its
 // name would change meaning the day a plugin declares that verb.
 
-import { nxProjectTarget } from '../orchestrator/index.js'
+import { nxProjectTarget, projectNamed } from '../orchestrator/index.js'
 import { findWorkspaceRoot, loadWorkspace } from '../workspace/index.js'
 import { findCwdProject } from './select.js'
 import { discoverCliProjects, loadCliProjects } from './workspace-config.js'
@@ -20,7 +20,7 @@ export async function taskVerbHint(
   if (projects === null) return null
   if (![...projects.values()].some((p) => p.config.tasks?.[command] !== undefined)) return null
   // Nx's `nx build app`: the word after the target is its project.
-  const project = rest[0] !== undefined && projects.has(rest[0]) ? rest[0] : undefined
+  const project = rest[0] === undefined ? undefined : projectNamed(rest[0], projects)
   const run =
     project !== undefined
       ? `vx run ${command} --filter ${project}`

package/src/orchestrator/index.ts

@@ -1,7 +1,7 @@
 // Module contract for `orchestrator`. Cross-module imports must come
 // through here (enforced by tests/module-boundaries.test.ts).
 
-export { run, planRun, nxProjectTarget } from './run.js'
+export { run, planRun, nxProjectTarget, projectNamed } from './run.js'
 export { prepareRun, type PreparedRun } from './prepare.js'
 export {
   discoverProjects,

package/src/orchestrator/prepare.ts

@@ -111,8 +111,10 @@ export interface PreparedRun {
    * selection (the cwd's project, a `--filter`) declares: no typo, a scope.
    */
   declaredElsewhere: readonly string[]
-  /** Every discovered project — the declared task names a typo is measured against. */
+  /** The loaded projects: the whole workspace, or a scoped run's closure. */
   projects: ReadonlyMap<string, ProjectEntry>
+  /** What a typo is measured against: `projects`, or every project when a `pkg#task` named none loaded. */
+  hintProjects: ReadonlyMap<string, ProjectEntry>
   /**
    * True iff at least one package in the workspace has a `vx.config.*` at
    * all — regardless of scope, so a `--filter` that matched nothing is not
@@ -353,6 +355,24 @@ export async function prepareRun(options: RunOptions, log: Logger): Promise<Prep
     }
     declaredElsewhere = bare.filter((t) => !nowhere.includes(t))
   }
+  // A `pkg#task` run loads pkg's closure alone, so a typo'd pkg (or Nx's
+  // short name for `@scope/pkg`) was measured against nothing and got no
+  // "did you mean". Only a failing run pays for the rest of the workspace.
+  let hintProjects: ReadonlyMap<string, ProjectEntry> = projects
+  if (
+    unresolvedTasks.some((t) => {
+      const at = t.indexOf('#')
+      return at > 0 && !projects.has(t.slice(0, at))
+    })
+  ) {
+    try {
+      hintProjects = (
+        await loadProjects({ ...loadArgs, seeds: 'all', closure: false, staged: projects })
+      ).projects
+    } catch {
+      // A config the scope skipped fails to load: no hint, the run's refusal stands.
+    }
+  }
 
   // Cache seam precedence: an EXPLICITLY injected remote layer
   // (RunOptions.remoteCache — a distribution agent or daemon that already
@@ -438,6 +458,7 @@ export async function prepareRun(options: RunOptions, log: Logger): Promise<Prep
         unresolvedTasks,
         declaredElsewhere,
         projects,
+        hintProjects,
         anyProjectConfig: projectsWithConfigs.length > 0,
         workspaceFingerprint,
         fingerprintWatch,
@@ -558,6 +579,7 @@ export async function prepareRun(options: RunOptions, log: Logger): Promise<Prep
       unresolvedTasks,
       declaredElsewhere,
       projects,
+      hintProjects,
       anyProjectConfig: projectsWithConfigs.length > 0,
       workspaceFingerprint,
       fingerprintWatch,

package/src/orchestrator/run.ts

@@ -273,7 +273,7 @@ async function runOnBus(
   // case too; the message is identical, so that branch stays below.
   if (prepared.unresolvedTasks.length > 0) {
     log.status(
-      `No projects declare task(s): ${prepared.unresolvedTasks.join(', ')}.${elsewhereHint(prepared.declaredElsewhere)}${didYouMean(prepared.unresolvedTasks, prepared.projects)}${await initHint(prepared)}`,
+      `No projects declare task(s): ${prepared.unresolvedTasks.join(', ')}.${elsewhereHint(prepared.declaredElsewhere)}${didYouMean(prepared.unresolvedTasks, prepared.hintProjects)}${await initHint(prepared)}`,
     )
     await teardown()
     prepared.cache.close()
@@ -1210,7 +1210,7 @@ export async function planRun(options: RunOptions): Promise<RunPlan> {
       return {
         tasks: [],
         unresolvedTasks: prepared.unresolvedTasks,
-        unresolvedHint: `${elsewhereHint(prepared.declaredElsewhere)}${didYouMean(prepared.unresolvedTasks, prepared.projects)}${await initHint(prepared)}`,
+        unresolvedHint: `${elsewhereHint(prepared.declaredElsewhere)}${didYouMean(prepared.unresolvedTasks, prepared.hintProjects)}${await initHint(prepared)}`,
       }
     }
     if (prepared.empty === 'no-tasks-declared' && prepared.declaredElsewhere.length > 0) {
@@ -1323,7 +1323,7 @@ function didYouMean(
     }
     const [proj, task] = [spec.slice(0, at), spec.slice(at + 1)]
     if (!projects.has(proj)) {
-      const p = nearest(proj, projects.keys())
+      const p = projectNamed(proj, projects) ?? nearest(proj, projects.keys())
       if (p !== undefined && tasksOf(projects.get(p)).includes(task)) hints.add(`${p}#${task}`)
       continue
     }
@@ -1344,12 +1344,28 @@ export function nxProjectTarget(
 ): string | undefined {
   const colon = spec.indexOf(':')
   if (colon <= 0 || spec.includes('#')) return undefined
-  const [project, task] = [spec.slice(0, colon), spec.slice(colon + 1)]
-  return projects.get(project)?.config.tasks?.[task] === undefined
+  const [typed, task] = [spec.slice(0, colon), spec.slice(colon + 1)]
+  const project = projectNamed(typed, projects)
+  return project === undefined || projects.get(project)?.config.tasks?.[task] === undefined
     ? undefined
     : `${project}#${task}`
 }
 
+/**
+ * The project a typed name means: itself, else the one project whose
+ * scoped name ends in it. Nx names nx-examples' `@nx-example/cart` `cart`,
+ * and `nx run cart:build` is what its users type.
+ */
+export function projectNamed(
+  typed: string,
+  projects: ReadonlyMap<string, ProjectEntry>,
+): string | undefined {
+  if (projects.has(typed)) return typed
+  if (typed.includes('/')) return undefined
+  const scoped = [...projects.keys()].filter((n) => n.startsWith('@') && n.endsWith(`/${typed}`))
+  return scoped.length === 1 ? scoped[0] : undefined
+}
+
 /** The executed, keyed outcomes of a run — what flakiness is judged on. */
 function flakyCandidates(outcomes: readonly TaskOutcome[]): FlakyCandidate[] {
   const out: FlakyCandidate[] = []

package/src/workspace/filter.ts

@@ -41,6 +41,12 @@ export interface ParsedFilter {
    * concrete set of project names before calling applyFilters.
    */
   gitSince?: string
+  /**
+   * `<name>...[<since>]`: the named packages that changed OR depend on one
+   * that did, as Turbo reads it (2.5.8: `@acme/api...[HEAD]` is api when
+   * only its dependency db changed). Not a walk: no dependency is added.
+   */
+  sinceViaDeps?: true
   /** A path form carrying a glob (`./packages/*`): matched over the root-relative project dir. */
   pathGlob?: Bun.Glob
   /** The workspace root `pathGlob` is relative to. */
@@ -94,9 +100,16 @@ export function parseFilter(raw: string, workspaceRoot: string): ParsedFilter {
   // An unbraced path keeps its brackets: `./packages/[abc]` is a glob
   // class, and Turbo takes a directory with a ref only as `{dir}[ref]`.
   const scoped = /^(.+)\[([^\]]+)\]$/.exec(s)
+  let sinceViaDeps = false
   if (scoped !== null && !scoped[1]!.startsWith('./') && scoped[1] !== '.') {
     s = scoped[1]!
     gitSince = scoped[2]!
+    // The name glob kept the `...` and matched nothing (create-t3-turbo,
+    // `@acme/*...[HEAD]`).
+    if (s.endsWith('...') && !s.endsWith('^...')) {
+      s = s.slice(0, -3)
+      sinceViaDeps = true
+    }
   }
 
   // `...`, `!`, `^...`: the operators with no project between them. An
@@ -122,6 +135,7 @@ export function parseFilter(raw: string, workspaceRoot: string): ParsedFilter {
       matcher: path.resolve(workspaceRoot),
       exactDir: true,
       ...(gitSince !== undefined ? { gitSince } : {}),
+      ...(sinceViaDeps ? { sinceViaDeps: true as const } : {}),
     }
   }
 
@@ -158,6 +172,7 @@ export function parseFilter(raw: string, workspaceRoot: string): ParsedFilter {
     matcher,
     ...(pathGlob !== undefined ? { pathGlob, pathRoot: workspaceRoot } : {}),
     ...(gitSince !== undefined ? { gitSince } : {}),
+    ...(sinceViaDeps ? { sinceViaDeps: true as const } : {}),
   }
 }
 
@@ -165,12 +180,18 @@ function matchProjects(
   filter: ParsedFilter,
   projects: ProjectMeta[],
   affectedByFilter: Map<ParsedFilter, Set<string>> | undefined,
+  graph: PackageGraph,
 ): string[] {
   // `[<since>]` selectors are pre-resolved by the caller (the parser
   // is pure; git access happens upstream). Use the provided set as
   // the match set for this filter.
   if (filter.gitSince !== undefined) {
-    const changed = affectedByFilter?.get(filter) ?? new Set<string>()
+    let changed = affectedByFilter?.get(filter) ?? new Set<string>()
+    if (filter.sinceViaDeps === true) {
+      changed = new Set(changed)
+      for (const name of [...changed])
+        for (const d of graph.transitiveDependents(name)) changed.add(d)
+    }
     if (filter.matcher === '') return [...changed]
     return matchSelector(filter, projects).filter((name) => changed.has(name))
   }
@@ -268,7 +289,7 @@ export function applyFilters(opts: ApplyFiltersOptions): Set<string> {
   // taken in argv order, so `onNoMatch` names the filters as typed.
   const excludes: Set<string>[] = []
   for (const f of opts.filters) {
-    const matched = matchProjects(f, opts.projects, opts.affectedByFilter)
+    const matched = matchProjects(f, opts.projects, opts.affectedByFilter, opts.graph)
     if (matched.length === 0) opts.onNoMatch?.(f)
     const expanded = new Set<string>()
     for (const name of matched) {
@@ -277,7 +298,14 @@ export function applyFilters(opts: ApplyFiltersOptions): Set<string> {
         for (const d of opts.graph.transitiveDeps(name)) expanded.add(d)
       }
       if (f.withDependents) {
-        for (const d of opts.graph.transitiveDependents(name)) expanded.add(d)
+        // Both walks: the dependents' own dependencies too, as Turbo 2.5.8
+        // selects (`...db...` on create-t3-turbo ran the ui and validators
+        // its apps build on; vx ran db's dependencies alone).
+        const both = f.withDeps || f.onlyDeps
+        for (const d of opts.graph.transitiveDependents(name)) {
+          expanded.add(d)
+          if (both) for (const dd of opts.graph.transitiveDeps(d)) expanded.add(dd)
+        }
       }
     }
     if (matched.length > 0 && expanded.size === 0) opts.onEmptyWalk?.(f, matched)