@vzn/vx 0.0.306 → 0.0.308

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vzn/vx",
-  "version": "0.0.306",
+  "version": "0.0.308",
   "description": "A fast, correct task runner and build cache for JavaScript monorepos.",
   "type": "module",
   "exports": {
@@ -17,10 +17,10 @@
     "node": ">=18"
   },
   "optionalDependencies": {
-    "@vzn/vx-linux-x64": "0.0.306",
-    "@vzn/vx-linux-arm64": "0.0.306",
-    "@vzn/vx-darwin-x64": "0.0.306",
-    "@vzn/vx-darwin-arm64": "0.0.306"
+    "@vzn/vx-linux-x64": "0.0.308",
+    "@vzn/vx-linux-arm64": "0.0.308",
+    "@vzn/vx-darwin-x64": "0.0.308",
+    "@vzn/vx-darwin-arm64": "0.0.308"
   },
   "dependencies": {
     "@anthropic-ai/sandbox-runtime": "^0.0.76"

package/src/cli/init.ts

@@ -102,6 +102,7 @@ export async function initCmd(args: readonly string[]): Promise<number> {
     plan: migrateScripts(
       metas,
       metas.some((m) => m.dir === root) ? undefined : await readRootManifest(root),
+      root,
     ),
     source: 'package.json scripts',
     verb: 'vx init',

package/src/orchestrator/prepare.ts

@@ -106,6 +106,11 @@ export interface PreparedRun {
    * than run the remainder silently.
    */
   unresolvedTasks: readonly string[]
+  /**
+   * The bare names in `unresolvedTasks` a project outside a scoped run's
+   * selection (the cwd's project, a `--filter`) declares: no typo, a scope.
+   */
+  declaredElsewhere: readonly string[]
   /** Every discovered project — the declared task names a typo is measured against. */
   projects: ReadonlyMap<string, ProjectEntry>
   /**
@@ -330,6 +335,24 @@ export async function prepareRun(options: RunOptions, log: Logger): Promise<Prep
       )
     }
   }
+  // Run inside a project that lacks the task (`vx run typecheck` at a
+  // root whose members declare it), the run said no project declares it.
+  // Only a failing run pays for the rest of the workspace.
+  let declaredElsewhere: string[] = []
+  // A scope with no project to ask (a member with no vx config) leaves
+  // every requested name unjudged.
+  const bare = (candidateProjects.length === 0 ? tasks : unresolvedTasks).filter(
+    (t) => !t.includes('#'),
+  )
+  if (options.projects !== undefined && options.selectedByDiff !== true && bare.length > 0) {
+    let nowhere = undeclaredIn(bare, projects)
+    if (nowhere.length > 0 && projectsWithConfigs.some((m) => !projects.has(m.name))) {
+      nowhere = await declaredNowhere(nowhere, () =>
+        loadProjects({ ...loadArgs, seeds: 'all', closure: false, staged: projects }),
+      )
+    }
+    declaredElsewhere = bare.filter((t) => !nowhere.includes(t))
+  }
 
   // Cache seam precedence: an EXPLICITLY injected remote layer
   // (RunOptions.remoteCache — a distribution agent or daemon that already
@@ -413,6 +436,7 @@ export async function prepareRun(options: RunOptions, log: Logger): Promise<Prep
         nodes: new Map(),
         keyOnly: new Map(),
         unresolvedTasks,
+        declaredElsewhere,
         projects,
         anyProjectConfig: projectsWithConfigs.length > 0,
         workspaceFingerprint,
@@ -532,6 +556,7 @@ export async function prepareRun(options: RunOptions, log: Logger): Promise<Prep
       nodes,
       keyOnly,
       unresolvedTasks,
+      declaredElsewhere,
       projects,
       anyProjectConfig: projectsWithConfigs.length > 0,
       workspaceFingerprint,

package/src/orchestrator/run.ts

@@ -273,7 +273,7 @@ async function runOnBus(
   // case too; the message is identical, so that branch stays below.
   if (prepared.unresolvedTasks.length > 0) {
     log.status(
-      `No projects declare task(s): ${prepared.unresolvedTasks.join(', ')}.${didYouMean(prepared.unresolvedTasks, prepared.projects)}${await initHint(prepared)}`,
+      `No projects declare task(s): ${prepared.unresolvedTasks.join(', ')}.${elsewhereHint(prepared.declaredElsewhere)}${didYouMean(prepared.unresolvedTasks, prepared.projects)}${await initHint(prepared)}`,
     )
     await teardown()
     prepared.cache.close()
@@ -292,7 +292,7 @@ async function runOnBus(
     // buildTaskGraph semantics but logged just in case.
     const msg =
       prepared.empty === 'no-tasks-declared'
-        ? `No projects declare task(s): ${options.tasks.join(', ')}.${await initHint(prepared)}`
+        ? `No projects declare task(s): ${options.tasks.join(', ')}.${elsewhereHint(prepared.declaredElsewhere)}${await initHint(prepared)}`
         : 'No tasks to run.'
     log.status(msg)
     await teardown()
@@ -1210,7 +1210,14 @@ export async function planRun(options: RunOptions): Promise<RunPlan> {
       return {
         tasks: [],
         unresolvedTasks: prepared.unresolvedTasks,
-        unresolvedHint: `${didYouMean(prepared.unresolvedTasks, prepared.projects)}${await initHint(prepared)}`,
+        unresolvedHint: `${elsewhereHint(prepared.declaredElsewhere)}${didYouMean(prepared.unresolvedTasks, prepared.projects)}${await initHint(prepared)}`,
+      }
+    }
+    if (prepared.empty === 'no-tasks-declared' && prepared.declaredElsewhere.length > 0) {
+      return {
+        tasks: [],
+        unresolvedTasks: prepared.declaredElsewhere,
+        unresolvedHint: elsewhereHint(prepared.declaredElsewhere),
       }
     }
     if (prepared.empty !== null) return { tasks: [] }
@@ -1258,6 +1265,12 @@ export async function planRun(options: RunOptions): Promise<RunPlan> {
   }
 }
 
+/** The names a project outside the run's selection declares, and how to reach them. */
+function elsewhereHint(names: readonly string[]): string {
+  if (names.length === 0) return ''
+  return ` Only projects outside the selection declare ${names.join(', ')} — pass --all, or --filter to pick them.`
+}
+
 /**
  * The first-run case, told apart from a typo: no package in the workspace
  * has a `vx.config.*` at all, so no name could have resolved. Reached only

package/src/workspace/migrate-scripts.ts

@@ -244,24 +244,67 @@ function upstreamBuildOnWorker(tasks: GeneratedTask[]): void {
   if (!at.todos.includes(todo)) at.todos.push(todo)
 }
 
+/**
+ * A root script that runs the members rather than checking the repo:
+ * pnpm's `-r` / `--filter` / `-C`, npm's and Yarn's workspace flags, Bun's
+ * `--filter`, and the other runners, vx itself included. Mapped, it ran
+ * every member's task again beside the member's own (D-45).
+ */
+const RUNS_MEMBERS =
+  /(^|[\s;&|(])(turbo|nx|lerna|ultra|wireit|nps|moon|rush|vx)(\s|$)|\s(-r|--recursive|--filter|-F|--workspaces|-ws|--workspace|-w|-C|--dir|--if-present|--parallel|--stream)(\s|=|$)|\bworkspaces?\s+(foreach|run)\b|\bcd\s/
+
 /**
  * `outside`: the root manifest when the root is no member (pnpm's and
  * Yarn's default), whose own scripts (`lint: eslint .`) went unmapped
- * without a word.
+ * without a word; `outsideDir` is where it sits.
  */
 export function migrateScripts(
   metas: readonly ProjectMeta[],
   outside?: Readonly<Record<string, unknown>>,
+  outsideDir?: string,
 ): MigrationPlan {
   const projects: GeneratedProject[] = []
   const hookMemo = new Map<string, string | null>()
-  // The workspace root among members: its scripts run the workspace
-  // (`npm run build --workspaces`, `pnpm -r build`), and a root task made
-  // of one ran every member's build again under `--all`. Since D-39 a
-  // hand-written root config makes the root a project, and `--force`
-  // replaced it so (D-45). A lone package is its repo's project and maps.
+  // The workspace root among members: many of its scripts run the
+  // workspace (`npm run build --workspaces`, `pnpm -r build`), and a root
+  // task made of one ran every member's build again under `--all`. Since
+  // D-39 a hand-written root config makes the root a project, and
+  // `--force` replaced it so (D-45). A lone package is its repo's project
+  // and maps.
   const root = metas.length > 1 ? workspaceRootOf(metas) : undefined
   const notes: string[] = []
+  // The rest check the whole repo (`lint: oxlint .`, `test: vitest`):
+  // `vx run lint` found no project in remix, wagmi or element-plus. Such a
+  // script maps onto the root, when the root has a name (vx skips a
+  // nameless one's config), no config of its own, and no member declares
+  // the task, so `--all` never runs one check twice.
+  const outsideName =
+    typeof outside?.['name'] === 'string' && outside['name'] !== '' ? outside['name'] : undefined
+  const rootMeta: ProjectMeta | undefined =
+    root !== undefined
+      ? root.configPath === null
+        ? root
+        : undefined
+      : outsideName !== undefined && outsideDir !== undefined
+        ? { name: outsideName, dir: outsideDir, packageJson: outside as never, configPath: null }
+        : undefined
+  const memberTasks = new Set(
+    metas
+      .filter((m) => m !== root)
+      .flatMap((m) => Object.entries(scriptsOf(m)))
+      .filter(([, v]) => typeof v === 'string' && v !== '')
+      .map(([n]) => n),
+  )
+  const rootScripts = (meta: ProjectMeta): Record<string, unknown> =>
+    Object.fromEntries(
+      Object.entries(scriptsOf(meta)).filter(
+        ([n, v]) => typeof v === 'string' && !memberTasks.has(n) && !RUNS_MEMBERS.test(` ${v}`),
+      ),
+    )
+  const rootMapped =
+    rootMeta === undefined
+      ? 0
+      : Object.keys(rootScripts(rootMeta)).filter((n) => !LIFECYCLE.test(n)).length
   const outsideScripts = outside?.['scripts']
   const outsideRuns =
     typeof outsideScripts === 'object' &&
@@ -274,7 +317,11 @@ export function migrateScripts(
         ? outside['name']
         : 'package.json'
       : undefined)
-  if (rootName !== undefined) {
+  if (rootName !== undefined && rootMapped > 0) {
+    notes.push(
+      `${rootName} (the workspace root): its scripts that check the whole repo are its tasks; those that run the members (\`pnpm -r\`, \`--filter\`, a runner) or share a member's task name are left out`,
+    )
+  } else if (rootName !== undefined) {
     // A nameless root's vx.config is skipped (vx names projects by their
     // manifest's name), so the hand-written one needs a name first (vuejs/core).
     notes.push(
@@ -282,9 +329,10 @@ export function migrateScripts(
         (rootName === 'package.json' ? ', after giving its package.json a "name"' : ''),
     )
   }
-  for (const meta of metas) {
-    if (meta === root) continue
-    const scripts = scriptsOf(meta)
+  const mapped = metas.filter((m) => m !== root)
+  if (rootMeta !== undefined && rootMapped > 0) mapped.push(rootMeta)
+  for (const meta of mapped) {
+    const scripts = meta === rootMeta ? rootScripts(meta) : scriptsOf(meta)
     const hooksBy = runsScriptHooks(meta.dir, hookMemo)
     const runsHooks = hooksBy !== null
     const runnable = Object.keys(scripts).filter(