@vzn/vx 0.0.244 → 0.0.246

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vzn/vx",
-  "version": "0.0.244",
+  "version": "0.0.246",
   "description": "A fast, correct task runner and build cache for JavaScript monorepos.",
   "type": "module",
   "exports": {
@@ -17,10 +17,10 @@
     "node": ">=18"
   },
   "optionalDependencies": {
-    "@vzn/vx-linux-x64": "0.0.244",
-    "@vzn/vx-linux-arm64": "0.0.244",
-    "@vzn/vx-darwin-x64": "0.0.244",
-    "@vzn/vx-darwin-arm64": "0.0.244"
+    "@vzn/vx-linux-x64": "0.0.246",
+    "@vzn/vx-linux-arm64": "0.0.246",
+    "@vzn/vx-darwin-x64": "0.0.246",
+    "@vzn/vx-darwin-arm64": "0.0.246"
   },
   "dependencies": {
     "@anthropic-ai/sandbox-runtime": "^0.0.76"

package/src/cache/inputs.ts

@@ -29,6 +29,7 @@ import {
   shellArgv,
   splitNegations,
   slashBraceExpansions,
+  staticPrefix,
   taskGlob,
   UserError,
 } from '../util/index.js'
@@ -615,13 +616,25 @@ export async function cleanOutputs(args: {
   projectDir: string
   outputs: string[]
   nestedProjectDirs: string[]
+  /**
+   * Before a miss: keep the directory each wildcard glob is rooted at
+   * (`dist` for `dist/**`). The task writes its matches under it, so a
+   * remove there bought only an rmdir and the task's mkdir: 0.4 ms of a
+   * 4.9 ms one-file miss (B-49). A restore prunes it, since the entry's
+   * shape decides there.
+   */
+  keepGlobRoots?: boolean
 }): Promise<string[]> {
   const files = await resolveOutputs(args)
   // `force: true` makes rm tolerate ENOENT (e.g. when two output
   // globs overlap and a sibling already deleted a path mid-iteration).
   // A symlink is unlinked, never followed.
   await removeAll(files, args.projectDir)
-  await pruneEmptiedDirs(args.projectDir, files)
+  await pruneEmptiedDirs(
+    args.projectDir,
+    files,
+    args.keepGlobRoots === true ? globRoots(args.projectDir, args.outputs) : undefined,
+  )
   // Project-relative posix paths of what was removed — the caller
   // feeds these to GitFilesCache.markOutputsChanged after a restore.
   return files.map((f) => path.relative(args.projectDir, f).split(path.sep).join('/'))
@@ -778,7 +791,11 @@ async function removeAll(files: readonly string[], root: string): Promise<void>
  * holds something — a stray the globs do not cover — stays, and the restore
  * says so if it is in the way.
  */
-async function pruneEmptiedDirs(root: string, removed: readonly string[]): Promise<void> {
+async function pruneEmptiedDirs(
+  root: string,
+  removed: readonly string[],
+  keep?: ReadonlySet<string>,
+): Promise<void> {
   const rootResolved = path.resolve(root)
   // LEVEL ORDER, not a walk-up per directory. A parent is attempted only
   // once every one of its children has had its turn, which is what makes
@@ -794,7 +811,8 @@ async function pruneEmptiedDirs(root: string, removed: readonly string[]): Promi
   while (level.size > 0) {
     const parents = new Set<string>()
     const dirs = [...level].filter(
-      (dir) => dir !== rootResolved && dir.startsWith(rootResolved + path.sep),
+      (dir) =>
+        dir !== rootResolved && dir.startsWith(rootResolved + path.sep) && keep?.has(dir) !== true,
     )
     const gone = (err: NodeJS.ErrnoException): boolean => err.code === 'ENOENT'
     if (dirs.length <= SYNC_CLEAN_MAX) {
@@ -817,6 +835,21 @@ async function pruneEmptiedDirs(root: string, removed: readonly string[]): Promi
   }
 }
 
+/**
+ * The directories the wildcard output globs are rooted at, absolute. A
+ * literal names a file or a tree whose shape the task decides, so it has
+ * none; nor has a glob rooted at the project itself.
+ */
+function globRoots(projectDir: string, outputs: readonly string[]): Set<string> {
+  const roots = new Set<string>()
+  for (const g of outputs) {
+    if (g.startsWith('!') || isLiteralPattern(g)) continue
+    const prefix = staticPrefix(g)
+    if (prefix !== '.') roots.add(path.resolve(projectDir, prefix))
+  }
+  return roots
+}
+
 /**
  * Resolve declared `outputs.workspaceFiles` globs (workspace-root-
  * relative) to actual produced files. Live-FS glob like

package/src/orchestrator/execute-task.ts

@@ -758,7 +758,7 @@ async function executeCachedTask(args: ExecuteArgs): Promise<TaskOutcome> {
       // re-create would stay in a same-project consumer's input set, keeping
       // that consumer's key unchanged while the file is gone from disk.
       const endClean = span('miss: clean outputs')
-      const cleanedRels = await cleanOutputs(cleanArgs)
+      const cleanedRels = await cleanOutputs({ ...cleanArgs, keepGlobRoots: true })
       endClean()
       args.gitFilesCache?.noteClean(node.id, node.projectDir, cleanedRels)
       args.gitFilesCache?.markOutputsChanged(node.projectDir, cleanedRels)

package/src/workspace/migrate-scripts.ts

@@ -96,8 +96,8 @@ const OWN_COMMANDS: Readonly<Record<string, ReadonlySet<string>>> = {
 }
 
 /**
- * Whether the package manager that owns `dir` runs `pre` / `post` hooks
- * around a script. The manager is the nearest `packageManager` field or
+ * The package manager that owns `dir`, when it runs `pre` / `post` hooks
+ * around a script; null when it runs none. The manager is the nearest `packageManager` field or
  * lockfile, and its settings are read beside it, as each reads them for a
  * member too. Probed with a `prebuild` / `build` / `postbuild` trio: Yarn
  * 2+ runs none (D-31); npm runs none under `ignore-scripts=true` in
@@ -105,7 +105,7 @@ const OWN_COMMANDS: Readonly<Record<string, ReadonlySet<string>>> = {
  * `enablePrePostScripts: false` in `pnpm-workspace.yaml` (D-33); Bun and
  * Yarn 1 run them whatever those say. No manager found is npm's default.
  */
-function runsScriptHooks(dir: string, memo: Map<string, boolean>): boolean {
+function runsScriptHooks(dir: string, memo: Map<string, string | null>): string | null {
   const known = memo.get(dir)
   if (known !== undefined) return known
   const read = (f: string): string | undefined => {
@@ -129,15 +129,15 @@ function runsScriptHooks(dir: string, memo: Map<string, boolean>): boolean {
     else if (existsSync(path.join(dir, 'package-lock.json'))) manager = 'npm'
     else if (['bun.lock', 'bun.lockb'].some((f) => existsSync(path.join(dir, f)))) manager = 'bun'
   }
-  let answer: boolean
+  let answer: string | null
   if (manager === undefined) {
     const up = path.dirname(dir)
-    answer = up === dir ? true : runsScriptHooks(up, memo)
+    answer = up === dir ? 'npm' : runsScriptHooks(up, memo)
   } else {
     const npmrc = read('.npmrc') ?? ''
     const set = (key: string, value: string): boolean =>
       new RegExp(`^\\s*${key}\\s*=\\s*${value}\\s*$`, 'm').test(npmrc)
-    answer =
+    const runs =
       manager === 'berry'
         ? false
         : manager === 'npm'
@@ -146,6 +146,7 @@ function runsScriptHooks(dir: string, memo: Map<string, boolean>): boolean {
             ? !set('enable-pre-post-scripts', 'false') &&
               !/^enablePrePostScripts:\s*false\s*$/m.test(read('pnpm-workspace.yaml') ?? '')
             : true
+    answer = runs ? manager : null
   }
   memo.set(dir, answer)
   return answer
@@ -242,7 +243,7 @@ function upstreamBuildOnWorker(tasks: GeneratedTask[]): void {
 
 export function migrateScripts(metas: readonly ProjectMeta[]): MigrationPlan {
   const projects: GeneratedProject[] = []
-  const hookMemo = new Map<string, boolean>()
+  const hookMemo = new Map<string, string | null>()
   // The workspace root among members: its scripts run the workspace
   // (`npm run build --workspaces`, `pnpm -r build`), and a root task made
   // of one ran every member's build again under `--all`. Since D-39 a
@@ -258,7 +259,8 @@ export function migrateScripts(metas: readonly ProjectMeta[]): MigrationPlan {
   for (const meta of metas) {
     if (meta === root) continue
     const scripts = scriptsOf(meta)
-    const runsHooks = runsScriptHooks(meta.dir, hookMemo)
+    const hooksBy = runsScriptHooks(meta.dir, hookMemo)
+    const runsHooks = hooksBy !== null
     const runnable = Object.keys(scripts).filter(
       (n) => typeof scripts[n] === 'string' && scripts[n] !== '',
     )
@@ -314,7 +316,7 @@ export function migrateScripts(metas: readonly ProjectMeta[]): MigrationPlan {
       )
       if (hooks.length > 0) {
         todos.push(
-          `npm ran ${hooks.map((h) => `\`${h}\``).join(' and ')} around this script without being asked; folded into the command in that order`,
+          `${hooksBy} ran ${hooks.map((h) => `\`${h}\``).join(' and ')} around this script without being asked; folded into the command in that order`,
         )
       }
       const exec: Record<string, unknown> = { command }