@vzn/vx 0.0.113 → 0.0.115

package/README.md

@@ -38,7 +38,7 @@ burns 35 s of CPU in vx, 73 s in Turborepo and 114 minutes in Nx; a
 fully cached run replays the graph in 510 ms.
 <!-- bench:end -->
 
-Measured on eleven real Turborepo and Nx repos too: [tried on real repos](#tried-on-real-repos).
+Measured on twelve real Turborepo, Nx and moon repos too: [tried on real repos](#tried-on-real-repos).
 
 ## Install
 
@@ -145,24 +145,25 @@ Turbo and Nx feature is in vx, pinned by a test:
 
 ## Tried on real repos
 
-Eleven public monorepos, each run with its own `turbo.json` or Nx graph
+Twelve public monorepos, each run with its own `turbo.json`, Nx graph or moon config
 and nothing rewritten, against the tool it ships with. Both tools on the same machine and
 tasks per row, medians; vx first, theirs second. Where the other tool
 wins, the row says so.
 
-| Repo                                                        | Against | Cold build            | Restore outputs | Nothing to do       |
-| ----------------------------------------------------------- | ------- | --------------------- | --------------- | ------------------- |
-| [solidjs/solid](https://github.com/solidjs/solid)           | Turbo   | 40.6 s / 45.5 s       | 66 ms / 127 ms  | 51 ms / 95 ms       |
-| [withastro/astro](https://github.com/withastro/astro)       | Turbo   | 48.0 s / 57.9 s       | 478 ms / 1.43 s | 249 ms / 1.38 s     |
-| [payloadcms/payload](https://github.com/payloadcms/payload) | Turbo   | 126.9 s / 127.5 s     | 3.44 s / 3.46 s | 256 ms / **237 ms** |
-| [medusajs/medusa](https://github.com/medusajs/medusa)       | Turbo   | 308 s / 315 s         | 3.86 s / 7.16 s | 947 ms / 3.29 s     |
-| [n8n-io/n8n](https://github.com/n8n-io/n8n)                 | Turbo   | 137.2 s / **133.7 s** | 8.27 s / 12.5 s | 842 ms / 1.36 s     |
-| [calcom/cal.com](https://github.com/calcom/cal.com)         | Turbo   | 245.7 s / 250.7 s     | 17.4 s / 19.9 s | 14.7 s / 18.5 s     |
-| [TanStack/query](https://github.com/TanStack/query)         | Nx      | 47.4 s / 55.1 s       | 656 ms / 1.98 s | 174 ms / 1.88 s     |
-| [strapi/strapi](https://github.com/strapi/strapi)           | Nx      | 238.2 s / 245.7 s     | 1.61 s / 3.94 s | 341 ms / 4.02 s     |
-| [novuhq/novu](https://github.com/novuhq/novu)               | Nx      | 291.2 s / 299.4 s     | 3.10 s / 9.05 s | 655 ms / 8.55 s     |
-| [TanStack/router](https://github.com/TanStack/router)       | Nx      | 199.9 s / 226.7 s     | 1.00 s / 3.33 s | 505 ms / 3.21 s     |
-| [refinedev/refine](https://github.com/refinedev/refine)     | Nx      | 96.2 s / 105.9 s      | 1.06 s / 1.19 s | 303 ms / 1.16 s     |
+| Repo                                                                  | Against | Cold build            | Restore outputs | Nothing to do       |
+| --------------------------------------------------------------------- | ------- | --------------------- | --------------- | ------------------- |
+| [solidjs/solid](https://github.com/solidjs/solid)                     | Turbo   | 40.6 s / 45.5 s       | 66 ms / 127 ms  | 51 ms / 95 ms       |
+| [withastro/astro](https://github.com/withastro/astro)                 | Turbo   | 48.0 s / 57.9 s       | 478 ms / 1.43 s | 249 ms / 1.38 s     |
+| [payloadcms/payload](https://github.com/payloadcms/payload)           | Turbo   | 126.9 s / 127.5 s     | 3.44 s / 3.46 s | 256 ms / **237 ms** |
+| [medusajs/medusa](https://github.com/medusajs/medusa)                 | Turbo   | 308 s / 315 s         | 3.86 s / 7.16 s | 947 ms / 3.29 s     |
+| [n8n-io/n8n](https://github.com/n8n-io/n8n)                           | Turbo   | 137.2 s / **133.7 s** | 8.27 s / 12.5 s | 842 ms / 1.36 s     |
+| [calcom/cal.com](https://github.com/calcom/cal.com)                   | Turbo   | 245.7 s / 250.7 s     | 17.4 s / 19.9 s | 14.7 s / 18.5 s     |
+| [TanStack/query](https://github.com/TanStack/query)                   | Nx      | 47.4 s / 55.1 s       | 656 ms / 1.98 s | 174 ms / 1.88 s     |
+| [strapi/strapi](https://github.com/strapi/strapi)                     | Nx      | 238.2 s / 245.7 s     | 1.61 s / 3.94 s | 341 ms / 4.02 s     |
+| [novuhq/novu](https://github.com/novuhq/novu)                         | Nx      | 291.2 s / 299.4 s     | 3.10 s / 9.05 s | 655 ms / 8.55 s     |
+| [TanStack/router](https://github.com/TanStack/router)                 | Nx      | 199.9 s / 226.7 s     | 1.00 s / 3.33 s | 505 ms / 3.21 s     |
+| [refinedev/refine](https://github.com/refinedev/refine)               | Nx      | 96.2 s / 105.9 s      | 1.06 s / 1.19 s | 303 ms / 1.16 s     |
+| [kindspells/astro-shield](https://github.com/kindspells/astro-shield) | moon    | 2.64 s / 3.78 s       | 125 ms / 2.46 s | 111 ms / 2.37 s     |
 
 **Bold** marks the other tool winning. Versions, revisions, scopes and
 harness per repo: [benchmarks](packages/vx/docs/benchmarks.md) (astro

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vzn/vx",
-  "version": "0.0.113",
+  "version": "0.0.115",
   "description": "A fast, correct task runner and build cache for JavaScript monorepos.",
   "type": "module",
   "exports": {
@@ -17,10 +17,10 @@
     "node": ">=18"
   },
   "optionalDependencies": {
-    "@vzn/vx-linux-x64": "0.0.113",
-    "@vzn/vx-linux-arm64": "0.0.113",
-    "@vzn/vx-darwin-x64": "0.0.113",
-    "@vzn/vx-darwin-arm64": "0.0.113"
+    "@vzn/vx-linux-x64": "0.0.115",
+    "@vzn/vx-linux-arm64": "0.0.115",
+    "@vzn/vx-darwin-x64": "0.0.115",
+    "@vzn/vx-darwin-arm64": "0.0.115"
   },
   "dependencies": {
     "@anthropic-ai/sandbox-runtime": "^0.0.76"

package/src/cli/completions.ts

@@ -101,7 +101,8 @@ export async function completionsCmd(
     return 1
   }
   const verbs = [...CORE_VERBS.filter((v) => v !== 'help' && v !== 'version'), 'help', 'version']
-  for (const v of pluginVerbs) if (!verbs.includes(v)) verbs.push(v)
+  // No overlap to skip: the workspace load refuses a plugin verb named like a core one.
+  verbs.push(...pluginVerbs)
   process.stdout.write(completionScript(shell as CompletionShell, verbs))
   return 0
 }

package/src/workspace/migrate-scripts.ts

@@ -23,7 +23,11 @@
 // hook is usually `rimraf dist`); and a script that is nothing but
 // `<pm> run <other>` becomes a GROUP over `<other>`, so the graph sees the
 // dependency instead of a package-manager subprocess it cannot cache.
+// Yarn 2+ runs no such hooks (probed: `yarn run build` printed BUILD alone),
+// so under it `prebuild` is a script like any other (D-31).
 
+import { existsSync, readFileSync } from 'node:fs'
+import path from 'node:path'
 import { taskNameProblem } from './config-schema.js'
 import type { ProjectMeta } from './workspace.js'
 import {
@@ -82,6 +86,40 @@ const OWN_COMMANDS: Readonly<Record<string, ReadonlySet<string>>> = {
   ),
 }
 
+/**
+ * Whether the package manager that owns `dir` is Yarn 2+: the nearest
+ * `packageManager: yarn@<2+>`, or the nearest lockfile being a Berry
+ * `yarn.lock` (it opens with `__metadata:`). Another lockfile, or none,
+ * is a manager that runs `pre` / `post` hooks.
+ */
+function isYarnBerry(dir: string, memo: Map<string, boolean>): boolean {
+  const known = memo.get(dir)
+  if (known !== undefined) return known
+  let answer: boolean | undefined
+  const manifest = path.join(dir, 'package.json')
+  try {
+    const pm = (JSON.parse(readFileSync(manifest, 'utf8')) as { packageManager?: unknown })
+      .packageManager
+    if (typeof pm === 'string') answer = /^yarn@([2-9]|\d{2,})/.test(pm)
+  } catch {}
+  if (answer === undefined) {
+    const lock = path.join(dir, 'yarn.lock')
+    if (existsSync(lock)) answer = readFileSync(lock, 'utf8').includes('\n__metadata:')
+    else if (
+      ['package-lock.json', 'pnpm-lock.yaml', 'bun.lock', 'bun.lockb'].some((f) =>
+        existsSync(path.join(dir, f)),
+      )
+    )
+      answer = false
+  }
+  if (answer === undefined) {
+    const up = path.dirname(dir)
+    answer = up === dir ? false : isYarnBerry(up, memo)
+  }
+  memo.set(dir, answer)
+  return answer
+}
+
 function scriptsOf(meta: ProjectMeta): Record<string, unknown> {
   // package.json is a boundary: `scripts` is whatever the file holds. A
   // string or an array would enumerate its indices as script names.
@@ -132,8 +170,10 @@ function upstreamBuildOnWorker(tasks: GeneratedTask[]): void {
 
 export function migrateScripts(metas: readonly ProjectMeta[]): MigrationPlan {
   const projects: GeneratedProject[] = []
+  const berry = new Map<string, boolean>()
   for (const meta of metas) {
     const scripts = scriptsOf(meta)
+    const runsHooks = !isYarnBerry(meta.dir, berry)
     const runnable = Object.keys(scripts).filter(
       (n) => typeof scripts[n] === 'string' && scripts[n] !== '',
     )
@@ -153,7 +193,7 @@ export function migrateScripts(metas: readonly ProjectMeta[]): MigrationPlan {
     // of a script that exists rides inside that script's command.
     const isTask = (n: string): boolean => {
       if (!has(n) || LIFECYCLE.test(n)) return false
-      const hookOf = /^(pre|post)(.+)$/.exec(n)
+      const hookOf = runsHooks ? /^(pre|post)(.+)$/.exec(n) : null
       return hookOf === null || !has(hookOf[2]!) || LIFECYCLE.test(hookOf[2]!)
     }
     const tasks: GeneratedTask[] = []
@@ -165,7 +205,7 @@ export function migrateScripts(metas: readonly ProjectMeta[]): MigrationPlan {
       const delegate = delegatedScript(own)
       // npm lifecycle hooks (`prepack`, `prepublishOnly`, …) belong to the
       // package manager and never ride inside a task — `pack` stays alone.
-      const hook = (h: string): boolean => has(h) && !LIFECYCLE.test(h)
+      const hook = (h: string): boolean => runsHooks && has(h) && !LIFECYCLE.test(h)
       const hooks = [`pre${name}`, `post${name}`].filter(hook)
       // A group over a script that is no task (`setup: npm run prepare`)
       // named a task nothing defines, and the run `vx init` suggested