@vzn/vx-reapi 0.0.612 → 0.0.614

package/README.md

@@ -37,7 +37,8 @@ from the environment, and `VX_REAPI_EXECUTE=1` turns on remote execution the
 way `execute: true` does (off by default: a plugin must not move where a
 build runs merely by being configured for caching). `execute` is a
 boolean: a string (`process.env.X`) is refused.
-`instanceName` is the option form of `VX_REAPI_INSTANCE`, and `headers`
+`instanceName` is the option form of `VX_REAPI_INSTANCE`; like the endpoint
+it is trimmed, and a blank one is unset. `headers`
 adds gRPC metadata to every call: a hosted server's API key goes there
 (`headers: { 'x-buildbuddy-api-key': process.env.BB_KEY! }`).
 `toolName` and `toolVersion` (default `vx`, `0.0.0`) fill each call's

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vzn/vx-reapi",
-  "version": "0.0.612",
+  "version": "0.0.614",
   "license": "MIT",
   "description": "Bazel Remote Execution API plugin for vx — remote cache (ActionCache + CAS) against NativeLink, BuildBuddy, Buildbarn or bazel-remote.",
   "keywords": [
@@ -39,7 +39,7 @@
     "access": "public"
   },
   "peerDependencies": {
-    "@vzn/vx": "^0.0.612"
+    "@vzn/vx": "^0.0.614"
   },
   "repository": {
     "type": "git",

package/src/index.ts

@@ -98,7 +98,10 @@ function connection(options: ReapiPluginOptions): ReapiOptions | undefined {
   const endpoint = (options.endpoint ?? process.env['VX_REAPI_ENDPOINT'])?.trim()
   if (endpoint === undefined || endpoint === '') return undefined
   assertEndpoint(endpoint, from)
-  const instanceName = options.instanceName ?? process.env['VX_REAPI_INSTANCE']
+  // A secrets file's trailing newline sent a name no blob is under, and
+  // every lookup missed in silence.
+  const instanceName =
+    (options.instanceName ?? process.env['VX_REAPI_INSTANCE'])?.trim() || undefined
   // A server behind a private CA, or one that asks for a client
   // certificate, was unreachable: TLS used the system roots and no client
   // pair (F-41). Each is a PEM file, read here; one that cannot be read is
@@ -203,9 +206,11 @@ export function reapi(options: ReapiPluginOptions = {}): VxPlugin {
   let remoteCache: ReapiRemoteCache | undefined
   return definePlugin(import.meta, {
     async executor(ctx): Promise<TaskExecutor | undefined> {
-      const wanted = options.execute === true || process.env['VX_REAPI_EXECUTE'] === '1'
+      // Before the connection: with execute off, an unreadable PEM is the
+      // cache hook's to refuse, never a failure "in executor".
+      if (options.execute !== true && process.env['VX_REAPI_EXECUTE'] !== '1') return undefined
       const conn = connection(options)
-      if (!wanted || conn === undefined) return undefined
+      if (conn === undefined) return undefined
       executorClient = new ReapiClient({ ...conn, onWarn: (m) => ctx.warn(m) })
       // Negotiate once: turns zstd transfer compression on when the server
       // advertises it. The digest function stays SHA256 (see wire.negotiate).