@vuu-ui/vuu-data-test 2.3.0 → 3.0.0-beta.1

package/esm/core/module/VuuModule.js

@@ -1,10 +1,9 @@
 import { isDeleteSelectedRowsRpcRequest, isUndoRowChangeRpcRequest, isEditCellRpcRequest, isRpcSuccess, isCreateSessionTableRpcRequest, uuid, isBeginEditSessionRpcRequest, isAddRowRpcRequest, isEndEditSessionRpcRequest } from '@vuu-ui/vuu-utils';
 import { Table, buildDataColumnMapFromSchema } from '../../Table.js';
-import { SessionTable, isProxySessionTable } from '../../SessionTable.js';
 import { TickingArrayDataSource } from '../../TickingArrayDataSource.js';
 import { RuntimeVisualLink } from '../../RuntimeVisualLink.js';
 import moduleContainer from './ModuleContainer.js';
-import { sessionTableSchema } from '../../session-table-utils.js';
+import { sessionTableSchema, sessionTableRow } from '../../session-table-utils.js';
 
 var __defProp = Object.defineProperty;
 var __typeError = (msg) => {
@@ -16,7 +15,7 @@ var __accessCheck = (obj, member, msg) => member.has(obj) || __typeError("Cannot
 var __privateGet = (obj, member, getter) => (__accessCheck(obj, member, "read from private field"), getter ? getter.call(obj) : member.get(obj));
 var __privateAdd = (obj, member, value) => member.has(obj) ? __typeError("Cannot add the same private member more than once") : member instanceof WeakSet ? member.add(obj) : member.set(obj, value);
 var __privateSet = (obj, member, value, setter) => (__accessCheck(obj, member, "write to private field"), member.set(obj, value), value);
-var _name, _sessionTableMessageColumn, _runtimeVisualLinks, _sessionTableMap, _tableServices, _subscriptionMap, _moduleServices, _moduleMenuServices;
+var _name, _sessionTableMessageColumn, _runtimeVisualLinks, _sessionSourceTableMap, _sessionTableMap, _tableServices, _subscriptionMap, _moduleServices, _moduleMenuServices;
 const assertUpdateIsValid = (schema, column, data) => {
   const col = schema.columns.find((col2) => col2.name === column);
   if (col) {
@@ -32,6 +31,7 @@ class VuuModule {
     __privateAdd(this, _name);
     __privateAdd(this, _sessionTableMessageColumn);
     __privateAdd(this, _runtimeVisualLinks, /* @__PURE__ */ new Map());
+    __privateAdd(this, _sessionSourceTableMap, {});
     __privateAdd(this, _sessionTableMap, {});
     __privateAdd(this, _tableServices);
     __privateAdd(this, _subscriptionMap, /* @__PURE__ */ new Map());
@@ -190,7 +190,6 @@ class VuuModule {
         menu: this.menus?.[tableName],
         rpcServices: this.getServices(tableName),
         rpcMenuServices: this.getMenuServices(tableName),
-        sessionTables: __privateGet(this, _sessionTableMap),
         viewport,
         visualLinkService: this.visualLinkService,
         vuuModule
@@ -200,7 +199,9 @@ class VuuModule {
       const existingSubscriptions = __privateGet(this, _subscriptionMap).get(tableName);
       const subscription = {
         viewportId: dataSource.viewport,
-        dataSource
+        dataSource,
+        sessionTableName: sessionTable ? tableName : void 0,
+        sourceTableName: __privateGet(this, _sessionSourceTableMap)[tableName]
       };
       if (existingSubscriptions) {
         existingSubscriptions.push(subscription);
@@ -216,11 +217,7 @@ class VuuModule {
         const sessionTable = this.getSessionTable(viewPortId, false);
         if (sessionTable) {
           if (mode === "soft") {
-            sessionTable.update(
-              key,
-              __privateGet(this, _sessionTableMessageColumn),
-              "SOFT_DELETED"
-            );
+            sessionTable.update(key, "vuu_action", "deleteRow");
           } else {
             sessionTable.delete(key);
           }
@@ -251,23 +248,20 @@ class VuuModule {
         const { viewPortId } = rpcRequest.context;
         const { mode = "soft" } = rpcRequest.params;
         const sessionTable = this.getSessionTable(viewPortId, false);
-        if (sessionTable && isProxySessionTable(sessionTable)) {
+        if (sessionTable) {
           const { dataSource } = this.getSubscriptionByViewport(viewPortId);
           const selectedRowIds = dataSource.getSelectedRowIds();
           const deletedKeys = [];
           if (selectedRowIds.length > 0) {
             for (const key of selectedRowIds) {
               if (mode === "soft") {
-                sessionTable.update(
-                  key,
-                  __privateGet(this, _sessionTableMessageColumn),
-                  "SOFT_DELETED"
-                );
+                sessionTable.update(key, "vuu_action", "deleteRow");
               } else {
                 sessionTable.delete(key);
               }
               deletedKeys.push(key);
             }
+            dataSource.select?.({ type: "DESELECT_ALL" });
           }
           return { type: "SUCCESS_RESULT", data: { deletedKeys } };
         }
@@ -286,34 +280,49 @@ class VuuModule {
         const { viewPortId } = rpcRequest.context;
         const { key } = rpcRequest.params;
         const sessionTable = this.getSessionTable(viewPortId, false);
-        if (sessionTable && isProxySessionTable(sessionTable)) {
-          const { dataSource } = this.getSubscriptionByViewport(viewPortId);
-          const sourceTable = this.tables[dataSource.table?.table];
+        if (sessionTable) {
+          const subscription = this.getSubscriptionByViewport(viewPortId);
+          const { dataSource } = subscription;
+          const sourceTableName = subscription.sourceTableName ?? dataSource.table?.table;
+          const sourceTable = this.tables[sourceTableName];
           if (!sourceTable) {
             return {
               type: "ERROR_RESULT",
               errorMessage: `undoRowChange: source table not found for viewport ${viewPortId}`
             };
           }
-          const sourceRow = sourceTable.findByKey(key);
-          if (!sourceRow) {
+          const sessionRow = sessionTable.findByKey(key);
+          if (!sessionRow) {
+            return {
+              type: "ERROR_RESULT",
+              errorMessage: `undoRowChange: session row not found for key ${key}`
+            };
+          }
+          const action = sessionRow[sessionTable.map.vuu_action];
+          if (action === "addRow") {
             sessionTable.delete(key);
             return { type: "SUCCESS_RESULT", data: { wasInsertedRow: true } };
           }
-          const updates = sessionTable.getSessionUpdates();
-          const rowUpdates = updates.get(key);
-          if (rowUpdates) {
-            for (const column of Object.keys(rowUpdates.cellUpdates)) {
-              const originalValue = sourceRow[sourceTable.map[column]];
-              sessionTable.update(key, column, originalValue);
+          if (action === "deleteRow" || action === "editCell") {
+            const sourceRow = sourceTable.findByKey(key);
+            if (!sourceRow) {
+              return {
+                type: "ERROR_RESULT",
+                errorMessage: `undoRowChange: source row not found for key ${key}`
+              };
+            }
+            const restoredRow = sessionRow.slice();
+            for (const column of sourceTable.schema.columns) {
+              restoredRow[sessionTable.map[column.name]] = sourceRow[sourceTable.map[column.name]];
             }
-            updates.delete(key);
+            sessionTable.updateRow(restoredRow);
+            sessionTable.update(key, "vuu_action", "");
           }
           return { type: "SUCCESS_RESULT", data: void 0 };
         }
         return {
           type: "ERROR_RESULT",
-          errorMessage: `undoRowChange: no active proxy session table for viewport ${viewPortId}`
+          errorMessage: `undoRowChange: no active session table for viewport ${viewPortId}`
         };
       }
       return {
@@ -325,7 +334,8 @@ class VuuModule {
       if (isEditCellRpcRequest(rpcRequest)) {
         const { viewPortId } = rpcRequest.context;
         const { column, data, key } = rpcRequest.params;
-        let targetTable = __privateGet(this, _sessionTableMap)[viewPortId];
+        const sessionTable = __privateGet(this, _sessionTableMap)[viewPortId];
+        let targetTable = sessionTable;
         if (!targetTable) {
           const { dataSource } = this.getSubscriptionByViewport(viewPortId);
           if (dataSource.table) {
@@ -334,8 +344,15 @@ class VuuModule {
         }
         if (targetTable) {
           try {
+            const sessionRow = sessionTable?.findByKey(key);
+            if (sessionRow?.[sessionTable.map.vuu_action] === "deleteRow") {
+              throw Error("editCell: cannot edit a deleted row");
+            }
             assertUpdateIsValid(targetTable.schema, column, data);
             targetTable.update(key, column, data);
+            if (sessionTable && sessionTable.findByKey(key)?.[sessionTable.map.vuu_action] !== "addRow") {
+              sessionTable.update(key, "vuu_action", "editCell");
+            }
             return {
               type: "SUCCESS_RESULT",
               data: void 0
@@ -351,7 +368,7 @@ class VuuModule {
           throw Error("[VuuModule] editCell unable to find table for dataSource");
         }
       } else {
-        throw Error(`[VuuModule] editCell invalid rpc type`);
+        throw Error("[VuuModule] editCell invalid rpc type");
       }
     });
     __publicField(this, "beginEditSessionMenuHandler", async ({
@@ -422,11 +439,10 @@ class VuuModule {
                 sourceTable,
                 sessionTableName,
                 copyOption,
-                // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-                // @ts-ignore
                 dataSource
               );
               __privateGet(this, _sessionTableMap)[sessionTableName] = sessionTable;
+              __privateGet(this, _sessionSourceTableMap)[sessionTableName] = vuuTable.table;
               subscription.sessionTableName = sessionTableName;
               return {
                 data: {
@@ -464,11 +480,10 @@ class VuuModule {
                 sourceTable,
                 sessionTableName,
                 editSessionMode,
-                // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-                // @ts-ignore
                 dataSource
               );
               __privateGet(this, _sessionTableMap)[sessionTableName] = sessionTable;
+              __privateGet(this, _sessionSourceTableMap)[sessionTableName] = vuuTable.table;
               subscription.sessionTableName = sessionTableName;
               return {
                 data: {
@@ -489,7 +504,7 @@ class VuuModule {
           }
         }
       } else {
-        throw Error(`[VuuModule] endEditSession invalid rpc type`);
+        throw Error("[VuuModule] endEditSession invalid rpc type");
       }
       return {
         type: "ERROR_RESULT",
@@ -500,7 +515,8 @@ class VuuModule {
       if (isAddRowRpcRequest(rpcRequest)) {
         const { viewPortId } = rpcRequest.context;
         const subscription = this.getSubscriptionByViewport(viewPortId);
-        const sessionTable = subscription.sessionTableName ? __privateGet(this, _sessionTableMap)[subscription.sessionTableName] : void 0;
+        const sessionTableName = subscription.sessionTableName ?? viewPortId;
+        const sessionTable = __privateGet(this, _sessionTableMap)[sessionTableName];
         if (!sessionTable) {
           return {
             type: "ERROR_RESULT",
@@ -511,6 +527,7 @@ class VuuModule {
         const columnMap = sessionTable.map;
         const columnCount = Object.keys(columnMap).length;
         const row = new Array(columnCount).fill("");
+        row[columnMap.vuu_action] = "addRow";
         for (const [col, idx] of Object.entries(columnMap)) {
           if (data[col] !== void 0) {
             row[idx] = data[col];
@@ -532,44 +549,53 @@ class VuuModule {
         const sessionTable = __privateGet(this, _sessionTableMap)[sessionTableName];
         const { dataSource } = subscription;
         if (dataSource.table) {
-          const sourceTable = this.tables[dataSource.table.table];
+          const sourceTableName = subscription.sourceTableName ?? dataSource.table.table;
+          const sourceTable = this.tables[sourceTableName];
           if (rpcRequest.params.save === true) {
             let rejectedCount = 0;
-            if (isProxySessionTable(sessionTable)) {
-              const updates = sessionTable.getSessionUpdates();
-              updates.forEach((rowUpdates, key) => {
-                const { cellUpdates, lastUpdateTimestamp } = rowUpdates;
-                const currentRow = sourceTable.findByKey(key);
-                const lastUpdateTimestampOnTable = currentRow[sourceTable.map.vuuUpdatedTimestamp];
-                if (lastUpdateTimestamp !== lastUpdateTimestampOnTable) {
-                  rejectedCount += 1;
-                  const sessionTableRow = sessionTable.findByKey(key);
-                  const newRow = sessionTableRow.slice();
-                  const messages = [];
-                  Object.entries(cellUpdates).forEach(([column, value]) => {
-                    messages.push(`${column}:${value}`);
-                  });
-                  newRow[sessionTable.map[__privateGet(this, _sessionTableMessageColumn)]] = messages.join(",");
-                  sessionTable.updateRow(newRow);
-                } else {
-                  const newRow = currentRow.slice();
-                  Object.entries(cellUpdates).forEach(([column, value]) => {
-                    newRow[sourceTable.map[column]] = value;
-                  });
-                  sourceTable.updateRow(newRow);
+            const vuuMsgIdx = sessionTable.map[__privateGet(this, _sessionTableMessageColumn)];
+            const actionIdx = sessionTable.map.vuu_action;
+            const sessionTimestampIdx = sessionTable.map.vuuUpdatedTimestamp;
+            const sourceTimestampIdx = sourceTable.map.vuuUpdatedTimestamp;
+            const sourceColumns = sourceTable.schema.columns;
+            for (let i = 0; i < sessionTable.data.length; i++) {
+              const sessionRow = sessionTable.data[i];
+              const key = String(
+                sessionRow[sessionTable.map[sourceTable.schema.key]]
+              );
+              const currentRow = sourceTable.findByKey(key);
+              const action = sessionRow[actionIdx];
+              if (action === "deleteRow") {
+                if (currentRow) {
+                  const sessionTimestamp = sessionRow[sessionTimestampIdx];
+                  const sourceTimestamp = currentRow[sourceTimestampIdx];
+                  if (typeof sessionTimestamp === "number" && typeof sourceTimestamp === "number" && sourceTimestamp > sessionTimestamp) {
+                    rejectedCount += 1;
+                    sessionTable.update(
+                      key,
+                      __privateGet(this, _sessionTableMessageColumn),
+                      "stale delete"
+                    );
+                  } else {
+                    sourceTable.delete(key);
+                  }
+                }
+                continue;
+              }
+              if (sessionRow[vuuMsgIdx]) continue;
+              if (action === "editCell" && currentRow) {
+                for (const column of sourceColumns) {
+                  const value = sessionRow[sessionTable.map[column.name]];
+                  if (currentRow[sourceTable.map[column.name]] !== value) {
+                    sourceTable.update(key, column.name, value);
+                  }
                 }
-              });
-              updates.clear();
-            } else {
-              const vuuMsgIdx = sessionTable.map[__privateGet(this, _sessionTableMessageColumn)];
-              const sourceColumns = sourceTable.schema.columns;
-              for (let i = 0; i < sessionTable.data.length; i++) {
-                const sessionRow = sessionTable.data[i];
-                if (sessionRow[vuuMsgIdx]) continue;
-                const sourceRow = sourceColumns.map(
-                  (col) => sessionRow[sessionTable.map[col.name]]
+              } else if (action === "addRow" && !currentRow) {
+                sourceTable.insert(
+                  sourceColumns.map(
+                    (column) => sessionRow[sessionTable.map[column.name]]
+                  )
                 );
-                sourceTable.insert(sourceRow);
               }
             }
             if (rejectedCount > 0) {
@@ -577,12 +603,11 @@ class VuuModule {
                 errorMessage: "stale update",
                 type: "ERROR_RESULT"
               };
-            } else {
-              return {
-                type: "SUCCESS_RESULT",
-                data: void 0
-              };
             }
+            return {
+              type: "SUCCESS_RESULT",
+              data: void 0
+            };
           } else {
             return {
               type: "SUCCESS_RESULT",
@@ -593,7 +618,7 @@ class VuuModule {
           throw Error("[VuuModule], exitEditMode");
         }
       } else {
-        throw Error(`[VuuModule] endEditSession invalid rpc type`);
+        throw Error("[VuuModule] endEditSession invalid rpc type");
       }
     });
     // Bulk-edit with input in session table
@@ -616,7 +641,7 @@ class VuuModule {
           data: void 0
         };
       } else {
-        throw Error(`[VuuModule] applyBulkEdits invalid rpc type`);
+        throw Error("[VuuModule] applyBulkEdits invalid rpc type");
       }
     });
     /**
@@ -747,7 +772,7 @@ class VuuModule {
       );
     }
   }
-  createSessionTable(sourceTable, sessionTableName, editSessionMode = "inline-all-rows", dataSource) {
+  createSessionTable(sourceTable, sessionTableName, editSessionMode, dataSource) {
     if (editSessionMode === "All" || editSessionMode.endsWith("all-rows")) {
       return this.createSessionTableWithAllRows(sourceTable, sessionTableName);
     } else if (editSessionMode === "Selected" || editSessionMode === "selected-rows") {
@@ -764,8 +789,13 @@ class VuuModule {
       );
     }
   }
-  createSessionTableWithAllRows(sourceTable, sessionTableName) {
-    return SessionTable(sourceTable, sessionTableName);
+  createSessionTableWithAllRows({ data, schema }, _sessionTableName) {
+    const sessionSchema = sessionTableSchema(schema);
+    return new Table(
+      sessionSchema,
+      data.map((row) => sessionTableRow(row, schema)),
+      buildDataColumnMapFromSchema(sessionSchema)
+    );
   }
   createEmptySessionTable({ schema }, sessionTableName) {
     const sessionSchema = sessionTableSchema({
@@ -785,7 +815,7 @@ class VuuModule {
     for (let i = 0; i < selectedRowIds.length; i++) {
       for (let j = 0; j < data.length; j++) {
         if (data[j][keyIndex] === selectedRowIds[i]) {
-          sessionData.push(data[j]);
+          sessionData.push(sessionTableRow(data[j], schema));
         }
       }
     }
@@ -800,6 +830,7 @@ class VuuModule {
 _name = new WeakMap();
 _sessionTableMessageColumn = new WeakMap();
 _runtimeVisualLinks = new WeakMap();
+_sessionSourceTableMap = new WeakMap();
 _sessionTableMap = new WeakMap();
 _tableServices = new WeakMap();
 _subscriptionMap = new WeakMap();