@vultisig/walletcore-native 1.0.0 → 1.1.0

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # @vultisig/walletcore-native
 
+## 1.1.0
+
+### Minor Changes
+
+- [#2427](https://github.com/vultisig/vultisig-sdk/pull/2427) [`b38628f`](https://github.com/vultisig/vultisig-sdk/commit/b38628f1ad09fa9dac3e23b2056b24c0040500fe) Thanks [@rcoderdev](https://github.com/rcoderdev)! - Use prefix-aware WalletCore SS58 constructors for Bittensor address derivation and transaction destinations, including native iOS and Android bridges. Reject destinations with a different network prefix or invalid account data.
+
+  Apply the Expo module Gradle plugin so Expo 56's required Kotlin compiler transformations run before Android module registration.
+
+  Direct callers of `buildBittensorSigningPayload` must pass their initialized WalletCore as the second argument. Direct callers of `refineBittensorChainSpecific` must provide `walletCore` in the input. High-level SDK signing and fee estimation pass the existing runtime automatically.
+
 ## 1.0.0
 
 ### Major Changes

package/android/build.gradle

@@ -1,6 +1,4 @@
-apply plugin: 'com.android.library'
-apply plugin: 'kotlin-android'
-apply plugin: 'maven-publish'
+apply plugin: 'expo-module-gradle-plugin'
 
 group = 'expo.modules.walletcore'
 version = '0.1.0'
@@ -13,12 +11,7 @@ android {
     defaultConfig {
         minSdkVersion safeExtGet("minSdkVersion", 23)
         targetSdkVersion safeExtGet("targetSdkVersion", 34)
-    }
-
-    publishing {
-        singleVariant("release") {
-            withSourcesJar()
-        }
+        versionName project.version.toString()
     }
 
     lint {

package/android/src/main/java/expo/modules/walletcore/ExpoWalletCoreModule.kt

@@ -149,6 +149,22 @@ class ExpoWalletCoreModule : Module() {
             AnyAddress.isValidSS58(address, CoinType.createFromValue(coinType), ss58Prefix)
         }
 
+        Function("anyAddressCreateSS58") { address: String, coinType: Int, ss58Prefix: Int ->
+            require(ss58Prefix >= 0) { "Invalid SS58 prefix" }
+            val coin = CoinType.createFromValue(coinType)
+            require(AnyAddress.isValidSS58(address, coin, ss58Prefix)) { "Invalid SS58 address" }
+            val addr = AnyAddress(address, coin, ss58Prefix)
+            mapOf("description" to addr.description(), "data" to android.util.Base64.encodeToString(addr.data(), android.util.Base64.NO_WRAP))
+        }
+
+        Function("anyAddressCreateSS58WithPublicKey") { publicKeyHandle: Int, coinType: Int, ss58Prefix: Int ->
+            val pk = publicKeys[publicKeyHandle] ?: throw Exception("Invalid PublicKey handle")
+            require(ss58Prefix >= 0) { "Invalid SS58 prefix" }
+            val addr = AnyAddress(pk, CoinType.createFromValue(coinType), ss58Prefix)
+            require(addr.description().isNotEmpty()) { "Failed to derive SS58 address" }
+            mapOf("description" to addr.description(), "data" to android.util.Base64.encodeToString(addr.data(), android.util.Base64.NO_WRAP))
+        }
+
         Function("anyAddressCreateWithString") { address: String, coinType: Int ->
             AnyAddress(address, CoinType.createFromValue(coinType)).description()
         }

package/ios/ExpoWalletCoreModule.swift

@@ -200,6 +200,30 @@ public class ExpoWalletCoreModule: Module {
             return AnyAddress.isValidSS58(string: address, coin: ct, ss58Prefix: UInt32(ss58Prefix))
         }
 
+        Function("anyAddressCreateSS58") { (address: String, coinType: Int, ss58Prefix: Int) -> [String: String] in
+            let ct = try coinTypeFromValue(coinType)
+            guard let prefix = UInt32(exactly: ss58Prefix),
+                  let addr = AnyAddress(string: address, coin: ct, ss58Prefix: prefix) else {
+                throw NSError(domain: "ExpoWalletCore", code: -1, userInfo: [NSLocalizedDescriptionKey: "Invalid SS58 address or prefix"])
+            }
+            return ["description": addr.description, "data": addr.data.base64EncodedString()]
+        }
+
+        Function("anyAddressCreateSS58WithPublicKey") { (publicKeyHandle: Int, coinType: Int, ss58Prefix: Int) -> [String: String] in
+            guard let pk = publicKeys[publicKeyHandle] else {
+                throw NSError(domain: "ExpoWalletCore", code: -1, userInfo: [NSLocalizedDescriptionKey: "Invalid PublicKey handle"])
+            }
+            let ct = try coinTypeFromValue(coinType)
+            guard let prefix = UInt32(exactly: ss58Prefix) else {
+                throw NSError(domain: "ExpoWalletCore", code: -1, userInfo: [NSLocalizedDescriptionKey: "Invalid SS58 prefix"])
+            }
+            let addr = AnyAddress(publicKey: pk, coin: ct, ss58Prefix: prefix)
+            guard !addr.description.isEmpty else {
+                throw NSError(domain: "ExpoWalletCore", code: -1, userInfo: [NSLocalizedDescriptionKey: "Failed to derive SS58 address"])
+            }
+            return ["description": addr.description, "data": addr.data.base64EncodedString()]
+        }
+
         Function("anyAddressCreateWithString") { (address: String, coinType: Int) -> String in
             let ct = try coinTypeFromValue(coinType)
             guard let addr = AnyAddress(string: address, coin: ct) else {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vultisig/walletcore-native",
-  "version": "1.0.0",
+  "version": "1.1.0",
   "description": "Native WalletCore bridge for Vultisig SDK (React Native / Expo)",
   "main": "src/index.ts",
   "types": "src/index.ts",

package/src/ExpoWalletCoreModule.ts

@@ -69,6 +69,16 @@ interface ExpoWalletCoreModuleType {
   /** Check if an SS58 address is valid. */
   anyAddressIsValidSS58(address: string, coinType: number, ss58Prefix: number): boolean
 
+  /** Create an SS58 address with an explicit prefix, returning its description and base64 data. */
+  anyAddressCreateSS58(address: string, coinType: number, ss58Prefix: number): { description: string; data: string }
+
+  /** Derive an SS58 address with an explicit prefix, returning its description and base64 data. */
+  anyAddressCreateSS58WithPublicKey(
+    publicKeyHandle: number,
+    coinType: number,
+    ss58Prefix: number
+  ): { description: string; data: string }
+
   /** Create an AnyAddress from a string. Returns the description (formatted address). */
   anyAddressCreateWithString(address: string, coinType: number): string
 

package/src/index.test.ts

@@ -1,6 +1,9 @@
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 
 const native = vi.hoisted(() => ({
+  anyAddressCreateSS58: vi.fn(() => ({ description: 'ss58-address', data: 'AQID' })),
+  anyAddressCreateSS58WithPublicKey: vi.fn(() => ({ description: 'ss58-address', data: 'AQID' })),
+  anyAddressData: vi.fn(),
   derivationPath: vi.fn((_coinType: number) => "m/44'/60'/0'/0/0"),
   deriveAddressFromPublicKey: vi.fn((_coinType: number, _handle: number) => '0x1234'),
 }))
@@ -39,3 +42,35 @@ describe('NativeWalletCore Robinhood contract', () => {
     expect(native.deriveAddressFromPublicKey).toHaveBeenNthCalledWith(2, 10_004_663, 7)
   })
 })
+
+describe('NativeWalletCore SS58 constructors', () => {
+  beforeEach(() => vi.clearAllMocks())
+
+  it('forwards the explicit prefix and preserves description and bytes from one native result', () => {
+    const wc = NativeWalletCore.getInstance()
+    const address = wc.AnyAddress.createSS58('ss58-address', wc.CoinType.polkadot, 42)
+    expect(native.anyAddressCreateSS58).toHaveBeenCalledWith('ss58-address', 354, 42)
+    expect(address.description()).toBe('ss58-address')
+    expect(address.data()).toEqual(new Uint8Array([1, 2, 3]))
+    expect(native.anyAddressData).not.toHaveBeenCalled()
+    expect(() => address.delete()).not.toThrow()
+  })
+
+  it('forwards the public-key handle and prefix without reparsing with a default prefix', () => {
+    const wc = NativeWalletCore.getInstance()
+    const publicKey = { _handle: 7 } as NativePublicKeyInstance
+    const address = wc.AnyAddress.createSS58WithPublicKey(publicKey, wc.CoinType.polkadot, 42)
+    expect(native.anyAddressCreateSS58WithPublicKey).toHaveBeenCalledWith(7, 354, 42)
+    expect(address.description()).toBe('ss58-address')
+    expect(address.data()).toEqual(new Uint8Array([1, 2, 3]))
+    expect(native.anyAddressData).not.toHaveBeenCalled()
+  })
+
+  it('propagates invalid-address errors from the native constructor', () => {
+    const wc = NativeWalletCore.getInstance()
+    native.anyAddressCreateSS58.mockImplementationOnce(() => {
+      throw new Error('Invalid SS58 address')
+    })
+    expect(() => wc.AnyAddress.createSS58('invalid', wc.CoinType.polkadot, 42)).toThrow('Invalid SS58 address')
+  })
+})

package/src/index.ts

@@ -68,6 +68,7 @@ export interface NativeDataVectorInstance {
 }
 
 export interface NativeAnyAddressInstance {
+  delete(): void
   description(): string
   data(): Uint8Array
 }
@@ -95,6 +96,12 @@ export interface WalletCoreLike {
     isValid(address: string, coinType: number): boolean
     isValidBech32(address: string, coinType: number, hrp: string): boolean
     isValidSS58(address: string, coinType: number, ss58Prefix: number): boolean
+    createSS58(address: string, coinType: number, ss58Prefix: number): NativeAnyAddressInstance
+    createSS58WithPublicKey(
+      publicKey: NativePublicKeyInstance,
+      coinType: number,
+      ss58Prefix: number
+    ): NativeAnyAddressInstance
     createWithString(address: string, coinType: number): NativeAnyAddressInstance
     createBech32WithPublicKey(
       publicKey: NativePublicKeyInstance,
@@ -434,6 +441,9 @@ class NativeDataVector implements NativeDataVectorInstance {
 // ---------------------------------------------------------------------------
 
 class NativeAnyAddress implements NativeAnyAddressInstance {
+  delete(): void {
+    // Results are copied from native objects; no native handle is retained.
+  }
   private readonly _description: string
   private readonly _data: string | null
 
@@ -785,6 +795,14 @@ export class NativeWalletCore {
         isValidSS58(address: string, coinType: number, ss58Prefix: number): boolean {
           return ExpoWalletCore.anyAddressIsValidSS58(address, coinType, ss58Prefix)
         },
+        createSS58(address: string, coinType: number, ss58Prefix: number): NativeAnyAddress {
+          const result = ExpoWalletCore.anyAddressCreateSS58(address, coinType, ss58Prefix)
+          return new NativeAnyAddress(result.description, result.data)
+        },
+        createSS58WithPublicKey(publicKey: NativePublicKey, coinType: number, ss58Prefix: number): NativeAnyAddress {
+          const result = ExpoWalletCore.anyAddressCreateSS58WithPublicKey(publicKey._handle, coinType, ss58Prefix)
+          return new NativeAnyAddress(result.description, result.data)
+        },
         createWithString(address: string, coinType: number): NativeAnyAddress {
           const desc = ExpoWalletCore.anyAddressCreateWithString(address, coinType)
           const dataB64 = ExpoWalletCore.anyAddressData(address, coinType)