@vultisig/cli 0.24.1 → 0.25.0

package/CHANGELOG.md

@@ -1,5 +1,27 @@
 # @vultisig/cli
 
+## 0.25.0
+
+### Patch Changes
+
+- [#500](https://github.com/vultisig/vultisig-sdk/pull/500) [`46bb0ff`](https://github.com/vultisig/vultisig-sdk/commit/46bb0ff399fef2b082c906a097e10ebb223682a8) Thanks [@neavra](https://github.com/neavra)! - agent: report honest tool success instead of a hardcoded `true`
+
+  The agent CLI reported every finished server-side tool as `success: true`
+  regardless of outcome. `session.ts` hardcoded the result and `client.ts`
+  discarded the `tool-output-available` payload, so a failed `execute_send` /
+  `execute_swap` (invalid address, insufficient balance, no swap route, signing
+  failure) surfaced as a success to programmatic consumers (the `--via-agent`
+  pipe, automation, UI status). The client now derives success from the tool's
+  output payload (`{"status":"error"}` / `{"error"}` / stringified), passed
+  through `onToolProgress`; `ok ?? true` keeps the prior optimistic default when
+  no output is present so older backends cannot regress legitimate successes.
+
+- Updated dependencies [[`c2fd086`](https://github.com/vultisig/vultisig-sdk/commit/c2fd08670ad67e9ec93443569f9b9b9aa5f9d685), [`7b384c8`](https://github.com/vultisig/vultisig-sdk/commit/7b384c89cb0fd82e76161feee78eccbc2c4401eb), [`585c177`](https://github.com/vultisig/vultisig-sdk/commit/585c177d4de4960a764f2528aa48aebc42450f7d), [`1667b79`](https://github.com/vultisig/vultisig-sdk/commit/1667b79fbc754e36032942fb5e749706dfc09bf3), [`46274d7`](https://github.com/vultisig/vultisig-sdk/commit/46274d70fe19fb2f44bc90d9ec0cd4ac1994ae69), [`0c9f6d5`](https://github.com/vultisig/vultisig-sdk/commit/0c9f6d5139d4a096645a575505c7550c2b26bd2a)]:
+  - @vultisig/sdk@0.25.0
+  - @vultisig/core-chain@2.1.0
+  - @vultisig/client-shared@0.2.9
+  - @vultisig/rujira@20.0.0
+
 ## 0.24.1
 
 ### Patch Changes

package/dist/index.js

@@ -5,16 +5,10 @@ var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
 var __getOwnPropNames = Object.getOwnPropertyNames;
 var __getProtoOf = Object.getPrototypeOf;
 var __hasOwnProp = Object.prototype.hasOwnProperty;
-var __require = /* @__PURE__ */ ((x) => typeof require !== "undefined" ? require : typeof Proxy !== "undefined" ? new Proxy(x, {
-  get: (a, b) => (typeof require !== "undefined" ? require : a)[b]
-}) : x)(function(x) {
-  if (typeof require !== "undefined") return require.apply(this, arguments);
-  throw Error('Dynamic require of "' + x + '" is not supported');
-});
 var __esm = (fn, res) => function __init() {
   return fn && (res = (0, fn[__getOwnPropNames(fn)[0]])(fn = 0)), res;
 };
-var __commonJS = (cb, mod) => function __require2() {
+var __commonJS = (cb, mod) => function __require() {
   return mod || (0, cb[__getOwnPropNames(cb)[0]])((mod = { exports: {} }).exports, mod), mod.exports;
 };
 var __export = (target, all) => {
@@ -4056,60 +4050,78 @@ async function executeSwapQuote(ctx2, options) {
   info('\nTo execute this swap, use the "swap" command');
   return quote;
 }
-async function executeSwap(ctx2, options) {
-  const vault = await ctx2.ensureActiveVault();
-  const isMax = options.amount === "max";
-  if (!isMax && (isNaN(options.amount) || options.amount <= 0)) {
-    throw new Error("Invalid amount");
-  }
-  const amountStr = isMax ? "max" : String(options.amount);
-  const quoteSpinner = createSpinner("Getting swap quote...");
-  const dryResult = await vault.swap({
+function validateSwapAmount(amount) {
+  if (amount === "max") return;
+  if (isNaN(amount) || amount <= 0) throw new Error("Invalid amount");
+}
+function getSwapAmountString(amount) {
+  return amount === "max" ? "max" : String(amount);
+}
+function toSwapRequest(options, amount, dryRun) {
+  return {
     fromChain: options.fromChain,
     fromSymbol: options.fromToken || "",
     toChain: options.toChain,
     toSymbol: options.toToken || "",
-    amount: amountStr,
-    dryRun: true
-  });
+    amount,
+    ...dryRun && { dryRun: true }
+  };
+}
+function toDryRunResult(options, quote, fromAmountRaw) {
+  const result = {
+    dryRun: true,
+    fromChain: String(options.fromChain),
+    fromToken: quote.fromCoin.ticker,
+    toChain: String(options.toChain),
+    toToken: quote.toCoin.ticker,
+    inputAmount: fromAmountRaw,
+    ...options.amount === "max" && { isMax: true },
+    estimatedOutput: formatBigintAmount(quote.estimatedOutput, quote.toCoin.decimals),
+    provider: quote.provider
+  };
+  if (quote.estimatedOutputFiat != null) result.estimatedOutputFiat = parseFloat(quote.estimatedOutputFiat.toFixed(2));
+  if (quote.requiresApproval) result.requiresApproval = true;
+  if (quote.warnings?.length) result.warnings = [...quote.warnings];
+  return result;
+}
+function displayDryRunResult(result) {
+  info(`
+Dry-run preview:`);
+  info(`  From:             ${result.inputAmount} ${result.fromToken} (${result.fromChain})`);
+  info(`  To:               ${result.estimatedOutput} ${result.toToken} (${result.toChain})`);
+  info(`  Provider:         ${result.provider}`);
+  if (result.estimatedOutputFiat != null) info(`  Est. value (USD): $${result.estimatedOutputFiat}`);
+  if (result.requiresApproval) info(`  Requires approval: yes`);
+  if (result.warnings?.length) result.warnings.forEach((w) => warn(`  Warning: ${w}`));
+}
+async function confirmSwapIfNeeded(options) {
+  if (options.yes) return;
+  if (isNonInteractive()) {
+    throw new Error("Swap requires confirmation. Use --yes to skip, or --dry-run to preview.");
+  }
+  const confirmed = await confirmSwap();
+  if (!confirmed) {
+    warn("Swap cancelled");
+    throw new Error("Swap cancelled by user");
+  }
+}
+async function executeSwap(ctx2, options) {
+  const vault = await ctx2.ensureActiveVault();
+  validateSwapAmount(options.amount);
+  const amountStr = getSwapAmountString(options.amount);
+  const quoteSpinner = createSpinner("Getting swap quote...");
+  const dryResult = await vault.swap(toSwapRequest(options, amountStr, true));
   if (!dryResult.dryRun) throw new Error("unreachable");
   quoteSpinner.succeed("Quote received");
   const quote = dryResult.quote;
-  const fromAmountRaw = isMax ? formatBigintAmount(quote.maxSwapable, quote.fromCoin.decimals) : String(options.amount);
-  const fromAmountDisplay = isMax ? `${fromAmountRaw} (max)` : fromAmountRaw;
+  const fromAmountRaw = options.amount === "max" ? formatBigintAmount(quote.maxSwapable, quote.fromCoin.decimals) : String(options.amount);
+  const fromAmountDisplay = options.amount === "max" ? `${fromAmountRaw} (max)` : fromAmountRaw;
   if (options.dryRun) {
-    const estimatedOutput = formatBigintAmount(quote.estimatedOutput, quote.toCoin.decimals);
-    const result = {
-      dryRun: true,
-      fromChain: String(options.fromChain),
-      fromToken: quote.fromCoin.ticker,
-      toChain: String(options.toChain),
-      toToken: quote.toCoin.ticker,
-      inputAmount: fromAmountRaw,
-      ...isMax && { isMax: true },
-      estimatedOutput,
-      provider: quote.provider
-    };
-    if (quote.estimatedOutputFiat != null) {
-      result.estimatedOutputFiat = parseFloat(quote.estimatedOutputFiat.toFixed(2));
-    }
-    if (quote.requiresApproval) {
-      result.requiresApproval = true;
-    }
-    if (quote.warnings && quote.warnings.length > 0) {
-      result.warnings = [...quote.warnings];
-    }
+    const result = toDryRunResult(options, quote, fromAmountRaw);
     if (isJsonOutput()) {
       outputJson(result);
     } else {
-      info(`
-Dry-run preview:`);
-      info(`  From:             ${result.inputAmount} ${result.fromToken} (${result.fromChain})`);
-      info(`  To:               ${result.estimatedOutput} ${result.toToken} (${result.toChain})`);
-      info(`  Provider:         ${result.provider}`);
-      if (result.estimatedOutputFiat != null) info(`  Est. value (USD): $${result.estimatedOutputFiat}`);
-      if (result.requiresApproval) info(`  Requires approval: yes`);
-      if (result.warnings?.length) result.warnings.forEach((w) => warn(`  Warning: ${w}`));
+      displayDryRunResult(result);
     }
     return result;
   }
@@ -4124,29 +4136,14 @@ Dry-run preview:`);
       discountTier
     });
   }
-  if (!options.yes) {
-    if (isNonInteractive()) {
-      throw new Error("Swap requires confirmation. Use --yes to skip, or --dry-run to preview.");
-    }
-    const confirmed = await confirmSwap();
-    if (!confirmed) {
-      warn("Swap cancelled");
-      throw new Error("Swap cancelled by user");
-    }
-  }
+  await confirmSwapIfNeeded(options);
   await ensureVaultUnlocked(vault, options.password);
   const signSpinner = createSpinner("Signing swap transaction...");
   vault.on("signingProgress", ({ step }) => {
     signSpinner.text = `${step.message} (${step.progress}%)`;
   });
   try {
-    const result = await vault.swap({
-      fromChain: options.fromChain,
-      fromSymbol: options.fromToken || "",
-      toChain: options.toChain,
-      toSymbol: options.toToken || "",
-      amount: amountStr
-    });
+    const result = await vault.swap(toSwapRequest(options, amountStr));
     if (result.dryRun) throw new Error("unreachable");
     const broadcast = result;
     signSpinner.succeed(`Swap broadcast: ${broadcast.txHash}`);
@@ -4944,6 +4941,28 @@ function v1StatusFromType(type) {
       return void 0;
   }
 }
+function isErrorPayloadObject(o) {
+  return o.status === "error" || "error" in o;
+}
+function deriveToolDoneOk(status, output) {
+  if (status !== "done" || output == null) return void 0;
+  if (typeof output === "object") {
+    return !isErrorPayloadObject(output);
+  }
+  if (typeof output === "string") {
+    const s = output.trim();
+    if (/^error\b/i.test(s)) return false;
+    try {
+      const parsed = JSON.parse(s);
+      if (parsed !== null && typeof parsed === "object" && !Array.isArray(parsed)) {
+        return !isErrorPayloadObject(parsed);
+      }
+    } catch {
+    }
+    return !(/"status"\s*:\s*"error"/i.test(s) || /"error"\s*:/i.test(s));
+  }
+  return true;
+}
 function sseErrorToMessage(value) {
   if (value == null) return "";
   if (typeof value === "string") return value;
@@ -4955,6 +4974,16 @@ function sseErrorToMessage(value) {
     return String(value);
   }
 }
+function getV1Type(parsed) {
+  return typeof parsed?.type === "string" && parsed.type.length > 0 ? parsed.type : null;
+}
+function getV1Data(parsed, v1Type) {
+  return v1Type?.startsWith("data-") ? parsed.data : null;
+}
+function getToolInput(parsed) {
+  const rawInput = parsed.input;
+  return rawInput && typeof rawInput === "object" && !Array.isArray(rawInput) ? rawInput : {};
+}
 var AgentClient = class {
   baseUrl;
   authToken = null;
@@ -5104,40 +5133,16 @@ var AgentClient = class {
   handleSSEEvent(event, data, result, callbacks, toolNameByCallId) {
     try {
       const parsed = JSON.parse(data);
-      const v1Type = typeof parsed?.type === "string" && parsed.type.length > 0 ? parsed.type : null;
+      const v1Type = getV1Type(parsed);
       const routingEvent = v1Type ? this.mapV1EventType(v1Type) : event;
-      const v1Data = typeof parsed?.type === "string" && parsed.type.startsWith("data-") ? parsed.data : null;
+      const v1Data = getV1Data(parsed, v1Type);
       switch (routingEvent) {
         case "text_delta":
-          if (typeof parsed.delta === "string") {
-            result.fullText += parsed.delta;
-            callbacks.onTextDelta?.(parsed.delta);
-          }
+          this.handleTextDelta(parsed, result, callbacks);
           break;
-        case "tool_progress": {
-          if (this.verbose) process.stderr.write(`[SSE:tool_progress] raw: ${data.slice(0, 1e3)}
-`);
-          const v1Status = v1StatusFromType(v1Type);
-          const status = parsed.status ?? v1Status;
-          const callId = typeof parsed.toolCallId === "string" ? parsed.toolCallId : null;
-          const rawInlineName = parsed.tool ?? parsed.toolName;
-          const inlineName = typeof rawInlineName === "string" && rawInlineName.length > 0 ? rawInlineName : void 0;
-          if (callId && inlineName) {
-            toolNameByCallId.set(callId, inlineName);
-          }
-          const toolName = inlineName ?? (callId ? toolNameByCallId.get(callId) : void 0);
-          const label = typeof parsed.label === "string" ? parsed.label : void 0;
-          if (v1Type === "tool-input-available" && parsed.clientExecuted === true && callId && toolName && callbacks.onClientSideToolCall) {
-            const rawInput = parsed.input;
-            const input = rawInput && typeof rawInput === "object" && !Array.isArray(rawInput) ? rawInput : {};
-            callbacks.onClientSideToolCall(callId, toolName, input);
-          }
-          if (status && toolName) {
-            callbacks.onToolProgress?.(toolName, status, label);
-          }
-          if (status === "done" && callId) toolNameByCallId.delete(callId);
+        case "tool_progress":
+          this.handleToolProgress(parsed, data, callbacks, toolNameByCallId, v1Type);
           break;
-        }
         case "title": {
           const title = v1Data?.title ?? parsed.title;
           if (typeof title === "string") callbacks.onTitle?.(title);
@@ -5165,10 +5170,7 @@ var AgentClient = class {
           break;
         }
         case "error": {
-          const errorText = typeof parsed.errorText === "string" ? parsed.errorText : parsed.error;
-          const msg = sseErrorToMessage(errorText);
-          const codeFromBackend = typeof parsed.code === "string" && isAgentErrorCode(parsed.code) ? parsed.code : inferAgentErrorCodeFromMessage(msg);
-          callbacks.onError?.(msg, codeFromBackend);
+          this.handleErrorEvent(parsed, callbacks);
           break;
         }
         case "done":
@@ -5183,6 +5185,38 @@ var AgentClient = class {
       }
     }
   }
+  handleTextDelta(parsed, result, callbacks) {
+    if (typeof parsed.delta !== "string") return;
+    result.fullText += parsed.delta;
+    callbacks.onTextDelta?.(parsed.delta);
+  }
+  handleToolProgress(parsed, data, callbacks, toolNameByCallId, v1Type) {
+    if (this.verbose) process.stderr.write(`[SSE:tool_progress] raw: ${data.slice(0, 1e3)}
+`);
+    const status = parsed.status ?? v1StatusFromType(v1Type);
+    const callId = typeof parsed.toolCallId === "string" ? parsed.toolCallId : null;
+    const rawInlineName = parsed.tool ?? parsed.toolName;
+    const inlineName = typeof rawInlineName === "string" && rawInlineName.length > 0 ? rawInlineName : void 0;
+    if (callId && inlineName) toolNameByCallId.set(callId, inlineName);
+    const toolName = inlineName ?? (callId ? toolNameByCallId.get(callId) : void 0);
+    const label = typeof parsed.label === "string" ? parsed.label : void 0;
+    this.maybeEmitClientSideToolCall(parsed, callbacks, v1Type, callId, toolName);
+    const ok = deriveToolDoneOk(status, parsed.output);
+    if (status && toolName) callbacks.onToolProgress?.(toolName, status, label, ok);
+    if (status === "done" && callId) toolNameByCallId.delete(callId);
+  }
+  maybeEmitClientSideToolCall(parsed, callbacks, v1Type, callId, toolName) {
+    if (v1Type !== "tool-input-available" || parsed.clientExecuted !== true || !callId || !toolName || !callbacks.onClientSideToolCall) {
+      return;
+    }
+    callbacks.onClientSideToolCall(callId, toolName, getToolInput(parsed));
+  }
+  handleErrorEvent(parsed, callbacks) {
+    const errorText = typeof parsed.errorText === "string" ? parsed.errorText : parsed.error;
+    const msg = sseErrorToMessage(errorText);
+    const codeFromBackend = typeof parsed.code === "string" && isAgentErrorCode(parsed.code) ? parsed.code : inferAgentErrorCodeFromMessage(msg);
+    callbacks.onError?.(msg, codeFromBackend);
+  }
   // Maps a V1 `type` field to the legacy event bucket used by handleSSEEvent's
   // switch. Frame-level types (start, text-start, text-end, finish-step) and
   // non-critical telemetry (data-tokens, data-usage, data-confirmation) route
@@ -5479,17 +5513,8 @@ var Chain9 = {
   ...CosmosChain,
   ...OtherChain
 };
-var UtxoBasedChain = [
-  ...Object.values(UtxoChain),
-  OtherChain.Cardano
-];
-var defaultChains = [
-  Chain9.Bitcoin,
-  Chain9.Ethereum,
-  Chain9.THORChain,
-  Chain9.Solana,
-  Chain9.BSC
-];
+var UtxoBasedChain = [...Object.values(UtxoChain), OtherChain.Cardano];
+var defaultChains = [Chain9.Bitcoin, Chain9.Ethereum, Chain9.THORChain, Chain9.Solana, Chain9.BSC];
 
 // ../../packages/core/chain/dist/ChainKind.js
 var chainKindRecord = {
@@ -5538,10 +5563,7 @@ function getChainKind(chain) {
 
 // ../../packages/lib/utils/dist/record/recordMap.js
 function recordMap(record, fn) {
-  return Object.fromEntries(Object.entries(record).map(([key, value]) => [
-    key,
-    fn(value, key)
-  ]));
+  return Object.fromEntries(Object.entries(record).map(([key, value]) => [key, fn(value, key)]));
 }
 
 // ../../packages/lib/utils/dist/record/makeRecord/index.js
@@ -5554,14 +5576,7 @@ var makeRecord = (keys, getValue) => {
 };
 
 // ../../packages/core/chain/dist/chains/cosmos/thor/kujira-merge/index.js
-var kujiraCoinsMigratedToThorChain = [
-  "kuji",
-  "rkuji",
-  "fuzn",
-  "nstk",
-  "wink",
-  "lvn"
-];
+var kujiraCoinsMigratedToThorChain = ["kuji", "rkuji", "fuzn", "nstk", "wink", "lvn"];
 var kujiraCoinsMigratedToThorChainMetadata = {
   kuji: {
     ticker: "KUJI",
@@ -7951,11 +7966,12 @@ var AgentSession = class {
     let dispatchChain = Promise.resolve();
     const callbacks = {
       onTextDelta: (delta) => ui.onTextDelta(delta),
-      onToolProgress: (tool, status, label) => {
+      onToolProgress: (tool, status, label, ok) => {
         if (status === "running") {
           ui.onToolCall(`mcp-${tool}`, tool);
         } else {
-          ui.onToolResult(`mcp-${tool}`, tool, true, { label });
+          const success2 = ok ?? true;
+          ui.onToolResult(`mcp-${tool}`, tool, success2, { label }, success2 ? void 0 : `${tool} reported an error`);
         }
       },
       onClientSideToolCall: (toolCallId, toolName, input) => {
@@ -8739,14 +8755,14 @@ function formatDate(iso) {
 
 // src/lib/version.ts
 import chalk10 from "chalk";
-import { readFileSync as readFileSync3, writeFileSync as writeFileSync3, mkdirSync as mkdirSync3, existsSync as existsSync2 } from "fs";
+import { existsSync as existsSync2, mkdirSync as mkdirSync3, readFileSync as readFileSync3, writeFileSync as writeFileSync3 } from "fs";
 import { homedir as homedir3 } from "os";
 import { join as join3 } from "path";
 var cachedVersion = null;
 function getVersion() {
   if (cachedVersion) return cachedVersion;
   if (true) {
-    cachedVersion = "0.24.1";
+    cachedVersion = "0.25.0";
     return cachedVersion;
   }
   try {
@@ -10421,13 +10437,10 @@ Error: ${error2.message}`));
   }
 };
 
-// src/lib/errors.ts
-import chalk14 from "chalk";
-
 // src/lib/completion.ts
+import { existsSync as existsSync3, readdirSync, readFileSync as readFileSync4 } from "fs";
 import { homedir as homedir4 } from "os";
 import { join as join4 } from "path";
-import { readFileSync as readFileSync4, existsSync as existsSync3 } from "fs";
 var tabtab = null;
 async function getTabtab() {
   if (!tabtab) {
@@ -10494,7 +10507,6 @@ function getVaultNames() {
   try {
     const vaultDir = join4(homedir4(), ".vultisig", "vaults");
     if (!existsSync3(vaultDir)) return [];
-    const { readdirSync } = __require("fs");
     const files = readdirSync(vaultDir);
     const names = [];
     for (const file of files) {
@@ -10738,6 +10750,9 @@ complete -c vsig -n "__fish_seen_subcommand_from import export" -a "(__fish_comp
 `.trim();
 }
 
+// src/lib/errors.ts
+import chalk14 from "chalk";
+
 // src/lib/user-agent.ts
 function setupUserAgent() {
   const userAgent = `vultisig-cli/${getVersion()}`;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vultisig/cli",
-  "version": "0.24.1",
+  "version": "0.25.0",
   "description": "The self-custody MPC wallet CLI for AI coding agents (Claude Code, Cursor, OpenCode). Natural-language agent mode, 36+ chains, DKLS23 threshold signatures. Seedless.",
   "type": "module",
   "bin": {
@@ -73,15 +73,15 @@
     "@cosmjs/stargate": "^0.38.1",
     "@napi-rs/keyring": "^1.3.0",
     "@noble/hashes": "^2.0.1",
-    "@vultisig/client-shared": "^0.2.8",
-    "@vultisig/core-chain": "^2.0.0",
-    "@vultisig/rujira": "^19.0.0",
-    "@vultisig/sdk": "^0.24.0",
+    "@vultisig/client-shared": "^0.2.9",
+    "@vultisig/core-chain": "^2.1.0",
+    "@vultisig/rujira": "^20.0.0",
+    "@vultisig/sdk": "^0.25.0",
     "chalk": "^5.6.2",
     "cli-table3": "^0.6.5",
     "commander": "^14.0.3",
     "dotenv": "^17.3.1",
-    "ora": "^9.3.0",
+    "ora": "^9.4.0",
     "qrcode-terminal": "^0.12.0",
     "tabtab": "^3.0.2",
     "viem": "^2.48.4",
@@ -95,7 +95,7 @@
     "esbuild": "^0.27.4",
     "tsx": "^4.21.0",
     "typescript": "^6.0.3",
-    "vitest": "^4.1.5"
+    "vitest": "^4.1.6"
   },
   "engines": {
     "node": ">=20.0.0"