@vtex/faststore-plugin-buyer-portal 1.3.86 → 1.3.88

package/CHANGELOG.md

@@ -7,6 +7,28 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.3.88] - 2026-07-23
+
+### Removed
+
+- PO Numbers, Cost Centers, and Releases pages, routes, and every dedicated client/hook/service/component (the `custom-fields` feature and the shared `custom-field` building blocks) — the underlying BFF service is discontinued on 2026-07-30
+- Address Locations client, hooks, services, and dedicated components/drawers, and the "Locations" tab from the "Add address" drawer (same discontinued BFF service)
+- PO Number/Cost Center/Release as selectable allocation types in "Add budget allocations" and as criteria presets in "Set order field criteria" (existing budget allocations and buying policy criteria created before this change keep displaying normally)
+- "Add cost center"/"Add PO number"/"Add release" shortcuts in the Org Unit "Add" dropdown (now disabled, no action)
+
+### Added
+
+- A persistent deprecation alert on the Org Unit Details page, explaining that PO Numbers, Cost Centers, and Releases were replaced by Accounting Fields and pointing to the upgrade path (buyer-portal plugin `v2.0.1+`, FastStore `v4`)
+- A persistent deprecation alert on the Address Details page, explaining that Address Locations was replaced by Accounting Fields and pointing to the same upgrade path
+- Support for a disabled, tooltip-carrying state on `VerticalNav.Link`, used to keep the "PO numbers"/"Cost centers"/"Releases" navigation entries visible (but disabled) in the Org Unit Details cards and the Contract-settings sidebar
+- Support for a disabled state on `TabOption`, used to keep the "Locations" tab visible (but disabled) on the Address Details page; the "Add Locations" shortcut in the address actions dropdown is disabled the same way
+
+## [1.3.87] - 2026-05-21
+
+### Fixed
+
+- Assortments page: use consistent "Assortments" title during loading and after page load by updating `routeLayoutMapping` and replacing the custom header with `HeaderInside`, aligning title position with other Contract settings pages
+
 ## [1.3.86] - 2026-05-19
 
 ### Added
@@ -640,7 +662,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Add CHANGELOG file
 - Add README file
 
-[unreleased]: https://github.com/vtex/faststore-plugin-buyer-portal/compare/1.3.86...HEAD
+[unreleased]: https://github.com/vtex/faststore-plugin-buyer-portal/compare/v1.3.87...HEAD
 [1.3.55]: https://github.com/vtex/faststore-plugin-buyer-portal/compare/v1.3.54...v1.3.55
 [1.3.54]: https://github.com/vtex/faststore-plugin-buyer-portal/compare/v1.3.53...v1.3.54
 [1.3.53]: https://github.com/vtex/faststore-plugin-buyer-portal/compare/v1.3.52...v1.3.53
@@ -725,4 +747,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 [1.3.70]: https://github.com/vtex/faststore-plugin-buyer-portal/compare/v1.3.69...v1.3.70
 [1.3.85]: https://github.com/vtex/faststore-plugin-buyer-portal/releases/tag/1.3.85
 
+[1.3.88]: https://github.com/vtex/faststore-plugin-buyer-portal/compare/v1.3.87...v1.3.88
+[1.3.87]: https://github.com/vtex/faststore-plugin-buyer-portal/compare/v1.3.86...v1.3.87
 [1.3.86]: https://github.com/vtex/faststore-plugin-buyer-portal/releases/tag/1.3.86

package/cypress/constants.ts

@@ -89,14 +89,6 @@ export const TEST_DATA = {
     NEW_ADDRESS_STATE: "RJ",
     NEW_ADDRESS_POSTAL_CODE: "22250-905",
   },
-  LOCATIONS: {
-    LOCATION_ADDRESS_NAME: "LOCATIONS",
-    FIRST_LOCATION: "Location 1",
-    SECOND_LOCATION: "Location 2",
-    THIRD_LOCATION: "Location 3",
-    FOURTH_LOCATION: "Location 4",
-    EDITED_LOCATION: "Edited Location",
-  },
   RECIPIENTS: {
     RECIPIENTS_ADDRESS_NAME: "RECIPIENTS",
     FIRST_RECIPIENT_NAME: "First Recipient",

package/cypress/integration/product-assortment.test.ts

@@ -6,7 +6,7 @@ function visitProductAssortmentPage() {
 
   // Navigate to product assortment page
   cy.get("[data-fs-vertical-nav-menu-item]")
-    .contains("Product assortment")
+    .contains("Assortments")
     .click({ timeout: TEST_CONFIG.TIMEOUTS.PAGE_LOAD });
 
   cy.wait(1000);
@@ -58,7 +58,7 @@ describe(
 
       // Wait for product assortment section to be visible
       cy.get("[data-fs-bp-header-inside-title]")
-        .contains("Product assortment")
+        .contains("Assortments")
         .should("be.visible");
 
       // Wait for product assortment table to be loaded

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vtex/faststore-plugin-buyer-portal",
-  "version": "1.3.86",
+  "version": "1.3.88",
   "description": "A plugin for faststore with buyer portal",
   "main": "index.js",
   "scripts": {

package/plugin.config.js

@@ -40,18 +40,6 @@ module.exports = {
       path: "/pvt/organization-account/product-assortment/[orgUnitId]/[contractId]",
       appLayout: false,
     },
-    "po-numbers": {
-      path: "/pvt/organization-account/po-numbers/[orgUnitId]/[contractId]",
-      appLayout: false,
-    },
-    "cost-centers": {
-      path: "/pvt/organization-account/cost-centers/[orgUnitId]/[contractId]",
-      appLayout: false,
-    },
-    releases: {
-      path: "/pvt/organization-account/releases/[orgUnitId]/[contractId]",
-      appLayout: false,
-    },
     roles: {
       path: "/pvt/organization-account/roles/[orgUnitId]",
       appLayout: false,

package/specs/assortments-page-fixes.md

@@ -0,0 +1,222 @@
+# Assortments Page Fixes
+
+> **Status**: Approved
+> **Created**: 2026-05-19
+
+## 1. Business Context
+
+### Problem Statement
+
+The **Assortments** page was recently released in the Buyer Portal (Contract settings), but manual testing revealed two UX inconsistencies compared to sibling pages in the same group (Profile, Addresses, Payment methods, Credit cards):
+
+1. **Unstable title during loading** — when navigating via the sidebar, users temporarily see "Product Assortment", and after the page finishes loading the title changes to "Assortments".
+2. **Incorrect title vertical position** — the "Assortments" title appears higher on the page than on sibling pages.
+
+These issues affect B2B administrators who manage organizational units and need to select the correct product assortment for each unit.
+
+### Goals
+
+- Ensure the title "Assortments" is displayed consistently during and after page load.
+- Align the page header positioning and typography with other Contract settings pages.
+
+### User Stories
+
+#### US-1: Consistent title during navigation
+
+- **Story**: As a contract administrator, I want the page title to remain "Assortments" while the page loads, so that I am not confused by a temporary, incorrect label.
+- **Acceptance Criteria**:
+  - **Given** I am on any Contract settings page, **when** I click "Assortments" in the sidebar, **then** the loading state shows the title "Assortments" (not "Product Assortment" or "Product assortment").
+  - **Given** the Assortments page finishes loading, **when** the content is rendered, **then** the title remains "Assortments" with no visible title swap.
+
+#### US-2: Header aligned with sibling pages
+
+- **Story**: As a contract administrator, I want the Assortments page header to match Profile, Addresses, and Payment methods, so that the portal feels cohesive.
+- **Acceptance Criteria**:
+  - **Given** I open Assortments and any other Contract settings page (e.g. Addresses), **when** I compare the page title position, **then** both titles share the same vertical offset from the top of the content area.
+  - **Given** the Assortments page is loaded, **when** I view the header, **then** it uses the shared `HeaderInside` component and styling used by sibling pages.
+  - **Given** the Assortments page is loaded, **when** I read the descriptive text below the title, **then** the subtitle "Select the product assortment that users in this organizational unit should access" is still visible.
+
+### Key Scenarios
+
+| Scenario | Pre-conditions | Steps | Expected Result |
+|---|---|---|---|
+| Happy path — list and selection | Contract with assortments; one assortment enabled | Open Assortments → select a different assortment | Title stays "Assortments"; all assortments listed; selection saves with success toast |
+| Error case — failed selection save | User on Assortments page; API PUT fails | Select a different assortment | Radio reverts to previous selection; error toast "Failed to save assortment" |
+| Edge case — loading transition | User on Profile page | Click "Assortments" in sidebar | Loading skeleton shows `HeaderInside` with title "Assortments"; no flicker to a different label after load |
+
+### Functional Requirements
+
+- FR-1: The assortments route `pageTitle` in `routeLayoutMapping.ts` must be `"Assortments"`.
+- FR-2: `ProductAssortmentLayout` must use `HeaderInside title="Assortments"` instead of the custom header (`h1` + custom styles).
+- FR-3: The descriptive subtitle must remain below `HeaderInside`, with scoped styles in the page section.
+- FR-4: Radio selection behavior and persistence via `useSetAssortment` remain unchanged.
+- FR-5: The listing must display all assortments returned by the API in a single request (maximum of 20 per contract — pagination is not required).
+
+### Non-Functional Requirements
+
+- Maintain plugin boundary compatibility — changes limited to `src/features/product-assortment/` and existing shared utilities.
+- Pass `make lint`, `make typecheck`, and `make test`.
+- Update Cypress tests only where the title or navigation label changed to "Assortments".
+
+### Out of Scope
+
+- **Pagination** — a contract supports at most 20 assortments; the API returns all of them in a single response, making pagination controls unnecessary.
+- Add/remove assortment drawer functionality (present in legacy Cypress tests, absent from the current implementation).
+- Name search/filter (the hook already accepts `search`, but it is not part of this fix).
+- Changes to the API logic that places the enabled assortment at the top.
+- Renaming routes or paths (`/product-assortment/...` remains unchanged).
+
+---
+
+## 2. Arch Decisions
+
+### Proposed Solution
+
+Fix the two UX bugs by aligning the Assortments page header with other Contract settings pages, reusing `HeaderInside` and unifying the title via `routeLayoutMapping`.
+
+### Architecture Overview
+
+```mermaid
+sequenceDiagram
+    participant User
+    participant LoadingTabsLayout
+    participant ProductAssortmentLayout
+    participant useGetProductAssortment
+    participant API
+
+    User->>LoadingTabsLayout: Click "Assortments"
+    LoadingTabsLayout->>User: HeaderInside title="Assortments" (from routeLayoutMapping)
+    LoadingTabsLayout->>ProductAssortmentLayout: Route loaded
+    ProductAssortmentLayout->>useGetProductAssortment: orgUnitId, contractId
+    useGetProductAssortment->>API: GET .../assortments/available
+    API-->>ProductAssortmentLayout: items (up to 20)
+    ProductAssortmentLayout->>User: HeaderInside + table
+```
+
+### Root Cause Analysis
+
+| Bug | Root cause (original code) |
+|---|---|
+| Title flicker | `LoadingTabsLayout` reads `pageTitle: "Product assortment"` from `routeLayoutMapping.ts` and renders it via `HeaderInside` (with `text-transform: capitalize` → "Product Assortment"). After load, `ProductAssortmentLayout` renders a custom `h1` with text "Assortments". |
+| Title position | `ProductAssortmentLayout` does not use `HeaderInside`; it uses `[data-fs-bp-assortments-header]` with `padding: var(--fs-spacing-3) 0` and custom typography, unlike `[data-fs-bp-header-inside]` (`padding: var(--fs-bp-padding-4/8/9) 0`). |
+
+### Alternatives Considered
+
+| Alternative | Pros | Cons | Verdict |
+|---|---|---|---|
+| A. Unified `HeaderInside` + `routeLayoutMapping` | Consistent with sibling pages; fixes flicker and position | Requires subtitle adjustment below the header | **Accepted** |
+| B. Keep custom header and only adjust padding | Minimal diff | Still diverges from `HeaderInside` typography/responsiveness; does not fix flicker alone | Rejected |
+| C. Server-side pagination | Supports large lists | Unnecessary — maximum of 20 assortments per contract | Rejected |
+| D. Remove subtitle to match Profile | Less markup | Loses useful context for the user; subtitle is a product requirement | Rejected |
+
+### Risks & Mitigations
+
+| Risk | Impact | Likelihood | Mitigation |
+|---|---|---|---|
+| Legacy Cypress tests fail | Med | High | Update only title and navigation label expectations; leave legacy drawer/filter scenarios unchanged |
+| Contract assortment limit increases in the future | Low | Low | Re-evaluate pagination if the business limit changes |
+
+### Key Decisions
+
+#### Decision 1: Unify title via `routeLayoutMapping` + `HeaderInside`
+
+- **Status**: Accepted
+- **Context**: Loading and loaded states use different title mechanisms.
+- **Decision**: Change `pageTitle` to `"Assortments"` and migrate the loaded layout to `HeaderInside title="Assortments"`.
+- **Consequences**: `LoadingTabsLayout`, `ErrorTabsLayout`, and the loaded page all display the same title. Removes the custom `[data-fs-bp-assortments-title]`.
+
+#### Decision 2: No pagination
+
+- **Status**: Accepted
+- **Context**: Contracts support at most 20 assortments; the API returns all of them in a single response.
+- **Decision**: Do not implement pagination, `useUrlPaginatedSearch`, or a `page` query param.
+- **Consequences**: Simpler layout; single fetch via `useGetProductAssortment` without lazy/router sync.
+
+#### Decision 3: Keep subtitle as a separate element
+
+- **Status**: Accepted
+- **Context**: No sibling page has a subtitle, but Assortments needs explanatory text.
+- **Decision**: Render `<p data-fs-bp-assortments-subtitle>` immediately below `HeaderInside`, keeping existing scoped styles.
+- **Consequences**: Title position aligns with sibling pages; subtitle sits below without affecting the `h1` offset.
+
+### Implementation Plan
+
+1. **Consistent title**
+   - Edit `src/features/shared/utils/routeLayoutMapping.ts`: `pageTitle: "Assortments"`.
+
+2. **Aligned header**
+   - Refactor `ProductAssortmentLayout.tsx`:
+     - Import and use `HeaderInside title="Assortments"`.
+     - Remove `div[data-fs-bp-assortments-header]` and the custom `h1`.
+     - Keep the subtitle below the header.
+   - Remove obsolete `[data-fs-bp-assortments-title]` and header styles from `product-assortment-layout.scss`; preserve subtitle styles.
+
+3. **Tests**
+   - Update `cypress/integration/product-assortment.test.ts` only where the title or navigation label changed to "Assortments".
+
+4. **Verification**
+   - Run `make check`.
+   - Manual test against a linked host store: navigate to Assortments, confirm stable title, visual alignment vs Addresses, and full assortment listing.
+
+---
+
+## 3. Technical Contract
+
+### Data Models
+
+No changes to existing types in `src/features/product-assortment/types/index.ts`. The API response may include `paging`, but the frontend does not consume pagination in this scope.
+
+### Interfaces
+
+#### API — GET assortments (consumed by the plugin)
+
+| Field | Type | Notes |
+|---|---|---|
+| Path | `GET /customers/{contractId}/units/{unitId}/assortments/available` | Existing |
+| Query `name` | `string` (optional) | Existing, out of scope |
+| Response `items[]` | `{ id, name, enabled }` | Rendered in full (up to 20) |
+
+#### `useGetProductAssortment`
+
+```typescript
+useGetProductAssortment({
+  contractId: string;
+  orgUnitId: string;
+  search?: string;
+  options?: QueryOptions<...>;
+})
+// Returns: { data: { items, paging }, isProductAssortmentLoading, ... }
+```
+
+Single fetch on mount — no `page`, no `lazy`, no URL sync.
+
+#### Component boundaries
+
+| Module | Responsibility |
+|---|---|
+| `routeLayoutMapping.ts` | Loading/error title: `"Assortments"` |
+| `ProductAssortmentLayout` | Header, data fetch, empty state |
+| `ProductAssortmentTable` | Table rendering + radio selection |
+| `useSetAssortment` | PUT selection (unchanged) |
+
+### Integration Points
+
+- **LoadingTabsLayout / ErrorTabsLayout** — read `pageTitle` via `getTabsLayoutConfigFromRoute`; fixed indirectly by the `routeLayoutMapping` change.
+- **BFF/API** — `assortments/available` endpoint returns all contract assortments (max. 20).
+- **Host store** — no changes to `plugin.config.js` (route already registered).
+
+### Invariants & Constraints
+
+- The sidebar menu continues to display **"Assortments"** (`getContractSettingsLinks.ts` — already correct).
+- The loaded, loading, and error page title must always be **"Assortments"**.
+- The assortment with `enabled: true` remains selected via radio; the API is responsible for placing it at the top when applicable.
+- No new cross-domain dependencies — only `shared` (`HeaderInside`).
+
+### Files to Change
+
+| File | Change |
+|---|---|
+| `src/features/shared/utils/routeLayoutMapping.ts` | `pageTitle` → `"Assortments"` |
+| `src/features/product-assortment/layouts/ProductAssortmentLayout/ProductAssortmentLayout.tsx` | `HeaderInside`, simple fetch |
+| `src/features/product-assortment/layouts/ProductAssortmentLayout/product-assortment-layout.scss` | Remove custom title styles; keep subtitle |
+| `cypress/integration/product-assortment.test.ts` | Update title and navigation label to "Assortments" |