@vtex/api 6.52.0 → 6.52.5

package/CHANGELOG.md

@@ -7,30 +7,56 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
-## [6.52.0]
-### Added
-- Cluster-wide Prometheus `/metrics` aggregation. Each cluster worker keeps its own
-  prom-client registry, so serving `/metrics` from a single round-robin selected
-  worker exposed only that worker's counters; Prometheus read the per-scrape braid
-  of independent monotonic counters as counter resets and inflated `rate()` /
-  `increase()` on `runtime_http_*` counters by orders of magnitude. In multi-worker
-  mode the worker answering a scrape now asks the master for a merged, monotonic
-  view built from every worker's registry over the existing cluster IPC (via
-  prom-client's `AggregatorRegistry`), with a bounded timeout and a local-registry
-  fallback. Single-worker mode (`workers === 1`, includes `LINKED`) is unchanged.
-  Backport of #667 to the 6.x line.
-### Fixed
-- `runtime_http_*` metrics no longer emit samples without a `handler` label. Requests
-  that never reach a named handler (unmatched paths, replica-level rate limit
-  rejections, errors before the route pipeline) were counted with
-  `handler: undefined`; Node's cluster IPC serializes worker registries as JSON, which
-  drops `undefined` values, so the aggregated `/metrics` exposed a second, unnamed
-  series that Prometheus reads as `handler=""`. Those requests are now labelled
-  `handler="undefined"` — the same value prom-client rendered locally before cluster
-  aggregation — keeping dashboards and alerts that filter on it working. Backport of
-  #673 to the 6.x line.
-- `/_status` requests are now reported as `handler="builtin:status-track"`, matching
-  the other builtin handlers, instead of falling into the unnamed bucket.
+## [6.52.5]
+
+### Security
+
+- Error objects assigned to the response body no longer expose the request
+  configuration, credentials, connection agents or, outside link mode, the
+  stack. If the response cannot be sanitized it is withheld. A body the walk cannot
+  inspect completely is sent as it is, and the limit is reported.
+- String response bodies built from an error (`` `failed: ${JSON.stringify(error)}` ``) no longer
+  expose its credentials: the request's tokens, the value of credential headers (`authorization`,
+  `proxy-authorization`, `VtexIdclientAutCookie`, `x-vtex-api-*`), the VTEX ID cookie and `Bearer`
+  tokens are replaced with `[Redacted]`. The same names are replaced when the request is
+  embedded as header lines (`Cookie`, `Set-Cookie`, `X-Vtex-Session`), not only as JSON keys.
+- The body the runtime builds from a thrown value goes through the same sanitizer. An error that is
+  a property of the thrown one (`originalError`), or sits in a thrown object, no longer exposes its
+  request configuration, request or stack, and the upstream response headers are no longer
+  included. Linked apps keep the stack but no longer get the configuration in the body.
+- Errors printed by the runtime no longer include the request configuration.
+- GraphQL error responses no longer include the stack outside link mode.
+
+## [6.52.4]
+### Fixed
+- `yarn test` no longer fails to even load `src/service/logger` and its transitive
+  dependents under `jest@25`: that resolver predates the package `exports` field, so
+  it couldn't resolve `@vtex/diagnostics-nodejs@0.1.0-beta.10`'s OpenTelemetry OTLP
+  exporter chain (reached via `@opentelemetry/otlp-exporter-base/node-http`), which is
+  loaded at module-eval time by nearly every service module. Stubbed the package for
+  tests via `jest.config.js` `moduleNameMapper` (see `jest/stubs/diagnosticsNodejs.js`);
+  the real telemetry/log-client paths are lazy and error-guarded, so this has no
+  behavioural effect on the code under test.
+- `TestServer.closeServer()`'s `new Promise((resolve) => ...)` failed to type-check
+  under strict `Promise<void>` typing; typed the executor explicitly.
+- The `axiosTracing.test.ts` "forcing ECONNREFUSED" suite pointed at `localhost`, which
+  Node's `autoSelectFamily` (Happy Eyeballs) resolves to both loopback addresses; since
+  both connections are refused, Node throws an `AggregateError` with an empty top-level
+  `message` instead of the plain `ECONNREFUSED` error the test asserts on. Uses the
+  literal `127.0.0.1` instead.
+
+## [6.52.2]
+### Fixed
+- TSLint violations across `src/axios.d.ts`, `src/caches/MultilayeredCache.ts`,
+  `src/HttpClient/middlewares/cache.ts`, `src/HttpClient/middlewares/request/index.ts`,
+  `src/HttpClient/middlewares/request/setupAxios/interceptors/tracing/spanSetup.ts`,
+  `src/service/logger/client.ts`, `src/service/logger/logger.ts`,
+  `src/service/telemetry/client.ts`,
+  `src/service/worker/runtime/graphql/schema/schemaDirectives/Auth.ts`,
+  `src/tracing/utils.test.ts` and `src/utils/buildFullPath.ts` (semicolon usage,
+  member ordering, `==` vs `===`, unsorted object keys, import ordering, and
+  other `tslint-config-vtex` rule failures) that were blocking the CI lint gate
+  on unrelated PRs against the 6.x line.
 
 ## [6.51.0] - 2026-06-23
 ### Added

package/lib/HttpClient/middlewares/cache.js

@@ -73,7 +73,7 @@ const cacheMiddleware = ({ type, storage, asyncSet }) => {
             ["key-with-segment" /* HttpCacheLogFields.KEY_WITH_SEGMENT */]: keyWithSegment,
         });
         const cacheReadSpan = createCacheSpan(cacheType, 'read', tracer, span);
-        let cached = undefined;
+        let cached;
         try {
             const cacheHasWithSegment = await storage.has(keyWithSegment);
             cached = cacheHasWithSegment ? await storage.get(keyWithSegment) : await storage.get(key);
@@ -114,7 +114,7 @@ const cacheMiddleware = ({ type, storage, asyncSet }) => {
             if (cachedEtag && validateStatus(response.status)) {
                 ctx.config.headers = {
                     ...ctx.config.headers,
-                    'if-none-match': cachedEtag
+                    'if-none-match': cachedEtag,
                 };
                 ctx.config.validateStatus = validateStatus;
             }

package/lib/HttpClient/middlewares/request/index.js

@@ -4,9 +4,9 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.requestMiddleware = exports.routerCacheMiddleware = exports.defaultsMiddleware = void 0;
-const buildFullPath_1 = __importDefault(require("../../../utils/buildFullPath"));
 const qs_1 = require("qs");
 const ramda_1 = require("ramda");
+const buildFullPath_1 = __importDefault(require("../../../utils/buildFullPath"));
 const Tags_1 = require("../../../tracing/Tags");
 const renameBy_1 = require("../../../utils/renameBy");
 const setupAxios_1 = require("./setupAxios");

package/lib/HttpClient/middlewares/request/setupAxios/interceptors/tracing/spanSetup.js

@@ -4,10 +4,10 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.injectResponseInfoOnSpan = exports.injectRequestInfoOnSpan = void 0;
-const buildFullPath_1 = __importDefault(require("../../../../../../utils/buildFullPath"));
 const constants_1 = require("../../../../../../constants");
 const Tags_1 = require("../../../../../../tracing/Tags");
 const utils_1 = require("../../../../../../tracing/utils");
+const buildFullPath_1 = __importDefault(require("../../../../../../utils/buildFullPath"));
 const injectRequestInfoOnSpan = (span, http, config) => {
     span === null || span === void 0 ? void 0 : span.addTags({
         [Tags_1.OpentracingTags.SPAN_KIND]: Tags_1.OpentracingTags.SPAN_KIND_RPC_CLIENT,

package/lib/caches/MultilayeredCache.js

@@ -8,7 +8,7 @@ class MultilayeredCache {
         this.hits = 0;
         this.total = 0;
         this.get = async (key, fetcher) => {
-            let value = undefined;
+            let value;
             let maxAge;
             let successIndex = await this.findIndex(async (cache) => {
                 const [getValue, hasKey] = await Promise.all([cache.get(key), cache.has(key)]);

package/lib/service/logger/client.js

@@ -5,7 +5,7 @@ const diagnostics_nodejs_1 = require("@vtex/diagnostics-nodejs");
 const telemetry_1 = require("../telemetry");
 let logClient;
 let isInitializing = false;
-let initPromise = undefined;
+let initPromise;
 async function getLogClient(account, workspace, appName) {
     if (logClient) {
         return logClient;
@@ -23,11 +23,11 @@ async function initializeClient(account, workspace, appName) {
         const telemetryClient = await (0, telemetry_1.getTelemetryClient)();
         const logsConfig = diagnostics_nodejs_1.Exporters.CreateLogsExporterConfig({
             endpoint: process.env.OTEL_EXPORTER_OTLP_ENDPOINT,
+            headers: { 'Content-Type': 'application/json' },
+            interval: 5,
             path: process.env.OTEL_EXPORTER_OTLP_PATH || '/v1/logs',
             protocol: 'http',
-            interval: 5,
             timeoutSeconds: 5,
-            headers: { 'Content-Type': 'application/json' },
         });
         const logsExporter = diagnostics_nodejs_1.Exporters.CreateExporter(logsConfig, 'otlp');
         await logsExporter.initialize();

package/lib/service/logger/logger.d.ts

@@ -9,10 +9,10 @@ export declare class Logger {
     private logClient;
     private clientInitPromise;
     constructor(ctx: LoggerContext);
-    private initLogClient;
     debug: (message: any) => void;
     info: (message: any) => void;
     warn: (warning: any) => void;
     error: (error: any) => void;
     log: (message: any, level: LogLevel) => void;
+    private initLogClient;
 }

package/lib/service/logger/logger.js

@@ -4,8 +4,8 @@ exports.Logger = void 0;
 const constants_1 = require("../../constants");
 const error_1 = require("../../utils/error");
 const log_1 = require("../../utils/log");
-const loggerTypes_1 = require("./loggerTypes");
 const client_1 = require("./client");
+const loggerTypes_1 = require("./loggerTypes");
 const app = constants_1.APP.ID;
 const EMPTY_MESSAGE = 'Logger.log was called with null or undefined message';
 class Logger {
@@ -42,7 +42,7 @@ class Logger {
             }
             if (this.logClient) {
                 try {
-                    let logMessage = typeof data === 'string' ? data : JSON.stringify(data);
+                    const logMessage = typeof data === 'string' ? data : JSON.stringify(data);
                     switch (level) {
                         case loggerTypes_1.LogLevel.Debug:
                             this.logClient.debug(logMessage, inflatedLog);
@@ -90,7 +90,7 @@ class Logger {
                 });
                 this.logClient = await Promise.race([
                     (0, client_1.getLogClient)(this.account, this.workspace, constants_1.APP.NAME),
-                    timeoutPromise
+                    timeoutPromise,
                 ]);
                 return this.logClient;
             }

package/lib/service/master.d.ts

@@ -1,4 +1,2 @@
-import { Worker } from 'cluster';
 import { ServiceJSON } from './worker/runtime/typings';
-export declare const onMessage: (worker: Worker, message: any) => void;
 export declare const startMaster: (service: ServiceJSON) => void;

package/lib/service/master.js

@@ -3,12 +3,11 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.startMaster = exports.onMessage = void 0;
+exports.startMaster = void 0;
 const cluster_1 = __importDefault(require("cluster"));
 const os_1 = require("os");
 const constants_1 = require("../constants");
 const logger_1 = require("./logger");
-const clusterMetricsAggregator_1 = require("./metrics/clusterMetricsAggregator");
 const listeners_1 = require("./worker/listeners");
 const statusTrack_1 = require("./worker/runtime/statusTrack");
 let handledSignal;
@@ -20,12 +19,7 @@ const onMessage = (worker, message) => {
         (0, statusTrack_1.trackStatus)();
         (0, statusTrack_1.broadcastStatusTrack)();
     }
-    else if ((0, clusterMetricsAggregator_1.isAggMetricsRequest)(message)) {
-        (0, clusterMetricsAggregator_1.handleWorkerMetricsRequest)(worker, message);
-    }
-    else if (!(0, clusterMetricsAggregator_1.isPromClientMessage)(message)) {
-        // prom-client's own cluster messages are handled by its cluster listener;
-        // anything else that reaches here is genuinely unexpected.
+    else {
         listeners_1.logger.warn({
             content: message,
             message: 'Worker sent message',
@@ -33,7 +27,6 @@ const onMessage = (worker, message) => {
         });
     }
 };
-exports.onMessage = onMessage;
 const onExit = (worker, code, signal) => {
     if (!constants_1.LINKED && worker.exitedAfterDisconnect === false) {
         listeners_1.logger.error({
@@ -77,11 +70,6 @@ const startMaster = (service) => {
     if (service.deterministicVary) {
         process.env.DETERMINISTIC_VARY = 'true';
     }
-    // Set up the master-side Prometheus aggregator so workers can request a
-    // merged, monotonic /metrics view across the whole cluster over IPC.
-    if (numWorkers > 1) {
-        (0, clusterMetricsAggregator_1.initMasterAggregatorRegistry)();
-    }
     // Setup dubugger
     if (constants_1.LINKED) {
         cluster_1.default.setupMaster({ inspectPort: constants_1.INSPECT_DEBUGGER_PORT });
@@ -94,7 +82,7 @@ const startMaster = (service) => {
     }
     cluster_1.default.on('online', onOnline);
     cluster_1.default.on('exit', onExit);
-    cluster_1.default.on('message', exports.onMessage);
+    cluster_1.default.on('message', onMessage);
     process.on('SIGINT', handleSignal(SIGINT_TIMEOUT_S));
     process.on('SIGTERM', handleSignal(shutdownTimeout));
 };

package/lib/service/metrics/requestMetricsMiddleware.js

@@ -4,7 +4,6 @@ exports.addRequestMetricsMiddleware = void 0;
 const stream_1 = require("stream");
 const utils_1 = require("../../utils");
 const instruments_1 = require("../tracing/metrics/instruments");
-const requestHandlerLabel_1 = require("./requestHandlerLabel");
 const addRequestMetricsMiddleware = () => {
     const concurrentRequests = (0, instruments_1.createConcurrentRequestsInstrument)();
     const requestTimings = (0, instruments_1.createRequestsTimingsInstrument)();
@@ -14,7 +13,7 @@ const addRequestMetricsMiddleware = () => {
     return async function addRequestMetrics(ctx, next) {
         const start = process.hrtime();
         concurrentRequests.inc(1);
-        ctx.req.once('aborted', () => abortedRequests.inc({ ["handler" /* RequestsMetricLabels.REQUEST_HANDLER */]: (0, requestHandlerLabel_1.requestHandlerLabel)(ctx.requestHandlerName) }, 1));
+        ctx.req.once('aborted', () => abortedRequests.inc({ ["handler" /* RequestsMetricLabels.REQUEST_HANDLER */]: ctx.requestHandlerName }, 1));
         let responseClosed = false;
         ctx.res.once('close', () => (responseClosed = true));
         try {
@@ -23,15 +22,15 @@ const addRequestMetricsMiddleware = () => {
         finally {
             const responseLength = ctx.response.length;
             if (responseLength) {
-                responseSizes.observe({ ["handler" /* RequestsMetricLabels.REQUEST_HANDLER */]: (0, requestHandlerLabel_1.requestHandlerLabel)(ctx.requestHandlerName) }, responseLength);
+                responseSizes.observe({ ["handler" /* RequestsMetricLabels.REQUEST_HANDLER */]: ctx.requestHandlerName }, responseLength);
             }
             totalRequests.inc({
-                ["handler" /* RequestsMetricLabels.REQUEST_HANDLER */]: (0, requestHandlerLabel_1.requestHandlerLabel)(ctx.requestHandlerName),
+                ["handler" /* RequestsMetricLabels.REQUEST_HANDLER */]: ctx.requestHandlerName,
                 ["status_code" /* RequestsMetricLabels.STATUS_CODE */]: ctx.response.status,
             }, 1);
             const onResFinished = () => {
                 requestTimings.observe({
-                    ["handler" /* RequestsMetricLabels.REQUEST_HANDLER */]: (0, requestHandlerLabel_1.requestHandlerLabel)(ctx.requestHandlerName),
+                    ["handler" /* RequestsMetricLabels.REQUEST_HANDLER */]: ctx.requestHandlerName,
                 }, (0, utils_1.hrToMillisFloat)(process.hrtime(start)));
                 concurrentRequests.dec(1);
             };

package/lib/service/telemetry/client.js

@@ -4,21 +4,35 @@ exports.resetTelemetryClient = exports.getTelemetryClient = void 0;
 const diagnostics_nodejs_1 = require("@vtex/diagnostics-nodejs");
 const constants_1 = require("../../constants");
 class TelemetryClientSingleton {
-    constructor() {
-        this.initializationPromise = undefined;
-    }
     static getInstance() {
         if (!TelemetryClientSingleton.instance) {
             TelemetryClientSingleton.instance = new TelemetryClientSingleton();
         }
         return TelemetryClientSingleton.instance;
     }
+    constructor() {
+        this.initializationPromise = undefined;
+    }
+    async getClient() {
+        if (this.telemetryClient) {
+            return this.telemetryClient;
+        }
+        if (this.initializationPromise) {
+            return this.initializationPromise;
+        }
+        this.initializationPromise = this.initTelemetryClient();
+        return this.initializationPromise;
+    }
+    reset() {
+        this.telemetryClient = undefined;
+        this.initializationPromise = undefined;
+    }
     async initTelemetryClient() {
         try {
             const telemetryClient = await (0, diagnostics_nodejs_1.NewTelemetryClient)('node-vtex-api', constants_1.APP.ID || 'vtex-app', {
                 additionalAttrs: {
-                    'version': constants_1.APP.VERSION || '',
                     'environment': process.env.VTEX_WORKSPACE || 'development',
+                    'version': constants_1.APP.VERSION || '',
                 },
             });
             this.telemetryClient = telemetryClient;
@@ -32,20 +46,6 @@ class TelemetryClientSingleton {
             this.initializationPromise = undefined;
         }
     }
-    async getClient() {
-        if (this.telemetryClient) {
-            return this.telemetryClient;
-        }
-        if (this.initializationPromise) {
-            return this.initializationPromise;
-        }
-        this.initializationPromise = this.initTelemetryClient();
-        return this.initializationPromise;
-    }
-    reset() {
-        this.telemetryClient = undefined;
-        this.initializationPromise = undefined;
-    }
 }
 async function getTelemetryClient() {
     return TelemetryClientSingleton.getInstance().getClient();

package/lib/service/worker/index.d.ts

@@ -1,7 +1,6 @@
 import Koa from 'koa';
 import { MetricsAccumulator } from '../../metrics/MetricsAccumulator';
 import { ServiceJSON } from './runtime/typings';
-export declare const onMessage: (service: ServiceJSON) => (message: any) => void;
 export declare const startWorker: (serviceJSON: ServiceJSON) => Koa<Koa.DefaultState, Koa.DefaultContext>;
 declare global {
     namespace NodeJS {

package/lib/service/worker/index.js

@@ -3,7 +3,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.startWorker = exports.onMessage = void 0;
+exports.startWorker = void 0;
 const http_1 = require("http");
 const koa_1 = __importDefault(require("koa"));
 const koa_compress_1 = __importDefault(require("koa-compress"));
@@ -14,7 +14,6 @@ const MetricsAccumulator_1 = require("../../metrics/MetricsAccumulator");
 const loaders_1 = require("../loaders");
 const console_1 = require("../logger/console");
 const loggerTypes_1 = require("../logger/loggerTypes");
-const clusterMetricsAggregator_1 = require("../metrics/clusterMetricsAggregator");
 const requestMetricsMiddleware_1 = require("../metrics/requestMetricsMiddleware");
 const TracerSingleton_1 = require("../tracing/TracerSingleton");
 const tracingMiddlewares_1 = require("../tracing/tracingMiddlewares");
@@ -27,6 +26,7 @@ const graphql_1 = require("./runtime/graphql");
 const http_2 = require("./runtime/http");
 const error_1 = require("./runtime/http/middlewares/error");
 const rateLimit_1 = require("./runtime/http/middlewares/rateLimit");
+const sanitizeResponse_1 = require("./runtime/http/middlewares/sanitizeResponse");
 const router_2 = require("./runtime/http/router");
 const routes_1 = require("./runtime/http/routes");
 const statusTrack_1 = require("./runtime/statusTrack");
@@ -55,12 +55,7 @@ const onMessage = (service) => (message) => {
     else if ((0, statusTrack_1.isStatusTrack)(message)) {
         (0, statusTrack_1.trackStatus)();
     }
-    else if ((0, clusterMetricsAggregator_1.isAggMetricsResponse)(message)) {
-        (0, clusterMetricsAggregator_1.handleMasterMetricsResponse)(message);
-    }
-    else if (!(0, clusterMetricsAggregator_1.isPromClientMessage)(message)) {
-        // prom-client's own cluster messages are handled by its worker listener;
-        // anything else that reaches here is genuinely unexpected.
+    else {
         listeners_1.logger.warn({
             content: message,
             message: 'Master sent message',
@@ -68,7 +63,6 @@ const onMessage = (service) => (message) => {
         });
     }
 };
-exports.onMessage = onMessage;
 const createAppHttpHandlers = ({ config: { routes, clients } }, serviceJSON, globalLimiter) => {
     if (routes && clients) {
         return Object.keys(routes).reduce((acc, routeId) => {
@@ -160,22 +154,18 @@ const startWorker = (serviceJSON) => {
     var _a, _b;
     (0, listeners_1.addProcessListeners)();
     const tracer = TracerSingleton_1.TracerSingleton.getTracer();
-    // In multi-worker mode install prom-client's worker-side cluster responder so
-    // the master can collect this worker's registry for the aggregated /metrics.
-    if (serviceJSON.workers > 1) {
-        (0, clusterMetricsAggregator_1.ensureWorkerAggregatorRegistry)();
-    }
     const app = new koa_1.default();
     app.proxy = true;
     app
         .use(error_1.error)
-        .use((0, middlewares_1.prometheusLoggerMiddleware)(serviceJSON.workers))
+        .use((0, middlewares_1.prometheusLoggerMiddleware)())
         .use((0, tracingMiddlewares_1.addTracingMiddleware)(tracer))
         .use((0, requestMetricsMiddleware_1.addRequestMetricsMiddleware)())
         .use((0, middlewares_1.addMetricsLoggerMiddleware)())
         .use((0, rateLimit_1.concurrentRateLimiter)((_a = serviceJSON === null || serviceJSON === void 0 ? void 0 : serviceJSON.rateLimitPerReplica) === null || _a === void 0 ? void 0 : _a.concurrent))
         .use((0, koa_compress_1.default)())
-        .use(middlewares_1.recorderMiddleware);
+        .use(middlewares_1.recorderMiddleware)
+        .use(sanitizeResponse_1.sanitizeResponse);
     const service = (0, loaders_1.getService)();
     const { config: { clients } } = service;
     if (clients) {
@@ -202,7 +192,7 @@ const startWorker = (serviceJSON) => {
         const privateHandlersRouter = routerFromPrivateHttpHandlers(httpHandlers.pvt);
         app.use(privateHandlersRouter.routes());
     }
-    process.on('message', (0, exports.onMessage)(serviceJSON));
+    process.on('message', onMessage(serviceJSON));
     return app;
 };
 exports.startWorker = startWorker;

package/lib/service/worker/listeners.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.addProcessListeners = exports.logger = void 0;
 const os_1 = require("os");
 const RequestCancelledError_1 = require("../../errors/RequestCancelledError");
+const responseSanitizer_1 = require("../../utils/responseSanitizer");
 const logger_1 = require("../logger");
 exports.logger = new logger_1.Logger({ account: 'unhandled', workspace: 'unhandled', requestId: 'unhandled', operationId: 'unhandled', production: process.env.VTEX_PRODUCTION === 'true' });
 let watched;
@@ -15,18 +16,19 @@ const addProcessListeners = () => {
         return;
     }
     watched = process.on('uncaughtException', (err) => {
-        console.error('uncaughtException', err);
+        console.error('uncaughtException', (0, responseSanitizer_1.toLoggableError)(err));
         if (err && exports.logger) {
             err.type = 'uncaughtException';
             exports.logger.error(err);
         }
         process.exit(420);
     });
-    process.on('unhandledRejection', (reason, promise) => {
+    process.on('unhandledRejection', (reason) => {
         if (reason instanceof RequestCancelledError_1.RequestCancelledError) {
             return;
         }
-        console.error('unhandledRejection', reason, promise);
+        // The promise is not printed: inspecting it shows the rejection reason again, unsanitized.
+        console.error('unhandledRejection', (0, responseSanitizer_1.toLoggableError)(reason));
         if (reason && exports.logger) {
             reason.type = 'unhandledRejection';
             exports.logger.error(reason);

package/lib/service/worker/runtime/builtIn/middlewares.d.ts

@@ -1,4 +1,4 @@
 import { ServiceContext } from '../typings';
 export declare function recorderMiddleware(ctx: ServiceContext, next: () => Promise<void>): Promise<void>;
 export declare const addMetricsLoggerMiddleware: () => (ctx: ServiceContext, next: () => Promise<void>) => Promise<void>;
-export declare const prometheusLoggerMiddleware: (workers?: number) => (ctx: ServiceContext, next: () => Promise<void>) => Promise<void>;
+export declare const prometheusLoggerMiddleware: () => (ctx: ServiceContext, next: () => Promise<void>) => Promise<void>;

package/lib/service/worker/runtime/builtIn/middlewares.js

@@ -4,7 +4,6 @@ exports.prometheusLoggerMiddleware = exports.addMetricsLoggerMiddleware = export
 const prom_client_1 = require("prom-client");
 const constants_1 = require("../../../../constants");
 const metricsLogger_1 = require("../../../logger/metricsLogger");
-const clusterMetricsAggregator_1 = require("../../../metrics/clusterMetricsAggregator");
 const EventLoopLagMeasurer_1 = require("../../../tracing/metrics/measurers/EventLoopLagMeasurer");
 const recorder_1 = require("../utils/recorder");
 async function recorderMiddleware(ctx, next) {
@@ -23,14 +22,10 @@ const addMetricsLoggerMiddleware = () => {
     };
 };
 exports.addMetricsLoggerMiddleware = addMetricsLoggerMiddleware;
-const prometheusLoggerMiddleware = (workers = 1) => {
+const prometheusLoggerMiddleware = () => {
     (0, prom_client_1.collectDefaultMetrics)();
     const eventLoopLagMeasurer = new EventLoopLagMeasurer_1.EventLoopLagMeasurer();
     eventLoopLagMeasurer.start();
-    // In multi-worker mode each worker holds only its own registry, so /metrics
-    // must serve the cluster-wide aggregate requested from the master over IPC.
-    // In single-worker mode (LINKED / workers:1) the local registry is complete.
-    const isMultiWorker = workers > 1;
     return async (ctx, next) => {
         if (ctx.request.path !== '/metrics') {
             return next();
@@ -41,7 +36,7 @@ const prometheusLoggerMiddleware = (workers = 1) => {
         }
         await eventLoopLagMeasurer.updateInstrumentsAndReset();
         ctx.set('Content-Type', prom_client_1.register.contentType);
-        ctx.body = isMultiWorker ? await (0, clusterMetricsAggregator_1.requestAggregatedMetrics)() : await prom_client_1.register.metrics();
+        ctx.body = await prom_client_1.register.metrics();
         ctx.status = 200;
     };
 };

package/lib/service/worker/runtime/graphql/middlewares/error.js

@@ -36,8 +36,14 @@ const createLogErrorToSplunk = (vtex) => (err) => {
         logger.log(log, level);
     }
     finally {
-        if (!constants_1.LINKED && ((_f = (_e = err === null || err === void 0 ? void 0 : err.extensions) === null || _e === void 0 ? void 0 : _e.exception) === null || _f === void 0 ? void 0 : _f.sensitive)) {
-            delete err.extensions.exception.sensitive;
+        if (!constants_1.LINKED) {
+            // Already logged above. The response must not carry them.
+            if ((_f = (_e = err === null || err === void 0 ? void 0 : err.extensions) === null || _e === void 0 ? void 0 : _e.exception) === null || _f === void 0 ? void 0 : _f.sensitive) {
+                delete err.extensions.exception.sensitive;
+            }
+            if (err) {
+                delete err.stack;
+            }
         }
     }
 };

package/lib/service/worker/runtime/graphql/schema/schemaDirectives/Auth.js

@@ -50,7 +50,7 @@ async function auth(ctx, authArgs) {
     }
 }
 function parseArgs(authArgs) {
-    if (authArgs.scope == 'PUBLIC') {
+    if (authArgs.scope === 'PUBLIC') {
         return authArgs;
     }
     if (!authArgs.productCode || !authArgs.resourceCode) {
@@ -63,7 +63,7 @@ class Auth extends graphql_tools_1.SchemaDirectiveVisitor {
         const { resolve = graphql_1.defaultFieldResolver } = field;
         field.resolve = async (root, args, ctx, info) => {
             const authArgs = parseArgs(this.args);
-            if (!authArgs.scope || authArgs.scope == 'PRIVATE') {
+            if (!authArgs.scope || authArgs.scope === 'PRIVATE') {
                 await auth(ctx, authArgs);
             }
             return resolve(root, args, ctx, info);

package/lib/service/worker/runtime/http/middlewares/error.js

@@ -5,7 +5,9 @@ const constants_1 = require("../../../../../constants");
 const RequestCancelledError_1 = require("../../../../../errors/RequestCancelledError");
 const TooManyRequestsError_1 = require("../../../../../errors/TooManyRequestsError");
 const error_1 = require("../../../../../utils/error");
+const responseSanitizer_1 = require("../../../../../utils/responseSanitizer");
 const logger_1 = require("../../../../logger");
+const sanitizeResponse_1 = require("./sanitizeResponse");
 const CACHE_CONTROL_HEADER = 'cache-control';
 const META_HEADER = 'x-vtex-meta';
 const ETAG_HEADER = 'etag';
@@ -45,6 +47,19 @@ const logAndRemoveSensitiveData = (ctx, err) => {
         });
     }
 };
+// What is sent to the client for a thrown value. It is built with the sanitizer that covers the
+// bodies the app sets, so both paths expose the same: `cleanError` alone removes credentials only
+// at the top level, and by a short list of header names, so an error that is a property of the
+// thrown value (`originalError`) kept its config, request and stack.
+const buildResponseBody = (thrown) => {
+    try {
+        return (0, error_1.cleanError)((0, responseSanitizer_1.sanitizeErrors)(thrown, { linked: constants_1.LINKED }).value);
+    }
+    catch (sanitizeError) {
+        console.error('[node-vtex-api error] the thrown value could not be sanitized', sanitizeError === null || sanitizeError === void 0 ? void 0 : sanitizeError.name);
+        return sanitizeResponse_1.WITHHELD_BODY;
+    }
+};
 async function error(ctx, next) {
     var _a;
     try {
@@ -59,7 +74,8 @@ async function error(ctx, next) {
             ctx.status = TooManyRequestsError_1.tooManyRequestsStatus;
             return;
         }
-        console.error('[node-vtex-api error]', e);
+        // The raw error carries the request config, whose headers include credentials.
+        console.error('[node-vtex-api error]', (0, responseSanitizer_1.toLoggableError)(e));
         const err = (0, error_1.cleanError)(e);
         // Add response
         ctx.status = (e === null || e === void 0 ? void 0 : e.status) && e.status >= 400 && e.status <= 599
@@ -78,8 +94,10 @@ async function error(ctx, next) {
         else {
             ctx.set(CACHE_CONTROL_HEADER, `no-cache, no-store`);
         }
+        // `err` is what is logged, which keeps the config and the request to debug with. It is not the
+        // body: the sanitized value is.
         logAndRemoveSensitiveData(ctx, err);
-        ctx.body = ctx.body || err;
+        ctx.body = ctx.body || buildResponseBody(e);
     }
 }
 exports.error = error;