@vscode/gulp-electron 1.36.0 → 1.37.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (5) hide show
  1. package/azure-pipelines.yml +3 -3
  2. package/package.json +4 -4
  3. package/src/download.js +2 -2
  4. package/src/index.js +2 -0
  5. package/src/win32.js +5 -5
package/azure-pipelines.yml CHANGED
@@ -29,11 +29,11 @@ extends:
29
29
  - script: npm ci
30
30
  testPlatforms:
31
31
  - name: Linux
32
- nodeVersions: [14.x, 16.x, 17.x]
32
+ nodeVersions: [22.x, 24.x]
33
33
  - name: MacOS
34
- nodeVersions: [14.x, 16.x, 17.x]
34
+ nodeVersions: [22.x, 24.x]
35
35
  - name: Windows
36
- nodeVersions: [14.x, 16.x, 17.x]
36
+ nodeVersions: [22.x, 24.x]
37
37
  testSteps:
38
38
  - script: npm ci
39
39
  - script: npm test
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@vscode/gulp-electron",
3
- "version": "1.36.0",
3
+ "version": "1.37.0",
4
4
  "description": "gulp plugin for packaging Electron into VS Code",
5
5
  "main": "src/index.js",
6
6
  "scripts": {
@@ -28,7 +28,7 @@
28
28
  },
29
29
  "homepage": "https://github.com/microsoft/vscode-gulp-electron",
30
30
  "dependencies": {
31
- "@electron/get": "^2.0.2",
31
+ "@electron/get": "^4.0.1",
32
32
  "@octokit/rest": "^18.0.14",
33
33
  "event-stream": "3.3.4",
34
34
  "gulp-filter": "^5.1.0",
@@ -38,9 +38,9 @@
38
38
  "mkdirp": "^0.5.1",
39
39
  "plist": "^3.0.1",
40
40
  "progress": "^1.1.8",
41
- "rcedit": "^0.3.0",
41
+ "rcedit": "^4.0.1",
42
42
  "rimraf": "^2.4.2",
43
- "semver": "^4.3.4",
43
+ "semver": "^7.7.2",
44
44
  "sumchecker": "^3.0.1",
45
45
  "temp": "^0.8.3",
46
46
  "vinyl": "^3.0.0",
package/src/download.js CHANGED
@@ -88,10 +88,10 @@ async function download(opts) {
88
88
  arch = "x64";
89
89
  break;
90
90
  case "win32":
91
- arch = "ia32";
91
+ arch = "x64";
92
92
  break;
93
93
  case "linux":
94
- arch = "ia32";
94
+ arch = "x64";
95
95
  break;
96
96
  }
97
97
  }
package/src/index.js CHANGED
@@ -96,6 +96,8 @@ function electron(opts) {
96
96
  }
97
97
  }
98
98
 
99
+ opts.arch = opts.arch || process.arch;
100
+
99
101
  return _electron(opts);
100
102
  }
101
103
 
package/src/win32.js CHANGED
@@ -93,11 +93,7 @@ function patchExecutable(opts) {
93
93
  return cb(error);
94
94
  }
95
95
 
96
- rcedit(tempPath, patch, function (err) {
97
- if (err) {
98
- return cb(err);
99
- }
100
-
96
+ rcedit(tempPath, patch).then(() => {
101
97
  fs.readFile(tempPath, function (err, data) {
102
98
  if (err) {
103
99
  return cb(err);
@@ -113,6 +109,10 @@ function patchExecutable(opts) {
113
109
  cb(null, f);
114
110
  });
115
111
  });
112
+ }).catch(err => {
113
+ if (err) {
114
+ return cb(err);
115
+ }
116
116
  });
117
117
  });
118
118
  });