@vscode/gulp-electron 1.35.0 → 1.37.0

package/SECURITY.md

@@ -0,0 +1,41 @@
+<!-- BEGIN MICROSOFT SECURITY.MD V0.0.8 BLOCK -->
+
+## Security
+
+Microsoft takes the security of our software products and services seriously, which includes all source code repositories managed through our GitHub organizations, which include [Microsoft](https://github.com/microsoft), [Azure](https://github.com/Azure), [DotNet](https://github.com/dotnet), [AspNet](https://github.com/aspnet), [Xamarin](https://github.com/xamarin), and [our GitHub organizations](https://opensource.microsoft.com/).
+
+If you believe you have found a security vulnerability in any Microsoft-owned repository that meets [Microsoft's definition of a security vulnerability](https://aka.ms/opensource/security/definition), please report it to us as described below.
+
+## Reporting Security Issues
+
+**Please do not report security vulnerabilities through public GitHub issues.**
+
+Instead, please report them to the Microsoft Security Response Center (MSRC) at [https://msrc.microsoft.com/create-report](https://aka.ms/opensource/security/create-report).
+
+If you prefer to submit without logging in, send email to [secure@microsoft.com](mailto:secure@microsoft.com).  If possible, encrypt your message with our PGP key; please download it from the [Microsoft Security Response Center PGP Key page](https://aka.ms/opensource/security/pgpkey).
+
+You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Additional information can be found at [microsoft.com/msrc](https://aka.ms/opensource/security/msrc). 
+
+Please include the requested information listed below (as much as you can provide) to help us better understand the nature and scope of the possible issue:
+
+  * Type of issue (e.g. buffer overflow, SQL injection, cross-site scripting, etc.)
+  * Full paths of source file(s) related to the manifestation of the issue
+  * The location of the affected source code (tag/branch/commit or direct URL)
+  * Any special configuration required to reproduce the issue
+  * Step-by-step instructions to reproduce the issue
+  * Proof-of-concept or exploit code (if possible)
+  * Impact of the issue, including how an attacker might exploit the issue
+
+This information will help us triage your report more quickly.
+
+If you are reporting for a bug bounty, more complete reports can contribute to a higher bounty award. Please visit our [Microsoft Bug Bounty Program](https://aka.ms/opensource/security/bounty) page for more details about our active programs.
+
+## Preferred Languages
+
+We prefer all communications to be in English.
+
+## Policy
+
+Microsoft follows the principle of [Coordinated Vulnerability Disclosure](https://aka.ms/opensource/security/cvd).
+
+<!-- END MICROSOFT SECURITY.MD BLOCK -->

package/azure-pipelines.yml

@@ -29,11 +29,11 @@ extends:
           - script: npm ci
         testPlatforms:
           - name: Linux
-            nodeVersions: [14.x, 16.x, 17.x]
+            nodeVersions: [22.x, 24.x]
           - name: MacOS
-            nodeVersions: [14.x, 16.x, 17.x]
+            nodeVersions: [22.x, 24.x]
           - name: Windows
-            nodeVersions: [14.x, 16.x, 17.x]
+            nodeVersions: [22.x, 24.x]
         testSteps:
           - script: npm ci
           - script: npm test

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vscode/gulp-electron",
-  "version": "1.35.0",
+  "version": "1.37.0",
   "description": "gulp plugin for packaging Electron into VS Code",
   "main": "src/index.js",
   "scripts": {
@@ -28,7 +28,7 @@
   },
   "homepage": "https://github.com/microsoft/vscode-gulp-electron",
   "dependencies": {
-    "@electron/get": "^2.0.2",
+    "@electron/get": "^4.0.1",
     "@octokit/rest": "^18.0.14",
     "event-stream": "3.3.4",
     "gulp-filter": "^5.1.0",
@@ -38,9 +38,10 @@
     "mkdirp": "^0.5.1",
     "plist": "^3.0.1",
     "progress": "^1.1.8",
-    "rcedit": "^0.3.0",
+    "rcedit": "^4.0.1",
     "rimraf": "^2.4.2",
-    "semver": "^4.3.4",
+    "semver": "^7.7.2",
+    "sumchecker": "^3.0.1",
     "temp": "^0.8.3",
     "vinyl": "^3.0.0",
     "vinyl-fs": "^3.0.3"

package/src/download.js

@@ -9,6 +9,7 @@ var zfs = require("gulp-vinyl-zip");
 var filter = require("gulp-filter");
 const { Octokit } = require("@octokit/rest");
 const got = require("got");
+const sumchecker = require('sumchecker');
 
 async function getDownloadUrl(
   ownerRepo, customTag,
@@ -87,10 +88,10 @@ async function download(opts) {
         arch = "x64";
         break;
       case "win32":
-        arch = "ia32";
+        arch = "x64";
         break;
       case "linux":
-        arch = "ia32";
+        arch = "x64";
         break;
     }
   }
@@ -139,7 +140,16 @@ async function download(opts) {
 function downloadStream(opts) {
   return es.readable(function (_, cb) {
     download(opts).then(
-      (assets) => {
+      async (assets) => {
+        if (opts.validateChecksum) {
+          try {
+            await sumchecker('sha256', opts.checksumFile, path.dirname(assets), [
+              path.basename(assets),
+            ]);
+          } catch (err) {
+            return cb(err);
+          }
+        }
         zfs
           .src(assets)
           .on("data", (data) => this.emit("data", data))
@@ -166,16 +176,9 @@ function getDarwinLibFFMpegPath(opts) {
 
 module.exports = function (opts) {
   const downloadOpts = {
-    version: opts.version,
-    tag: opts.tag,
-    platform: opts.platform,
+    ...opts,
     arch: opts.arch === "arm" ? "armv7l" : opts.arch,
     artifactName: "electron",
-    token: opts.token,
-    quiet: opts.quiet,
-    repo: opts.repo,
-    symbols: opts.symbols,
-    pdbs: opts.pdbs,
   };
 
   if (opts.symbols) {

package/src/index.js

@@ -88,6 +88,16 @@ function electron(opts) {
     );
   }
 
+  if (opts.validateChecksum) {
+    try {
+      fs.openSync(opts.checksumFile, fs.constants.R_OK);
+    } catch (err) {
+      throw new Error(`Unable to read checksum file: ${opts.checksumFile}`);
+    }
+  }
+
+  opts.arch = opts.arch || process.arch;
+
   return _electron(opts);
 }
 

package/src/win32.js

@@ -93,11 +93,7 @@ function patchExecutable(opts) {
         return cb(error);
       }
 
-      rcedit(tempPath, patch, function (err) {
-        if (err) {
-          return cb(err);
-        }
-
+      rcedit(tempPath, patch).then(() => {
         fs.readFile(tempPath, function (err, data) {
           if (err) {
             return cb(err);
@@ -113,6 +109,10 @@ function patchExecutable(opts) {
             cb(null, f);
           });
         });
+      }).catch(err => {
+        if (err) {
+          return cb(err);
+        }
       });
     });
   });