@vruum/skills 0.6.1 → 0.6.2

package/install.js

@@ -191,6 +191,59 @@ function syncVruumRoot({ dryRun }) {
   return rows;
 }
 
+// A symlink is "ours" if its target resolves into ~/.vruum/skills/. Resolve
+// textually from the readlink string (relative links against the link's own
+// dir) — never realpathSync, which THROWS on a dangling link, i.e. exactly the
+// renamed/removed-skill bug case we need to prune. The trailing path.sep
+// boundary matters: ~/.vruum/skills is a string prefix of
+// ~/.vruum/skills-operator, so a bare startsWith would wrongly claim the
+// operator installer's links. Equality covers a link straight at the dir.
+function isOurLink(dst, linkTarget) {
+  const resolved = path.isAbsolute(linkTarget)
+    ? path.resolve(linkTarget)
+    : path.resolve(path.dirname(dst), linkTarget);
+  return resolved === VRUUM_SKILLS || resolved.startsWith(VRUUM_SKILLS + path.sep);
+}
+
+// Prune pass — after relinking current skills, remove links for skills no
+// longer in the package (renamed or deleted), but ONLY symlinks this installer
+// owns (target under ~/.vruum/skills/). Non-symlinks (real user dirs/files) and
+// foreign symlinks (the operator installer's links, arbitrary user links) are
+// never touched, so the two npm installers + the bash setup coexist in the same
+// harness dir without pruning each other.
+function pruneStaleLinks({ target, skills, dryRun }) {
+  const results = [];
+  let entries;
+  try {
+    entries = fs.readdirSync(target);
+  } catch (err) {
+    if (err.code === 'ENOENT') return results;
+    throw err;
+  }
+  const current = new Set(skills);
+  for (const entry of entries) {
+    if (current.has(entry)) continue; // current skill — keep
+    const dst = path.join(target, entry);
+    let linkTarget;
+    try {
+      const lstat = fs.lstatSync(dst);
+      if (!lstat.isSymbolicLink()) continue; // never touch non-symlinks
+      linkTarget = fs.readlinkSync(dst);
+    } catch (err) {
+      if (err.code === 'ENOENT') continue; // raced away
+      throw err;
+    }
+    if (!isOurLink(dst, linkTarget)) continue; // foreign symlink — keep
+    if (dryRun) {
+      results.push({ name: entry, target, action: 'would-prune' });
+    } else {
+      fs.unlinkSync(dst);
+      results.push({ name: entry, target, action: 'pruned' });
+    }
+  }
+  return results;
+}
+
 function ensureTargetDir(target, dryRun) {
   if (fs.existsSync(target)) return { created: false };
   if (dryRun) return { created: 'would' };
@@ -283,6 +336,11 @@ function commandInstall({ targets: extraTargets, dryRun }) {
       const srcAbs = path.join(VRUUM_SKILLS, skillName);
       summary.push(linkSkill({ name: skillName, srcAbs, target: target.dir, dryRun }));
     }
+    // Prune links we own for skills no longer in the package (renamed/removed),
+    // so installed clients don't keep a broken slash command.
+    for (const row of pruneStaleLinks({ target: target.dir, skills, dryRun })) {
+      summary.push(row);
+    }
   }
 
   const prefix = dryRun ? '[dry-run] ' : '';
@@ -313,7 +371,6 @@ function commandInstall({ targets: extraTargets, dryRun }) {
 }
 
 function commandUninstall({ targets: extraTargets, dryRun }) {
-  const skills = listAvailableSkills();
   const targets = detectTargets(extraTargets);
   const prefix = dryRun ? '[dry-run] ' : '';
   console.log(`${prefix}@vruum/skills v${VERSION} uninstall`);
@@ -322,18 +379,21 @@ function commandUninstall({ targets: extraTargets, dryRun }) {
     console.error('No AI harness skill directories detected.');
   }
 
-  // A symlink is "ours" if it points into ~/.vruum/skills/. We accept any
-  // target there (not just the current skill name) so stale links from
-  // renamed skills still get cleaned up.
-  const isOurLink = (linkTarget) => {
-    const resolved = path.resolve(linkTarget);
-    return resolved.startsWith(VRUUM_SKILLS + path.sep) || resolved === VRUUM_SKILLS;
-  };
-
+  // Scan each target dir and remove every symlink we own — not just the
+  // current skill names — so stale links left by renamed/removed skills are
+  // cleaned up too. Foreign symlinks and non-symlinks are left untouched
+  // (shared `isOurLink` ownership predicate).
   for (const target of targets) {
     console.log(`${prefix}target: ${target.dir}`);
-    for (const skillName of skills) {
-      const dst = path.join(target.dir, skillName);
+    let entries;
+    try {
+      entries = fs.readdirSync(target.dir);
+    } catch (err) {
+      if (err.code === 'ENOENT') continue;
+      throw err;
+    }
+    for (const entry of entries) {
+      const dst = path.join(target.dir, entry);
       let existing = null;
       try {
         const lstat = fs.lstatSync(dst);
@@ -346,19 +406,14 @@ function commandUninstall({ targets: extraTargets, dryRun }) {
         if (err.code !== 'ENOENT') throw err;
       }
 
-      if (!existing) {
-        console.log(`  ${prefix}not-installed  ${skillName}`);
-        continue;
-      }
-      if (existing.kind !== 'symlink' || !isOurLink(existing.target)) {
-        console.log(`  ${prefix}skipped        ${skillName}  [not our symlink]`);
-        continue;
+      if (!existing || existing.kind !== 'symlink' || !isOurLink(dst, existing.target)) {
+        continue; // not our symlink — leave it
       }
       if (dryRun) {
-        console.log(`  ${prefix}would-remove   ${skillName}`);
+        console.log(`  ${prefix}would-remove   ${entry}`);
       } else {
         fs.unlinkSync(dst);
-        console.log(`  ${prefix}removed        ${skillName}`);
+        console.log(`  ${prefix}removed        ${entry}`);
       }
     }
   }
@@ -461,4 +516,15 @@ function main() {
   }
 }
 
-main();
+if (require.main === module) main();
+
+module.exports = {
+  parseArgs,
+  listAvailableSkills,
+  linkSkill,
+  isOurLink,
+  pruneStaleLinks,
+  commandInstall,
+  commandUninstall,
+  commandList,
+};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vruum/skills",
-  "version": "0.6.1",
+  "version": "0.6.2",
   "description": "Vruum AI skills for Claude Code, Claude Desktop, Codex CLI, and any AI assistant with a skill directory. Slash commands for outreach triage, engagement triage, pipeline filling, prospect enrichment, and reply diagnosis. Pairs with the Vruum MCP server at https://api.vruum.ai/mcp.",
   "license": "MIT",
   "repository": {
@@ -26,6 +26,9 @@
   "engines": {
     "node": ">=18"
   },
+  "scripts": {
+    "test": "node --test __tests__/*.test.js"
+  },
   "keywords": [
     "vruum",
     "mcp",
@@ -36,5 +39,5 @@
     "outreach",
     "gtm"
   ],
-  "contentHash": "4bcdec8d3e471c8e08561b920faafca0c170aa2966ff5683576545aa2723b2f1"
+  "contentHash": "753b0d94ad80acaf1986cadaa6502df2a6b6f32a913ec9b39349922331378345"
 }