@voyant-travel/finance 0.167.0 → 0.169.0

package/README.md

@@ -114,14 +114,19 @@ Mounted Finance routes include:
 ## Booking Tax Preview
 
 Booking creation UIs can show the same tax line that booking finalization will
-persist by mounting the booking-tax extension:
+persist by mounting the booking-tax extensions. The surface is split in two:
+tax **settings** live on the finance admin surface, and tax **preview** lives on
+the bookings admin surface:
 
 ```typescript
-import { createBookingTaxApiExtension } from "@voyant-travel/finance/booking-tax"
+import {
+  createBookingTaxSettingsApiExtension,
+  createBookingTaxPreviewApiExtension,
+} from "@voyant-travel/finance/booking-tax"
 
 createApp({
   extensions: [
-    createBookingTaxApiExtension({
+    createBookingTaxSettingsApiExtension({
       resolveBookingTaxSettings: async (db) => {
         const settings = await getTaxSettings(db)
         return {
@@ -129,6 +134,10 @@ createApp({
           taxPolicyProfileId: settings?.taxPolicyProfileId ?? null,
         }
       },
+      updateBookingTaxSettings: async (db, next) => saveTaxSettings(db, next),
+    }),
+    createBookingTaxPreviewApiExtension({
+      resolveBookingTaxSettings: async (db) => getTaxSettings(db),
     }),
   ],
 })
@@ -139,16 +148,21 @@ settings table, KV, environment configuration, or any other deployment-owned
 store, while `@voyant-travel/finance` owns the tax policy rule walker, tax-regime
 lookup, product tax-class fallback, and inclusive/exclusive math.
 
-Templates that already mount custom routes can call `mountBookingTaxRoutes(...)`
-from the same entrypoint instead of using the API extension.
+Templates that already mount custom routes can call
+`mountBookingTaxSettingsRoutes(...)` / `mountBookingTaxPreviewRoutes(...)` from
+the same entrypoint instead of using the API extensions.
 
-Mounting this route registers:
+Mounting these routes registers:
 
-- `GET /v1/admin/bookings/tax-settings`
-- `PATCH /v1/admin/bookings/tax-settings` when `updateBookingTaxSettings` is supplied
+- `GET /v1/admin/finance/tax-settings`
+- `PATCH /v1/admin/finance/tax-settings` when `updateBookingTaxSettings` is supplied
 - `POST /v1/admin/bookings/tax-preview`
 
-The preview endpoint is consumed by `@voyant-travel/bookings-react` tax-preview
+Tax settings sit on the finance admin surface (alongside tax regimes, policy
+rules, and invoice-fx) so the managed runtime's per-unit, prefix-first-match
+admin dispatch does not let the bookings `GET /{id}` route swallow
+`/tax-settings`. The preview endpoint is consumed by
+`@voyant-travel/bookings-react` tax-preview
 hooks. Consumers that use the booking-create dialog without mounting the route
 will silently lose tax rows in the dialog summary because the client treats a
 missing preview as "no tax to show".

package/dist/booking-tax.d.ts

@@ -13,12 +13,6 @@ export type ResolvedBookingSellTaxRate = {
     priceMode: "inclusive" | "exclusive";
 };
 export type InvoicingMode = "direct" | "proforma-first";
-/**
- * Official FX reference-rate source. `ecb` (default) covers most EU
- * operators; `bnr` is the National Bank of Romania. A setting, not
- * per-country code — new jurisdictions add values here, not modules.
- */
-export type FxReferenceSource = "ecb" | "bnr";
 export type BookingTaxSettings = {
     taxPriceMode?: "inclusive" | "exclusive" | null;
     taxPolicyProfileId?: string | null;
@@ -30,10 +24,6 @@ export type BookingTaxSettings = {
      * never consult this. Absent/null → `proforma-first`.
      */
     invoicingMode?: InvoicingMode | null;
-    /**
-     * Operator's official FX reference-rate source. Absent/null → `ecb`.
-     */
-    fxReferenceSource?: FxReferenceSource | null;
 };
 export type ResolveBookingTaxSettings = (db: PostgresJsDatabase) => BookingTaxSettings | null | undefined | Promise<BookingTaxSettings | null | undefined>;
 export type UpdateBookingTaxSettings = (db: PostgresJsDatabase, settings: BookingTaxSettings) => BookingTaxSettings | null | undefined | Promise<BookingTaxSettings | null | undefined>;
@@ -71,7 +61,16 @@ export declare function computeBookingItemTaxLine(taxRate: ResolvedBookingSellTa
 } | null;
 export declare function loadProductTaxFacts(db: PostgresJsDatabase, productId: string): Promise<ProductTaxFacts>;
 export declare function matchesTaxPolicyCondition(condition: TaxPolicyCondition | null | undefined, facts: ProductTaxFacts): boolean;
-export declare function createBookingTaxRoutes(options?: BookingTaxRouteOptions): OpenAPIHono<{
+/**
+ * Booking tax **settings** routes: `GET`/`PATCH /tax-settings`.
+ *
+ * Mounted on the finance admin surface (`/v1/admin/finance/tax-settings`)
+ * so it lands alongside the other finance-owned settings (tax regimes,
+ * tax-policy-rules, invoice-fx) rather than under `/v1/admin/bookings`,
+ * where the bookings package's `GET /{id}` route would otherwise capture
+ * `/tax-settings` under the managed runtime's prefix-first-match dispatch.
+ */
+export declare function createBookingTaxSettingsRoutes(options?: BookingTaxRouteOptions): OpenAPIHono<{
     Variables: {
         db: PostgresJsDatabase;
     };
@@ -84,7 +83,6 @@ export declare function createBookingTaxRoutes(options?: BookingTaxRouteOptions)
                     taxPriceMode: "inclusive" | "exclusive";
                     taxPolicyProfileId: string | null;
                     invoicingMode: "direct" | "proforma-first";
-                    fxReferenceSource: "ecb" | "bnr";
                 };
             };
             outputFormat: "json";
@@ -99,7 +97,6 @@ export declare function createBookingTaxRoutes(options?: BookingTaxRouteOptions)
                     taxPriceMode?: "inclusive" | "exclusive" | undefined;
                     taxPolicyProfileId?: string | null | undefined;
                     invoicingMode?: "direct" | "proforma-first" | undefined;
-                    fxReferenceSource?: "ecb" | "bnr" | undefined;
                 };
             };
             output: {};
@@ -111,7 +108,6 @@ export declare function createBookingTaxRoutes(options?: BookingTaxRouteOptions)
                     taxPriceMode?: "inclusive" | "exclusive" | undefined;
                     taxPolicyProfileId?: string | null | undefined;
                     invoicingMode?: "direct" | "proforma-first" | undefined;
-                    fxReferenceSource?: "ecb" | "bnr" | undefined;
                 };
             };
             output: {
@@ -119,14 +115,25 @@ export declare function createBookingTaxRoutes(options?: BookingTaxRouteOptions)
                     taxPriceMode: "inclusive" | "exclusive";
                     taxPolicyProfileId: string | null;
                     invoicingMode: "direct" | "proforma-first";
-                    fxReferenceSource: "ecb" | "bnr";
                 };
             };
             outputFormat: "json";
             status: 200;
         };
     };
-} & {
+}, "/">;
+/**
+ * Booking tax **preview** route: `POST /tax-preview`.
+ *
+ * Stays on the bookings admin surface (`/v1/admin/bookings/tax-preview`);
+ * `POST` does not collide with bookings' `GET /{id}`, and
+ * `@voyant-travel/bookings-react` consumes it there.
+ */
+export declare function createBookingTaxPreviewRoutes(options?: BookingTaxRouteOptions): OpenAPIHono<{
+    Variables: {
+        db: PostgresJsDatabase;
+    };
+}, {
     "/tax-preview": {
         $post: {
             input: {
@@ -155,6 +162,11 @@ export declare function createBookingTaxRoutes(options?: BookingTaxRouteOptions)
         };
     };
 }, "/">;
-export declare function mountBookingTaxRoutes(hono: Hono, options?: BookingTaxRouteOptions): void;
-export declare function createBookingTaxApiExtension(options?: BookingTaxRouteOptions): ApiExtension;
-export declare const createBookingTaxVoyantRuntime: import("@voyant-travel/core/project").VoyantGraphRuntimeFactory<ApiExtension>;
+/** Mount the tax-settings routes under the finance admin surface. */
+export declare function mountBookingTaxSettingsRoutes(hono: Hono, options?: BookingTaxRouteOptions): void;
+/** Mount the tax-preview route under the bookings admin surface. */
+export declare function mountBookingTaxPreviewRoutes(hono: Hono, options?: BookingTaxRouteOptions): void;
+export declare function createBookingTaxSettingsApiExtension(options?: BookingTaxRouteOptions): ApiExtension;
+export declare function createBookingTaxPreviewApiExtension(options?: BookingTaxRouteOptions): ApiExtension;
+export declare const createBookingTaxSettingsVoyantRuntime: import("@voyant-travel/core/project").VoyantGraphRuntimeFactory<ApiExtension>;
+export declare const createBookingTaxPreviewVoyantRuntime: import("@voyant-travel/core/project").VoyantGraphRuntimeFactory<ApiExtension>;

package/dist/booking-tax.js

@@ -15,14 +15,12 @@ const bookingTaxSettingsPatchSchema = z.object({
     taxPriceMode: z.enum(["inclusive", "exclusive"]).optional(),
     taxPolicyProfileId: z.string().min(1).nullable().optional(),
     invoicingMode: z.enum(["direct", "proforma-first"]).optional(),
-    fxReferenceSource: z.enum(["ecb", "bnr"]).optional(),
 });
 const bookingTaxSettingsResponseSchema = z.object({
     data: z.object({
         taxPriceMode: z.enum(["inclusive", "exclusive"]),
         taxPolicyProfileId: z.string().nullable(),
         invoicingMode: z.enum(["direct", "proforma-first"]),
-        fxReferenceSource: z.enum(["ecb", "bnr"]),
     }),
 });
 const bookingTaxPreviewResponseSchema = z.object({
@@ -118,7 +116,6 @@ async function resolveBookingTaxSettingsOrDefault(db, options = {}) {
         taxPriceMode: settings?.taxPriceMode === "exclusive" ? "exclusive" : "inclusive",
         taxPolicyProfileId: settings?.taxPolicyProfileId ?? null,
         invoicingMode: settings?.invoicingMode === "direct" ? "direct" : "proforma-first",
-        fxReferenceSource: settings?.fxReferenceSource === "bnr" ? "bnr" : "ecb",
     };
 }
 export function computeBookingItemTaxLine(taxRate, amountCents, currency, sortOrder = 0) {
@@ -260,7 +257,16 @@ async function resolveProductTaxClassRate(db, productId, priceMode) {
     const resolved = await loadResolvedTaxRegime(db, klass.defaultRegimeId, klass.code);
     return resolved ? { ...resolved, priceMode } : null;
 }
-export function createBookingTaxRoutes(options = {}) {
+/**
+ * Booking tax **settings** routes: `GET`/`PATCH /tax-settings`.
+ *
+ * Mounted on the finance admin surface (`/v1/admin/finance/tax-settings`)
+ * so it lands alongside the other finance-owned settings (tax regimes,
+ * tax-policy-rules, invoice-fx) rather than under `/v1/admin/bookings`,
+ * where the bookings package's `GET /{id}` route would otherwise capture
+ * `/tax-settings` under the managed runtime's prefix-first-match dispatch.
+ */
+export function createBookingTaxSettingsRoutes(options = {}) {
     const routes = new OpenAPIHono({ defaultHook: openApiValidationHook })
         .openapi(getBookingTaxSettingsRoute, async (c) => {
         return c.json({
@@ -282,13 +288,22 @@ export function createBookingTaxRoutes(options = {}) {
                 ? current.taxPolicyProfileId
                 : patch.taxPolicyProfileId,
             invoicingMode: patch.invoicingMode ?? current.invoicingMode,
-            fxReferenceSource: patch.fxReferenceSource ?? current.fxReferenceSource,
         });
         return c.json({
             data: await resolveBookingTaxSettingsOrDefault(c.get("db"), { settings: next }),
         }, 200);
-    })
-        .openapi(previewBookingTaxRoute, async (c) => {
+    });
+    return stampOpenApiRegistryApiId(routes, "@voyant-travel/finance#booking-tax-settings-extension.api");
+}
+/**
+ * Booking tax **preview** route: `POST /tax-preview`.
+ *
+ * Stays on the bookings admin surface (`/v1/admin/bookings/tax-preview`);
+ * `POST` does not collide with bookings' `GET /{id}`, and
+ * `@voyant-travel/bookings-react` consumes it there.
+ */
+export function createBookingTaxPreviewRoutes(options = {}) {
+    const routes = new OpenAPIHono({ defaultHook: openApiValidationHook }).openapi(previewBookingTaxRoute, async (c) => {
         const body = c.req.valid("json");
         const taxRate = await resolveBookingSellTaxRate(c.get("db"), { productId: body.productId }, options);
         const taxLine = computeBookingItemTaxLine(taxRate, body.subtotalCents, body.currency);
@@ -323,21 +338,39 @@ export function createBookingTaxRoutes(options = {}) {
             },
         }, 200);
     });
-    return stampOpenApiRegistryApiId(routes, "@voyant-travel/finance#booking-tax-extension.api");
+    return stampOpenApiRegistryApiId(routes, "@voyant-travel/finance#booking-tax-preview-extension.api");
 }
-export function mountBookingTaxRoutes(hono, options = {}) {
-    hono.route("/v1/admin/bookings", createBookingTaxRoutes(options));
+/** Mount the tax-settings routes under the finance admin surface. */
+export function mountBookingTaxSettingsRoutes(hono, options = {}) {
+    hono.route("/v1/admin/finance", createBookingTaxSettingsRoutes(options));
 }
-export function createBookingTaxApiExtension(options = {}) {
+/** Mount the tax-preview route under the bookings admin surface. */
+export function mountBookingTaxPreviewRoutes(hono, options = {}) {
+    hono.route("/v1/admin/bookings", createBookingTaxPreviewRoutes(options));
+}
+export function createBookingTaxSettingsApiExtension(options = {}) {
     const extension = {
-        name: "booking-tax",
+        name: "booking-tax-settings",
+        module: "finance",
+    };
+    return {
+        extension,
+        adminRoutes: createBookingTaxSettingsRoutes(options),
+    };
+}
+export function createBookingTaxPreviewApiExtension(options = {}) {
+    const extension = {
+        name: "booking-tax-preview",
         module: "bookings",
     };
     return {
         extension,
-        adminRoutes: createBookingTaxRoutes(options),
+        adminRoutes: createBookingTaxPreviewRoutes(options),
     };
 }
-export const createBookingTaxVoyantRuntime = defineGraphRuntimeFactory(async ({ getPort }) => {
-    return createBookingTaxApiExtension(createFinanceBookingTaxRuntime(await getPort(financeOperatorSettingsRuntimePort)));
+export const createBookingTaxSettingsVoyantRuntime = defineGraphRuntimeFactory(async ({ getPort }) => {
+    return createBookingTaxSettingsApiExtension(createFinanceBookingTaxRuntime(await getPort(financeOperatorSettingsRuntimePort)));
+});
+export const createBookingTaxPreviewVoyantRuntime = defineGraphRuntimeFactory(async ({ getPort }) => {
+    return createBookingTaxPreviewApiExtension(createFinanceBookingTaxRuntime(await getPort(financeOperatorSettingsRuntimePort)));
 });

package/dist/index.d.ts

@@ -26,7 +26,7 @@ export declare const createFinanceVoyantRuntime: import("@voyant-travel/core/pro
 export type { PaymentAdapter, PaymentAdapterCapabilities, PaymentAdapterConformanceHarness, PaymentAdapterConformanceResult, PaymentAdapterDiagnostics, PaymentAdapterRuntimeContext, PaymentCallbackEvent, PaymentCallbackRequest, PaymentCallbackVerificationResult, PaymentInitiationInput, PaymentInitiationResult, PaymentMoney, PaymentOperationInput, PaymentOperationResult, PaymentStatusInput, PaymentStatusResult, } from "@voyant-travel/payments";
 export { PAYMENT_ADAPTER_CONTRACT_VERSION, PAYMENT_ADAPTER_RUNTIME_PORT_ID, paymentAdapterRuntimePort, runPaymentAdapterConformance, } from "@voyant-travel/payments";
 export { type BookingCancellationSettlementInput, buildPaidBookingCancellationSettlementNote, closeTerminalBookingPaymentSchedules, financeBookingLifecycle, recordPaidBookingCancellationSettlement, } from "./booking-lifecycle.js";
-export { type BookingTaxRouteOptions, type BookingTaxSettings, computeBookingItemTaxLine, createBookingTaxApiExtension, createBookingTaxRoutes, createBookingTaxVoyantRuntime, loadProductTaxFacts, matchesTaxPolicyCondition, mountBookingTaxRoutes, type ProductTaxFacts, type ResolveBookingSellTaxRateOptions, type ResolveBookingTaxSettings, type ResolvedBookingSellTaxRate, resolveBookingSellTaxRate, type TaxPolicyCondition, type UpdateBookingTaxSettings, } from "./booking-tax.js";
+export { type BookingTaxRouteOptions, type BookingTaxSettings, computeBookingItemTaxLine, createBookingTaxPreviewApiExtension, createBookingTaxPreviewRoutes, createBookingTaxPreviewVoyantRuntime, createBookingTaxSettingsApiExtension, createBookingTaxSettingsRoutes, createBookingTaxSettingsVoyantRuntime, loadProductTaxFacts, matchesTaxPolicyCondition, mountBookingTaxPreviewRoutes, mountBookingTaxSettingsRoutes, type ProductTaxFacts, type ResolveBookingSellTaxRateOptions, type ResolveBookingTaxSettings, type ResolvedBookingSellTaxRate, resolveBookingSellTaxRate, type TaxPolicyCondition, type UpdateBookingTaxSettings, } from "./booking-tax.js";
 export type { CardPaymentBilling, CardPaymentStartArgs, CardPaymentStarter, CardPaymentStartResult, PaymentAdapterCardPaymentStarterOptions, } from "./card-payment.js";
 export { createPaymentAdapterCardPaymentStarter } from "./card-payment.js";
 export { type DocumentDownloadEnvelope, type DocumentDownloadResolution, type DocumentDownloadResolver, resolveStoredDocumentDownload, type StoredDocumentReference, } from "./document-download.js";

package/dist/index.js

@@ -5,7 +5,7 @@ import { customFieldsRuntimePort } from "@voyant-travel/core/custom-fields";
 import { defineGraphRuntimeFactory } from "@voyant-travel/core/project";
 import { stampOpenApiRegistryApiId } from "@voyant-travel/hono";
 import { financeBookingLifecycle } from "./booking-lifecycle.js";
-import { createBookingTaxRoutes } from "./booking-tax.js";
+import { createBookingTaxSettingsRoutes } from "./booking-tax.js";
 import { buildFinanceCheckoutRouteRuntime, createFinanceCheckoutAdminRoutes, createFinanceCheckoutRoutes, FINANCE_CHECKOUT_ROUTE_RUNTIME_CONTAINER_KEY, } from "./checkout-routes.js";
 import { createInvoiceFxRoutes } from "./invoice-fx.js";
 import { financeLinkable } from "./linkables.js";
@@ -39,7 +39,7 @@ export function createFinanceApiModule(options = {}) {
         .route("/", supplierInvoiceRoutes)
         .route("/", createInvoiceFxRoutes(options))
         .route("/", createFinanceAdminDocumentRoutes(options))
-        .route("/", createFinanceAdminSettlementRoutes(options)), "@voyant-travel/finance#api.admin").route("/", createBookingTaxRoutes(options));
+        .route("/", createFinanceAdminSettlementRoutes(options)), "@voyant-travel/finance#api.admin").route("/", createBookingTaxSettingsRoutes(options));
     const module = {
         ...financeModule,
         bootstrap: ({ bindings, container, eventBus }) => {
@@ -89,7 +89,7 @@ export const createFinanceVoyantRuntime = defineGraphRuntimeFactory(async ({ api
 });
 export { PAYMENT_ADAPTER_CONTRACT_VERSION, PAYMENT_ADAPTER_RUNTIME_PORT_ID, paymentAdapterRuntimePort, runPaymentAdapterConformance, } from "@voyant-travel/payments";
 export { buildPaidBookingCancellationSettlementNote, closeTerminalBookingPaymentSchedules, financeBookingLifecycle, recordPaidBookingCancellationSettlement, } from "./booking-lifecycle.js";
-export { computeBookingItemTaxLine, createBookingTaxApiExtension, createBookingTaxRoutes, createBookingTaxVoyantRuntime, loadProductTaxFacts, matchesTaxPolicyCondition, mountBookingTaxRoutes, resolveBookingSellTaxRate, } from "./booking-tax.js";
+export { computeBookingItemTaxLine, createBookingTaxPreviewApiExtension, createBookingTaxPreviewRoutes, createBookingTaxPreviewVoyantRuntime, createBookingTaxSettingsApiExtension, createBookingTaxSettingsRoutes, createBookingTaxSettingsVoyantRuntime, loadProductTaxFacts, matchesTaxPolicyCondition, mountBookingTaxPreviewRoutes, mountBookingTaxSettingsRoutes, resolveBookingSellTaxRate, } from "./booking-tax.js";
 export { createPaymentAdapterCardPaymentStarter } from "./card-payment.js";
 export { resolveStoredDocumentDownload, } from "./document-download.js";
 export { createInvoiceFxApiExtension, createInvoiceFxRoutes, createVoyantDataFxExchangeRateResolver, mountInvoiceFxRoutes, resolveInvoiceFxContext, resolveInvoiceFxSettingsOrDefault, } from "./invoice-fx.js";

package/dist/runtime-port.d.ts

@@ -1,7 +1,7 @@
 import type { VoyantRuntimeHostPrimitives } from "@voyant-travel/core";
 import type { AnyDrizzleDb } from "@voyant-travel/db";
 import type { PostgresJsDatabase } from "drizzle-orm/postgres-js";
-import type { BookingTaxRouteOptions, FxReferenceSource } from "./booking-tax.js";
+import type { BookingTaxRouteOptions } from "./booking-tax.js";
 import type { CheckoutRoutesOptions } from "./checkout-routes.js";
 import type { CheckoutPaymentStarter } from "./checkout-service.js";
 import type { PaymentPolicy } from "./payment-policy.js";
@@ -24,17 +24,18 @@ export interface FinanceOperatorSettingsRuntime {
      * settled proforma should be auto-converted to a fiscal invoice.
      */
     resolveInvoicingMode: (db: PostgresJsDatabase) => Promise<"direct" | "proforma-first">;
-    /**
-     * Resolve the operator's official FX reference-rate source
-     * (`ecb` | `bnr`, default `ecb`). Read by the finance fx-reference
-     * helper to pick the host-provided rate source for the operator.
-     */
-    resolveFxReferenceSource: (db: PostgresJsDatabase) => Promise<FxReferenceSource>;
 }
 export interface FinanceNotificationsRuntime {
     resolveNotificationDispatcher: NonNullable<CheckoutRoutesOptions["resolveNotificationDispatcher"]>;
     listBookingReminderRuns: NonNullable<CheckoutRoutesOptions["listBookingReminderRuns"]>;
 }
+/**
+ * Label for the official source that published a resolved reference rate
+ * (e.g. `ecb`, `bnr`). This is an OUTPUT annotation only — the operator
+ * does not pick a source; the host adapter knows its own. Free-form so a
+ * host can report whatever series it drew from.
+ */
+export type FxReferenceSource = string;
 /** Request for one official FX reference rate on a given date. */
 export interface FxReferenceRateRequest {
     /** Currency to convert from, e.g. `EUR` (ISO 4217). */
@@ -56,17 +57,14 @@ export interface FxReferenceRate {
 /**
  * Host-provided official FX reference-rate source. Finance defines the
  * seam only; hosts/deployments wire it to their own FX data source. No
- * HTTP client or API key lives inside finance.
+ * HTTP client or API key lives inside finance. The operator does not pick
+ * a source — the host adapter knows its own (managed FX on Voyant Cloud;
+ * a self-hoster's own adapter otherwise; a legally mandated source such
+ * as BNR for RO). The chosen source is reported back on the rate.
  */
 export interface FinanceFxReferenceRuntime {
-    /**
-     * Resolve one official reference rate. `source` is the operator's
-     * configured reference source (e.g. `ecb`, `bnr`); the host uses it
-     * to pick the correct published series.
-     */
-    resolveReferenceRate(request: FxReferenceRateRequest & {
-        source: FxReferenceSource;
-    }): Promise<FxReferenceRate>;
+    /** Resolve one official reference rate for the host's own source. */
+    resolveReferenceRate(request: FxReferenceRateRequest): Promise<FxReferenceRate>;
 }
 export interface FinanceDistributionPaymentPolicyRuntime {
     resolveSupplierPolicy: PolicyReader;
@@ -115,23 +113,21 @@ export declare const financeFxReferenceRuntimePort: import("@voyant-travel/core/
  */
 export declare class FinanceFxReferenceSourceUnavailableError extends Error {
     readonly code = "finance_fx_reference_source_unavailable";
-    constructor(source: FxReferenceSource);
+    constructor();
 }
 export interface ResolveReferenceRateHelperInput {
     base: string;
     quote: string;
     date?: string;
-    /** The operator's configured reference source (e.g. `ecb`, `bnr`). */
-    source: FxReferenceSource;
     /** Host-provided implementation. Absent → typed unavailable error. */
     provider?: FinanceFxReferenceRuntime | null;
 }
 /**
- * Typed helper that resolves an official FX reference rate for an
- * operator's configured source by delegating to the host-provided
- * `finance.fx-reference.runtime` implementation. When no provider is
- * wired, throws {@link FinanceFxReferenceSourceUnavailableError} — a
- * clear, typed signal rather than a silent fallback. Finance holds no
+ * Typed helper that resolves an official FX reference rate by delegating
+ * to the host-provided `finance.fx-reference.runtime` implementation. The
+ * source is the host adapter's own — the operator does not pick one. When
+ * no provider is wired, throws {@link FinanceFxReferenceSourceUnavailableError}
+ * — a clear, typed signal rather than a silent fallback. Finance holds no
  * FX data itself.
  */
 export declare function resolveReferenceRate(input: ResolveReferenceRateHelperInput): Promise<FxReferenceRate>;

package/dist/runtime-port.js

@@ -20,7 +20,6 @@ export const financeOperatorSettingsRuntimePort = objectPort("finance.operator-s
     "resolveBookingTaxSettings",
     "updateBookingTaxSettings",
     "resolveInvoicingMode",
-    "resolveFxReferenceSource",
 ]);
 export const financeNotificationsRuntimePort = objectPort("finance.notifications.runtime", ["resolveNotificationDispatcher", "listBookingReminderRuns"]);
 export const financeFxReferenceRuntimePort = objectPort("finance.fx-reference.runtime", ["resolveReferenceRate"]);
@@ -32,25 +31,25 @@ export const financeFxReferenceRuntimePort = objectPort("finance.fx-reference.ru
  */
 export class FinanceFxReferenceSourceUnavailableError extends Error {
     code = "finance_fx_reference_source_unavailable";
-    constructor(source) {
-        super(`No FX reference-rate source is configured for "${source}". A host must provide the finance.fx-reference.runtime port.`);
+    constructor() {
+        super("No FX reference-rate source is configured. A host must provide the finance.fx-reference.runtime port.");
         this.name = "FinanceFxReferenceSourceUnavailableError";
     }
 }
 /**
- * Typed helper that resolves an official FX reference rate for an
- * operator's configured source by delegating to the host-provided
- * `finance.fx-reference.runtime` implementation. When no provider is
- * wired, throws {@link FinanceFxReferenceSourceUnavailableError} — a
- * clear, typed signal rather than a silent fallback. Finance holds no
+ * Typed helper that resolves an official FX reference rate by delegating
+ * to the host-provided `finance.fx-reference.runtime` implementation. The
+ * source is the host adapter's own — the operator does not pick one. When
+ * no provider is wired, throws {@link FinanceFxReferenceSourceUnavailableError}
+ * — a clear, typed signal rather than a silent fallback. Finance holds no
  * FX data itself.
  */
 export function resolveReferenceRate(input) {
-    const { provider, source, base, quote, date } = input;
+    const { provider, base, quote, date } = input;
     if (!provider) {
-        throw new FinanceFxReferenceSourceUnavailableError(source);
+        throw new FinanceFxReferenceSourceUnavailableError();
     }
-    return provider.resolveReferenceRate({ base, quote, date, source });
+    return provider.resolveReferenceRate({ base, quote, date });
 }
 export const financeDistributionPaymentPolicyRuntimePort = objectPort("finance.distribution-payment-policy.runtime", ["resolveSupplierPolicy", "resolveSupplierPolicyById"]);
 export const financeAccommodationsPaymentPolicyRuntimePort = objectPort("finance.accommodations-payment-policy.runtime", ["resolveBookingPolicy", "resolveEntityPolicy"]);

package/dist/voyant.d.ts

@@ -1,6 +1,7 @@
 /** Import-cheap deployment declaration owned by the finance package. */
 export declare const financeVoyantModule: import("@voyant-travel/core").VoyantGraphUnitManifest;
-export declare const financeBookingTaxVoyantPlugin: import("@voyant-travel/core").VoyantGraphUnitManifest;
+export declare const financeBookingTaxSettingsVoyantPlugin: import("@voyant-travel/core").VoyantGraphUnitManifest;
+export declare const financeBookingTaxPreviewVoyantPlugin: import("@voyant-travel/core").VoyantGraphUnitManifest;
 export declare const financeBookingsCreateVoyantPlugin: import("@voyant-travel/core").VoyantGraphUnitManifest;
 export declare const financeBookingScheduleVoyantPlugin: import("@voyant-travel/core").VoyantGraphUnitManifest;
 export default financeVoyantModule;

package/dist/voyant.js

@@ -364,22 +364,58 @@ export const financeVoyantModule = defineModule({
         ownership: "package",
     },
 });
-export const financeBookingTaxVoyantPlugin = defineExtension({
-    id: "@voyant-travel/finance#booking-tax-extension",
+// The booking-tax facets are two independent extensions so the selected-graph
+// composition keeps them as separate composed extensions. Each `defineExtension`
+// yields one composed extension keyed on its localId; declaring both api facets
+// under a single extension would collapse them and drop the preview facet.
+//
+// Tax settings (GET/PATCH /tax-settings) live on the finance admin surface. On
+// the managed runtime admin routes dispatch per-unit with prefix-first-match,
+// so mounting them under `bookings` let the bookings `GET /{id}` route swallow
+// `/tax-settings`; the finance surface already serves `/v1/admin/finance/*`
+// settings safely.
+export const financeBookingTaxSettingsVoyantPlugin = defineExtension({
+    id: "@voyant-travel/finance#booking-tax-settings-extension",
     packageName: "@voyant-travel/finance",
-    localId: "finance.booking-tax-extension",
-    runtime: { entry: "@voyant-travel/finance", export: "createBookingTaxVoyantRuntime" },
+    localId: "finance.booking-tax-settings-extension",
+    runtime: { entry: "@voyant-travel/finance", export: "createBookingTaxSettingsVoyantRuntime" },
     runtimePorts: [requirePort(financeOperatorSettingsRuntimePort)],
     api: [
         {
-            id: "@voyant-travel/finance#booking-tax-extension.api",
+            id: "@voyant-travel/finance#booking-tax-settings-extension.api",
+            surface: "admin",
+            mount: "finance",
+            openapi: { document: "booking-tax-settings" },
+            transactional: true,
+            runtime: {
+                entry: "@voyant-travel/finance",
+                export: "createBookingTaxSettingsApiExtension",
+            },
+        },
+    ],
+    meta: {
+        ownership: "package",
+    },
+});
+// Tax preview (POST /tax-preview) stays on the bookings admin surface — POST
+// does not collide with the bookings `GET /{id}` route and bookings-react
+// consumes it at `/v1/admin/bookings/tax-preview`.
+export const financeBookingTaxPreviewVoyantPlugin = defineExtension({
+    id: "@voyant-travel/finance#booking-tax-preview-extension",
+    packageName: "@voyant-travel/finance",
+    localId: "finance.booking-tax-preview-extension",
+    runtime: { entry: "@voyant-travel/finance", export: "createBookingTaxPreviewVoyantRuntime" },
+    runtimePorts: [requirePort(financeOperatorSettingsRuntimePort)],
+    api: [
+        {
+            id: "@voyant-travel/finance#booking-tax-preview-extension.api",
             surface: "admin",
             mount: "bookings",
-            openapi: { document: "booking-tax" },
+            openapi: { document: "booking-tax-preview" },
             transactional: true,
             runtime: {
                 entry: "@voyant-travel/finance",
-                export: "createBookingTaxApiExtension",
+                export: "createBookingTaxPreviewApiExtension",
             },
         },
     ],

package/openapi/admin/booking-tax-preview.json

@@ -0,0 +1,33 @@
+{
+  "openapi": "3.1.0",
+  "info": {
+    "title": "Booking Tax Preview API",
+    "version": "1.0.0"
+  },
+  "paths": {
+    "/v1/admin/bookings/tax-preview": {
+      "post": {
+        "summary": "Preview tax for a booking item subtotal",
+        "x-voyant-api-id": "@voyant-travel/finance#booking-tax-preview-extension.api",
+        "requestBody": {
+          "required": true,
+          "content": {
+            "application/json": {
+              "schema": {
+                "type": "object",
+                "required": ["productId", "subtotalCents", "currency"],
+                "properties": {
+                  "productId": { "type": "string", "minLength": 1 },
+                  "subtotalCents": { "type": "integer", "minimum": 0 },
+                  "currency": { "type": "string", "minLength": 3, "maxLength": 8 }
+                }
+              }
+            }
+          }
+        },
+        "responses": { "200": { "description": "The calculated tax preview" } }
+      }
+    }
+  },
+  "components": { "schemas": {} }
+}

package/openapi/admin/{booking-tax.json → booking-tax-settings.json}

@@ -1,14 +1,14 @@
 {
   "openapi": "3.1.0",
   "info": {
-    "title": "Booking Tax API",
+    "title": "Booking Tax Settings API",
     "version": "1.0.0"
   },
   "paths": {
-    "/v1/admin/bookings/tax-settings": {
+    "/v1/admin/finance/tax-settings": {
       "get": {
         "summary": "Get booking tax settings",
-        "x-voyant-api-id": "@voyant-travel/finance#booking-tax-extension.api",
+        "x-voyant-api-id": "@voyant-travel/finance#booking-tax-settings-extension.api",
         "responses": {
           "200": {
             "description": "The effective booking tax settings",
@@ -26,7 +26,7 @@
       },
       "patch": {
         "summary": "Update booking tax settings",
-        "x-voyant-api-id": "@voyant-travel/finance#booking-tax-extension.api",
+        "x-voyant-api-id": "@voyant-travel/finance#booking-tax-settings-extension.api",
         "requestBody": {
           "required": true,
           "content": {
@@ -36,8 +36,7 @@
                 "properties": {
                   "taxPriceMode": { "type": "string", "enum": ["inclusive", "exclusive"] },
                   "taxPolicyProfileId": { "type": ["string", "null"] },
-                  "invoicingMode": { "type": "string", "enum": ["direct", "proforma-first"] },
-                  "fxReferenceSource": { "type": "string", "enum": ["ecb", "bnr"] }
+                  "invoicingMode": { "type": "string", "enum": ["direct", "proforma-first"] }
                 }
               }
             }
@@ -48,41 +47,17 @@
           "409": { "description": "This deployment does not support tax setting updates" }
         }
       }
-    },
-    "/v1/admin/bookings/tax-preview": {
-      "post": {
-        "summary": "Preview tax for a booking item subtotal",
-        "x-voyant-api-id": "@voyant-travel/finance#booking-tax-extension.api",
-        "requestBody": {
-          "required": true,
-          "content": {
-            "application/json": {
-              "schema": {
-                "type": "object",
-                "required": ["productId", "subtotalCents", "currency"],
-                "properties": {
-                  "productId": { "type": "string", "minLength": 1 },
-                  "subtotalCents": { "type": "integer", "minimum": 0 },
-                  "currency": { "type": "string", "minLength": 3, "maxLength": 8 }
-                }
-              }
-            }
-          }
-        },
-        "responses": { "200": { "description": "The calculated tax preview" } }
-      }
     }
   },
   "components": {
     "schemas": {
       "BookingTaxSettings": {
         "type": "object",
-        "required": ["taxPriceMode", "taxPolicyProfileId", "invoicingMode", "fxReferenceSource"],
+        "required": ["taxPriceMode", "taxPolicyProfileId", "invoicingMode"],
         "properties": {
           "taxPriceMode": { "type": "string", "enum": ["inclusive", "exclusive"] },
           "taxPolicyProfileId": { "type": ["string", "null"] },
-          "invoicingMode": { "type": "string", "enum": ["direct", "proforma-first"] },
-          "fxReferenceSource": { "type": "string", "enum": ["ecb", "bnr"] }
+          "invoicingMode": { "type": "string", "enum": ["direct", "proforma-first"] }
         }
       }
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@voyant-travel/finance",
-  "version": "0.167.0",
+  "version": "0.169.0",
   "license": "Apache-2.0",
   "type": "module",
   "exports": {
@@ -140,7 +140,8 @@
       "default": "./dist/voyant.js"
     },
     "./openapi/admin": "./openapi/admin/finance.json",
-    "./openapi/admin/booking-tax": "./openapi/admin/booking-tax.json",
+    "./openapi/admin/booking-tax-settings": "./openapi/admin/booking-tax-settings.json",
+    "./openapi/admin/booking-tax-preview": "./openapi/admin/booking-tax-preview.json",
     "./openapi/storefront": "./openapi/storefront/finance.json"
   },
   "dependencies": {
@@ -150,18 +151,18 @@
     "fflate": "^0.8.2",
     "hono": "^4.12.27",
     "zod": "^4.4.3",
+    "@voyant-travel/core": "^0.125.2",
     "@voyant-travel/action-ledger": "^0.111.1",
-    "@voyant-travel/bookings": "^0.167.0",
-    "@voyant-travel/core": "^0.125.0",
+    "@voyant-travel/bookings": "^0.169.0",
+    "@voyant-travel/types": "^0.109.4",
     "@voyant-travel/db": "^0.114.10",
-    "@voyant-travel/types": "^0.109.3",
     "@voyant-travel/finance-contracts": "^0.106.2",
-    "@voyant-travel/hono": "^0.128.1",
-    "@voyant-travel/payments": "^0.2.1",
+    "@voyant-travel/hono": "^0.128.3",
     "@voyant-travel/public-document-delivery": "^0.4.1",
-    "@voyant-travel/storage": "^0.111.1",
+    "@voyant-travel/payments": "^0.2.1",
+    "@voyant-travel/tools": "^0.3.0",
     "@voyant-travel/utils": "^0.107.1",
-    "@voyant-travel/tools": "^0.3.0"
+    "@voyant-travel/storage": "^0.111.1"
   },
   "devDependencies": {
     "drizzle-kit": "^0.31.10",