@voyant-travel/finance 0.166.0 → 0.167.0

package/dist/booking-tax.d.ts

@@ -23,9 +23,11 @@ export type BookingTaxSettings = {
     taxPriceMode?: "inclusive" | "exclusive" | null;
     taxPolicyProfileId?: string | null;
     /**
-     * Operator invoicing mode. `direct` bills the fiscal invoice
-     * straight away; `proforma-first` issues a proforma and converts it
-     * to a fiscal invoice on full settlement. Absent/null → `direct`.
+     * Operator invoicing mode for the deferred bank-transfer path.
+     * `proforma-first` issues a proforma at order placement and converts it
+     * to a fiscal invoice on full settlement; `direct` issues the fiscal
+     * invoice at order placement. Card payments always invoice directly and
+     * never consult this. Absent/null → `proforma-first`.
      */
     invoicingMode?: InvoicingMode | null;
     /**
@@ -57,12 +59,6 @@ export declare function resolveBookingSellTaxRate(db: PostgresJsDatabase, args:
     productId?: string | null;
     facts?: Partial<ProductTaxFacts>;
 }, options?: ResolveBookingSellTaxRateOptions): Promise<ResolvedBookingSellTaxRate | null>;
-/**
- * Resolve just the operator invoicing mode, defaulting to `direct`
- * when no settings row exists. Shared by the proforma-conversion
- * subscriber so it never converts unless the operator opted in.
- */
-export declare function resolveInvoicingModeOrDefault(db: PostgresJsDatabase, options?: ResolveBookingSellTaxRateOptions): Promise<InvoicingMode>;
 export declare function computeBookingItemTaxLine(taxRate: ResolvedBookingSellTaxRate | null, amountCents: number, currency: string, sortOrder?: number): {
     code: string;
     name: string;

package/dist/booking-tax.js

@@ -117,19 +117,10 @@ async function resolveBookingTaxSettingsOrDefault(db, options = {}) {
     return {
         taxPriceMode: settings?.taxPriceMode === "exclusive" ? "exclusive" : "inclusive",
         taxPolicyProfileId: settings?.taxPolicyProfileId ?? null,
-        invoicingMode: settings?.invoicingMode === "proforma-first" ? "proforma-first" : "direct",
+        invoicingMode: settings?.invoicingMode === "direct" ? "direct" : "proforma-first",
         fxReferenceSource: settings?.fxReferenceSource === "bnr" ? "bnr" : "ecb",
     };
 }
-/**
- * Resolve just the operator invoicing mode, defaulting to `direct`
- * when no settings row exists. Shared by the proforma-conversion
- * subscriber so it never converts unless the operator opted in.
- */
-export async function resolveInvoicingModeOrDefault(db, options = {}) {
-    const settings = await resolveBookingTaxSettingsOrDefault(db, options);
-    return settings.invoicingMode;
-}
 export function computeBookingItemTaxLine(taxRate, amountCents, currency, sortOrder = 0) {
     if (!taxRate || taxRate.rate <= 0 || amountCents <= 0)
         return null;

package/dist/index.d.ts

@@ -26,7 +26,7 @@ export declare const createFinanceVoyantRuntime: import("@voyant-travel/core/pro
 export type { PaymentAdapter, PaymentAdapterCapabilities, PaymentAdapterConformanceHarness, PaymentAdapterConformanceResult, PaymentAdapterDiagnostics, PaymentAdapterRuntimeContext, PaymentCallbackEvent, PaymentCallbackRequest, PaymentCallbackVerificationResult, PaymentInitiationInput, PaymentInitiationResult, PaymentMoney, PaymentOperationInput, PaymentOperationResult, PaymentStatusInput, PaymentStatusResult, } from "@voyant-travel/payments";
 export { PAYMENT_ADAPTER_CONTRACT_VERSION, PAYMENT_ADAPTER_RUNTIME_PORT_ID, paymentAdapterRuntimePort, runPaymentAdapterConformance, } from "@voyant-travel/payments";
 export { type BookingCancellationSettlementInput, buildPaidBookingCancellationSettlementNote, closeTerminalBookingPaymentSchedules, financeBookingLifecycle, recordPaidBookingCancellationSettlement, } from "./booking-lifecycle.js";
-export { type BookingTaxRouteOptions, type BookingTaxSettings, computeBookingItemTaxLine, createBookingTaxApiExtension, createBookingTaxRoutes, createBookingTaxVoyantRuntime, type InvoicingMode, loadProductTaxFacts, matchesTaxPolicyCondition, mountBookingTaxRoutes, type ProductTaxFacts, type ResolveBookingSellTaxRateOptions, type ResolveBookingTaxSettings, type ResolvedBookingSellTaxRate, resolveBookingSellTaxRate, type TaxPolicyCondition, type UpdateBookingTaxSettings, } from "./booking-tax.js";
+export { type BookingTaxRouteOptions, type BookingTaxSettings, computeBookingItemTaxLine, createBookingTaxApiExtension, createBookingTaxRoutes, createBookingTaxVoyantRuntime, loadProductTaxFacts, matchesTaxPolicyCondition, mountBookingTaxRoutes, type ProductTaxFacts, type ResolveBookingSellTaxRateOptions, type ResolveBookingTaxSettings, type ResolvedBookingSellTaxRate, resolveBookingSellTaxRate, type TaxPolicyCondition, type UpdateBookingTaxSettings, } from "./booking-tax.js";
 export type { CardPaymentBilling, CardPaymentStartArgs, CardPaymentStarter, CardPaymentStartResult, PaymentAdapterCardPaymentStarterOptions, } from "./card-payment.js";
 export { createPaymentAdapterCardPaymentStarter } from "./card-payment.js";
 export { type DocumentDownloadEnvelope, type DocumentDownloadResolution, type DocumentDownloadResolver, resolveStoredDocumentDownload, type StoredDocumentReference, } from "./document-download.js";

package/dist/payment-schedule/routes.js

@@ -385,11 +385,9 @@ export const createBookingScheduleVoyantRuntime = defineGraphRuntimeFactory(asyn
                     resolveRoutesOptions: () => provider.options,
                     withDb: provider.withDb,
                 });
-                // Same host/settings wiring powers the proforma-conversion
-                // subscriber: it reads the operator invoicing mode and, in
-                // proforma-first mode, mints the fiscal invoice on settlement.
+                // Same host wiring powers the proforma-conversion subscriber:
+                // when a fully-paid proforma settles it mints the fiscal invoice.
                 container.register(PROFORMA_CONVERSION_SUBSCRIBER_RUNTIME_KEY, {
-                    resolveInvoicingMode: operatorSettings.resolveInvoicingMode,
                     withDb: provider.withDb,
                     eventBus,
                 });

package/dist/proforma-conversion-runtime.d.ts

@@ -1,26 +1,29 @@
 import type { EventBus, SubscriberRuntimeDescriptor } from "@voyant-travel/core";
 import type { PostgresJsDatabase } from "drizzle-orm/postgres-js";
-import type { InvoicingMode } from "./booking-tax.js";
 /**
  * Standard proforma → fiscal invoice conversion.
  *
- * When the operator runs `invoicing.mode: "proforma-first"`, a proforma
- * is issued at checkout and the fiscal invoice is minted once the
- * proforma is fully settled. This subscriber watches settlement signals
- * (`invoice.settled` from the settlement poller and
- * `invoice.payment.recorded` from manual/processed payments) and, in
- * proforma-first mode only, converts a fully-paid proforma to its fiscal
- * invoice via {@link convertProformaToInvoice} (which copies lines,
- * assigns the fiscal number, links both documents, and voids the
- * proforma). `direct` mode is a no-op — zero behaviour change for
- * existing deployments — and the conversion is idempotent (the service
- * guards against double-conversion under an advisory lock).
+ * A proforma is issued for deferred (bank-transfer) checkouts when the
+ * operator runs the `proforma-first` invoicing mode, or by the manual
+ * `POST /invoices/{id}/convert-to-invoice` flow. This subscriber watches
+ * settlement signals (`invoice.settled` from the settlement poller and
+ * `invoice.payment.recorded` from manual/processed payments) and converts
+ * a fully-paid proforma to its fiscal invoice via
+ * {@link convertProformaToInvoice} (which copies lines, assigns the fiscal
+ * number, links both documents, and voids the proforma).
+ *
+ * The conversion is not gated on the invoicing mode: any fully-paid
+ * proforma should mint its fiscal invoice, and the `invoiceType ===
+ * "proforma"` guard already scopes it to proformas. Gating on the current
+ * mode would strand a proforma that is still outstanding when an operator
+ * switches from `proforma-first` to `direct`. When no proforma exists
+ * (card checkouts, or bank transfer in `direct` mode) the subscriber
+ * simply never fires. The conversion is idempotent (the service guards
+ * against double-conversion under an advisory lock).
  */
 export declare const FINANCE_PROFORMA_CONVERSION_SUBSCRIBER_ID = "@voyant-travel/finance#subscriber.proforma-conversion";
 export declare const PROFORMA_CONVERSION_SUBSCRIBER_RUNTIME_KEY = "finance.proformaConversionSubscriberRuntime";
 export interface ProformaConversionSubscriberRuntime {
-    /** Operator invoicing mode; defaults to `direct` when unconfigured. */
-    resolveInvoicingMode(db: PostgresJsDatabase): Promise<InvoicingMode>;
     /** Resolve the deployment database and retain ownership of its lifecycle. */
     withDb<T>(bindings: unknown, operation: (db: PostgresJsDatabase) => Promise<T>): Promise<T>;
     /** Event bus used to re-emit conversion events for downstream plugins. */

package/dist/proforma-conversion-runtime.js

@@ -3,17 +3,23 @@ import { convertProformaToInvoice } from "./service-issue.js";
 /**
  * Standard proforma → fiscal invoice conversion.
  *
- * When the operator runs `invoicing.mode: "proforma-first"`, a proforma
- * is issued at checkout and the fiscal invoice is minted once the
- * proforma is fully settled. This subscriber watches settlement signals
- * (`invoice.settled` from the settlement poller and
- * `invoice.payment.recorded` from manual/processed payments) and, in
- * proforma-first mode only, converts a fully-paid proforma to its fiscal
- * invoice via {@link convertProformaToInvoice} (which copies lines,
- * assigns the fiscal number, links both documents, and voids the
- * proforma). `direct` mode is a no-op — zero behaviour change for
- * existing deployments — and the conversion is idempotent (the service
- * guards against double-conversion under an advisory lock).
+ * A proforma is issued for deferred (bank-transfer) checkouts when the
+ * operator runs the `proforma-first` invoicing mode, or by the manual
+ * `POST /invoices/{id}/convert-to-invoice` flow. This subscriber watches
+ * settlement signals (`invoice.settled` from the settlement poller and
+ * `invoice.payment.recorded` from manual/processed payments) and converts
+ * a fully-paid proforma to its fiscal invoice via
+ * {@link convertProformaToInvoice} (which copies lines, assigns the fiscal
+ * number, links both documents, and voids the proforma).
+ *
+ * The conversion is not gated on the invoicing mode: any fully-paid
+ * proforma should mint its fiscal invoice, and the `invoiceType ===
+ * "proforma"` guard already scopes it to proformas. Gating on the current
+ * mode would strand a proforma that is still outstanding when an operator
+ * switches from `proforma-first` to `direct`. When no proforma exists
+ * (card checkouts, or bank transfer in `direct` mode) the subscriber
+ * simply never fires. The conversion is idempotent (the service guards
+ * against double-conversion under an advisory lock).
  */
 export const FINANCE_PROFORMA_CONVERSION_SUBSCRIBER_ID = "@voyant-travel/finance#subscriber.proforma-conversion";
 export const PROFORMA_CONVERSION_SUBSCRIBER_RUNTIME_KEY = "finance.proformaConversionSubscriberRuntime";
@@ -26,15 +32,13 @@ export function createProformaConversionSubscriberRuntime(dependencies = {}) {
         eventType: "invoice.settled",
         register: ({ bindings, container, eventBus }) => {
             const handler = async ({ data }) => {
-                // Runtime is only registered when the operator-settings port is
-                // available. Absent → treat as `direct` mode → no-op.
+                // Runtime is registered by the finance booking-schedule host wiring.
+                // Absent → the deployment did not mount finance settlement → no-op.
                 if (!container.has(PROFORMA_CONVERSION_SUBSCRIBER_RUNTIME_KEY))
                     return;
                 const runtime = resolveProformaConversionSubscriberRuntime(container);
                 try {
                     await runtime.withDb(bindings, async (db) => {
-                        if ((await runtime.resolveInvoicingMode(db)) !== "proforma-first")
-                            return;
                         const invoice = await financeService.getInvoiceById(db, data.invoiceId);
                         if (!invoice)
                             return;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@voyant-travel/finance",
-  "version": "0.166.0",
+  "version": "0.167.0",
   "license": "Apache-2.0",
   "type": "module",
   "exports": {
@@ -151,17 +151,17 @@
     "hono": "^4.12.27",
     "zod": "^4.4.3",
     "@voyant-travel/action-ledger": "^0.111.1",
+    "@voyant-travel/bookings": "^0.167.0",
+    "@voyant-travel/core": "^0.125.0",
     "@voyant-travel/db": "^0.114.10",
     "@voyant-travel/types": "^0.109.3",
-    "@voyant-travel/bookings": "^0.166.0",
+    "@voyant-travel/finance-contracts": "^0.106.2",
     "@voyant-travel/hono": "^0.128.1",
-    "@voyant-travel/core": "^0.125.0",
-    "@voyant-travel/storage": "^0.111.1",
-    "@voyant-travel/payments": "^0.2.0",
-    "@voyant-travel/tools": "^0.3.0",
+    "@voyant-travel/payments": "^0.2.1",
     "@voyant-travel/public-document-delivery": "^0.4.1",
-    "@voyant-travel/finance-contracts": "^0.106.2",
-    "@voyant-travel/utils": "^0.107.1"
+    "@voyant-travel/storage": "^0.111.1",
+    "@voyant-travel/utils": "^0.107.1",
+    "@voyant-travel/tools": "^0.3.0"
   },
   "devDependencies": {
     "drizzle-kit": "^0.31.10",