@voxgig/sdkgen 4.5.3 → 4.6.0

package/project/.sdk/tm/go/test/struct_runner_test.go

@@ -33,7 +33,7 @@ type StructUtility struct {
 	IsNode     func(val any) bool
 	Clone      func(val any) any
 	CloneFlags func(val any, flags map[string]bool) any
-	GetPath    func(path any, store any, injdefs ...*voxgigstruct.Injection) any
+	GetPath    func(store any, path any, injdefs ...*voxgigstruct.Injection) any
 	Inject     func(val any, store any, injdefs ...*voxgigstruct.Injection) any
 	Items      func(val any) [][2]any
 	Stringify  func(val any, maxlen ...int) string
@@ -65,7 +65,7 @@ type StructUtility struct {
 	Size       func(val any) int
 	Slice      func(val any, args ...any) any
 	StrKey     func(key any) string
-	Transform  func(data any, spec any, injdefs ...*voxgigstruct.Injection) any
+	Transform  func(data any, spec any, injdefs ...*voxgigstruct.Injection) (any, error)
 	Typify     func(value any) int
 	Typename   func(t int) string
 	Validate   func(data any, spec any, injdefs ...*voxgigstruct.Injection) (any, error)
@@ -73,8 +73,8 @@ type StructUtility struct {
 	SKIP   any
 	DELETE any
 
-	Jo func(kv ...any) map[string]any
-	Ja func(v ...any) []any
+	Jm func(kv ...any) map[string]any
+	Jt func(v ...any) []any
 
 	CheckPlacement func(modes int, ijname string, parentTypes int, inj *voxgigstruct.Injection) bool
 	InjectorArgs   func(argTypes []int, args []any) []any
@@ -681,7 +681,7 @@ func MatchNode(
 			scalar := !structUtil.IsNode(val)
 
 			if scalar {
-				baseval := structUtil.GetPath(path, base)
+				baseval := structUtil.GetPath(base, path)
 				if !MatchScalar(val, baseval, structUtil) {
 					pass = false
 					err = fmt.Errorf(
@@ -1058,8 +1058,8 @@ func NewStructSDK(opts map[string]any) *StructSDK {
 		SKIP:   voxgigstruct.SKIP,
 		DELETE: voxgigstruct.DELETE,
 
-		Jo: voxgigstruct.Jo,
-		Ja: voxgigstruct.Ja,
+		Jm: voxgigstruct.Jm,
+		Jt: voxgigstruct.Jt,
 
 		CheckPlacement: voxgigstruct.CheckPlacement,
 		InjectorArgs:   voxgigstruct.InjectorArgs,

package/project/.sdk/tm/go/test/struct_utility_test.go

@@ -159,20 +159,44 @@ func TestStructUtility(t *testing.T) {
 	})
 
 	t.Run("minor-escurl", func(t *testing.T) {
-		structRunSet(t, minorSpec["escurl"], func(in string) string {
-			return strings.ReplaceAll(voxgigstruct.EscUrl(fmt.Sprint(in)), "+", "%20")
-		})
+		// Passed BARE, like every other minor subject. This used to wrap
+		// EscUrl in ReplaceAll(..., "+", "%20") because the vendored copy
+		// implemented it with net/url.QueryEscape, which form-encodes: a
+		// space became '+' rather than '%20'. The workaround made the
+		// shared corpus pass while make_url.go still emitted '+' into real
+		// paths and query strings. Upstream's EscUrl matches the reference
+		// encodeURIComponent exactly, so there is nothing left to paper over.
+		structRunSet(t, minorSpec["escurl"], voxgigstruct.EscUrl)
 	})
 
 	t.Run("minor-stringify", func(t *testing.T) {
 		structRunSet(t, minorSpec["stringify"], func(v any) any {
 			m := v.(map[string]any)
-			val := m["val"]
+			val, hasVal := m["val"]
 
 			if "__NULL__" == val {
 				val = "null"
 			}
 
+			// Go has no `undefined`. Upstream Stringify renders nil as
+			// "null" ON PURPOSE - in Go nil IS JSON null, and
+			// JSON.stringify(null) is "null" - so the corpus's two
+			// separate cases,
+			//
+			//   {"val": null} -> "null"      and      {} -> ""
+			//
+			// both arrive here as a nil val and cannot be told apart by
+			// VALUE. They can be told apart by PRESENCE: the second case
+			// is the JavaScript stringify(undefined), and an absent key
+			// is the only thing Go has that means undefined.
+			//
+			// The runner is the right place for this: it is the seam
+			// between a language-neutral corpus and one language's type
+			// system, and it already bridges the same gap for pathify.
+			if !hasVal {
+				return ""
+			}
+
 			max, hasMax := m["max"]
 			if !hasMax || nil == max {
 				return voxgigstruct.Stringify(val)
@@ -585,9 +609,21 @@ func TestStructUtility(t *testing.T) {
 			} else {
 				ks = *k
 			}
+
+			// The ROOT node has no parent. The reference passes
+			// `undefined` there and logs `p=`; Go has only nil, which
+			// Stringify renders as "null" (its documented choice - see
+			// minor-stringify above). Rendering the absent parent as ""
+			// keeps the log identical to the reference's, which is what
+			// the corpus records.
+			ps := ""
+			if nil != p {
+				ps = voxgigstruct.Stringify(p)
+			}
+
 			entry := "k=" + voxgigstruct.Stringify(ks) +
 				", v=" + voxgigstruct.Stringify(v) +
-				", p=" + voxgigstruct.Stringify(p) +
+				", p=" + ps +
 				", t=" + voxgigstruct.Pathify(t)
 			return entry
 		}
@@ -840,7 +876,7 @@ func TestStructUtility(t *testing.T) {
 			path := m["path"]
 			store := m["store"]
 
-			return voxgigstruct.GetPath(path, store)
+			return voxgigstruct.GetPath(store, path)
 		})
 	})
 
@@ -862,7 +898,7 @@ func TestStructUtility(t *testing.T) {
 				Dpath:   dpath,
 			}
 
-			return voxgigstruct.GetPath(path, store, inj)
+			return voxgigstruct.GetPath(store, path, inj)
 		})
 	})
 
@@ -884,10 +920,10 @@ func TestStructUtility(t *testing.T) {
 						inj.Meta = metaMap
 					}
 				}
-				return voxgigstruct.GetPath(path, store, inj)
+				return voxgigstruct.GetPath(store, path, inj)
 			}
 
-			return voxgigstruct.GetPath(path, store)
+			return voxgigstruct.GetPath(store, path)
 		})
 	})
 
@@ -947,14 +983,14 @@ func TestStructUtility(t *testing.T) {
 		data := inVal["data"]
 		spec := inVal["spec"]
 		outVal := subtest["out"]
-		result := voxgigstruct.Transform(data, spec)
+		result, _ := voxgigstruct.Transform(data, spec)
 		if !reflect.DeepEqual(result, outVal) {
 			t.Errorf("Expected: %v, Got: %v", outVal, result)
 		}
 	})
 
 	t.Run("transform-paths", func(t *testing.T) {
-		structRunSet(t, transformSpec["paths"], func(v any) any {
+		structRunSet(t, transformSpec["paths"], func(v any) (any, error) {
 			m := v.(map[string]any)
 			data := m["data"]
 			spec := m["spec"]
@@ -963,7 +999,7 @@ func TestStructUtility(t *testing.T) {
 	})
 
 	t.Run("transform-cmds", func(t *testing.T) {
-		structRunSet(t, transformSpec["cmds"], func(v any) any {
+		structRunSet(t, transformSpec["cmds"], func(v any) (any, error) {
 			m := v.(map[string]any)
 			data := m["data"]
 			spec := m["spec"]
@@ -972,7 +1008,7 @@ func TestStructUtility(t *testing.T) {
 	})
 
 	t.Run("transform-each", func(t *testing.T) {
-		structRunSet(t, transformSpec["each"], func(v any) any {
+		structRunSet(t, transformSpec["each"], func(v any) (any, error) {
 			m := v.(map[string]any)
 			data := m["data"]
 			spec := m["spec"]
@@ -981,7 +1017,7 @@ func TestStructUtility(t *testing.T) {
 	})
 
 	t.Run("transform-pack", func(t *testing.T) {
-		structRunSet(t, transformSpec["pack"], func(v any) any {
+		structRunSet(t, transformSpec["pack"], func(v any) (any, error) {
 			m := v.(map[string]any)
 			data := m["data"]
 			spec := m["spec"]
@@ -990,7 +1026,7 @@ func TestStructUtility(t *testing.T) {
 	})
 
 	t.Run("transform-ref", func(t *testing.T) {
-		structRunSet(t, transformSpec["ref"], func(v any) any {
+		structRunSet(t, transformSpec["ref"], func(v any) (any, error) {
 			m := v.(map[string]any)
 			data := m["data"]
 			spec := m["spec"]
@@ -999,7 +1035,7 @@ func TestStructUtility(t *testing.T) {
 	})
 
 	t.Run("transform-format", func(t *testing.T) {
-		structRunSetFlags(t, transformSpec["format"], map[string]bool{"null": false}, func(v any) any {
+		structRunSetFlags(t, transformSpec["format"], map[string]bool{"null": false}, func(v any) (any, error) {
 			m := v.(map[string]any)
 			data := m["data"]
 			spec := m["spec"]
@@ -1021,7 +1057,7 @@ func TestStructUtility(t *testing.T) {
 	})
 
 	t.Run("transform-edge-apply", func(t *testing.T) {
-		result := voxgigstruct.Transform(
+		result, _ := voxgigstruct.Transform(
 			map[string]any{},
 			[]any{"`$APPLY`", func(v any) any { return 1 + v.(int) }, 1},
 		)
@@ -1105,25 +1141,25 @@ func TestStructUtility(t *testing.T) {
 	t.Run("transform-funcval", func(t *testing.T) {
 		f0 := func() int { return 22 }
 
-		result1 := voxgigstruct.Transform(map[string]any{}, map[string]any{"x": 1})
+		result1, _ := voxgigstruct.Transform(map[string]any{}, map[string]any{"x": 1})
 		expected1 := map[string]any{"x": 1}
 		if !reflect.DeepEqual(expected1, result1) {
 			t.Errorf("Expected simple value transform result")
 		}
 
-		result2 := voxgigstruct.Transform(map[string]any{}, map[string]any{"x": f0})
+		result2, _ := voxgigstruct.Transform(map[string]any{}, map[string]any{"x": f0})
 		var fr0 = result2.(map[string]any)["x"].(func() int)
 		if f0() != fr0() {
 			t.Errorf("Expected x to be f0")
 		}
 
-		result3 := voxgigstruct.Transform(map[string]any{"a": 1}, map[string]any{"x": "`a`"})
+		result3, _ := voxgigstruct.Transform(map[string]any{"a": 1}, map[string]any{"x": "`a`"})
 		expected3 := map[string]any{"x": 1}
 		if !reflect.DeepEqual(expected3, result3) {
 			t.Errorf("Expected value lookup transform to work")
 		}
 
-		result4 := voxgigstruct.Transform(map[string]any{"f0": f0}, map[string]any{"x": "`f0`"})
+		result4, _ := voxgigstruct.Transform(map[string]any{"f0": f0}, map[string]any{"x": "`f0`"})
 		var fr4 = result4.(map[string]any)["x"].(func() int)
 		if 22 != fr4() {
 			t.Errorf("Expected function to be preserved")
@@ -1347,22 +1383,22 @@ func TestStructUtility(t *testing.T) {
 
 	t.Run("json-builder", func(t *testing.T) {
 		expected0 := "{\n  \"a\": 1\n}"
-		result0 := voxgigstruct.Jsonify(voxgigstruct.Jo("a", 1))
+		result0 := voxgigstruct.Jsonify(voxgigstruct.Jm("a", 1))
 		if result0 != expected0 {
 			t.Errorf("Expected: %v, Got: %v", expected0, result0)
 		}
 
 		expected1 := "[\n  \"b\",\n  2\n]"
-		result1 := voxgigstruct.Jsonify(voxgigstruct.Ja("b", 2))
+		result1 := voxgigstruct.Jsonify(voxgigstruct.Jt("b", 2))
 		if result1 != expected1 {
 			t.Errorf("Expected: %v, Got: %v", expected1, result1)
 		}
 
 		expected2 := "{\n  \"c\": \"C\",\n  \"d\": {\n    \"x\": true\n  },\n  \"e\": [\n    null,\n    false\n  ]\n}"
-		result2 := voxgigstruct.Jsonify(voxgigstruct.Jo(
+		result2 := voxgigstruct.Jsonify(voxgigstruct.Jm(
 			"c", "C",
-			"d", voxgigstruct.Jo("x", true),
-			"e", voxgigstruct.Ja(nil, false),
+			"d", voxgigstruct.Jm("x", true),
+			"e", voxgigstruct.Jt(nil, false),
 		))
 		if result2 != expected2 {
 			t.Errorf("Expected:\n%v\nGot:\n%v", expected2, result2)
@@ -1397,7 +1433,7 @@ func TestStructUtility(t *testing.T) {
 				},
 			}
 
-			return voxgigstruct.GetPath(path, store, inj)
+			return voxgigstruct.GetPath(store, path, inj)
 		})
 	})
 }

package/project/.sdk/tm/go/utility/fetcher.go

@@ -118,13 +118,13 @@ func fetcherUtil(ctx *core.Context, fullurl string, fetchdef map[string]any) (an
 	}
 
 	options := ctx.Client.OptionsMap()
-	if vs.GetPath([]any{"feature", "test", "active"}, options) == true {
+	if vs.GetPath(options, []any{"feature", "test", "active"}) == true {
 		return nil, ctx.MakeError("fetch_test_block",
 			"Request blocked as test feature is active"+
 				" (URL was: \""+fullurl+"\")")
 	}
 
-	sysFetch := vs.GetPath([]any{"system", "fetch"}, options)
+	sysFetch := vs.GetPath(options, []any{"system", "fetch"})
 
 	if sysFetch == nil {
 		return defaultHTTPFetch(fullurl, fetchdef)

package/project/.sdk/tm/go/utility/make_options.go

@@ -36,6 +36,20 @@ func makeOptionsUtil(ctx *core.Context) map[string]any {
 		}
 	}
 
+	// `auth: nil` is the documented way to disable auth outright, and
+	// prepareAuth honours it before it ever reads the apikey. But validate
+	// treats a stored nil as "no value", so the optspec's `auth` default
+	// fires and the suppression silently becomes "use default auth" —
+	// transmitting a credential the caller explicitly asked not to send.
+	//
+	// Suppliedness cannot be recovered after validate, hence here. The
+	// two-value form is required: options["auth"] reads nil both when the
+	// key is ABSENT and when it is present and nil, and only the second is
+	// a suppression. (ts gets this for free — `null === options.auth` is
+	// false for an omitted key, since that reads undefined.)
+	authval, authgiven := options["auth"]
+	authsuppressed := authgiven && authval == nil
+
 	opts := vs.Clone(options).(map[string]any)
 
 	// Feature add-order (feature #2). options.feature may be given as an ordered
@@ -129,7 +143,7 @@ func makeOptionsUtil(ctx *core.Context) map[string]any {
 
 	// Preserve system.fetch before merge/validate.
 	var sysFetch any
-	if sf := vs.GetPath([]any{"system", "fetch"}, opts); sf != nil {
+	if sf := vs.GetPath(opts, []any{"system", "fetch"}); sf != nil {
 		sysFetch = sf
 	}
 
@@ -141,6 +155,11 @@ func makeOptionsUtil(ctx *core.Context) map[string]any {
 	validated, _ := vs.Validate(merged, optspec)
 	opts = validated.(map[string]any)
 
+	// Restore the suppression the optspec default would otherwise erase.
+	if authsuppressed {
+		opts["auth"] = nil
+	}
+
 	// Resolve a templated base URL (e.g. https://{tenant_id}.hanko.io).
 	// Every placeholder must resolve to a non-empty value: from
 	// options["server"] (user), else the config default. A placeholder that
@@ -151,15 +170,15 @@ func makeOptionsUtil(ctx *core.Context) map[string]any {
 	// PANICS (construction-time misconfiguration, as regexp.MustCompile).
 	if base, ok := opts["base"].(string); ok && strings.Contains(base, "{") {
 		testmode := false
-		if ta, ok := vs.GetPath([]any{"test", "active"}, opts).(bool); ok && ta {
+		if ta, ok := vs.GetPath(opts, []any{"test", "active"}).(bool); ok && ta {
 			testmode = true
 		}
-		if fa, ok := vs.GetPath([]any{"feature", "test", "active"}, opts).(bool); ok && fa {
+		if fa, ok := vs.GetPath(opts, []any{"feature", "test", "active"}).(bool); ok && fa {
 			testmode = true
 		}
 		server := core.ToMapAny(opts["server"])
 		sdkname := "SDK"
-		if mn, ok := vs.GetPath([]any{"main", "name"}, config).(string); ok && mn != "" {
+		if mn, ok := vs.GetPath(config, []any{"main", "name"}).(string); ok && mn != "" {
 			sdkname = mn
 		}
 		resolved := serverVarRe.ReplaceAllStringFunc(base, func(ph string) string {
@@ -191,7 +210,7 @@ func makeOptionsUtil(ctx *core.Context) map[string]any {
 
 	// Derived clean config.
 	cleanKeys := "key,token,id"
-	if ck := vs.GetPath([]any{"clean", "keys"}, opts); ck != nil {
+	if ck := vs.GetPath(opts, []any{"clean", "keys"}); ck != nil {
 		if cks, ok := ck.(string); ok {
 			cleanKeys = cks
 		}

package/project/.sdk/tm/go/utility/make_point.go

@@ -66,7 +66,7 @@ func makePointUtil(ctx *core.Context) (map[string]any, error) {
 	op := ctx.Op
 	options := ctx.Options
 
-	allowOp, _ := vs.GetPath([]any{"allow", "op"}, options).(string)
+	allowOp, _ := vs.GetPath(options, []any{"allow", "op"}).(string)
 	if !strings.Contains(allowOp, op.Name) {
 		return nil, ctx.MakeError("point_op_allow",
 			"Operation \""+op.Name+

package/project/.sdk/tm/go/utility/make_spec.go

@@ -41,7 +41,7 @@ func makeSpecUtil(ctx *core.Context) (*core.Spec, error) {
 
 	ctx.Spec.Method = utility.PrepareMethod(ctx)
 
-	allowMethod, _ := vs.GetPath([]any{"allow", "method"}, options).(string)
+	allowMethod, _ := vs.GetPath(options, []any{"allow", "method"}).(string)
 	if !strings.Contains(allowMethod, ctx.Spec.Method) {
 		return nil, ctx.MakeError("spec_method_allow",
 			"Method \""+ctx.Spec.Method+
@@ -68,6 +68,22 @@ func makeSpecUtil(ctx *core.Context) (*core.Spec, error) {
 		ctx.Spec.Headers["content-type"] = GraphqlContentType
 	} else {
 		ctx.Spec.Body = utility.PrepareBody(ctx)
+
+		// A failed request transform has nowhere else to report: the
+		// PrepareBody seam returns a plain value, and go's makeError RETURNS
+		// the error where the TS reference THROWS it, unwinding the operation
+		// from inside transformRequest. So the abort lands here. Without it
+		// the error object travels on as the request body and the call still
+		// goes out — a 200 would then make a failed transform look like a
+		// successful operation.
+		//
+		// Only the throwing path produces an error value: with ctrl.throw
+		// false, makeError hands back result.Resdata instead, and the
+		// pipeline continues, exactly as it does in ts.
+		if berr, isErr := ctx.Spec.Body.(error); isErr {
+			return nil, berr
+		}
+
 		ctx.Spec.Path = utility.PreparePath(ctx)
 	}
 

package/project/.sdk/tm/go/utility/prepare_auth.go

@@ -40,7 +40,7 @@ func prepareAuthUtil(ctx *core.Context) (*core.Spec, error) {
 		delete(headers, headerAuth)
 	} else {
 		authPrefix := ""
-		if ap := vs.GetPath([]any{"auth", "prefix"}, options); ap != nil {
+		if ap := vs.GetPath(options, []any{"auth", "prefix"}); ap != nil {
 			authPrefix, _ = ap.(string)
 		}
 		apikeyVal := ""