@voxgig/sdkgen 0.36.0 → 0.38.1

package/project/.sdk/src/cmp/js/TestDirect_js.ts

@@ -1,6 +1,7 @@
 
 import {
   nom,
+  depluralize,
 } from '@voxgig/apidef'
 
 
@@ -11,6 +12,7 @@ import {
   Fragment,
   Slot,
   cmp,
+  snakify,
 } from '@voxgig/sdkgen'
 
 
@@ -121,20 +123,20 @@ function directSetup(mockres) {
 
 function generateDirectLoad(model: any, entity: any) {
   const loadOp = entity.op.load
-  const loadPoint = loadOp.points[0]
+  const loadPoint = loadOp?.points?.[0]
 
   if (null == loadPoint) {
     return
   }
 
-  const loadPath = (loadPoint.parts || []).join('/')
   const loadParams = loadPoint.args?.params || []
+  const loadPath = normalizePathParams(loadPoint.parts || [], loadParams, loadPoint.rename?.param)
 
   // Get list info for live mode bootstrapping
   const listOp = entity.op.list
   const listPoint = listOp?.points?.[0]
-  const listPath = listPoint ? (listPoint.parts || []).join('/') : ''
   const listParams = listPoint?.args?.params || []
+  const listPath = listPoint ? normalizePathParams(listPoint.parts || [], listParams, listPoint.rename?.param) : ''
   const hasList = null != listPoint
 
   // Ancestor params (not 'id') for live mode
@@ -218,14 +220,14 @@ ${paramAsserts}    }
 
 function generateDirectList(model: any, entity: any) {
   const listOp = entity.op.list
-  const listPoint = listOp.points[0]
+  const listPoint = listOp?.points?.[0]
 
   if (null == listPoint) {
     return
   }
 
-  const listPath = (listPoint.parts || []).join('/')
   const listParams = listPoint.args?.params || []
+  const listPath = normalizePathParams(listPoint.parts || [], listParams, listPoint.rename?.param)
 
   // Build live params
   const liveParams = listParams.map((p: any) => {
@@ -283,6 +285,52 @@ ${paramAsserts}    }
 }
 
 
+// Replace raw OpenAPI parameter names in path parts with model parameter names.
+// Path parts may have e.g. {subBreed} while model params use sub_breed.
+// When a rename mapping exists (e.g. closureId -> id), path parts contain the
+// renamed form {id} but params still use the original name closure_id.
+// The rename mapping is used to reverse-lookup the original param name.
+function normalizePathParams(
+  parts: string[],
+  params: any[],
+  rename?: Record<string, string>
+): string {
+  return parts.map((part: string) => {
+    // Replace each {paramName} occurrence within the part.
+    // Handles both simple parts like "{id}" and compound parts like
+    // "{outputFields}.{format}" that contain multiple parameters.
+    return part.replace(/\{([^}]+)\}/g, (match: string, rawName: string) => {
+      const snaked = snakify(rawName)
+      const depluralized = depluralize(snaked)
+      const param = params.find((p: any) =>
+        p.orig === snaked || p.name === snaked ||
+        p.orig === depluralized || p.name === depluralized
+      )
+      if (param) return '{' + param.name + '}'
+
+      // Reverse-lookup through rename mapping: if rawName is a renamed value
+      // (e.g. "id"), find the original camelCase key (e.g. "closureId"),
+      // snakify+depluralize it (e.g. "closure_id"), and match against params.
+      if (rename) {
+        for (const [origCamel, renamedTo] of Object.entries(rename)) {
+          if (renamedTo === rawName) {
+            const origSnaked = snakify(origCamel)
+            const origDepluralized = depluralize(origSnaked)
+            const renamedParam = params.find(
+              (p: any) => p.orig === origSnaked || p.name === origSnaked ||
+                p.orig === origDepluralized || p.name === origDepluralized
+            )
+            if (renamedParam) return '{' + renamedParam.name + '}'
+          }
+        }
+      }
+
+      return match
+    })
+  }).join('/')
+}
+
+
 export {
   TestDirect
 }

package/project/.sdk/src/cmp/js/TestEntity_js.ts

@@ -37,7 +37,7 @@ import {
 } from './utility_js'
 
 
-type OpGen = (model: any, entity: any, flow: any, step: any, index: any) => void
+type OpGen = (model: any, entity: any, flow: any, step: any, index: { key$: number, val$: any }) => void
 
 
 const TestEntity = cmp(function TestEntity(props: any) {
@@ -78,9 +78,9 @@ const TestEntity = cmp(function TestEntity(props: any) {
         const indent = 2
 
         const idlist = flatten([
-          '${entity.name}01',
-          '${entity.name}02',
-          '${entity.name}03',
+          entity.name + '01',
+          entity.name + '02',
+          entity.name + '03',
           flatten(items(entity.relations.ancestors, (ap: any) =>
             items(ap[1], (a: any) =>
               items(['01', '02', '03'], (n: any) =>
@@ -156,6 +156,10 @@ function basicSetup(extra) {
 
 
         Slot({ name: 'basic' }, () => {
+          const flowHasCreate = Object.values(basicflow.step).some(
+            (s: any) => s.op === 'create'
+          )
+
           Content(`
     const setup = basicSetup()
     const client = setup.client
@@ -166,6 +170,15 @@ function basicSetup(extra) {
 
 `)
 
+          // When the flow has no create step, bootstrap the entity data variable
+          // from existing test data so that subsequent update/load/remove steps
+          // can reference it.
+          if (!flowHasCreate) {
+            const ref01 = entity.name + '_ref01'
+            Content(`    let ${ref01}_data = Object.values(setup.data.existing.${entity.name})[0]
+`)
+          }
+
           each(basicflow.step, (step: any, index: any) => {
             const opgen: OpGen = GENERATE_OP[step.op]
             opgen(model, entity, basicflow, step, index)
@@ -183,17 +196,39 @@ const generateCreate: OpGen = (
   entity: ModelEntity,
   flow: ModelEntityFlow,
   step: ModelEntityFlowStep,
-  index: number
+  index: any
 ) => {
   const ref = step.input.ref ?? entity.name + '_ref01'
   const entvar = step.input.entvar ?? ref + '_ent'
   const datavar = step.input.datavar ?? (ref + '_data' + (step.input.suffix ?? ''))
 
+  const priorSteps = Object.values(flow.step).slice(0, Number(index))
+  const needsEnt = !priorSteps.some((s: any) =>
+    ['create', 'list', 'load', 'update', 'remove'].includes(s.op))
+
+  const hasDatvar = priorSteps.some((s: any) => {
+    if ('create' === s.op) {
+      const priorRef = s.input?.ref ?? entity.name + '_ref01'
+      const priorDatvar = s.input?.datavar ?? (priorRef + '_data' + (s.input?.suffix ?? ''))
+      return priorDatvar === datavar
+    }
+    return false
+  })
+
   Content(`
     // CREATE
-    const ${entvar} = client.${nom(entity, 'Name')}()
-    let ${datavar} = setup.data.new.${entity.name}['${ref}']
 `)
+  if (needsEnt) {
+    Content(`    const ${entvar} = client.${nom(entity, 'Name')}()
+`)
+  }
+  if (hasDatvar) {
+    Content(`    ${datavar} = setup.data.new.${entity.name}['${ref}']
+`)
+  } else {
+    Content(`    let ${datavar} = setup.data.new.${entity.name}['${ref}']
+`)
+  }
 
   each(step.match, (mi: any) => {
     Content(`    ${datavar}['${mi.key$}'] = setup.idmap['${mi.val$}']
@@ -212,16 +247,25 @@ const generateList: OpGen = (
   entity: ModelEntity,
   flow: ModelEntityFlow,
   step: ModelEntityFlowStep,
-  index: number
+  index: any
 ) => {
   const ref = step.input.ref ?? entity.name + '_ref01'
   const entvar = step.input.entvar ?? ref + '_ent'
   const matchvar = step.input.matchvar ?? (ref + '_match' + (step.input.suffix ?? ''))
   const listvar = step.input.listvar ?? (ref + '_list' + (step.input.suffix ?? ''))
 
+  const priorSteps = Object.values(flow.step).slice(0, Number(index))
+  const needsEnt = !priorSteps.some((s: any) =>
+    ['create', 'list', 'load', 'update', 'remove'].includes(s.op))
+
   Content(`
     // LIST
-    const ${matchvar} = {}
+`)
+  if (needsEnt) {
+    Content(`    const ${entvar} = client.${nom(entity, 'Name')}()
+`)
+  }
+  Content(`    const ${matchvar} = {}
 `)
 
   each(step.match, (mi: any) => {
@@ -232,16 +276,21 @@ const generateList: OpGen = (
   Content(`
     const ${listvar} = await ${entvar}.list(${matchvar})
 `)
+  const allSteps = Object.values(flow.step)
   for (let vI = 0; vI < step.valid.length; vI++) {
     const validator = step.valid[vI]
-    if ('ItemExists' === validator.apply) {
+    const validRef = validator.def?.ref
+    const hasRefData = validRef && allSteps.some((s: any) => 'create' === s.op &&
+      ((s.input?.ref ?? entity.name + '_ref01') === validRef))
+
+    if ('ItemExists' === validator.apply && hasRefData) {
       Content(`
-    assert(!isempty(select(${listvar}, { id: ${validator.def.ref}_data.id })))
+    assert(!isempty(select(${listvar}, { id: ${validRef}_data.id })))
 `)
     }
-    else if ('ItemNotExists' === validator.apply) {
+    else if ('ItemNotExists' === validator.apply && hasRefData) {
       Content(`
-    assert(isempty(select(${listvar}, { id: ${validator.def.ref}_data.id })))
+    assert(isempty(select(${listvar}, { id: ${validRef}_data.id })))
 `)
     }
   }
@@ -253,7 +302,7 @@ const generateUpdate: OpGen = (
   entity: ModelEntity,
   flow: ModelEntityFlow,
   step: ModelEntityFlowStep,
-  index: number
+  index: any
 ) => {
   const ref = step.input.ref ?? entity.name + '_ref01'
   const entvar = step.input.entvar ?? ref + '_ent'
@@ -262,9 +311,18 @@ const generateUpdate: OpGen = (
   const markdefvar = step.input.markdefvar ?? (ref + '_markdef' + (step.input.suffix ?? ''))
   const srcdatavar = step.input.srcdatavar ?? (ref + '_data' + (step.input.suffix ?? ''))
 
+  const priorSteps = Object.values(flow.step).slice(0, Number(index))
+  const needsEnt = !priorSteps.some((s: any) =>
+    ['create', 'list', 'load', 'update', 'remove'].includes(s.op))
+
   Content(`
     // UPDATE
-    const ${datavar} = {}
+`)
+  if (needsEnt) {
+    Content(`    const ${entvar} = client.${nom(entity, 'Name')}()
+`)
+  }
+  Content(`    const ${datavar} = {}
     ${datavar}.id = ${srcdatavar}.id
 `)
 
@@ -295,7 +353,7 @@ const generateUpdate: OpGen = (
 
   for (let sI = 0; sI < step.spec.length; sI++) {
     const spec = step.spec[sI]
-    if ('TextFieldMark' === spec.apply) {
+    if ('TextFieldMark' === spec.apply && null != step.input.textfield) {
       Content(`
     assert(${resdatavar}[${markdefvar}.name] === ${markdefvar}.value)
 `)
@@ -310,7 +368,7 @@ const generateLoad: OpGen = (
   entity: ModelEntity,
   flow: ModelEntityFlow,
   step: ModelEntityFlowStep,
-  index: number
+  index: any
 ) => {
   const ref = step.input.ref ?? entity.name + '_ref01'
   const entvar = step.input.entvar ?? ref + '_ent'
@@ -318,9 +376,36 @@ const generateLoad: OpGen = (
   const datavar = step.input.datavar ?? (ref + '_data' + (step.input.suffix ?? ''))
   const srcdatavar = step.input.srcdatavar ?? (ref + '_data' + (step.input.suffix ?? ''))
 
+  const priorSteps = Object.values(flow.step).slice(0, Number(index))
+  const hasEntVar = priorSteps.some((s: any) =>
+    ['create', 'list', 'load', 'update', 'remove'].includes(s.op))
+
+  // Check if srcdatavar was declared by a prior create step or by the
+  // preamble bootstrap (which runs when the flow has no create step)
+  const flowHasCreate = Object.values(flow.step).some((s: any) => s.op === 'create')
+  const preambleRef = entity.name + '_ref01'
+  const hasSrcData = (!flowHasCreate && srcdatavar === preambleRef + '_data') ||
+    priorSteps.some((s: any) => {
+      if ('create' === s.op) {
+        const priorRef = s.input?.ref ?? entity.name + '_ref01'
+        const priorDatvar = s.input?.datavar ?? (priorRef + '_data' + (s.input?.suffix ?? ''))
+        return priorDatvar === srcdatavar
+      }
+      return false
+    })
+
   Content(`
     // LOAD
-    const ${matchvar} = {}
+`)
+  if (!hasEntVar) {
+    Content(`    const ${entvar} = client.${nom(entity, 'Name')}()
+`)
+  }
+  if (!hasSrcData) {
+    Content(`    const ${srcdatavar} = Object.values(setup.data.existing.${entity.name})[0]
+`)
+  }
+  Content(`    const ${matchvar} = {}
     ${matchvar}.id = ${srcdatavar}.id
     const ${datavar} = await ${entvar}.load(${matchvar})
     assert(${datavar}.id === ${srcdatavar}.id)
@@ -333,16 +418,25 @@ const generateRemove: OpGen = (
   entity: ModelEntity,
   flow: ModelEntityFlow,
   step: ModelEntityFlowStep,
-  index: number
+  index: any
 ) => {
   const ref = step.input.ref ?? entity.name + '_ref01'
   const entvar = step.input.entvar ?? ref + '_ent'
   const matchvar = step.input.matchvar ?? (ref + '_match' + (step.input.suffix ?? ''))
   const srcdatavar = step.input.srcdatavar ?? (ref + '_data')
 
+  const priorSteps = Object.values(flow.step).slice(0, Number(index))
+  const needsEnt = !priorSteps.some((s: any) =>
+    ['create', 'list', 'load', 'update', 'remove'].includes(s.op))
+
   Content(`
     // REMOVE
-    const ${matchvar} = {}
+`)
+  if (needsEnt) {
+    Content(`    const ${entvar} = client.${nom(entity, 'Name')}()
+`)
+  }
+  Content(`    const ${matchvar} = {}
     ${matchvar}.id = ${srcdatavar}.id
     await ${entvar}.remove(${matchvar})
   `)

package/project/.sdk/src/cmp/js/fragment/Entity.fragment.js

@@ -1,106 +1,22 @@
 
 const { inspect } = require('node:util')
 
-const {
-  SdkNameSDK,
-  SdkNameEntity,
-} = require('../SdkNameSDK')
-
-const {
-  Utility
-} = require('../utility/Utility')
+const { ProjectNameEntityBase } = require('../ProjectNameEntityBase')
 
 
 // TODO: needs Entity superclass
-class EntityNameEntity {
-  name = 'entityname'
-
-  #client
-  #utility
-  #entopts
-  #data
-  #match
-
-  _entctx
+class EntityNameEntity extends ProjectNameEntityBase {
 
   constructor(client, entopts) {
-    // super()
-    entopts = entopts || {}
-    entopts.active = false !== entopts.active
-
-    this.#client = client
-    this.#entopts = entopts
-    this.#utility = client.utility()
-    this.#data = {}
-    this.#match = {}
-
-    const makeContext = this.#utility.makeContext
-
-    this._entctx = makeContext({
-      entity: this,
-      entopts,
-    }, client._rootctx)
-
-    const featureHook = this.#utility.featureHook
-    featureHook(this._entctx, 'PostConstructEntity')
+    super(client, entopts)
+    this.name = 'entityname'
+    this.name_ = 'entityname'
+    this.Name = 'EntityName'
   }
 
-  entopts() {
-    return { ...this.#entopts }
-  }
-
-  client() {
-    return this.#client
-  }
 
   make() {
-    return new EntityNameEntity(this.#client, this.entopts())
-  }
-
-
-  data(data) {
-    const struct = this.#utility.struct
-    const featureHook = this.#utility.featureHook
-
-    if (null != data) {
-      this.#data = struct.clone(data)
-      featureHook(this._entctx, 'SetData')
-    }
-
-    featureHook(this._entctx, 'GetData')
-    let out = struct.clone(this.#data)
-
-    return out
-  }
-
-
-  match(match) {
-    const struct = this.#utility.struct
-    const featureHook = this.#utility.featureHook
-
-    if (null != match) {
-      this.#match = struct.clone(match)
-      featureHook(this._entctx, 'SetMatch')
-    }
-
-    featureHook(this._entctx, 'GetMatch')
-    let out = struct.clone(this.#match)
-
-    return out
-  }
-
-
-  toJSON() {
-    const struct = this.#utility.struct
-    return struct.merge([{}, struct.getdef(this.#data, {}), { $entity: 'EntityName' }])
-  }
-
-  toString() {
-    return 'EntityName ' + this.#utility.struct.jsonify(this.#data)
-  }
-
-  [inspect.custom]() {
-    return this.toString()
+    return new EntityNameEntity(this._client, this.entopts())
   }
 
 
@@ -114,54 +30,6 @@ class EntityNameEntity {
 
   // #RemoveOp
 
-
-  #unexpected(ctx, err) {
-    const clean = this.#utility.clean
-    const struct = this.#utility.struct
-
-    const delprop = struct.delprop
-    const clone = struct.clone
-    const merge = struct.merge
-
-    const ctrl = ctx.ctrl
-
-    ctrl.err = err
-
-    if (ctrl.explain) {
-      ctx.ctrl.explain = clean(ctx, ctx.ctrl.explain)
-      delprop(ctx.ctrl.explain.result, 'err')
-
-      if (null != ctx.result && null != ctx.result.err) {
-        ctrl.explain.err = clean(ctx, merge([
-          clone({ err: ctx.result.err }).err,
-          {
-            message: ctx.result.err.message,
-            stack: ctx.result.err.stack,
-          }]))
-      }
-
-      const cleanerr = clean(ctx, merge([
-        clone({ err }).err,
-        {
-          message: err.message,
-          stack: err.stack,
-        }]))
-
-      if (null == ctrl.explain.err) {
-        ctrl.explain.err = cleanerr
-      }
-      else if (ctrl.explain.err.message != cleanerr.message) {
-        ctrl.explain.unexpected = cleanerr
-      }
-    }
-
-    if (false === ctrl.throw) {
-      return undefined
-    }
-
-    return err
-  }
-
 }
 
 

package/project/.sdk/src/cmp/js/fragment/EntityBase.fragment.js

@@ -0,0 +1,149 @@
+
+const { inspect } = require('node:util')
+
+
+// TODO: needs Entity superclass
+class ProjectNameEntityBase {
+  name = ''
+  name_ = ''
+  Name = ''
+
+  _client
+  _utility
+  _entopts
+  _data
+  _match
+  _entctx
+
+
+  constructor(client, entopts) {
+    entopts = entopts || {}
+    entopts.active = false !== entopts.active
+
+    this._client = client
+    this._entopts = entopts
+    this._utility = client.utility()
+    this._data = {}
+    this._match = {}
+
+    const makeContext = this._utility.makeContext
+
+    this._entctx = makeContext({
+      entity: this,
+      entopts,
+    }, client._rootctx)
+
+    const featureHook = this._utility.featureHook
+    featureHook(this._entctx, 'PostConstructEntity')
+  }
+
+  entopts() {
+    return this._utility.struct.merge([{}, this._entopts])
+  }
+
+  client() {
+    return this._client
+  }
+
+
+  data(data) {
+    const struct = this._utility.struct
+    const featureHook = this._utility.featureHook
+
+    if (null != data) {
+      this._data = struct.clone(data)
+      featureHook(this._entctx, 'SetData')
+    }
+
+    featureHook(this._entctx, 'GetData')
+    let out = struct.clone(this._data)
+
+    return out
+  }
+
+
+  match(match) {
+    const struct = this._utility.struct
+    const featureHook = this._utility.featureHook
+
+    if (null != match) {
+      this._match = struct.clone(match)
+      featureHook(this._entctx, 'SetMatch')
+    }
+
+    featureHook(this._entctx, 'GetMatch')
+    let out = struct.clone(this._match)
+
+    return out
+  }
+
+
+  toJSON() {
+    const struct = this._utility.struct
+    return struct.merge([{}, struct.getdef(this._data, {}), { entity$: this.Name }])
+  }
+
+
+  toString() {
+    return this.Name + ' ' + this._utility.struct.jsonify(this._data)
+  }
+
+
+  [inspect.custom]() {
+    return this.toString()
+  }
+
+
+  _unexpected(ctx, err) {
+    const clean = this._utility.clean
+    const struct = this._utility.struct
+
+    const delprop = struct.delprop
+    const clone = struct.clone
+    const merge = struct.merge
+
+    const ctrl = ctx.ctrl
+
+    ctrl.err = err
+
+    if (ctrl.explain) {
+      ctx.ctrl.explain = clean(ctx, ctx.ctrl.explain)
+      delprop(ctx.ctrl.explain.result, 'err')
+
+      if (null != ctx.result && null != ctx.result.err) {
+        ctrl.explain.err = clean(ctx, merge([
+          clone({ err: ctx.result.err }).err,
+          {
+            message: ctx.result.err.message,
+            stack: ctx.result.err.stack,
+          }]))
+      }
+
+      const cleanerr = clean(ctx, merge([
+        clone({ err }).err,
+        {
+          message: err.message,
+          stack: err.stack,
+        }]))
+
+      if (null == ctrl.explain.err) {
+        ctrl.explain.err = cleanerr
+      }
+      else if (ctrl.explain.err.message != cleanerr.message) {
+        ctrl.explain.unexpected = cleanerr
+      }
+    }
+
+    if (false === ctrl.throw) {
+      return undefined
+    }
+
+    return err
+  }
+
+}
+
+
+module.exports = {
+  ProjectNameEntityBase
+}