@voxgig/apidef 2.4.1 → 3.0.2

package/src/guide/heuristic01.ts

@@ -1,103 +1,285 @@
 
+import { Ordu } from 'ordu'
+import type { TaskSpec } from 'ordu'
 
-import { each, snakify, names } from 'jostraca'
 
-import { size } from '@voxgig/struct'
+import { each } from 'jostraca'
+
+import { size, merge, getelem, isempty, items, keysof } from '@voxgig/struct'
 
 
 import {
-  depluralize,
-  getdlog,
+  ApiDefContext,
+
+  Guide,
+  GuideMetrics,
+  GuideEntity,
+  GuidePath,
+  GuidePathAction,
+  GuideRenameParam,
+  GuidePathOp,
+} from '../types'
+
+import type {
+  CmpDesc,
+  MethodDesc,
+  MethodEntityDesc,
+  EntityDesc,
+  EntityPathDesc,
+} from '../desc'
+
+
+
+import type {
+  PathDef,
+  MethodDef,
+} from '../def'
+
+
+import {
+  canonize,
   capture,
+  debugpath,
   find,
+  findPathsWithPrefix,
+  formatJSONIC,
+  getdlog,
+  pathMatch,
+  warnOnError,
+} from '../utility'
+
+import type {
+  PathMatch
 } from '../utility'
 
 
-type EntityDesc = {
-  name: string
-  origname: string
-  why_name?: string[]
-  plural: string
-  path: Record<string, EntityPathDesc>
-  alias: Record<string, string>
-}
 
+// Log non - fatal wierdness.
+const dlog = getdlog('apidef', __filename)
+
+// Schema components that occur less than this rate(over total method count) qualify
+// as unique entities, not shared schemas
+const IS_ENTCMP_METHOD_RATE = 0.21
+const IS_ENTCMP_PATH_RATE = 0.41
 
-type EntityPathDesc = {
-  op: Record<string, any>
-  why_ent: string[]
+
+
+const METHOD_IDOP: Record<string, string> = {
+  GET: 'load',
+  POST: 'create',
+  PUT: 'update',
+  DELETE: 'remove',
+  PATCH: 'patch',
+  HEAD: 'head',
+  OPTIONS: 'OPTIONS',
+}
+
+const METHOD_CONSIDER_ORDER: Record<string, number> = {
+  'GET': 100,
+  'POST': 200,
+  'PUT': 300,
+  'PATCH': 400,
+  'DELETE': 500,
+  'HEAD': 600,
+  'OPTIONS': 700,
 }
 
-// Log non-fatal wierdness.
-const dlog = getdlog('apidef', __filename)
 
 
-async function heuristic01(ctx: any): Promise<Record<string, any>> {
-  let guide = ctx.model.main.api.guide
+async function heuristic01(ctx: ApiDefContext): Promise<Guide> {
 
-  const metrics = measure(ctx)
-  // console.dir(metrics, { depth: null })
+  const analysis = new Ordu({ select: { sort: true } }).add([
+    Prepare,
+    {
+      select: 'def.paths', apply: [
+        MeasurePath,
+        { select: '', apply: MeasureMethod },
+        PreparePath
+      ]
+    },
+    { select: selectCmpXrefs, apply: MeasureRef },
+    {
+      select: selectAllMethods, apply: [
+        ResolveEntityComponent,
+        ResolveEntityName,
+        RenameParams,
+        FindActions,
+        ResolveOperation,
+        ResolveTransform,
+        // ShowNode,
+      ]
+    },
+    { select: 'work.entmap', apply: BuildEntity }
+  ])
 
-  const entityDescs = resolveEntityDescs(ctx)
+  const result = analysis.execSync(ctx, {})
 
-  guide = {
-    control: guide.control,
-    entity: entityDescs,
+  if (result.err) {
+    throw result.err
   }
 
+  const guide = result.data.guide
+
+  // console.log('WORK', result.data.work)
+
+  // console.log('GUIDE')
+  // console.dir(guide, { depth: null })
+
+
+  // TODO: move to Ordu
+  // warnOnError('reviewEntityDescs', ctx.warn, () => reviewEntityDescs(ctx, result))
+
   return guide
+
 }
 
 
-function measure(ctx: any) {
-  const metrics = {
-    count: {
-      schema: ({} as Record<string, number>)
-    }
-  }
+function ShowNode(spec: TaskSpec) {
+  console.log('NODE', spec.node.key, spec.node.val)
+}
 
-  let xrefs = find(ctx.def, 'x-ref')
-  // console.log('XREFS', xrefs)
 
-  let schemas = xrefs.filter(xref => xref.val.includes('schema'))
+function Prepare(spec: TaskSpec) {
+  const guide: Guide = {
+    control: {},
+    entity: {},
+    metrics: {
+      count: {
+        path: 0,
+        method: 0,
+        tag: 0,
+        cmp: 0,
+        entity: 0,
+        origcmprefs: {},
+      },
+      found: {
+        tag: {},
+        cmp: {},
+      }
+    },
+  }
 
-  schemas.map(schema => {
-    let m = schema.val.match(/\/components\/schemas\/(.+)$/)
-    if (m) {
-      const name = m[1]
-      metrics.count.schema[name] = 1 + (metrics.count.schema[name] || 0)
+  Object.assign(spec.data, {
+    def: spec.ctx.def,
+    guide,
+    work: {
+      pathmap: {},
+      entmap: {},
+      entity: {
+        count: {
+          seen: 0,
+          unresolved: 0,
+        }
+      },
     }
   })
+}
+
+
+// Expects to run over paths
+function MeasurePath(spec: TaskSpec) {
+  const guide = spec.data.guide
+  const metrics = guide.metrics
+  // const pathstr = spec.node.key
+  const pathdef = spec.node.val
 
+  metrics.count.path++
 
-  return metrics
+  metrics.count.method += (
+    (pathdef.get ? 1 : 0) +
+    (pathdef.post ? 1 : 0) +
+    (pathdef.put ? 1 : 0) +
+    (pathdef.patch ? 1 : 0) +
+    (pathdef.delete ? 1 : 0) +
+    (pathdef.head ? 1 : 0) +
+    (pathdef.options ? 1 : 0)
+  )
+
+}
+
+
+// Expects to run over paths.<method>
+function MeasureMethod(spec: TaskSpec) {
+  const guide = spec.data.guide
+  const metrics = guide.metrics
+  // const methodstr = spec.node.key
+  const methoddef = spec.node.val
+
+  const pathtags = methoddef.tags
+  if (Array.isArray(pathtags)) {
+    for (let tag of pathtags) {
+      if ('string' === typeof tag && 0 < tag.length) {
+        if (!metrics.found.tag[tag]) {
+          metrics.count.tag++
+          metrics.found.tag[tag] = {
+            name: tag,
+            canon: canonize(tag),
+          }
+        }
+      }
+    }
+  }
 }
 
 
+function PreparePath(spec: TaskSpec) {
+  const work = spec.data.work
+  const pathstr = spec.node.key
+  const pathdef = spec.node.val
 
+  const pathdesc = {
+    path: pathstr,
+    def: pathdef,
+    parts: pathstr.split('/').filter((p: string) => '' != p),
+    op: {}
+  }
 
-const METHOD_IDOP: Record<string, string> = {
-  get: 'load',
-  post: 'create',
-  put: 'update',
-  patch: 'update',
-  delete: 'remove',
+  work.pathmap[pathstr] = pathdesc
+}
+
+
+function selectCmpXrefs(_source: any, spec: TaskSpec) {
+  const out = find(spec.ctx.def, 'x-ref')
+    .filter(xref => xref.val.match(/\/(components\/schemas|definitions)\//))
+
+  // console.log('selectCmpXrefs', out)
+  return out
 }
 
 
-function resolveEntityDescs(ctx: any) {
-  const entityDescs: Record<string, any> = {}
-  const paths = ctx.def.paths
+function MeasureRef(spec: TaskSpec) {
+  const guide = spec.data.guide
+  const metrics = guide.metrics
+
+  let m = spec.node.val.val.match(/\/(components\/schemas|definitions)\/(.+)$/)
+  if (m) {
+    const name = canonize(m[2])
+    if (null == metrics.count.origcmprefs[name]) {
+      metrics.count.cmp++
+      metrics.count.origcmprefs[name] = 0
+    }
+    metrics.count.origcmprefs[name]++
+
+    if (null == metrics.found.cmp[name]) {
+      metrics.found.cmp[name] = { orig: m[2] }
+    }
+  }
+}
+
 
+function selectAllMethods(_source: any, spec: TaskSpec): MethodDesc[] {
+  const ctx = spec.ctx
+  // const paths = ctx.def.paths
 
-  const caught = capture(ctx.def, {
+  let caught = capture(ctx.def, {
     paths:
-      ['`$SELECT`', /\/([a-zA-Z0-1_-]+)(\/\{([a-zA-Z0-1_-]+)\})?$/,
-        ['`$SELECT`', /get|post|put|patch|delete/i,
+      ['`$SELECT`', /.*/,
+        ['`$SELECT`', /^get|post|put|patch|delete$/i,
           ['`$APPEND`', 'methods', {
             path: '`select$=key.paths`',
-            method: { '`$LOWER`': '`$KEY`' },
+            method: { '`$UPPER`': '`$KEY`' },
             summary: '`.summary`',
+            tags: '`.tags`',
             parameters: '`.parameters`',
             responses: '`.responses`',
             requestBody: '`.requestBody`'
@@ -106,347 +288,1544 @@ function resolveEntityDescs(ctx: any) {
       ]
   })
 
+  // TODO: capture should return these empty objects
+  caught = caught ?? {}
+  caught.methods = caught.methods ?? []
 
-  each(caught.methods, (pmdef) => {
-    let methodDef = pmdef
-    let pathStr = pmdef.path
-    let methodStr = pmdef.method
+  caught.methods.sort((a: any, b: any) => {
+    if (a.path < b.path) {
+      return -1
+    }
+    else if (a.path > b.path) {
+      return 1
+    }
+    else if (METHOD_CONSIDER_ORDER[a.method] < METHOD_CONSIDER_ORDER[b.method]) {
+      return -1
+    }
+    else if (METHOD_CONSIDER_ORDER[a.method] > METHOD_CONSIDER_ORDER[b.method]) {
+      return 1
+    }
+    else {
+      return 0
+    }
+  })
 
-    // methodStr = methodStr.toLowerCase()
-    let why_op: string[] = []
+  // console.log(caught.methods.map((n: any) => n.path + ' ' + n.method))
 
-    if (!METHOD_IDOP[methodStr]) {
-      return
-    }
+  return caught.methods || []
+}
 
-    const why_ent: string[] = []
-    const entdesc =
-      resolveEntity(entityDescs, pathStr, methodDef, methodStr, why_ent)
 
+function ResolveEntityComponent(spec: TaskSpec) {
+  const guide = spec.data.guide
+  const metrics = guide.metrics
 
-    if (null == entdesc) {
-      console.log(
-        'WARNING: unable to resolve entity for method ' + methodStr +
-        ' path ' + pathStr)
-      return
-    }
+  const work = spec.data.work
 
-    entdesc.path[pathStr].why_ent = why_ent
+  const methodDef = spec.node.val
+  const methodName = methodDef.method
+  const pathStr = methodDef.path
 
+  const parts = work.pathmap[pathStr].parts
 
-    // if (pathStr.includes('courses')) {
-    //   console.log('ENTRES', pathStr, methodStr)
-    //   console.dir(ent2, { depth: null })
-    // }
+  let why_cmp: string[] = []
 
-    let opname = resolveOpName(methodStr, methodDef, pathStr, entdesc, why_op)
+  let responses = methodDef.responses
 
-    if (null == opname) {
-      console.log(
-        'WARNING: unable to resolve operation for method ' + methodStr +
-        ' path ' + pathStr)
-      return
-    }
+  let origxrefs: any[] = findPotentialSchemaRefs(pathStr, methodName, responses).map(val => ({
+    val
+  }))
 
+  let cmpxrefs = origxrefs
+    .filter(xref => xref.val.includes('schema') || xref.val.includes('definitions'))
+    .map(xref => {
+      let m = xref.val.match(/\/components\/schemas\/(.+)$/)
+      if (!m) {
+        m = xref.val.match(/\/definitions\/(.+)$/)
+      }
+      if (m) {
+        const cmp = canonize(m[1])
 
-    const transform: Record<string, any> = {
-      // reqform: '`reqdata`',
-      // resform: '`body`',
-    }
+        xref.cmp = cmp
+        xref.origcmp = m[1]
+        xref.origcmpref = cmp
+      }
+      return xref
+    })
+    .filter(xref => null != xref.cmp)
+
+    // TODO: identify non - ent schemas
+    .filter(xref => !xref.val.includes('Meta'))
+
+  let cleanxrefs = cmpxrefs
+    .map(xref => {
+
+      // Redundancy in cmp name, remove request,response suffix
+      // const lastPart = getelem(pathStr.split('/'), -1)
+      const lastPart = getelem(parts, -1)
+      const lastPartLower = lastPart?.toLowerCase()
+      const lastPartCanon = canonize(lastPart)
+      const origcmpLower = xref.origcmp?.toLowerCase()
+
+      if (
+        '' !== lastPartCanon
+        && (
+          xref.cmp === lastPartCanon + '_response'
+          || xref.cmp === lastPartCanon + '_request'
+          || origcmpLower === lastPartLower + 'response'
+          || origcmpLower === lastPartLower + 'request'
+        )
+      ) {
+        let cparts = xref.cmp.split('_')
+
+        // rec-canonize to deal with plural before removed suffix
+        xref.cmp = canonize(cparts.slice(0, cparts.length - 1).join('_'))
+      }
+
+      return xref
+    })
 
-    const resokdef = methodDef.responses?.[200] || methodDef.responses?.[201]
-    const resbody = resokdef?.content?.['application/json']?.schema
-    if (resbody) {
-      if (resbody[entdesc.origname]) {
-        transform.resform = '`body.' + entdesc.origname + '`'
+  let goodxrefs = cleanxrefs
+    .filter(xref => {
+      if (
+        cleanxrefs.length <= 1
+        || pathStr.toLowerCase().includes('/' + xref.cmp + '/')
+        // || entityOccursInPath(pathStr.toLowerCase(), xref.cmp)
+        || entityOccursInPath(parts, xref.cmp)
+      ) {
+        return true
       }
-      else if (resbody[entdesc.name]) {
-        transform.resform = '`body.' + entdesc.name + '`'
+
+      // Exclude high frequency suspicious cmps as probably meta data
+      const cmprefs = metrics.count.origcmprefs[xref.origcmpref] ?? 0
+      const mcount = metrics.count.method
+      const pcount = metrics.count.path
+      const method_rate = (0 < mcount ? (cmprefs / mcount) : -1)
+      const path_rate = (0 < pcount ? (cmprefs / pcount) : -1)
+      // console.log('RCN', xref.cmp, cmprefs, mcount, method_rate, IS_ENTCMP_METHOD_RATE, method_rate < IS_ENTCMP_METHOD_RATE)
+      const infrequent =
+        method_rate < IS_ENTCMP_METHOD_RATE
+        || path_rate < IS_ENTCMP_PATH_RATE
+
+      if (!infrequent) {
+        debugpath(pathStr, methodName, 'CMP-INFREQ',
+          xref.val,
+          'method:', method_rate, IS_ENTCMP_METHOD_RATE,
+          'path:', path_rate, IS_ENTCMP_PATH_RATE
+        )
+      }
+
+      return infrequent
+    })
+
+  // .sort((a, b) => a.path.length - b.path.length)
+
+
+  const fcmp: any = goodxrefs[0]
+
+  let out: MethodEntityDesc | undefined = undefined
+
+  if (null != fcmp) {
+    out = makeMethodEntityDesc({
+      ref: fcmp.val,
+      cmp: fcmp.cmp,
+      origcmp: fcmp.origcmp,
+      origcmpref: fcmp.origcmpref,
+      entname: fcmp.cmp,
+    })
+  }
+
+  const tags = methodDef.tags ?? []
+  const goodtags = tags.filter((tag: any) => {
+    const tagdesc = metrics.found.tag[tag]
+    const ctag = tagdesc?.canon
+    return (
+      !!metrics.found.cmp[ctag] // tag matches a cmp
+      || null == fcmp // there's no cmp, so use tag
+    )
+  })
+
+  debugpath(pathStr, methodName, 'TAGS', tags, goodtags, fcmp, methodDef, metrics.found)
+
+  const ftag = goodtags[0]
+
+  if (null != ftag) {
+    const tagdesc = metrics.found.tag[ftag]
+    const tagcmp = metrics.found.cmp[tagdesc.canon]
+
+    if (tagdesc && (tagcmp || null == fcmp)) {
+      if (null == out) {
+        out = makeMethodEntityDesc({
+          ref: 'tag',
+          cmp: tagdesc.canon,
+          origcmp: ftag,
+          why_cmp,
+          entname: tagdesc.canon,
+        })
+        why_cmp.push('tag=' + out.cmp)
+      }
+      else if (
+        (pathStr.includes('/' + ftag + '/') || pathStr.includes('/' + tagdesc.canon + '/'))
+        && out.cmp !== tagdesc.canon
+      ) {
+        out = makeMethodEntityDesc({
+          ref: 'tag',
+          cmp: tagdesc.canon,
+          origcmp: ftag,
+          why_cmp,
+          entname: tagdesc.canon,
+        })
+        why_cmp.push('tag/path=' + out.cmp)
       }
     }
+  }
+
+  if (null != out) {
+    why_cmp.push('cmp/resolve=' + out.cmp)
+    out.why_cmp = why_cmp
+    out.cmpoccur = metrics.count.origcmprefs[out.origcmpref ?? ''] ?? 0
+    out.path_rate = 0 == metrics.count.path ? -1 : (out.cmpoccur / metrics.count.path)
+    out.method_rate = 0 == metrics.count.method ? -1 : (out.cmpoccur / metrics.count.method)
+
+    methodDef.MethodEntity = out
+  }
+
+  debugpath(pathStr, methodName, 'CMP-NAME', out, origxrefs, cleanxrefs, goodxrefs, goodtags)
+}
+
+
+
+function ResolveEntityName(spec: TaskSpec) {
+  const ctx = spec.ctx
+  const data = spec.data
+
+  const mdesc: MethodDesc = spec.node.val
+  const methodName = mdesc.method
+  const pathStr = mdesc.path
+
+  const work = spec.data.work
+
+  const pathDesc = work.pathmap[pathStr]
+  const parts = pathDesc.parts
+
+  work.entity.count.seen++
+
+  let ment: Partial<MethodEntityDesc>
+  ment = mdesc.MethodEntity
+
+  const why_path: string[] = []
+
+  if (null == ment) {
+    why_path.push('no-desc')
+    mdesc.MethodEntity = makeMethodEntityDesc({})
+    ment = mdesc.MethodEntity
+  }
+
+  why_path.push(...(ment.why_cmp ?? []))
+
+  let entname
+
+  let pm = undefined
 
-    const reqdef = methodDef.requestBody?.content?.['application/json']?.schema?.properties
-    if (reqdef) {
-      if (reqdef[entdesc.origname]) {
-        transform.reqform = { [entdesc.origname]: '`reqdata`' }
+  if (pm = pathMatch(parts, 't/p/t/')) {
+    entname = entityPathMatch_tpte(data, pm, mdesc, why_path)
+  }
+
+  else if (pm = pathMatch(parts, 't/p/')) {
+    entname = entityPathMatch_tpe(data, pm, mdesc, why_path)
+  }
+
+  else if (pm = pathMatch(parts, 'p/t/')) {
+    entname = entityPathMatch_pte(data, pm, mdesc, why_path)
+  }
+
+  else if (pm = pathMatch(parts, 't/')) {
+    entname = entityPathMatch_te(data, pm, mdesc, why_path)
+  }
+
+  else if (pm = pathMatch(parts, 't/p/p')) {
+    entname = entityPathMatch_tpp(data, pm, mdesc, why_path)
+  }
+
+  else {
+    work.entity.count.unresolved++
+    entname = 'entity' + work.entity.count.unresolved
+  }
+
+  const entdesc = work.entmap[entname] = work.entmap[entname] ?? {
+    name: entname,
+    id: 'N' + ('' + Math.random()).substring(2, 10),
+    op: {},
+    why_path,
+    ...ment
+  }
+
+  entdesc.path = (entdesc.path || {})
+  entdesc.path[pathStr] = entdesc.path[pathStr] || {
+    rename: { param: {} },
+    why_rename: { why_param: {} },
+    pm,
+  }
+  entdesc.path[pathStr].op = entdesc.path[pathStr].op || {}
+  entdesc.path[pathStr].why_path = why_path
+
+  ment.entname = entname
+  ment.pm = pm
+
+  debugpath(pathStr, methodName, 'RESOLVE-ENTITY-NAME',
+    formatJSONIC({ entdesc, ment }, { hsepd: 0, $: true, color: true }))
+}
+
+
+
+function RenameParams(spec: TaskSpec) {
+  const ctx = spec.ctx
+  const data = spec.data
+  const guide = data.guide
+  const metrics = guide.metrics
+
+  const mdesc = spec.node.val
+  const ment = mdesc.MethodEntity
+
+  const pathStr = mdesc.path
+  const work = spec.data.work
+
+  const entname = mdesc.MethodEntity.entname
+  const entdesc = work.entmap[entname]
+
+  const pathdesc = spec.data.work.pathmap[pathStr]
+
+  const methodName = mdesc.method
+
+  // Rewrite path parameters that are identifiers to follow the rules:
+  // 0. Parameters named [a-z]?id are considered identifiers
+  // 1. last identifier is always {id} as this is the primary entity
+  // 2. internal identifiers are formatted as {name_id} where name is the parent entity name
+  // Example: /api/bar/{id}/zed/{zid}/foo/{fid} ->
+  //          /api/bar/{bar_id}/zed/{zed_id}/foo/{id}
+
+  // id needs to be t/p/
+  const multParamEndMatch = pathMatch(mdesc.path, 'p/p/')
+  if (multParamEndMatch) {
+    return
+  }
+
+
+  const pathDesc = entdesc.path[pathStr]
+  pathDesc.rename = (pathDesc.rename ?? { param: {} })
+  pathDesc.why_rename = (pathDesc.why_rename ?? { why_param: {} })
+
+  pathDesc.action = (pathDesc.action ?? {})
+  pathDesc.why_action = (pathDesc.why_action ?? {})
+
+  const paramRenameCapture = {
+    rename: pathDesc.rename.param = (pathDesc.rename.param ?? {}),
+    why: pathDesc.why_rename.why_param = (pathDesc.why_rename.why_param ?? {}),
+  }
+  const parts = pathdesc.parts
+
+  const cmpname = mdesc.cmp
+  const considerCmp =
+    null != cmpname &&
+    0 < metrics.count.uniqschema &&
+    mdesc.method_rate < IS_ENTCMP_METHOD_RATE
+
+  const origParams = []
+
+  for (let partI = 0; partI < parts.length; partI++) {
+    let partStr = parts[partI]
+
+    if (isParam(partStr)) {
+      origParams.push(partStr.replace(/[\}\{\*]/g, ''))
+
+      const why = []
+
+      const oldParam = partStr.substring(1, partStr.length - 1)
+      paramRenameCapture.why[oldParam] = (paramRenameCapture.why[oldParam] ?? [])
+
+      const lastPart = partI === parts.length - 1
+      const secondLastPart = partI === parts.length - 2
+      const notLastPart = partI < parts.length - 1
+      const hasParent = 0 < partI && !isParam(parts[partI - 1])
+      const parentName = hasParent ? canonize(parts[partI - 1]) : null
+      const not_exact_id = 'id' !== oldParam
+      const probably_an_id =
+        oldParam.endsWith('id')
+        || oldParam.endsWith('Id')
+        || canonize(oldParam) === parentName
+
+      debugpath(pathStr, mdesc.method, 'RENAME-PARAM-PART', parts, partI, partStr, {
+        lastPart,
+        secondLastPart,
+        notLastPart,
+        hasParent,
+        parentName,
+        not_exact_id,
+        probably_an_id,
+      })
+
+      // Id-like not at end, and after a possible entname.
+      // .../parentent/{id}/...
+      if (
+        probably_an_id
+        && hasParent
+        && notLastPart
+      ) {
+        why.push('maybe-parent')
+
+        // actually an action
+        if (
+          secondLastPart
+          && (
+            (
+              parentName !== entdesc.name
+              && entdesc.name.startsWith(parentName + '_')
+            )
+            // || parentName === cmp.name
+            || parentName === cmpname
+          )
+        ) {
+          // let newParamName = 'id'
+          updateParamRename(
+            ctx, data, pathStr, methodName, paramRenameCapture, oldParam,
+            'id', 'action-parent:' + entdesc.name)
+          why.push('action')
+
+          updateAction(methodName, oldParam,
+            parts[partI + 1], entdesc, pathDesc, 'action-not-parent')
+        }
+
+        else if (hasParent && parentName === cmpname) {
+          updateParamRename(
+            ctx, data, pathStr, methodName, paramRenameCapture, oldParam,
+            'id', 'id-parent-cmp')
+          why.push('id-parent-cmp')
+        }
+
+        else if (hasParent && parentName === entdesc.name) {
+          updateParamRename(
+            ctx, data, pathStr, methodName, paramRenameCapture, oldParam,
+            'id', 'id-parent-ent')
+          why.push('id-parent-ent')
+        }
+
+        else {
+          updateParamRename(
+            ctx, data, pathStr, methodName, paramRenameCapture, oldParam,
+            parentName + '_id', 'parent:' + parentName)
+          why.push('parent')
+        }
       }
-      else if (reqdef[entdesc.origname]) {
-        transform.reqform = { [entdesc.origname]: '`reqdata`' }
+
+      // /api/foo/{foo}/bar/...
+      // param matches parent entname, but is not _id format
+
+
+      // At end, but not called id.
+      // .../ent/{not-id}
+      else if (
+        lastPart
+        && not_exact_id
+        && (!hasParent
+          || (
+            parentName === entdesc.name
+            || entdesc.name.endsWith('_' + parentName)
+          )
+        )
+        && (!considerCmp || cmpname === entdesc.name)
+      ) {
+        updateParamRename(
+          ctx, data, pathStr, methodName, paramRenameCapture, oldParam,
+          'id', 'end-id;' + methodName + ';parent=' + hasParent + '/' + parentName +
+          ';cmp=' + considerCmp + (null == cmpname ? '' : '/' + cmpname))
+        why.push('end-id')
       }
 
+      // Mot at end, has preceding non-param part.
+      // .../parentent/{paramname}/...
+      else if (
+        notLastPart
+        && 1 < partI
+        && hasParent
+      ) {
+        why.push('has-parent')
+
+        // Actually primary ent with an action$ suffix
+        if (
+          secondLastPart
+        ) {
+          why.push('second-last')
+
+          if (
+            'id' !== oldParam
+            // && fixEntName(partStr) === entdesc.name
+            && canonize(partStr) === entdesc.name
+          ) {
+            updateParamRename(
+              ctx, data, pathStr, methodName, paramRenameCapture, oldParam,
+              'id', 'end-action')
+            why.push('end-action')
+
+            updateAction(methodName, oldParam,
+              parts[partI + 1], entdesc, pathDesc, 'end-action')
+          }
+          else {
+            why.push('not-end-action')
+          }
+        }
+
+        // Primary ent id not at end!
+        else if (
+          hasParent
+          && parentName === cmpname
+        ) {
+          updateParamRename(
+            ctx, data, pathStr, methodName, paramRenameCapture, oldParam,
+            'id', 'id-not-last')
+
+          why.push('id-not-last')
+          // paramRenames[oldParam] = 'id'
+          // paramRenamesWhy[oldParam].push('id-not-last')
+        }
+
+        // Not primary ent.
+        else {
+          why.push('default')
+
+          let newParamName = parentName + '_id'
+          if (newParamName != oldParam) {
+            updateParamRename(
+              ctx, data, pathStr, methodName, paramRenameCapture, oldParam,
+              newParamName, 'not-primary')
+            why.push('not-primary')
+
+            // paramRenames[oldParam] = newParamName
+            // paramRenamesWhy[oldParam].push('not-primary')
+          }
+        }
+      }
+
+      why.push('done')
+
+      if (paramRenameCapture.rename[oldParam] === oldParam) {
+        why.push('delete-dup')
+        delete paramRenameCapture.rename[oldParam]
+        delete paramRenameCapture.why[oldParam]
+      }
+
+      // TODO: these need to done via an API
+      debugpath(pathStr, methodName, 'RENAME-PARAM',
+        {
+          pathStr,
+          methodName,
+          partStr,
+          why,
+          oldParam,
+          lastPart,
+          secondLastPart,
+          notLastPart,
+          hasParent,
+          parentName,
+          not_exact_id,
+          probably_an_id,
+          considerCmp,
+          cmp: mdesc.cmp,
+          cmpname,
+          paramRenameCapture,
+          entdesc
+        }
+      )
     }
+  }
+
+  ment.rename = paramRenameCapture.rename
+  ment.why_rename = paramRenameCapture.why
+  ment.rename_orig = origParams
+}
+
+
+function FindActions(spec: TaskSpec) {
+  const mdesc = spec.node.val
+  const pathStr = mdesc.path
+  const work = spec.data.work
+
+  const ment = mdesc.MethodEntity
+  const entname = ment.entname
+  const entdesc = work.entmap[entname]
+
+  // const pathdesc = spec.data.work.pathmap[pathStr]
+  const pathdesc = entdesc.path[pathStr]
+
+  const methodName = mdesc.method
+
+  pathdesc.action = (pathdesc.action ?? {})
+  pathdesc.why_action = (pathdesc.why_action ?? {})
+
+  const parts = spec.data.work.pathmap[pathStr].parts
 
-    const op = entdesc.path[pathStr].op
+  const fourthLastPart = parts[parts.length - 4]
+  const fourthLastPartCanon = canonize(fourthLastPart)
+  const thirdLastPart = parts[parts.length - 3]
+  const thirdLastPartCanon = canonize(thirdLastPart)
+  const secondLastPart = parts[parts.length - 2]
+  const secondLastPartCanon = canonize(secondLastPart)
+  const lastPart = parts[parts.length - 1]
+  const lastPartCanon = canonize(lastPart)
 
-    op[opname] = {
-      // TODO: in actual guide, remove "standard" method ops since redundant
-      method: methodStr,
-      why_op: why_op.join(';')
+  const cmp = ment.cmp
+
+  // /api/foo/bar where foo is the entity and bar is the action, no id param
+  if (
+    secondLastPartCanon === cmp
+    || secondLastPartCanon === ment.origcmp
+    || secondLastPartCanon === entname
+  ) {
+    if (!isParam(lastPart)) {
+      updateAction(methodName, lastPart, lastPartCanon, entdesc, pathdesc, 'no-param')
     }
+  }
 
-    if (0 < Object.entries(transform).length) {
-      op[opname].transform = transform
+  //  /api/foo/{param}/action
+  else if (
+    thirdLastPartCanon === cmp
+    || thirdLastPartCanon === ment.origcmp
+    || thirdLastPartCanon === entname
+  ) {
+    if (isParam(secondLastPart) && !isParam(lastPart)) {
+      updateAction(methodName, lastPart, lastPartCanon, entdesc, pathdesc,
+        'ent-param-2nd-last')
     }
+  }
 
-    // if ('/v2/users/{user_id}/enrollment' === pathStr) {
-    //   console.log('ENT')
-    //   console.dir(entdesc, { depth: null })
-    // }
-    // })
-    // }
-  })
+  //  /api/foo/{param}/action/subaction
+  else if (
+    fourthLastPartCanon === cmp
+    || fourthLastPartCanon === ment.origcmp
+    || fourthLastPartCanon === entname
+  ) {
+    if (isParam(thirdLastPart) && !isParam(secondLastPart) && !isParam(lastPart)) {
+      const oldActionName = secondLastPart + '/' + lastPart
+      const actionName = secondLastPartCanon + '_' + lastPartCanon
+      updateAction(methodName, oldActionName, actionName, entdesc, pathdesc,
+        'ent-param-3rd-last')
+    }
+  }
 
-  // console.log('USER')
-  // console.dir(entityDescs.user, { depth: null })
+  debugpath(pathStr, methodName, 'FIND-ACTIONS', cmp, parts, pathdesc.action, pathdesc.why_action)
 
-  return entityDescs
+  // return pathdesc.action
 }
 
 
-function resolveEntity(
-  entityDescs: Record<string, EntityDesc>,
-  // pathDef: Record<string, any>,
-  pathStr: string,
-  methodDef: Record<string, any>,
-  methodStr: string,
-  why_ent: string[]
-): EntityDesc | undefined {
+function ResolveOperation(spec: TaskSpec) {
+  const mdesc: MethodDesc = spec.node.val
+  const ment: MethodEntityDesc = mdesc.MethodEntity
 
-  let entdesc: EntityDesc
-  let entname: string = ''
-  let origentname: string = ''
+  const pathStr = mdesc.path
+  const work = spec.data.work
 
-  const why_name: string[] = []
+  const parts: string[] = work.pathmap[pathStr].parts
 
-  const m = pathStr.match(/\/([a-zA-Z0-1_-]+)(\/\{([a-zA-Z0-1_-]+)\})?$/)
-  if (m) {
-    let pathName = m[1]
-    let pathParam = m[3]
+  const entname = mdesc.MethodEntity.entname
+  const entdesc = work.entmap[entname]
+
+  const methodName = mdesc.method
+
+  const why_op: string[] = ment.why_op = []
+
+  let opname = METHOD_IDOP[methodName]
+  let standard_opname = opname
+
+  if (null == opname) {
+    why_op.push('no-op:' + methodName)
+    return
+  }
+
+  // REVIEW: using POST and PUT in non-restian ways is too wierd to handle consistently
+  // correct using guide customizations
+
+  // Sometimes POST is used to update, not create. Attempt to identify this.
+  // And sometimes vice versa for PUT
+  // const id_param_offset = ment.pm?.expr?.endsWith('/t/') ? 1 : 0
+  // const has_end_id_param =
+  //   entname == canonize(parts[parts.length - 2 - id_param_offset])
+  //   && parts[parts.length - 1 - id_param_offset]?.toLowerCase().endsWith('id}')
+
+
+  if ('load' === standard_opname) {
+    const islist = isListResponse(mdesc, pathStr, why_op)
+    opname = islist ? 'list' : opname
+  }
+
+  /*
+  else if (
+    'create' === standard_opname
+    && has_end_id_param
+  ) {
+    opname = 'update'
+    why_op.push('id-present')
+  }
+
+  else if (
+    'update' === standard_opname
+    && !has_end_id_param
+  ) {
+    opname = 'create'
+    why_op.push('no-id-present')
+  }
+  */
+
+
+  else {
+    why_op.push('not-load')
+  }
+
+  // why.push('ent=' + entdesc.name)
+
+  ment.opname = opname
+  ment.why_opname = why_op
+
+  const op = entdesc.path[pathStr].op
+
+  const opdef = {
+    method: methodName,
+    why_op: why_op.join(';')
+  }
+
+  if (null == op[opname]) {
+    op[opname] = opdef
+  }
+
+  // Conflicting methods for same operation
+  // METHOD_CONSIDER_ORDER wins
+  // Add operation using method name
+  else {
+    op[methodName.toLowerCase()] = opdef
+  }
+
+  debugpath(pathStr, methodName, 'ResolveOperation', standard_opname, opname, why_op, op)
+}
+
+
+function ResolveTransform(spec: TaskSpec) {
+  const mdesc = spec.node.val
+  const ment = mdesc.MethodEntity
 
+  const pathStr = mdesc.path
+  const work = spec.data.work
 
-    origentname = snakify(pathName)
-    entname = depluralize(origentname)
+  const entname = mdesc.MethodEntity.entname
+  const entdesc = work.entmap[entname]
 
-    // Check schema
-    const compname = resolveComponentName(entname, methodDef, methodStr, pathStr, why_name)
-    if (compname) {
-      origentname = snakify(compname)
-      entname = depluralize(origentname)
-      why_ent.push('cmp:' + entname)
+  // const pathdesc = spec.data.work.pathmap[pathStr]
+  const pathdesc = entdesc.path[pathStr]
+
+  const methodName = mdesc.method
+
+  const opname = ment.opname
+
+  const op = pathdesc.op
+
+  const transform: Record<string, any> = {
+    req: undefined,
+    res: undefined,
+  }
+
+  const resokdef = mdesc.responses?.[200] || mdesc.responses?.[201]
+  const resprops = getResponseSchema(resokdef)?.properties
+  debugpath(pathStr, methodName, 'TRANSFORM-RES', keysof(resprops))
+
+  if (resprops) {
+    if (resprops[entdesc.origname]) {
+      transform.res = '`body.' + entdesc.origname + '`'
     }
-    else {
-      why_ent.push('path:' + m[1])
-      why_name.push('path:' + m[1])
+    else if (resprops[entdesc.name]) {
+      transform.res = '`body.' + entdesc.name + '`'
     }
+  }
 
-    entdesc = (entityDescs[entname] = entityDescs[entname] || {
-      name: entname,
-      id: Math.random(),
-      alias: {}
-    })
+  const reqprops = getRequestBodySchema(mdesc.requestBody)
+  debugpath(pathStr, methodName, 'TRANSFORM-REQ', keysof(reqprops))
+  if (reqprops) {
+    if (reqprops[entdesc.origname]) {
+      transform.req = { [entdesc.origname]: '`reqdata`' }
+    }
+    else if (reqprops[entdesc.origname]) {
+      transform.req = { [entdesc.origname]: '`reqdata`' }
+    }
 
-    if (null != pathParam) {
-      const pathParamCanon = snakify(pathParam)
-      if ('id' != pathParamCanon) {
-        entdesc.alias.id = pathParamCanon
-        entdesc.alias[pathParamCanon] = 'id'
+  }
+
+  if (!isempty(transform)) {
+    op[opname].transform = transform
+  }
+}
+
+
+
+function BuildEntity(spec: TaskSpec) {
+  const entdesc = spec.node.val
+  // console.log('BUILD-ENTITY')
+  // console.dir(entdesc, { depth: null })
+
+  const guide: Guide = spec.data.guide
+  guide.metrics.count.entity++
+
+  const entityMap: Record<string, GuideEntity> = guide.entity
+
+  const path: Record<string, GuidePath> = {}
+
+  const rename_param = (pathdesc: any) => {
+    // console.log('RENAME-PATHDESC', pathdesc)
+    const out: Record<string, GuideRenameParam> = {}
+    each(pathdesc.rename.param, (item: any) => {
+      out[item.key$] = {
+        target: item.val$,
+        why_rename: pathdesc.why_rename.why_param[item.key$]
       }
+    })
+    return out
+  }
+
+  each(entdesc.path, (pathdesc: any, pathstr: string) => {
+    const guidepath = {
+      why_path: pathdesc.why_path,
+      action: pathdesc.action,
+      rename: {
+        param: rename_param(pathdesc)
+      },
+      op: pathdesc.op
     }
+    path[pathstr] = guidepath
+  })
+
+  entityMap[entdesc.name] = {
+    name: entdesc.name,
+    orig: entdesc.origcmp,
+    path,
   }
 
-  // Can't figure out the entity
+}
+
+
+
+
+
+
+
+function entityPathMatch_tpte(
+  data: { def: any, guide: any, work: any },
+  pm: PathMatch,
+  mdesc: any,
+  why: string[]
+) {
+  const ment = mdesc.MethodEntity
+
+  const pathNameIndex = 2
+
+  why.push('path=t/p/t/')
+  const origPathName = pm[pathNameIndex]
+  let entname = canonize(origPathName)
+  let ecm = undefined
+
+  if (null != ment.cmp) {
+    ecm = entityCmpMatch(data, entname, mdesc, why)
+    entname = ecm.name
+    why.push('has-cmp=' + ecm.orig)
+  }
+
+  else if (probableEntityMethod(data, ment, pm, why)) {
+    ecm = entityCmpMatch(data, entname, mdesc, why)
+    if (ecm.cmpish) {
+      entname = ecm.name
+      why.push('prob-ent=' + ecm.orig)
+    }
+    else if (endsWithCmp(data, pm)) {
+      entname = canonize(getelem(pm, -1))
+      why.push('prob-ent-last=' + ecm.orig)
+    }
+    else if (0 < findPathsWithPrefix(data, pm.path, { strict: true })) {
+      entname = canonize(getelem(pm, -1))
+      why.push('prob-ent-prefix=' + ecm.orig)
+    }
+    else {
+      entname = canonize(getelem(pm, -3)) + '_' + entname
+      why.push('prob-ent-part')
+    }
+  }
+
+  // Probably an entity action suffix
   else {
-    console.log('NO ENTTIY', pathStr)
-    return
+    why.push('prob-ent-act')
+    entname = canonize(getelem(pm, -3))
   }
 
+  return entname
+}
 
-  // entdesc.plural = origentname
-  entdesc.origname = origentname
+function endsWithCmp(data: any, pm: PathMatch) {
+  const last = canonize(getelem(pm, -1))
+  return isOrigCmp(data, last)
+}
 
-  names(entdesc, entname)
 
-  entdesc.alias = entdesc.alias || {}
+function isOrigCmp(data: any, name: string) {
+  return null != data.metrics.count.origcmprefs[name]
+}
 
-  entdesc.path = (entdesc.path || {})
-  entdesc.path[pathStr] = entdesc.path[pathStr] || {}
-  entdesc.path[pathStr].op = entdesc.path[pathStr].op || {}
 
-  if (null == entdesc.why_name) {
-    entdesc.why_name = why_name
+function entityOccursInPath(parts: string[], entname: string) {
+  let partsLower = parts.map(p => p.toLowerCase())
+  partsLower = partsLower.filter(p => '{' !== p[0]).map(p => canonize(p))
+  return !partsLower.reduce((a: boolean, p: string) => (a && p !== entname), true)
+}
+
+
+function entityPathMatch_tpe(
+  data: { def: any, guide: any, work: any },
+  pm: PathMatch, mdesc: any, why: string[]
+) {
+  const ment = mdesc.MethodEntity
+  const pathNameIndex = 0
+
+  why.push('path=t/p/')
+  const origPathName = pm[pathNameIndex]
+  // let entname = fixEntName(origPathName)
+  let entname = canonize(origPathName)
+
+  if (null != ment.cmp || probableEntityMethod(data, mdesc, pm, why)) {
+    let ecm = entityCmpMatch(data, entname, mdesc, why)
+    entname = ecm.name
+  }
+  else {
+    why.push('ent-act')
+  }
+
+  return entname
+}
+
+
+function entityPathMatch_pte(
+  data: { def: any, guide: any, work: any },
+  pm: PathMatch, mdesc: any, why: string[]
+) {
+  const ment = mdesc.MethodEntity
+  const pathNameIndex = 1
+
+  why.push('path=p/t/')
+  const origPathName = pm[pathNameIndex]
+  let entname = canonize(origPathName)
+
+  if (null != ment.cmp || probableEntityMethod(data, mdesc, pm, why)) {
+    let ecm = entityCmpMatch(data, entname, mdesc, why)
+    entname = ecm.name
+  }
+  else {
+    why.push('ent-act')
   }
 
-  return entdesc
+  return entname
 }
 
 
-const REQKIND: any = {
-  get: 'res',
-  post: 'req',
-  put: 'req',
-  patch: 'req',
+function entityPathMatch_te(
+  data: { def: any, guide: any, work: any },
+  pm: PathMatch, mdesc: any, why: string[]
+) {
+  const ment = mdesc.MethodEntity
+  const pathNameIndex = 0
+
+  why.push('path=t/')
+  const origPathName = pm[pathNameIndex]
+  // let entname = fixEntName(origPathName)
+  let entname = canonize(origPathName)
+
+  if (null != ment.cmp || probableEntityMethod(data, mdesc, pm, why)) {
+    let ecm = entityCmpMatch(data, entname, mdesc, why)
+    entname = ecm.name
+  }
+  else {
+    why.push('ent-act')
+  }
+
+  return entname
 }
 
 
-function resolveComponentName(
-  entname: string,
-  methodDef: Record<string, any>,
-  methodStr: string,
-  pathStr: string,
-  why_name: string[]
-): string | undefined {
-  let compname: string | undefined = undefined
+function entityPathMatch_tpp(
+  data: { def: any, guide: any, work: any },
+  pm: PathMatch, mdesc: any, why: string[]
+) {
+  const ment = mdesc.MethodEntity
+  const pathNameIndex = 0
 
-  let xrefs = find(methodDef, 'x-ref')
-    .filter(xref => xref.val.includes('schema'))
+  why.push('path=t/p/p')
+  const origPathName = pm[pathNameIndex]
+  // let entname = fixEntName(origPathName)
+  let entname = canonize(origPathName)
 
-    // TODO: identify non-ent schemas
-    .filter(xref => !xref.val.includes('Meta'))
+  if (null != ment.cmp || probableEntityMethod(data, mdesc, pm, why)) {
+    let ecm = entityCmpMatch(data, entname, mdesc, why)
+    entname = ecm.name
+  }
+  else {
+    why.push('ent-act')
+  }
 
-    .sort((a, b) => a.path.length - b.path.length)
+  return entname
+}
 
-  // console.log('RCN', pathStr, methodStr, xrefs.map(x => [x.val, x.path.length]))
 
-  let first = xrefs[0]?.val
+function getRequestBodySchema(requestBody: any) {
+  return requestBody?.content?.['application/json']?.schema ??
+    requestBody?.schema
+}
 
-  if (null != first) {
-    let xrefm = (first as string).match(/\/components\/schemas\/(.+)$/)
-    if (xrefm) {
-      why_name.push('cmp')
-      compname = xrefm[1]
-    }
+function getResponseSchema(response: any) {
+  return response?.content?.['application/json']?.schema ??
+    response?.schema
+}
+
+
+// No entity component was found, but there still might be an entity.
+function probableEntityMethod(
+  data: { def: any },
+  mdesc: any,
+  pm: PathMatch,
+  why: string[]
+) {
+  const request = mdesc.requestBody
+  const reqSchema = getRequestBodySchema(request)
+
+  const response = mdesc.responses?.['201'] || mdesc.responses?.['200']
+  const resSchema = getResponseSchema(response)
+  const noResponse = null == resSchema && null != mdesc.responses?.['204']
+
+  let prob_why = ''
+
+  let probent = false
+
+  if (noResponse) {
+    // No response at all means not an action, thus probably an entity.
+    prob_why = 'nores'
+    probent = true
   }
 
-  if (null != compname) {
-    compname = depluralize(snakify(compname))
+  else if (null != reqSchema) {
+    if (
+      'POST' === mdesc.method
+      && !pm.expr.endsWith('/p/')
+
+      // A real entity would probably occur in at least one other t/p path
+      // otherwise this is probably an action
+      && (1 < Object.keys(data.def.paths).filter(path =>
+        path.includes('/' + pm[pm.length - 1] + '/')).length)
+    ) {
+      prob_why = 'post'
+      probent = true
+    }
 
-    // Assume sub schemas suffixes are not real entities
-    if (compname.includes(entname)) {
-      compname = compname.slice(0, compname.indexOf(entname) + entname.length)
+    else if (
+      ('PUT' === mdesc.method || 'PATCH' === mdesc.method)
+      && pm.expr.endsWith('/p/')
+    ) {
+      prob_why = 'putish'
+      probent = true
     }
   }
+  else if ('GET' === mdesc.method) {
+    prob_why = 'get'
+    probent = true
+  }
 
-  return compname
-}
+  const rescodes = Object.keys(mdesc.responses ?? {})
 
+  debugpath(mdesc.path, mdesc.method, 'PROBABLE-ENTITY-RESPONSE',
+    { mdesc, responses: rescodes, probent, prob_why })
 
-function resolveOpName(
-  methodStr: string,
-  methodDef: any,
-  pathStr: string,
-  entdesc: EntityDesc,
-  why: string[]
-)
-  : string | undefined {
-  // console.log('ROP', pathStr, methodDef)
+  why.push('entres=' + probent + '/' + rescodes + ('' === prob_why ? '' : '/' + prob_why))
 
+  return probent
+}
 
-  let opname = METHOD_IDOP[methodStr]
-  if (null == opname) {
-    why.push('no-op:' + methodStr)
-    return
+
+function entityCmpMatch(
+  data: { def: any, guide: any, work: any },
+  entname: string,
+  mdesc: any,
+  why: string[]
+): {
+  name: string,
+  orig: string,
+  cmpish: boolean,
+  pathish: boolean,
+} {
+  const ment = mdesc.MethodEntity
+
+  let out = {
+    name: entname,
+    orig: ment.origcmp ?? entname,
+    cmpish: false,
+    pathish: true,
   }
 
-  if ('load' === opname) {
-    const islist = isListResponse(methodDef, pathStr, entdesc, why)
-    opname = islist ? 'list' : opname
+  // console.log('ECM-A', out, ment)
+
+  const cmpInfrequent = (
+    ment.method_rate < IS_ENTCMP_METHOD_RATE
+    || ment.path_rate < IS_ENTCMP_PATH_RATE
+  )
+
+  if (
+    null != ment.cmp
+    && entname != ment.cmp
+    && !ment.cmp.startsWith(entname)
+  ) {
+    if (cmpInfrequent) {
+      why.push('cmp-primary')
+      out.name = ment.cmp
+      out.orig = ment.origcmp
+      out.cmpish = true
+      out.pathish = false
+      why.push('cmp-infreq')
+    }
+    else if (cmpOccursInPath(data, ment.cmp)) {
+      why.push('cmp-path')
+      out.name = ment.cmp
+      out.orig = ment.origcmp
+      out.cmpish = true
+      out.pathish = false
+      why.push('cmp-inpath')
+    }
+    else {
+      why.push('path-over-cmp')
+    }
+  }
 
-    // console.log('ISLIST', entdesc.name, methodStr, opname, pathStr)
+  else if (
+    'DELETE' === mdesc.method
+    && null == ment.cmp
+  ) {
+    let cmps: { cmp: string, origcmp: string }[] =
+      findcmps(data, mdesc.path, ['responses'], { uniq: true })
+
+    if (1 === cmps.length) {
+      out.name = cmps[0].cmp
+      out.orig = cmps[0].origcmp
+      out.cmpish = true
+      out.pathish = false
+      why.push('cmp-found-delete')
+    }
+    else {
+      why.push('path-primary-delete')
+    }
   }
+
   else {
-    why.push('not-load')
+    why.push('path-primary')
   }
 
-  return opname
+  debugpath(mdesc.path, mdesc.method, 'ENTITY-CMP-NAME', mdesc.path,
+    mdesc.method, entname + '->', out, why, ment,
+    IS_ENTCMP_METHOD_RATE, IS_ENTCMP_PATH_RATE)
+
+  // console.log('ECM-Z', out, why, ment)
+
+  return out
 }
 
 
+function cmpOccursInPath(data: { def: any, work: any }, cmpname: string): boolean {
+  if (null == data.work.potentialCmpsFromPaths) {
+    data.work.potentialCmpsFromPaths = {}
+    each(data.def.paths, (_pathdef: PathDef, pathstr: string) => {
+      const parts: string[] = data.work.pathmap[pathstr].parts
+
+      parts
+        .filter(p => !p.startsWith('{'))
+        .map(p => data.work.potentialCmpsFromPaths[canonize(p)] = true)
+    })
+  }
+
+  return null != data.work.potentialCmpsFromPaths[cmpname]
+}
+
+
+
+
+
 function isListResponse(
-  methodDef: Record<string, any>,
+  mdesc: Record<string, any>,
   pathStr: string,
-  entdesc: EntityDesc,
   why: string[]
 ): boolean {
+  const ment = mdesc.MethodEntity
+  const pm = ment.pm
 
-  const caught = capture(methodDef, {
-    responses: {
-      '`$ANY`': { content: { 'application/json': { schema: '`$CAPTURE`' } } },
-    }
-  })
-
-  const schema = caught.schema
   let islist = false
+  let schema
 
-  if (null == schema) {
-    why.push('no-schema')
+  if (pm && pm.expr.endsWith('p/')) {
+    why.push('end-param')
   }
   else {
-    if (schema.type === 'array') {
-      why.push('array')
-      islist = true
+
+    let caught = capture(mdesc, {
+      responses:
+        // '`$ANY`': { content: { 'application/json': { schema: '`$CAPTURE`' } } },
+        ['`$SELECT`', { '$KEY': { '`$OR`': ['200', '201'] } },
+          { content: { 'application/json': { schema: '`$CAPTURE`' } } }],
+
+    })
+
+    schema = caught.schema
+
+    if (null == schema) {
+      caught = capture(mdesc, {
+        responses:
+          // '`$ANY`': { content: { 'application/json': { schema: '`$CAPTURE`' } } },
+          ['`$SELECT`', { '$KEY': { '`$OR`': ['200', '201'] } },
+            { schema: '`$CAPTURE`' }],
+
+      })
+      schema = caught.schema
     }
 
-    if (!islist) {
-      const properties = schema.properties || {}
-      each(properties, (prop) => {
-        if (prop.type === 'array') {
+    if (null == schema) {
+      why.push('no-schema')
+    }
+    else {
+      if (schema.type === 'array') {
+        why.push('array')
+        islist = true
+      }
 
-          if (1 === size(properties)) {
-            why.push('one-prop:' + prop.key$)
-            islist = true
-          }
+      if (!islist) {
+        const properties = resolveSchemaProperties(schema)
 
-          if (2 === size(properties) &&
-            ('data' === prop.key$ ||
-              'list' === prop.key$)
-          ) {
-            why.push('two-prop:' + prop.key$)
+        each(properties, (prop) => {
+          if (prop.type === 'array') {
+            why.push('array-prop:' + prop.key$)
             islist = true
           }
+        })
+      }
 
-          if (prop.key$ === entdesc.name) {
-            why.push('name:' + entdesc.origname)
-            islist = true
-          }
+      if (!islist) {
+        why.push('not-list')
+      }
+    }
+  }
 
-          if (prop.key$ === entdesc.origname) {
-            why.push('origname:' + entdesc.origname)
-            islist = true
-          }
 
-          const listent = listedEntity(prop)
-          if (listent === entdesc.name) {
-            why.push('listent:' + listent)
-            islist = true
-          }
+  debugpath(pathStr, mdesc.method, 'IS-LIST', islist, why, schema)
 
+  return islist
+}
 
-          // if ('/v2/users' === pathStr) {
-          //   console.log('islistresponse', islist, pathStr, entdesc.name, listedEntity(prop), properties)
-          // }
-        }
-      })
+
+function resolveSchemaProperties(schema: any) {
+  let properties: Record<string, any> = {}
+
+  // This is definitely heuristic!
+  if (schema.allOf) {
+    for (let i = schema.allOf.length - 1; -1 < i; --i) {
+      properties = merge([properties, schema.allOf[i].properties || {}])
+    }
+  }
+
+  if (schema.properties) {
+    properties = merge([properties, schema.properties])
+  }
+
+  return properties
+}
+
+
+
+
+
+
+
+
+function updateAction(
+  methodName: string,
+  oldParam: string,
+  actionName: string,
+  entityDesc: EntityDesc,
+  pathdesc: EntityPathDesc,
+  why: string
+) {
+  if (
+    // Entity not already encoding action.
+    !entityDesc.name.endsWith(canonize(actionName))
+    && null == pathdesc.action[actionName]
+  ) {
+    pathdesc.action[actionName] = {
+      // kind: '`$BOOLEAN`',
+      why_action: ['ent', `${entityDesc.name}`, `${why}`, `${oldParam}`, `${methodName}`]
     }
+  }
+}
+
 
-    if (!islist) {
-      why.push('not-list')
+
+function updateParamRename(
+  ctx: ApiDefContext,
+  data: { def: any, guide: any, work: any },
+  path: string,
+  method: string,
+  paramRenameCapture: {
+    rename: Record<string, string>,
+    why: Record<string, string[]>,
+  },
+  oldParamName: string,
+  newParamName: string,
+  why: string,
+) {
+  const existingNewName = paramRenameCapture.rename[oldParamName]
+  const existingWhy = paramRenameCapture.why[oldParamName]
+
+  debugpath(path, method, 'UPDATE-PARAM-RENAME', path, oldParamName, newParamName, existingNewName)
+
+  if (null == existingNewName) {
+    paramRenameCapture.rename[oldParamName] = newParamName
+    if (!existingWhy.includes(why)) {
+      existingWhy.push(why)
     }
+  }
+  else if (newParamName == existingNewName) {
+    // if (!existingWhy.includes(why)) {
+    //   existingWhy.push(why)
     // }
   }
+  else {
+    ctx.warn({
+      paramRenameCapture, oldParamName, newParamName, why,
+      note: 'Param rename mismatch: existing: ' +
+        oldParamName + ' -> ' + existingNewName + ' (why: ' + existingNewName + ') ' +
+        ' proposed: ' + newParamName + ' (why: ' + why + ') ' +
+        'for path: ' + path + '. method: ' + method
+    })
+  }
+}
 
-  return islist
+
+
+function isParam(partStr: string) {
+  return '{' === partStr[0] && '}' === partStr[partStr.length - 1]
 }
 
 
-function listedEntity(prop: any) {
-  const xref = prop?.items?.['x-ref']
-  const m = 'string' === typeof xref && xref.match(/^#\/components\/schemas\/(.+)$/)
-  if (m) {
-    return depluralize(snakify(m[1]))
+/*
+function fixEntName(origName: string) {
+  if (null == origName) {
+    return origName
+  }
+  return depluralize(snakify(origName))
+}
+*/
+
+
+function findcmps(
+  data: { def: any, work: any, guide: any },
+  pathStr: string,
+  underprops: string[],
+  opts?: { uniq?: boolean }
+): { cmp: string, origcmp: string }[] {
+  const cmplist: string[] = []
+  const cmpset = new Set<string>()
+
+  // TODO: cache in ctx.work
+
+  each(data.def.paths[pathStr])
+    .map((md: MethodDef) => {
+      underprops.map((up: string) => {
+        let found = find((md as any)[up], 'x-ref')
+
+
+        found.map((xref: { val: string }) => {
+          // console.log('FINDCMPS', pathStr, (md as any).key$, up, xref.val)
+          let m = xref.val.match(/\/(components\/schemas|definitions)\/(.+)$/)
+          if (m) {
+            cmplist.push(m[2])
+            cmpset.add(m[2])
+          }
+        })
+      })
+    })
+  // console.log('FOUNDCMPS', cmps)
+  return (opts?.uniq ? Array.from(cmpset) : cmplist).map(n =>
+    ({ cmp: canonize(n), origcmp: n }))
+}
+
+
+function makeMethodEntityDesc(desc: Record<string, any>): MethodEntityDesc {
+  let ment: MethodEntityDesc = {
+    cmp: desc.cmp ?? null,
+    origcmp: desc.origcmp ?? null,
+    origcmpref: desc.origcmpref ?? null,
+
+    ref: desc.ref ?? '',
+    why_cmp: desc.why_cmp ?? [],
+    cmpoccur: desc.cmpoccur ?? 0,
+    path_rate: desc.path_rate ?? 0,
+    method_rate: desc.method_rate ?? 0,
+    entname: desc.entname ?? '',
+    why_op: desc.why_op ?? [],
+    rename: desc.rename ?? { param: {} },
+    why_rename: desc.why_rename ?? { why_param: {} },
+    rename_orig: desc.rename_orig ?? [],
+    opname: desc.opname ?? '',
+    why_opname: desc.why_opname ?? [],
+  }
+  return ment
+}
+
+
+function findPotentialSchemaRefs(pathStr: string, methodName: string, responses: any) {
+  const xrefs: string[] = []
+  const rescodes = ['200', '201']
+  for (let rescode of rescodes) {
+    const schema = getResponseSchema(responses[rescode])
+    if (null != schema) {
+      if (null != schema['x-ref']) {
+        xrefs.push(schema['x-ref'])
+      }
+      else if ('array' === schema.type && null != schema.items?.['x-ref']) {
+        xrefs.push(schema.items?.['x-ref'])
+      }
+    }
   }
+
+  debugpath(pathStr, methodName, 'POTENTIAL-SCHEMA-REFS', xrefs)
+  return xrefs
 }
 
 
+function hasMethod(def: any, pathStr: string, methodName: string) {
+  const pathDef = def?.paths?.[pathStr]
+  const found = (
+    null != pathDef
+    && (
+      null != pathDef[methodName.toLowerCase()]
+      || null != pathDef[methodName.toUpperCase()]
+    )
+  )
+  console.log('hasMethod', pathStr, methodName, found)
+  return found
+}
+
+
+
+/*
+// Some decisions require the full list of potential entities.
+function reviewEntityDescs(ctx: ApiDefContext, result: any) {
+  const guide: Guide = result.data.guide
+  const metrics = guide.metrics
+  const entityDescs = result.data.work.entmap
+
+  if (0 < metrics.count.cmp) {
+    items(entityDescs).map(([entname, entdesc]: [string, EntityDesc]) => {
+
+      // Entities with a single path and single op and no cmp are suspicious
+
+      const pathmap = entdesc.path
+      const pathcount = size(pathmap)
+      const hascmp = null != entdesc.cmp?.namedesc
+
+      if (
+        1 === pathcount
+        && !hascmp
+      ) {
+        let pathdesc: EntityPathDesc = each(pathmap)[0]
+        const pathStr = (pathdesc as any).key$
+
+        if (1 === size(pathdesc.op)) {
+          let op = pathdesc.op
+
+          // console.log('REVIEW', entdesc.name, pathcount, hascmp, op)
+
+          if (op.create) {
+
+            // Entities without "good" components
+            if (
+              entname.includes('_')
+              && pathdesc.pm.expr.endsWith('p/t/')
+            ) {
+              const lastpart = canonize(getelem(pathdesc.pm, -1))
+              const tgtent = entityDescs[lastpart]
+
+              // console.log('REVIEW', entname, entdesc.cmp, size(pathmap), lastpart, realent)
+
+              if (
+                null != tgtent
+                && tgtent.name !== entname
+                && (
+                  null == tgtent.cmp
+                  || lastpart == tgtent.cmp
+                )
+              ) {
+
+                // Actually a known component
+                // console.dir(entdesc, { depth: null })
+
+
+                const realent = guide.entity[entname]
+                const realpathmap = realent.path
+                let realpath = realpathmap[pathStr]
+
+                if (null == realpath) {
+                  realpath = realpathmap[pathStr] = pathdesc
+                }
+                else if (null == realpath.op?.create) {
+                  realpath.op = (realpath.op ?? {})
+                  realpath.op.create = pathdesc.op.create
+                }
+
+                realpath.op.create.why_op =
+                  'was/create/A:' + entname + ':' + realpath.op.create.why_op
+
+                delete entityDescs[entname]
+
+                // console.log('REPLACE', entname, realent.name, realpath)
+              }
+
+            }
+          }
+
+          else if (op.remove) {
+            const otherents: EntityDesc[] = each(entityDescs)
+              .filter((ed: EntityDesc) => ed !== entdesc && each(ed.path)
+                .filter(epd => epd.key$ === pathStr).length)
+
+            const otherent = 1 === otherents.length ? otherents[0] : null
+
+            // console.log('OTHERENT', pathStr, otherents.length, otherent)
+
+            if (null != otherent && null != otherent.cmp) {
+              const otherpath = otherent.path[pathStr]
+
+              if (null == otherpath.op.remove) {
+                otherpath.op.remove = op.remove
+                otherpath.op.remove.why_op =
+                  'was/delete/A:' + entname + ':' + op.remove.why_op
+                delete entityDescs[entname]
+              }
+            }
+          }
+
+          debugpath(pathdesc.pm.path, null,
+            'REVIEW-ENTITY', formatJSONIC(entdesc, { hsepd: 0, $: true, color: true }))
+
+
+        }
+      }
+    })
+  }
+}
+*/
+
 
 export {
   heuristic01